Skip to contentSkip to conversation

Use correct FB handle in amdgpu_do_pageflip

PATCH In review Michel Dänzer 2 participants 2 messages Aug 16, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Use correct FB handle in amdgpu_do_pageflip

From: Michel Dänzer <[email protected]>

We were always using the handle of the client provided FB, which prevented RandR transforms from working, and could result in a black screen.

Fixes 9b6782c821e0 "Store FB for each CRTC in drmmode_flipdata_rec"
---
 src/drmmode_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
src/drmmode_display.c +2 -2
index e58e15d7b..be0e6b875 100644
@@ -3974,7 +3974,7 @@ Bool amdgpu_do_pageflip(ScrnInfoPtr scrn, ClientPtr client,
 		if (crtc == ref_crtc) {
 			if (drmmode_page_flip_target_absolute(pAMDGPUEnt,
 							      drmmode_crtc,
-							      fb->handle,
+							      flipdata->fb[i]->handle,
 							      flip_flags,
 							      drm_queue_seq,
 							      target_msc) != 0)
@@ -3982,7 +3982,7 @@ Bool amdgpu_do_pageflip(ScrnInfoPtr scrn, ClientPtr client,
 		} else {
 			if (drmmode_page_flip_target_relative(pAMDGPUEnt,
 							      drmmode_crtc,
-							      fb->handle,
+							      flipdata->fb[i]->handle,
 							      flip_flags,
 							      drm_queue_seq, 0) != 0)
 				goto flip_error;
Signature · 6 lines
2.18.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20180816143346.6763-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 9 lines · Michel Dänzer

From: Michel Dänzer <[email protected]>

We were always using the handle of the client provided FB, which prevented RandR transforms from working, and could result in a black screen.

Fixes 9b6782c821e0 "Store FB for each CRTC in drmmode_flipdata_rec"

Good catch!

Quoted 29 lines
---
 src/drmmode_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
src/drmmode_display.c +2 -3
index e58e15d7b..be0e6b875 100644
@@ -3974,7 +3974,7 @@ Bool amdgpu_do_pageflip(ScrnInfoPtr scrn, ClientPtr client,
                if (crtc == ref_crtc) {
                        if (drmmode_page_flip_target_absolute(pAMDGPUEnt,
                                                              drmmode_crtc,
-                                                             fb->handle,
+                                                             flipdata->fb[i]->handle,
                                                              flip_flags,
                                                              drm_queue_seq,
                                                              target_msc) != 0)
@@ -3982,7 +3982,7 @@ Bool amdgpu_do_pageflip(ScrnInfoPtr scrn, ClientPtr client,
                } else {
                        if (drmmode_page_flip_target_relative(pAMDGPUEnt,
                                                              drmmode_crtc,
-                                                             fb->handle,
+                                                             flipdata->fb[i]->handle,
                                                              flip_flags,
                                                              drm_queue_seq, 0) != 0)
                                goto flip_error;
--

2.18.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx