Skip to contentSkip to conversation

net: nixge: Add support for 64-bit platforms

PATCH In review Moritz Fischer 2 participants 2 messages Aug 16, 2018 – Aug 18, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: nixge: Add support for 64-bit platforms

Add support for 64-bit platforms to driver.

The hardware only supports 32-bit register accesses so the accesses need to be split up into two writes when setting the current and tail descriptor values.

Cc Florian Fainelli <[email protected]>

---

Changes from RFC:
- Work around warning when building by casting dma_addr to (u64) when netdev_err() printing it
- Use nixge_hw_dma_bd_set_{offset,phys} to zero out descs
- change KConfig from depends on ARCH_ZYNQ to "depends on HAS_IOMEM && HAS_DMA"

---
 drivers/net/ethernet/ni/Kconfig |   3 +-
 drivers/net/ethernet/ni/nixge.c | 168 ++++++++++++++++++++++----------
 2 files changed, 116 insertions(+), 55 deletions(-)
drivers/net/ethernet/ni/Kconfig +2 -1
index aa41e5f6e437..04e315704f71 100644
@@ -18,8 +18,9 @@ if NET_VENDOR_NI
 
 config NI_XGE_MANAGEMENT_ENET
 	tristate "National Instruments XGE management enet support"
-	depends on ARCH_ZYNQ
+	depends on HAS_IOMEM && HAS_DMA
 	select PHYLIB
+	select OF_MDIO
 	help
 	  Simple LAN device for debug or management purposes. Can
 	  support either 10G or 1G PHYs via SFP+ ports.
drivers/net/ethernet/ni/nixge.c +114 -54

351 lines not on this page · raw message

Signature · 1 line
2.18.0
maintainer
#1 lore raw

From: Moritz Fischer <[email protected]>
Date: Thu, 16 Aug 2018 12:07:06 -0700

Quoted 8 lines

Add support for 64-bit platforms to driver.

The hardware only supports 32-bit register accesses so the accesses need to be split up into two writes when setting the current and tail descriptor values.

Cc Florian Fainelli <[email protected]>

Please resubmit when the net-next tree opens back up.

Thank you.