Skip to contentSkip to conversation

dahdi-tools: unify dependencies comments

PATCH New Baruch Siach 3 participants 4 messages Aug 17, 2018 – Aug 24, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dahdi-tools: unify dependencies comments

The threads dependency comment is currently shown even though the toolchain supports threads, only because kernel build is disabled.

Merge the kernel and threads comments. This is similar to what we have in other packages that need the kernel.

---
v2: merge the two comments

---
 package/dahdi-tools/Config.in | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
package/dahdi-tools/Config.in +1 -5
index 39042df04134..a5f145dfe8cb 100644
@@ -15,9 +15,5 @@ config BR2_PACKAGE_DAHDI_TOOLS
 
 	  http://www.asterisk.org/downloads/dahdi
 
-# Two comments, otherwise it may not fit in menuconfig for narrow terminals
-comment "dahdi-tools needs a toolchain w/ threads"
+comment "dahdi-tools needs a toolchain w/ threads and a Linux kernel to be built"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LINUX_KERNEL
-
-comment "dahdi-tools needs a Linux kernel to be built"
-	depends on !BR2_LINUX_KERNEL
Signature · 1 line
2.18.0
#1 lore raw

PATCH v2 1/1 dahdi-tools: unify dependencies comments

Baruch, All,

On 2018-08-17 12:43 +0300, Baruch Siach spake thusly:

Quoted 5 lines

The threads dependency comment is currently shown even though the toolchain supports threads, only because kernel build is disabled.

Merge the kernel and threads comments. This is similar to what we have in other packages that need the kernel.

... and as described in the manual.

Quoted 2 lines

Regards,
Yann E. MORIN.

Quoted 24 lines

---
v2: merge the two comments

---
 package/dahdi-tools/Config.in | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
package/dahdi-tools/Config.in +1 -5
index 39042df04134..a5f145dfe8cb 100644
@@ -15,9 +15,5 @@ config BR2_PACKAGE_DAHDI_TOOLS
 
 	  http://www.asterisk.org/downloads/dahdi
 
-# Two comments, otherwise it may not fit in menuconfig for narrow terminals
-comment "dahdi-tools needs a toolchain w/ threads"
+comment "dahdi-tools needs a toolchain w/ threads and a Linux kernel to be built"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_LINUX_KERNEL
-
-comment "dahdi-tools needs a Linux kernel to be built"
-	depends on !BR2_LINUX_KERNEL
Signature · 1 line
2.18.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 dahdi-tools: unify dependencies comments

In reply to Baruch Siach
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

The threads dependency comment is currently shown even though the toolchain supports threads, only because kernel build is disabled.

Quoted 7 lines

Merge the kernel and threads comments. This is similar to what we have in other packages that need the kernel.

---
v2: merge the two comments

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/1 dahdi-tools: unify dependencies comments

In reply to Baruch Siach
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

The threads dependency comment is currently shown even though the toolchain supports threads, only because kernel build is disabled.

Quoted 7 lines

Merge the kernel and threads comments. This is similar to what we have in other packages that need the kernel.

---
v2: merge the two comments

Committed to 2018.02.x and 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard