Skip to contentSkip to conversation

drm/i915: Do not redefine the has_csr parameter.

PATCH Applied Anusha Srivatsa 5 participants 8 messages Aug 17, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Do not redefine the has_csr parameter.

Let us reuse the already defined has_csr check and not redefine it.

---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +0 -1
index e931b48..d6f7b9f 100644
@@ -600,7 +600,6 @@ static const struct intel_device_info intel_cannonlake_info = {
 	GEN10_FEATURES, \
 	GEN(11), \
 	.ddb_size = 2048, \
-	.has_csr = 0, \
 	.has_logical_ring_elsq = 1
 
 static const struct intel_device_info intel_icelake_11_info = {
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915: Do not redefine the has_csr parameter.

== Series Details ==

== Series Details ==

Series: drm/i915: Do not redefine the has_csr parameter.
URL : https://patchwork.freedesktop.org/series/48408/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4686 -> Patchwork_9974 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9974 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9974, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/48408/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9974:

=== IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@basic-rte:
      {fi-icl-u}:         PASS -> FAIL

    
    ==== Warnings ====

    igt@drv_selftest@live_guc:
      fi-kbl-7567u:       SKIP -> PASS +1

    igt@pm_rpm@basic-pci-d3-state:
      {fi-icl-u}:         PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_9974 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7560u:       PASS -> DMESG-FAIL (fdo#106560, fdo#106947)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7567u:       DMESG-FAIL (fdo#106560, fdo#106947) -> PASS

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      {fi-byt-clapper}:   FAIL (fdo#107362, fdo#103191) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> PASS

    {igt@pm_rpm@module-reload}:
      {fi-icl-u}:         WARN (fdo#107602) -> SKIP

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602

== Participating hosts (54 -> 49) ==

Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4686 -> Patchwork_9974

CI_DRM_4686: d8f9d99f574c7d0b6918d888071bc2f3f899b18b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9974: 74b11d9282c9471c3c0bf63de309b482bb89768e @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

74b11d9282c9 drm/i915: Do not redefine the has_csr parameter.

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9974/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#2 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: Do not redefine the has_csr parameter.

Quoted 23 lines · Patchwork

== Series Details ==

Series: drm/i915: Do not redefine the has_csr parameter.
URL : https://patchwork.freedesktop.org/series/48408/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4686 -> Patchwork_9974 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9974 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9974, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/48408/revisions/1/mbox/

== Possible new issues ==

Quoted 8 lines

Here are the unknown changes that may have been introduced in Patchwork_9974:

=== IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@basic-rte:
      {fi-icl-u}:         PASS -> FAIL

Is this related?

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9974/fi-icl-u/igt@[email protected]

I don't think so, but just checking before pushing...

Quoted 75 lines
    
    ==== Warnings ====

    igt@drv_selftest@live_guc:
      fi-kbl-7567u:       SKIP -> PASS +1

    igt@pm_rpm@basic-pci-d3-state:
      {fi-icl-u}:         PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_9974 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7560u:       PASS -> DMESG-FAIL (fdo#106560, fdo#106947)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7567u:       DMESG-FAIL (fdo#106560, fdo#106947) -> PASS

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      {fi-byt-clapper}:   FAIL (fdo#107362, fdo#103191) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> PASS

    {igt@pm_rpm@module-reload}:
      {fi-icl-u}:         WARN (fdo#107602) -> SKIP

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602

== Participating hosts (54 -> 49) ==

Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4686 -> Patchwork_9974

CI_DRM_4686: d8f9d99f574c7d0b6918d888071bc2f3f899b18b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9974: 74b11d9282c9471c3c0bf63de309b482bb89768e @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

74b11d9282c9 drm/i915: Do not redefine the has_csr parameter.

Quoted 7 lines

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9974/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: Do not redefine the has_csr parameter.

Quoting Rodrigo Vivi (2018-08-17 19:24:14)

Quoted 26 lines · Patchwork
Quoted 25 lines

== Series Details ==

Series: drm/i915: Do not redefine the has_csr parameter.
URL : https://patchwork.freedesktop.org/series/48408/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4686 -> Patchwork_9974 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9974 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9974, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/48408/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9974:

Quoted 8 lines
Quoted 6 lines

=== IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@basic-rte:
      {fi-icl-u}:         PASS -> FAIL

Is this related?

Yes. The platform now HAS_CSR but no DMC firmware so runtime-pm has to be disabled. Allowing the platform to enter runtime suspend with programming the dmc as before the patch is an undefined hazard. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: Do not redefine the has_csr parameter.

Quoted 31 lines · Chris Wilson

Quoting Rodrigo Vivi (2018-08-17 19:24:14)

Quoted 30 lines · Patchwork
Quoted 29 lines

== Series Details ==

Series: drm/i915: Do not redefine the has_csr parameter.
URL : https://patchwork.freedesktop.org/series/48408/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4686 -> Patchwork_9974 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9974 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9974, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/48408/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9974:

=== IGT changes ===

    ==== Possible regressions ====
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
    igt@pm_rpm@basic-rte:
      {fi-icl-u}:         PASS -> FAIL

Is this related?

Yes. The platform now HAS_CSR but no DMC firmware so runtime-pm has to be disabled. Allowing the platform to enter runtime suspend with programming the dmc as before the patch is an undefined hazard.

Right. We could convert the result to be skip in this case, not sure if it's worth the effort.

In any case the patch is good to be merged.

Quoted 5 lines

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#5 lore raw
In reply to Anusha Srivatsa
Quoted 2 lines · Anusha Srivatsa

Let us reuse the already defined has_csr check and not redefine it.

The main difference is that in effect this will flip .has_csr to 1 (via GEN9_FEATURES which GEN11_FEATURES pulls in).

Quoted 5 lines
Quoted 19 lines
---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +0 -1
index e931b48..d6f7b9f 100644
@@ -600,7 +600,6 @@ static const struct intel_device_info intel_cannonlake_info = {
 	GEN10_FEATURES, \
 	GEN(11), \
 	.ddb_size = 2048, \
-	.has_csr = 0, \
 	.has_logical_ring_elsq = 1
 
 static const struct intel_device_info intel_icelake_11_info = {
Signature · 1 line
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Applied
#6 lore raw
Quoted 6 lines · Imre Deak
Quoted 2 lines · Anusha Srivatsa

Let us reuse the already defined has_csr check and not redefine it.

The main difference is that in effect this will flip .has_csr to 1 (via GEN9_FEATURES which GEN11_FEATURES pulls in).

amended when pushing

Quoted 9 lines
Quoted 5 lines

pushed to dinq. thanks for patch and review

Quoted 16 lines
Quoted 16 lines
---
 drivers/gpu/drm/i915/i915_pci.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/i915/i915_pci.c +0 -1
index e931b48..d6f7b9f 100644
@@ -600,7 +600,6 @@ static const struct intel_device_info intel_cannonlake_info = {
 	GEN10_FEATURES, \
 	GEN(11), \
 	.ddb_size = 2048, \
-	.has_csr = 0, \
 	.has_logical_ring_elsq = 1
 
Quoted 8 lines
Quoted 4 lines
drivers/gpu/drm/i915/i915_pci.c +0 -0
 static const struct intel_device_info intel_icelake_11_info = {
Signature · 1 line
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.IGT: success for drm/i915: Do not redefine the has_csr parameter.

In reply to Anusha Srivatsa
== Series Details ==

== Series Details ==

Series: drm/i915: Do not redefine the has_csr parameter.
URL : https://patchwork.freedesktop.org/series/48408/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4686_full -> Patchwork_9974_full =

== Summary - SUCCESS ==

No regressions found.

== Known issues ==

Here are the changes found in Patchwork_9974_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_ctx_isolation@rcs0-s3:
      shard-glk:          PASS -> FAIL (fdo#103375)

    
    ==== Possible fixes ====

    igt@drv_suspend@debugfs-reader:
      shard-glk:          FAIL (fdo#103375) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105363) -> PASS

fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4686 -> Patchwork_9974

CI_DRM_4686: d8f9d99f574c7d0b6918d888071bc2f3f899b18b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9974: 74b11d9282c9471c3c0bf63de309b482bb89768e @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9974/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx