drm/i915: Increase LSPCON timeout
Subsystems (3)
PATCH v2 1/1 drm/i915: Increase LSPCON timeout
100 ms is not enough time for the LSPCON adapter on Intel NUC devices to settle. This causes dropped display modes at boot or screen reconfiguration. Empirical testing can reproduce the error up to a timeout of 190 ms. Basic boot and stress testing at 200 ms has not (yet) failed.
Increase timeout to 400 ms to get some margin of error.
Changes from v1:
The initial suggestion of 1000 ms was lowered due to concerns about delaying valid timeout cases.
Update patch metadata.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107503
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1570392
--- drivers/gpu/drm/i915/intel_lspcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lspcon.c +1 -1
@@ -74,7 +74,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,DRM_DEBUG_KMS ("Waiting for LSPCON mode %s to settle\n" ,lspcon_mode_name (mode)); -wait_for ((current_mode =lspcon_get_current_mode (lspcon)) == mode,100 ); +wait_for ((current_mode =lspcon_get_current_mode (lspcon)) == mode,400 );if (current_mode != mode)DRM_ERROR ("LSPCON mode hasn't settled\n" );
Signature · 1 line
2.17.1
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915: Increase LSPCON timeout
== Series Details ==
== Series Details ==
Series: drm/i915: Increase LSPCON timeout
URL : https://patchwork.freedesktop.org/series/48414/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip b7c954809a11 drm/i915: Increase LSPCON timeout -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: settle. This causes dropped display modes at boot or screen reconfiguration.
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Increase LSPCON timeout
In reply to Fredrik Schön== Series Details ==
== Series Details ==
Series: drm/i915: Increase LSPCON timeout
URL : https://patchwork.freedesktop.org/series/48414/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4686 -> Patchwork_9975 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9975 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9975, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48414/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9975:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_guc:
fi-kbl-7567u: SKIP -> PASS +1== Known issues ==
Here are the changes found in Patchwork_9975 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-bxt-dsi: PASS -> DMESG-FAIL (fdo#106560)
igt@kms_frontbuffer_tracking@basic:
{fi-byt-clapper}: PASS -> FAIL (fdo#103167)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-kbl-7567u: DMESG-FAIL (fdo#106947, fdo#106560) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
{fi-byt-clapper}: FAIL (fdo#107362, fdo#103191) -> PASS {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (54 -> 49) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4686 -> Patchwork_9975
CI_DRM_4686: d8f9d99f574c7d0b6918d888071bc2f3f899b18b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9975: b7c954809a11c4ac1bb54527b24801c08e145d89 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b7c954809a11 drm/i915: Increase LSPCON timeout
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9975/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Increase LSPCON timeout
In reply to Fredrik Schön== Series Details ==
== Series Details ==
Series: drm/i915: Increase LSPCON timeout
URL : https://patchwork.freedesktop.org/series/48414/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4686_full -> Patchwork_9975_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9975_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9975_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9975_full:
=== IGT changes ===
==== Warnings ====
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
shard-snb: PASS -> SKIP== Known issues ==
Here are the changes found in Patchwork_9975_full that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@drv_suspend@forcewake:
shard-glk: FAIL (fdo#103375) -> PASS
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665) -> PASS
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4686 -> Patchwork_9975
CI_DRM_4686: d8f9d99f574c7d0b6918d888071bc2f3f899b18b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9975: b7c954809a11c4ac1bb54527b24801c08e145d89 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9975/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 30 lines · Fredrik Schön
100 ms is not enough time for the LSPCON adapter on Intel NUC devices to settle. This causes dropped display modes at boot or screen reconfiguration. Empirical testing can reproduce the error up to a timeout of 190 ms. Basic boot and stress testing at 200 ms has not (yet) failed.
Increase timeout to 400 ms to get some margin of error.
Changes from v1:
The initial suggestion of 1000 ms was lowered due to concerns about delaying valid timeout cases.
Update patch metadata.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107503
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1570392Fixes 357c0ae9198a ("drm/i915/lspcon: Wait for expected LSPCON mode to settle")Cc Shashank Sharma <[email protected]>Cc Imre Deak <[email protected]>Cc Jani Nikula <[email protected]>Cc <[email protected]> # v4.11+Reviewed-by Rodrigo Vivi <[email protected]>Signed-off-by Fredrik Schön <[email protected]>--- drivers/gpu/drm/i915/intel_lspcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_lspcon.c +0
-0
drivers/gpu/drm/i915/intel_lspcon.c static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon, · line 80
Quoted 8 lines
drivers/gpu/drm/i915/intel_lspcon.c +1
-1@@ -74,7 +74,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,DRM_DEBUG_KMS ("Waiting for LSPCON mode %s to settle\n" ,lspcon_mode_name (mode)); -wait_for ((current_mode =lspcon_get_current_mode (lspcon)) == mode,100 ); +wait_for ((current_mode =lspcon_get_current_mode (lspcon)) == mode,400 );if (current_mode != mode)DRM_ERROR ("LSPCON mode hasn't settled\n" );
Looks good to me
- Shashank
Jani Nikula
AppliedQuoted 35 lines · Shashank
Quoted 33 lines · Fredrik Schön
100 ms is not enough time for the LSPCON adapter on Intel NUC devices to settle. This causes dropped display modes at boot or screen reconfiguration. Empirical testing can reproduce the error up to a timeout of 190 ms. Basic boot and stress testing at 200 ms has not (yet) failed.
Increase timeout to 400 ms to get some margin of error.
Changes from v1:
The initial suggestion of 1000 ms was lowered due to concerns about delaying valid timeout cases.
Update patch metadata.Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107503
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1570392Fixes 357c0ae9198a ("drm/i915/lspcon: Wait for expected LSPCON mode to settle")Cc Shashank Sharma <[email protected]>Cc Imre Deak <[email protected]>Cc Jani Nikula <[email protected]>Cc <[email protected]> # v4.11+Reviewed-by Rodrigo Vivi <[email protected]>Signed-off-by Fredrik Schön <[email protected]>--- drivers/gpu/drm/i915/intel_lspcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_lspcon.c +0
-0@@ -74,7 +74,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,DRM_DEBUG_KMS ("Waiting for LSPCON mode %s to settle\n" ,lspcon_mode_name (mode));
Quoted 7 lines
drivers/gpu/drm/i915/intel_lspcon.c static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon, · line 80
Quoted 5 lines
drivers/gpu/drm/i915/intel_lspcon.c +1
-1-wait_for ((current_mode =lspcon_get_current_mode (lspcon)) == mode,100 ); +wait_for ((current_mode =lspcon_get_current_mode (lspcon)) == mode,400 );if (current_mode != mode)DRM_ERROR ("LSPCON mode hasn't settled\n" );Looks good to me
Reviewed-by Shashank Sharma <[email protected]>
Pushed to drm-intel-next-queued, thanks for the patch and review.
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center