Skip to contentSkip to conversation

pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no dmtimer platform data

PATCH New David Rivshin 2 participants 2 messages Aug 1, 2018 – Aug 20, 2018 PWM

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no dmtimer platform data

From: David Rivshin <[email protected]>

If a pwm-omap-dmtimer is probed before the dmtimer it uses, the platform data won't be set yet.

Fixes ac30751df953 ("ARM: OMAP: pdata-quirks: Remove unused timer pdata")
Cc <[email protected]> # 4.17+

---
Changes in v4:
* Added Ladislav's Acked-by [2]
* Added Andreas's Tested-by [3]
Changes in v3:
* Changed dev_info to dev_dbg
Changes in v2:
* Added Pavel's Acked-by/Tested-by [1]

[1] https://lkml.org/lkml/2018/7/16/346
[2] https://www.spinics.net/lists/arm-kernel/msg668768.html
[3] https://www.spinics.net/lists/arm-kernel/msg669302.html

drivers/pwm/pwm-omap-dmtimer.c | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pwm/pwm-omap-dmtimer.c +3 -2
index 665da3c8fbceb..f45798679e3c0 100644
@@ -264,8 +264,9 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev)
 
 	timer_pdata = dev_get_platdata(&timer_pdev->dev);
 	if (!timer_pdata) {
-		dev_err(&pdev->dev, "dmtimer pdata structure NULL\n");
-		ret = -EINVAL;
+		dev_dbg(&pdev->dev,
+			 "dmtimer pdata structure NULL, deferring probe\n");
+		ret = -EPROBE_DEFER;
 		goto put;
 	}
 

base-commit: acb1872577b346bd15ab3a3f8dff780d6cca4b70

Signature · 1 line
2.17.1
#1 lore raw

PATCH v4 1/1 pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no dmtimer platform data

Quoted 21 lines · David Rivshin

From: David Rivshin <[email protected]>

If a pwm-omap-dmtimer is probed before the dmtimer it uses, the platform data won't be set yet.

Fixes ac30751df953 ("ARM: OMAP: pdata-quirks: Remove unused timer pdata")
Cc <[email protected]> # 4.17+

---
Changes in v4:
* Added Ladislav's Acked-by [2]
* Added Andreas's Tested-by [3]
Changes in v3:
* Changed dev_info to dev_dbg
Changes in v2:
* Added Pavel's Acked-by/Tested-by [1]

Quoted 6 lines

[1] https://lkml.org/lkml/2018/7/16/346
[2] https://www.spinics.net/lists/arm-kernel/msg668768.html
[3] https://www.spinics.net/lists/arm-kernel/msg669302.html

drivers/pwm/pwm-omap-dmtimer.c | 5 +++--

 1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180820/d8b05dca/attachment.sig>