Skip to contentSkip to conversation

qt5base: fix double-conversion for or1k

PATCH New Peter Seiderer 3 participants 3 messages Aug 18, 2018 – Aug 20, 2018

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH 1/1 qt5base: fix double-conversion for or1k

Fixes [1]:

../3rdparty/double-conversion/include/double-conversion/utils.h:81:2: error: #error Target architecture was not detected as supported by Double-Conversion. #error Target architecture was not detected as supported by Double-Conversion.

[1] http://autobuild.buildroot.net/results/a3535cdf5e91df011a59a4b9f60d69195f5efdcb

Signed-off-by Peter Seiderer <[email protected]>
---
 ...03-double-conversion-enable-for-or1k.patch | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 package/qt5/qt5base/5.11.1/0003-double-conversion-enable-for-or1k.patch
package/qt5/qt5base/5.11.1/0003-double-conversion-enable-for-or1k.patch new file +27 -0
new file mode 100644
index 0000000000..53c5a31832
@@ -0,0 +1,27 @@
+From f9920819e6600a68829fb4600f11b70ebc2a33e7 Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <[email protected]>
+Date: Sat, 18 Aug 2018 23:44:20 +0200
+Subject: [PATCH] double-conversion: enable for or1k
+
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ .../double-conversion/include/double-conversion/utils.h        | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/3rdparty/double-conversion/include/double-conversion/utils.h b/src/3rdparty/double-conversion/include/double-conversion/utils.h
+index 77baa2861a..b0a7d5d4f4 100644
+--- a/src/3rdparty/double-conversion/include/double-conversion/utils.h
++++ b/src/3rdparty/double-conversion/include/double-conversion/utils.h
+@@ -65,7 +65,8 @@
+     defined(__sparc__) || defined(__sparc) || defined(__s390__) || \
+     defined(__SH4__) || defined(__alpha__) || \
+     defined(_MIPS_ARCH_MIPS32R2) || \
+-    defined(__AARCH64EL__) || defined(__AARCH64EB__)
++    defined(__AARCH64EL__) || defined(__AARCH64EB__) || \
++    defined(__or1k__)
+ #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1
+ #elif defined(_M_IX86) || defined(__i386__) || defined(__i386)
+ #if defined(_WIN32)
+-- 
+2.18.0
+
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 qt5base: fix double-conversion for or1k

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

Fixes [1]:
../3rdparty/double-conversion/include/double-conversion/utils.h:81:2: error: #error Target architecture was not detected as supported by Double-Conversion. #error Target architecture was not detected as supported by Double-Conversion.

[1] http://autobuild.buildroot.net/results/a3535cdf5e91df011a59a4b9f60d69195f5efdcb

Signed-off-by Peter Seiderer <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 qt5base: fix double-conversion for or1k

In reply to Peter Seiderer

Hello,

Quoted 8 lines · Peter Seiderer

Fixes [1]:

../3rdparty/double-conversion/include/double-conversion/utils.h:81:2: error: #error Target architecture was not detected as supported by Double-Conversion. #error Target architecture was not detected as supported by Double-Conversion.

[1] http://autobuild.buildroot.net/results/a3535cdf5e91df011a59a4b9f60d69195f5efdcb

Signed-off-by Peter Seiderer <[email protected]>

Thanks a lot for this patch! Actually, we would need the same on Microblaze:

http://autobuild.buildroot.net/?arch=microblazeel&status=NOK&reason=qt5base%

Thanks :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com