ARM: display5: config: Replace hardcoded size of kernel (0x2000) with variable (fitImg_fw_sz)
PATCH 1/1 ARM: display5: config: Replace hardcoded size of kernel (0x2000) with variable (fitImg_fw_sz)
This cosmetic change allow easy adjustment of the to-load kernel size if needed.
---
include/configs/display5.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
include/configs/display5.h +2 -1
@@ -166,7 +166,7 @@"rootwait rootfstype=ext4 rw; " \"run set_kernel_part;" \"part start mmc ${mmcdev} ${kernel_part} lba_start; " \ -"mmc read ${loadaddr} ${lba_start} 0x2000; " \ +"mmc read ${loadaddr} ${lba_start} ${fitImg_fw_sz}; " \"setenv fdt_conf imx6q-${board}-${display}.dtb; " /* All the numbers are in LBAs */
@@ -273,6 +273,7 @@"fdt_high=0xffffffff\0" \"initrd_high=0xffffffff\0" \"kernel_file=fitImage\0" \ +"fitImg_fw_sz=0x2200\0" \"up=run tftp_sf_SPL; run tftp_sf_uboot\0" \"download_kernel=" \"tftpboot ${loadaddr} ${kernel_file};\0" \
Signature · 1 line
2.11.0
PATCH 1/1 ARM: display5: config: Replace hardcoded size of kernel (0x2000) with variable (fitImg_fw_sz)
Hi Lukasz,
Quoted 4 lines · Lukasz Majewski
This cosmetic change allow easy adjustment of the to-load kernel size if needed.
Signed-off-by Lukasz Majewski <[email protected]>
Looks good:
Only minor nit is that the Subject like looks excessively large.
It could be something more succinct like:
display5: Introduce fitImg_fw_sz variable
PATCH 1/1 ARM: display5: config: Replace hardcoded size of kernel (0x2000) with variable (fitImg_fw_sz)
Quoted 10 lines · Fabio Estevam
Hi Lukasz,
Quoted 4 lines · Lukasz Majewski
This cosmetic change allow easy adjustment of the to-load kernel size if needed.
Signed-off-by Lukasz Majewski <[email protected]>Looks good:
Quoted 7 lines
Reviewed-by Fabio Estevam <[email protected]>Only minor nit is that the Subject like looks excessively large.
It could be something more succinct like:
display5: Introduce
fitImg_fw_szvariable
No need to v2 this 'tho, since it's small and from the listed maintainer I grabbed it and am about to push (but I'll re-word to add the R-b tag).
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180820/457c8696/attachment.sig>
Quoted 4 lines · Lukasz Majewski
This cosmetic change allow easy adjustment of the to-load kernel size if needed.
Signed-off-by Lukasz Majewski <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180820/3a2313bf/attachment.sig>