fpga: dfl: region: Restory symmetry in probe()/remove()

Replace dev_get_drvdata() with platform_get_drvdata() to match the platform_set_drvdata() in the probe function of the platform driver.

Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for FME")

Signed-off-by Moritz Fischer <[email protected]>

---

Changes from v1:
- Still compile after change ...

---
 drivers/fpga/dfl-fme-region.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/fpga/dfl-fme-region.c +1 -2

index 0b7e19c27c6d..11d3c23a8936 100644
@@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev)
 
 static int fme_region_remove(struct platform_device *pdev)
 {
-       struct fpga_region *region = dev_get_drvdata(&pdev->dev);
+       struct fpga_region *region = platform_get_drvdata(pdev);
 
        fpga_region_unregister(region);
        fpga_mgr_put(region->mgr);
--

2.18.0

On Mon, Aug 20, 2018 at 12:18 PM, Moritz Fischer <[email protected]> wrote:

Hi Moritz,

Quoted 11 lines

Replace dev_get_drvdata() with platform_get_drvdata() to match the platform_set_drvdata() in the probe function of the platform driver.

Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for FME")

Signed-off-by Moritz Fischer <[email protected]>

---

Changes from v1:
- Still compile after change ...

Quoted 2 lines

---
 drivers/fpga/dfl-fme-region.c | 2 +-

Thanks for catching this. of-fpga-region.c does a similar thing and needs s/dev_set_drvdata/platform_set_drvdata/ in the probe. Could you fix it here too?

Hi Alan,

Quoted 21 lines · Alan Tull

On Mon, Aug 20, 2018 at 12:18 PM, Moritz Fischer <[email protected]> wrote:

Hi Moritz,

Quoted 5 lines

Replace dev_get_drvdata() with platform_get_drvdata() to match the platform_set_drvdata() in the probe function of the platform driver.

Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for FME")

Quoted 8 lines

Signed-off-by Moritz Fischer <[email protected]>

---

Changes from v1:
- Still compile after change ...

---
 drivers/fpga/dfl-fme-region.c | 2 +-

Thanks for catching this. of-fpga-region.c does a similar thing and needs s/dev_set_drvdata/platform_set_drvdata/ in the probe. Could you fix it here too?

Yeah, can do in a v3 series ... Will add your Suggested-by: ...

Cheers,

Moritz