Skip to contentSkip to conversation

synopsys/hsdk: Boot log cleanup

PATCH New Evgeniy Didin 2 participants 4 messages Aug 20, 2018

lore
Share & tools
lore

Evgeniy Didin

author
#0 lore raw

PATCH 1/1 synopsys/hsdk: Boot log cleanup

Remove duplicate messages in boot log on HSDK board. Console ttyS3 is already set in Linux bootargs.

Signed-off-by Evgeniy Didin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc arc-buildroot at synopsys.com
---
 board/synopsys/hsdk/uboot.env.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/synopsys/hsdk/uboot.env.txt +1 -1
index 6bcfb56a77..216f0c9043 100644
@@ -1,5 +1,5 @@
 baudrate=115200
-bootargs=console=ttyS3,115200n8 root=/dev/mmcblk0p2 rootwait
+bootargs=root=/dev/mmcblk0p2 rootwait
 bootcmd=fatload mmc 0:1; bootm
 bootdelay=2
 bootfile=uImage
Signature · 1 line
2.16.2
#1 lore raw

PATCH 1/1 synopsys/hsdk: Boot log cleanup

Hello,

Quoted 15 lines · Evgeniy Didin

Remove duplicate messages in boot log on HSDK board. Console ttyS3 is already set in Linux bootargs.

Signed-off-by Evgeniy Didin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc arc-buildroot at synopsys.com
---
 board/synopsys/hsdk/uboot.env.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/synopsys/hsdk/uboot.env.txt +0 -0
index 6bcfb56a77..216f0c9043 100644

board/synopsys/hsdk/uboot.env.txt line 2

Quoted 3 lines
board/synopsys/hsdk/uboot.env.txt +1 -1
@@ -1,5 +1,5 @@
 baudrate=115200
-bootargs=console=ttyS3,115200n8 root=/dev/mmcblk0p2 rootwait
+bootargs=root=/dev/mmcblk0p2 rootwait

Well, *these* are the Linux bootargs.

Do you mean that something else is re-adding "console=ttyS3" to the bootargs ?

Could you clarify ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 synopsys/hsdk: Boot log cleanup

Hello Thomas,

Quoted 24 lines · Thomas Petazzoni

Hello,

Quoted 15 lines · Evgeniy Didin

Remove duplicate messages in boot log on HSDK board. Console ttyS3 is already set in Linux bootargs.

Signed-off-by Evgeniy Didin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc arc-buildroot at synopsys.com
---
 board/synopsys/hsdk/uboot.env.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/synopsys/hsdk/uboot.env.txt +0 -0
index 6bcfb56a77..216f0c9043 100644

board/synopsys/hsdk/uboot.env.txt line 2

Quoted 3 lines
board/synopsys/hsdk/uboot.env.txt +1 -1
@@ -1,5 +1,5 @@
 baudrate=115200
-bootargs=console=ttyS3,115200n8 root=/dev/mmcblk0p2 rootwait
+bootargs=root=/dev/mmcblk0p2 rootwait

Well, *these* are the Linux bootargs.

Quoted 4 lines

Do you mean that something else is re-adding "console=ttyS3" to the bootargs ?

Could you clarify ?

For HSDK board we setup bootargs via device tree, see https://elixir.bootlin.com/linux/latest/source/arch/arc/boot/dts/hsdk.dts#L25
"console=ttyS3" was mistakenly placed in u-boot bootargs which are appended to Kernel bootargs.

Quoted 3 lines

Thanks,

Thomas

Best regards,
Evgeniy Didin

#3 lore raw

PATCH 1/1 synopsys/hsdk: Boot log cleanup

Hello,

Quoted 2 lines · Evgeniy Didin

For HSDK board we setup bootargs via device tree, see https://elixir.bootlin.com/linux/latest/source/arch/arc/boot/dts/hsdk.dts#L25
"console=ttyS3" was mistakenly placed in u-boot bootargs which are appended to Kernel bootargs.

OK. This must be an ARC-specific behavior, because on ARM, the U-Boot bootargs *replace* the DT bootargs.

Thanks for the additional explanation.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com