Skip to contentSkip to conversation

efi patch queue 2018-08-21

GIT PULL Alexander Graf 3 participants 5 messages Aug 21, 2018 – Aug 23, 2018

lore
Share & tools
lore

Alexander Graf

author
#0 lore raw

Hi Tom,

This is my current patch queue for efi to be applied for 2018.09. Please pull.

Alex

The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931:

Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400)

are available in the git repository at:

git://github.com/agraf/u-boot.git tags/signed-efi-2018.09

for you to fetch changes up to dbb148b22cbf242156edf53cca6d661cd320cb83:

cmd: efi: Clarify calculation precedence for '&' and '?' (2018-08-21 00:04:24 +0200)

----------------------------------------------------------------
Patch queue for efi - 2018-08-21

A few fixes for 2018.09. Most noticable are:

- unbreak x86 target (-fdata-section fallout)
- fix undefined behavior in a few corner cases
- make Jetson TX1 boot again
- RTS fixes
- implement reset for simple output

----------------------------------------------------------------
AKASHI Takahiro (1):
efi_loader: fix a parameter check at CreateEvent()

Alexander Graf (4):
sandbox: Move BSS after EFI sections
x86: Include bss subsections in linker script
x86: Enable -fdata-sections always
riscv: Include bss subsections in linker script

Eugeniu Rosca (3):
efi: Fix truncation of constant value
efi: Add EFI_MEMORY_{NV, MORE_RELIABLE, RO} attributes
cmd: efi: Clarify calculation precedence for '&' and '?'

Heinrich Schuchardt (7):
efi_loader: relocate pointer to tables
efi_loader: avoid NULL dereference in efi_get_memory_map()
lib: crc32: mark function crc32() as __efi_runtime
efi_loader: update runtime services table crc32
efi_loader: document runtime functions
efi_selftest: correct block device unit test
efi_loader: EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.Reset()

Stephen Warren (1):
Revert "efi_loader: efi_allocate_pages is too restrictive"

 arch/riscv/cpu/ax25/u-boot.lds               |   2 +-
 arch/sandbox/cpu/u-boot.lds                  |   5 +-
 arch/x86/config.mk                           |   4 +-
 arch/x86/cpu/u-boot-64.lds                   |   2 +-
 arch/x86/cpu/u-boot.lds                      |   2 +-
 arch/x86/lib/elf_ia32_efi.lds                |   2 +-
 arch/x86/lib/elf_x86_64_efi.lds              |   2 +-
 cmd/efi.c                                    |  27 ++--
 include/efi.h                                |  28 ++---
 include/efi_loader.h                         |   3 +
 lib/crc32.c                                  |  26 ++--
 lib/efi_loader/efi_boottime.c                |  15 +--
 lib/efi_loader/efi_console.c                 |  22 ++--
 lib/efi_loader/efi_memory.c                  |  13 +-
 lib/efi_loader/efi_runtime.c                 | 177 ++++++++++++++++++++++++++-
 lib/efi_selftest/efi_selftest_block_device.c |   2 +-
 16 files changed, 250 insertions(+), 82 deletions(-)
#1 lore raw

Hi Alex,

Quoted 5 lines · Alexander Graf

Hi Tom,

This is my current patch queue for efi to be applied for 2018.09. Please pull.

Alex

I still think we should be reverting the offending patch rather than patching on top of it.

Are you able to apply my sandbox revert patch in this pull request?

Quoted 69 lines

The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931:

Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400)

are available in the git repository at:

git://github.com/agraf/u-boot.git tags/signed-efi-2018.09

for you to fetch changes up to dbb148b22cbf242156edf53cca6d661cd320cb83:

cmd: efi: Clarify calculation precedence for '&' and '?' (2018-08-21 00:04:24 +0200)

----------------------------------------------------------------
Patch queue for efi - 2018-08-21

A few fixes for 2018.09. Most noticable are:

- unbreak x86 target (-fdata-section fallout)
- fix undefined behavior in a few corner cases
- make Jetson TX1 boot again
- RTS fixes
- implement reset for simple output

----------------------------------------------------------------
AKASHI Takahiro (1):
efi_loader: fix a parameter check at CreateEvent()

Alexander Graf (4):
sandbox: Move BSS after EFI sections
x86: Include bss subsections in linker script
x86: Enable -fdata-sections always
riscv: Include bss subsections in linker script

Eugeniu Rosca (3):
efi: Fix truncation of constant value
efi: Add EFI_MEMORY_{NV, MORE_RELIABLE, RO} attributes
cmd: efi: Clarify calculation precedence for '&' and '?'

Heinrich Schuchardt (7):
efi_loader: relocate pointer to tables
efi_loader: avoid NULL dereference in efi_get_memory_map()
lib: crc32: mark function crc32() as __efi_runtime
efi_loader: update runtime services table crc32
efi_loader: document runtime functions
efi_selftest: correct block device unit test
efi_loader: EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.Reset()

Stephen Warren (1):
Revert "efi_loader: efi_allocate_pages is too restrictive"

 arch/riscv/cpu/ax25/u-boot.lds               |   2 +-
 arch/sandbox/cpu/u-boot.lds                  |   5 +-
 arch/x86/config.mk                           |   4 +-
 arch/x86/cpu/u-boot-64.lds                   |   2 +-
 arch/x86/cpu/u-boot.lds                      |   2 +-
 arch/x86/lib/elf_ia32_efi.lds                |   2 +-
 arch/x86/lib/elf_x86_64_efi.lds              |   2 +-
 cmd/efi.c                                    |  27 ++--
 include/efi.h                                |  28 ++---
 include/efi_loader.h                         |   3 +
 lib/crc32.c                                  |  26 ++--
 lib/efi_loader/efi_boottime.c                |  15 +--
 lib/efi_loader/efi_console.c                 |  22 ++--
 lib/efi_loader/efi_memory.c                  |  13 +-
 lib/efi_loader/efi_runtime.c                 | 177 ++++++++++++++++++++++++++-
 lib/efi_selftest/efi_selftest_block_device.c |   2 +-
 16 files changed, 250 insertions(+), 82 deletions(-)
Quoted 4 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Regards,
Simon

#2 lore raw
Quoted 11 lines · Simon Glass

Hi Alex,

Quoted 5 lines · Alexander Graf

Hi Tom,

This is my current patch queue for efi to be applied for 2018.09. Please pull.

Alex

I still think we should be reverting the offending patch rather than patching on top of it.

Given that, if I'm following right, the fix for this issue is some correct-by-inspection linker script fixes, I think it's OK to make the changes now.

Quoted 79 lines

Are you able to apply my sandbox revert patch in this pull request?

Quoted 69 lines

The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931:

Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400)

are available in the git repository at:

git://github.com/agraf/u-boot.git tags/signed-efi-2018.09

for you to fetch changes up to dbb148b22cbf242156edf53cca6d661cd320cb83:

cmd: efi: Clarify calculation precedence for '&' and '?' (2018-08-21 00:04:24 +0200)

----------------------------------------------------------------
Patch queue for efi - 2018-08-21

A few fixes for 2018.09. Most noticable are:

- unbreak x86 target (-fdata-section fallout)
- fix undefined behavior in a few corner cases
- make Jetson TX1 boot again
- RTS fixes
- implement reset for simple output

----------------------------------------------------------------
AKASHI Takahiro (1):
efi_loader: fix a parameter check at CreateEvent()

Alexander Graf (4):
sandbox: Move BSS after EFI sections
x86: Include bss subsections in linker script
x86: Enable -fdata-sections always
riscv: Include bss subsections in linker script

Eugeniu Rosca (3):
efi: Fix truncation of constant value
efi: Add EFI_MEMORY_{NV, MORE_RELIABLE, RO} attributes
cmd: efi: Clarify calculation precedence for '&' and '?'

Heinrich Schuchardt (7):
efi_loader: relocate pointer to tables
efi_loader: avoid NULL dereference in efi_get_memory_map()
lib: crc32: mark function crc32() as __efi_runtime
efi_loader: update runtime services table crc32
efi_loader: document runtime functions
efi_selftest: correct block device unit test
efi_loader: EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL.Reset()

Stephen Warren (1):
Revert "efi_loader: efi_allocate_pages is too restrictive"

 arch/riscv/cpu/ax25/u-boot.lds               |   2 +-
 arch/sandbox/cpu/u-boot.lds                  |   5 +-
 arch/x86/config.mk                           |   4 +-
 arch/x86/cpu/u-boot-64.lds                   |   2 +-
 arch/x86/cpu/u-boot.lds                      |   2 +-
 arch/x86/lib/elf_ia32_efi.lds                |   2 +-
 arch/x86/lib/elf_x86_64_efi.lds              |   2 +-
 cmd/efi.c                                    |  27 ++--
 include/efi.h                                |  28 ++---
 include/efi_loader.h                         |   3 +
 lib/crc32.c                                  |  26 ++--
 lib/efi_loader/efi_boottime.c                |  15 +--
 lib/efi_loader/efi_console.c                 |  22 ++--
 lib/efi_loader/efi_memory.c                  |  13 +-
 lib/efi_loader/efi_runtime.c                 | 177 ++++++++++++++++++++++++++-
 lib/efi_selftest/efi_selftest_block_device.c |   2 +-
 16 files changed, 250 insertions(+), 82 deletions(-)
Quoted 4 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Regards,
Simon

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180821/e4a077bf/attachment.sig>
author
#3 lore raw
Quoted 8 lines · Tom Rini
Quoted 7 lines · Simon Glass

Hi Alex,

Quoted 4 lines · Alexander Graf

Hi Tom,

This is my current patch queue for efi to be applied for 2018.09. Please pull.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Alex

I still think we should be reverting the offending patch rather than patching on top of it.

Given that, if I'm following right, the fix for this issue is some correct-by-inspection linker script fixes, I think it's OK to make the changes now.

Yeah, I think for x86 the only good way forward is to fix the linker script issues, as the data/function section addition fixed real life bugs with implicitly generated .rodata objects.

Quoted 3 lines
Quoted 3 lines

Are you able to apply my sandbox revert patch in this pull request?

I can't apply anything to this pull request anymore because it's signed. I could do a new one, but I think it's easier to apply this one as is and then apply your revert for sandbox on top.

Alex

#4 lore raw
In reply to Alexander Graf
Quoted 11 lines · Alexander Graf

Hi Tom,

This is my current patch queue for efi to be applied for 2018.09. Please pull.

Alex

The following changes since commit 9f8cf76be256a83643ee05de6cffaeb452ed0931:

Convert CONFIG_SYS_I2C_DAVINCI to Kconfig (2018-08-17 15:43:38 -0400)

Quoted 8 lines

are available in the git repository at:

git://github.com/agraf/u-boot.git tags/signed-efi-2018.09

for you to fetch changes up to dbb148b22cbf242156edf53cca6d661cd320cb83:

cmd: efi: Clarify calculation precedence for '&' and '?' (2018-08-21 00:04:24 +0200)

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180823/b2c7cc61/attachment.sig>