Skip to contentSkip to conversation

remove unnecessray fw declarations

PATCH In review Rami Rosen 2 participants 2 messages Aug 22, 2018 – Nov 18, 2018

lore
Share & tools
lore

Rami Rosen

author
#0 lore raw

PATCH 1/1 remove unnecessray fw declarations

Signed-off-by Rami Rosen <[email protected]>
---
 app/test-pmd/testpmd.c | 3 ---
 1 file changed, 3 deletions(-)
app/test-pmd/testpmd.c +0 -3
index ee48db2a3..8a31722db 100644
@@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id,
 static void eth_dev_event_callback(char *device_name,
 				enum rte_dev_event_type type,
 				void *param);
-static int eth_dev_event_callback_register(void);
-static int eth_dev_event_callback_unregister(void);
-
 
 /*
  * Check if all the ports are started.
Signature · 1 line
2.17.1
#1 lore raw

22/08/2018 16:37, Rami Rosen:

app/test-pmd/testpmd.c static int eth_event_callback(portid_t port_id, · line 439

Quoted 8 lines
app/test-pmd/testpmd.c +0 -2
@@ -435,9 +435,6 @@ static int eth_event_callback(portid_t port_id,
 static void eth_dev_event_callback(char *device_name,
 				enum rte_dev_event_type type,
 				void *param);
-static int eth_dev_event_callback_register(void);
-static int eth_dev_event_callback_unregister(void);

I has been fixed by 2049c5113fe8 ("app/testpmd: use hotplug failure handler").

However I agree that some forward declarations could be removed, ideally all.
Generally speaking, a lot of cleanup could be done in this file.