Skip to contentSkip to conversation

btrfs-progs: print-tree: Skip deprecated blockptr / nodesize output

PATCH Applied Qu Wenruo 2 participants 2 messages Aug 23, 2018 – Sep 11, 2018 Btrfs file system

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 btrfs-progs: print-tree: Skip deprecated blockptr / nodesize output

When printing tree nodes, we output slots like:
key (EXTENT_TREE ROOT_ITEM 0) block 73625600 (17975) gen 16

The number in the parentheses is blockptr / nodesize.

However this number doesn't really do any thing useful.
And in fact for unaligned metadata block group (block group start bytenr is not aligned to 16K), the number doesn't even make sense as it's rounded down.

In factor kernel doesn't ever output such divided result in its print-tree.c

Remove it so later reader won't wonder what the number means.

---
 print-tree.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
print-tree.c +1 -2
index a09ecfbb28f0..31f6fa12522f 100644
@@ -1420,9 +1420,8 @@ void btrfs_print_tree(struct extent_buffer *eb, int follow)
 		btrfs_disk_key_to_cpu(&key, &disk_key);
 		printf("\t");
 		btrfs_print_key(&disk_key);
-		printf(" block %llu (%llu) gen %llu\n",
+		printf(" block %llu gen %llu\n",
 		       (unsigned long long)blocknr,
-		       (unsigned long long)blocknr / eb->len,
 		       (unsigned long long)btrfs_node_ptr_generation(eb, i));
 		fflush(stdout);
 	}
Signature · 1 line
2.18.0
Applied
#1 lore raw
Quoted 10 lines · Qu Wenruo

When printing tree nodes, we output slots like:
key (EXTENT_TREE ROOT_ITEM 0) block 73625600 (17975) gen 16

The number in the parentheses is blockptr / nodesize.

However this number doesn't really do any thing useful.
And in fact for unaligned metadata block group (block group start bytenr is not aligned to 16K), the number doesn't even make sense as it's rounded down.

Quoted 6 lines

In factor kernel doesn't ever output such divided result in its print-tree.c

Remove it so later reader won't wonder what the number means.

Applied, thanks.