ui: remove deprecated UI frontends
v2 cover ui: remove deprecated UI frontends
We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to be removed entirely in the 3.1.0 release. The min GTK3 version can also be bumped up based the distros we aim to support.
Note that before this can merge, the openbsd VM test image needs to be updated to have SDL2, as openbsd build mandates SDL availability.
The freebsd & netbsd images should also be updated, but they are not build blockers as they automatically disable SDL
Changed in v2:
- Rebased to resolve conflicts
Daniel P. Berrangé (3):
ui: remove support for GTK2 in favour of GTK3
ui: increase min required GTK3 version to 3.14.0
ui: remove support for SDL1.2 in favour of SDL2
configure | 111 +---- include/ui/gtk.h | 9 - qemu-deprecated.texi | 16 - ui/Makefile.objs | 5 - ui/gtk-egl.c | 10 +- ui/gtk.c | 202 +------- ui/sdl.c | 1027 ---------------------------------------- ui/sdl_zoom.c | 93 ---- ui/sdl_zoom.h | 25 - ui/sdl_zoom_template.h | 219 --------- 10 files changed, 33 insertions(+), 1684 deletions(-) delete mode 100644 ui/sdl.c delete mode 100644 ui/sdl_zoom.c delete mode 100644 ui/sdl_zoom.h delete mode 100644 ui/sdl_zoom_template.h
Signature · 1 line
2.17.1
PATCH v2 1/3 ui: remove support for GTK2 in favour of GTK3
GTK2 was deprecated in the 2.12.0 release with:
commit b7715af2b31f47060cc5b4be930d16c13be93fa9
Author: Daniel P. Berrange <[email protected]>
Date: Tue Dec 12 11:34:40 2017 +0000
ui: deprecate use of GTK 2.x in favour of 3.x series
The GTK 3.0 release was made in Feb, 2011:
https://blog.gtk.org/2011/02/10/gtk-3-0-released/
That will soon be 7 years ago, which is enough time to consider the 3.x series widely supported.
Thus we deprecate the GTK 2.x support, which will allow us to delete it in the last release of 2018. By this time, GTK 3.x will be almost 8 years old.
Message-id: [email protected]
It is thus able to be removed in the 3.1.0 release.
--- configure | 51 ++---------- include/ui/gtk.h | 9 -- qemu-deprecated.texi | 7 -- ui/gtk-egl.c | 10 +-- ui/gtk.c | 192 ++++--------------------------------------- 5 files changed, 26 insertions(+), 243 deletions(-)
configure +8 -43
@@ -453,7 +453,6 @@ glusterfs_discard="no" glusterfs_fallocate="no" glusterfs_zerofill="no" gtk="" -gtkabi="" gtk_gl="no" tls_priority="NORMAL" gnutls=""
@@ -1369,8 +1368,6 @@ for opt do ;; --disable-pvrdma) pvrdma="no" ;; - --with-gtkabi=*) gtkabi="$optarg" - ;; --disable-vte) vte="no" ;; --enable-vte) vte="yes"
@@ -1658,7 +1655,6 @@ disabled with --disable-FEATURE, default is enabled if available: sdl SDL UI --with-sdlabi select preferred SDL ABI 1.2 or 2.0 gtk gtk UI - --with-gtkabi select preferred GTK ABI 2.0 or 3.0 vte vte support for the gtk UI curses curses UI vnc VNC UI support
@@ -2648,24 +2644,9 @@ fi # GTK probe if test "$gtk" != "no"; then - if test "$gtkabi" = ""; then - # The GTK ABI was not specified explicitly, so try whether 3.0 is available. - # Use 2.0 as a fallback if that is available. - if $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then - gtkabi=3.0 - elif $pkg_config --exists "gtk+-2.0 >= 2.18.0"; then - gtkabi=2.0 - else - gtkabi=3.0 - fi - fi - gtkpackage="gtk+-$gtkabi" - gtkx11package="gtk+-x11-$gtkabi" - if test "$gtkabi" = "3.0" ; then - gtkversion="3.0.0" - else - gtkversion="2.18.0" - fi + gtkpackage="gtk+-3.0" + gtkx11package="gtk+-x11-3.0" + gtkversion="3.0.0" if $pkg_config --exists "$gtkpackage >= $gtkversion"; then gtk_cflags=$($pkg_config --cflags $gtkpackage) gtk_libs=$($pkg_config --libs $gtkpackage)
@@ -2909,16 +2890,11 @@ fi # VTE probe if test "$vte" != "no"; then - if test "$gtkabi" = "3.0"; then - vteminversion="0.32.0" - if $pkg_config --exists "vte-2.91"; then - vtepackage="vte-2.91" - else - vtepackage="vte-2.90" - fi + vteminversion="0.32.0" + if $pkg_config --exists "vte-2.91"; then + vtepackage="vte-2.91" else - vtepackage="vte" - vteminversion="0.24.0" + vtepackage="vte-2.90" fi if $pkg_config --exists "$vtepackage >= $vteminversion"; then vte_cflags=$($pkg_config --cflags $vtepackage)
@@ -2926,11 +2902,7 @@ if test "$vte" != "no"; then vteversion=$($pkg_config --modversion $vtepackage) vte="yes" elif test "$vte" = "yes"; then - if test "$gtkabi" = "3.0"; then - feature_not_found "vte" "Install libvte-2.90/2.91 devel" - else - feature_not_found "vte" "Install libvte devel" - fi + feature_not_found "vte" "Install libvte-2.90/2.91 devel" else vte="no" fi
@@ -6089,12 +6061,6 @@ if test "$sdl_too_old" = "yes"; then echo "-> Your SDL version is too old - please upgrade to have SDL support" fi -if test "$gtkabi" = "2.0"; then - echo - echo "WARNING: Use of GTK 2.0 is deprecated and will be removed in" - echo "WARNING: future releases. Please switch to using GTK 3.0" -fi - if test "$sdlabi" = "1.2"; then echo echo "WARNING: Use of SDL 1.2 is deprecated and will be removed in"
@@ -6414,7 +6380,6 @@ if test "$glib_subprocess" = "yes" ; then fi if test "$gtk" = "yes" ; then echo "CONFIG_GTK=m" >> $config_host_mak - echo "CONFIG_GTKABI=$gtkabi" >> $config_host_mak echo "GTK_CFLAGS=$gtk_cflags" >> $config_host_mak echo "GTK_LIBS=$gtk_libs" >> $config_host_mak if test "$gtk_gl" = "yes" ; then
include/ui/gtk.h +0 -9
@@ -27,15 +27,6 @@#include "ui/egl-context.h" #endif -/* Compatibility define to let us build on both Gtk2 and Gtk3 */ -#if GTK_CHECK_VERSION (3 ,0 ,0 ) -static inline void gdk_drawable_get_size (GdkWindow *w,gint *ww,gint *wh) -{ - *ww =gdk_window_get_width (w); - *wh =gdk_window_get_height (w); -} -#endif -typedef struct GtkDisplayState GtkDisplayState ; typedef struct VirtualGfxConsole {
qemu-deprecated.texi +0 -7
@@ -19,13 +19,6 @@ deprecated. @section Build options -@subsection GTK 2.x - -Previously QEMU has supported building against both GTK 2.x -and 3.x series APIs. Support for the GTK 2.x builds will be -discontinued, so maintainers should switch to using GTK 3.x, -which is the default. - @subsection SDL 1.2 Previously QEMU has supported building against both SDL 1.2
ui/gtk-egl.c +4 -6
@@ -48,11 +48,7 @@ void gd_egl_init(VirtualConsole *vc)return ; } -#if GTK_CHECK_VERSION (3 ,0 ,0 )Window x11_window =gdk_x11_window_get_xid (gdk_window); -#else -Window x11_window =gdk_x11_drawable_get_xid (gdk_window); -#endif if (!x11_window) {return ; }
@@ -82,7 +78,8 @@ void gd_egl_draw(VirtualConsole *vc) vc->gfx.esurface, vc->gfx.ectx); window =gtk_widget_get_window (vc->gfx.drawing_area); -gdk_drawable_get_size (window, &ww, &wh); + ww =gdk_window_get_width (window); + wh =gdk_window_get_height (window);surface_gl_setup_viewport (vc->gfx.gls, vc->gfx.ds, ww, wh);surface_gl_render_texture (vc->gfx.gls, vc->gfx.ds);
@@ -265,7 +262,8 @@ void gd_egl_scanout_flush(DisplayChangeListener *dcl, vc->gfx.esurface, vc->gfx.ectx); window =gtk_widget_get_window (vc->gfx.drawing_area); -gdk_drawable_get_size (window, &ww, &wh); + ww =gdk_window_get_width (window); + wh =gdk_window_get_height (window);egl_fb_setup_default (&vc->gfx.win_fb, ww, wh);if (vc->gfx.cursor_fb.texture) { egl_texture_blit(vc->gfx.gls, &vc->gfx.win_fb, &vc->gfx.guest_fb,
ui/gtk.c +14 -178
362 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v2 2/3 ui: increase min required GTK3 version to 3.14.0
In reply to Daniel P. BerrangéPer supported platforms doc[1], the various min GTK3 on relevant distros is:
RHEL-7.0: 3.8.8
RHEL-7.2: 3.14.13
RHEL-7.4: 3.22.10
RHEL-7.5: 3.22.26
Debian (Stretch): 3.22.11
Debian (Jessie): 3.14.5
OpenBSD (Ports): 3.22.30
FreeBSD (Ports): 3.22.29
OpenSUSE Leap 15: 3.22.30
SLE12-SP2: Unknown
Ubuntu (Xenial): 3.18.9
macOS (Homebrew): 3.22.30
This suggests that a minimum GTK3 of 3.14.0 is a reasonable target, as users are unlikely to be stuck on RHEL-7.0/7.1 still
[1] https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms
--- configure | 2 +- ui/gtk.c | 10 ---------- 2 files changed, 1 insertion(+), 11 deletions(-)
configure +1 -1
@@ -2646,7 +2646,7 @@ fi if test "$gtk" != "no"; then gtkpackage="gtk+-3.0" gtkx11package="gtk+-x11-3.0" - gtkversion="3.0.0" + gtkversion="3.14.0" if $pkg_config --exists "$gtkpackage >= $gtkversion"; then gtk_cflags=$($pkg_config --cflags $gtkpackage) gtk_libs=$($pkg_config --libs $gtkpackage)
ui/gtk.c +0 -10
@@ -998,7 +998,6 @@ static gboolean gd_scroll_event(GtkWidget *widget, GdkEventScroll *scroll, btn =INPUT_BUTTON_WHEEL_UP ; } else if (scroll->direction == GDK_SCROLL_DOWN) { btn =INPUT_BUTTON_WHEEL_DOWN ; -#if GTK_CHECK_VERSION (3 ,4 ,0 ) } else if (scroll->direction == GDK_SCROLL_SMOOTH) { gdouble delta_x, delta_y; if (!gdk_event_get_scroll_deltas((GdkEvent *)scroll,
@@ -1010,7 +1009,6 @@ static gboolean gd_scroll_event(GtkWidget *widget, GdkEventScroll *scroll, }else { btn =INPUT_BUTTON_WHEEL_UP ; } -#endif }else {return TRUE; }
@@ -1672,11 +1670,9 @@ static GSList *gd_vc_menu_init(GtkDisplayState *s, VirtualConsole *vc,gtk_accel_group_connect (s->accel_group,GDK_KEY_1 + idx,HOTKEY_MODIFIERS ,0 ,g_cclosure_new_swap (G_CALLBACK (gd_accel_switch_vc), vc,NULL )); -#if GTK_CHECK_VERSION (3 ,8 ,0 )gtk_accel_label_set_accel (GTK_ACCEL_LABEL (gtk_bin_get_child (GTK_BIN (vc->menu_item))),GDK_KEY_1 + idx,HOTKEY_MODIFIERS ); -#endif g_signal_connect (vc->menu_item,"activate" ,G_CALLBACK (gd_menu_switch_vc), s);
@@ -2167,11 +2163,9 @@ static GtkWidget *gd_create_menu_view(GtkDisplayState *s) TRUE);gtk_accel_group_connect (s->accel_group, GDK_KEY_m,HOTKEY_MODIFIERS ,0 ,g_cclosure_new_swap (G_CALLBACK (gd_accel_show_menubar), s,NULL )); -#if GTK_CHECK_VERSION (3 ,8 ,0 )gtk_accel_label_set_accel (GTK_ACCEL_LABEL (gtk_bin_get_child (GTK_BIN (s->show_menubar_item))), GDK_KEY_m,HOTKEY_MODIFIERS ); -#endif gtk_menu_shell_append (GTK_MENU_SHELL (view_menu), s->show_menubar_item);return view_menu;
@@ -2221,11 +2215,7 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts) s->opts = opts; s->window =gtk_window_new (GTK_WINDOW_TOPLEVEL ); -#if GTK_CHECK_VERSION (3 ,2 ,0 ) s->vbox =gtk_box_new (GTK_ORIENTATION_VERTICAL ,0 ); -#else - s->vbox =gtk_vbox_new (FALSE,0 ); -#endif s->notebook =gtk_notebook_new (); s->menu_bar =gtk_menu_bar_new ();
Signature · 1 line
2.17.1
PATCH v2 3/3 ui: remove support for SDL1.2 in favour of SDL2
In reply to Daniel P. BerrangéSDL1.2 was deprecated in the 2.12.0 release with:
commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa
Author: Daniel P. Berrange <[email protected]>
Date: Mon Jan 15 14:25:33 2018 +0000
ui: deprecate use of SDL 1.2 in favour of 2.0 series
The SDL 2.0 release was made in Aug, 2013:
https://www.libsdl.org/release/
That will soon be 4 + 1/2 years ago, which is enough time to consider the 2.0 series widely supported.
Thus we deprecate the SDL 1.2 support, which will allow us to delete it in the last release of 2018. By this time, SDL 2.0 will be more than 5 years old.
Message-id: [email protected]
It is thus able to be removed in the 3.1.0 release.
--- configure | 60 +-- qemu-deprecated.texi | 9 - ui/Makefile.objs | 5 - ui/sdl.c | 1027 ---------------------------------------- ui/sdl_zoom.c | 93 ---- ui/sdl_zoom.h | 25 - ui/sdl_zoom_template.h | 219 --------- 7 files changed, 7 insertions(+), 1431 deletions(-) delete mode 100644 ui/sdl.c delete mode 100644 ui/sdl_zoom.c delete mode 100644 ui/sdl_zoom.h delete mode 100644 ui/sdl_zoom_template.h
configure +7 -53
@@ -344,7 +344,6 @@ docs="" fdt="" netmap="no" sdl="" -sdlabi="" virtfs="" mpath="" vnc="yes"
@@ -565,7 +564,6 @@ query_pkg_config() { "${pkg_config_exe}" ${QEMU_PKG_CONFIG_FLAGS} "$@" } pkg_config=query_pkg_config -sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}" sdl2_config="${SDL2_CONFIG-${cross_prefix}sdl2-config}" # If the user hasn't specified ARFLAGS, default to 'rv', just as make does.
@@ -1028,8 +1026,6 @@ for opt do ;; --enable-sdl) sdl="yes" ;; - --with-sdlabi=*) sdlabi="$optarg" - ;; --disable-qom-cast-debug) qom_cast_debug="no" ;; --enable-qom-cast-debug) qom_cast_debug="yes"
@@ -1653,7 +1649,6 @@ disabled with --disable-FEATURE, default is enabled if available: nettle nettle cryptography support gcrypt libgcrypt cryptography support sdl SDL UI - --with-sdlabi select preferred SDL ABI 1.2 or 2.0 gtk gtk UI vte vte support for the gtk UI curses curses UI
@@ -2916,37 +2911,11 @@ fi sdl_probe () { - sdl_too_old=no - if test "$sdlabi" = ""; then - if $pkg_config --exists "sdl2"; then - sdlabi=2.0 - elif $pkg_config --exists "sdl"; then - sdlabi=1.2 - else - sdlabi=2.0 - fi - fi - - if test $sdlabi = "2.0"; then - sdl_config=$sdl2_config - sdlname=sdl2 - sdlconfigname=sdl2_config - elif test $sdlabi = "1.2"; then - sdlname=sdl - sdlconfigname=sdl_config - else - error_exit "Unknown sdlabi $sdlabi, must be 1.2 or 2.0" - fi - - if test "$(basename $sdl_config)" != $sdlconfigname && ! has ${sdl_config}; then - sdl_config=$sdlconfigname - fi - - if $pkg_config $sdlname --exists; then - sdlconfig="$pkg_config $sdlname" + if $pkg_config sdl2 --exists; then + sdlconfig="$pkg_config sdl2" sdlversion=$($sdlconfig --modversion 2>/dev/null) elif has ${sdl_config}; then - sdlconfig="$sdl_config" + sdlconfig="$sdl2_config" sdlversion=$($sdlconfig --version) else if test "$sdl" = "yes" ; then
@@ -2968,8 +2937,8 @@ EOF sdl_cflags=$($sdlconfig --cflags 2>/dev/null) sdl_cflags="$sdl_cflags -Wno-undef" # workaround 2.0.8 bug if test "$static" = "yes" ; then - if $pkg_config $sdlname --exists; then - sdl_libs=$($pkg_config $sdlname --static --libs 2>/dev/null) + if $pkg_config sdl2 --exists; then + sdl_libs=$($pkg_config sdl2 --static --libs 2>/dev/null) else sdl_libs=$($sdlconfig --static-libs 2>/dev/null) fi
@@ -2977,11 +2946,7 @@ EOF sdl_libs=$($sdlconfig --libs 2>/dev/null) fi if compile_prog "$sdl_cflags" "$sdl_libs" ; then - if test $(echo $sdlversion | sed 's/[^0-9]//g') -lt 121 ; then - sdl_too_old=yes - else - sdl=yes - fi + sdl=yes # static link with sdl ? (note: sdl.pc's --static --libs is broken) if test "$sdl" = "yes" -a "$static" = "yes" ; then
@@ -2997,7 +2962,7 @@ EOF fi # static link else # sdl not found if test "$sdl" = "yes" ; then - feature_not_found "sdl" "Install SDL devel" + feature_not_found "sdl" "Install SDL2 devel" fi sdl=no fi # sdl compile test
@@ -6057,16 +6022,6 @@ echo "capstone $capstone" echo "docker $docker" echo "libpmem support $libpmem" -if test "$sdl_too_old" = "yes"; then -echo "-> Your SDL version is too old - please upgrade to have SDL support" -fi - -if test "$sdlabi" = "1.2"; then - echo - echo "WARNING: Use of SDL 1.2 is deprecated and will be removed in" - echo "WARNING: future releases. Please switch to using SDL 2.0" -fi - if test "$supported_cpu" = "no"; then echo echo "WARNING: SUPPORT FOR THIS HOST CPU WILL GO AWAY IN FUTURE RELEASES!"
@@ -6269,7 +6224,6 @@ if test "$have_x11" = "yes" -a "$need_x11" = "yes"; then fi if test "$sdl" = "yes" ; then echo "CONFIG_SDL=m" >> $config_host_mak - echo "CONFIG_SDLABI=$sdlabi" >> $config_host_mak echo "SDL_CFLAGS=$sdl_cflags" >> $config_host_mak echo "SDL_LIBS=$sdl_libs" >> $config_host_mak fi
qemu-deprecated.texi +0 -9
@@ -17,15 +17,6 @@ they were first deprecated in the 2.10.0 release. What follows is a list of all features currently marked as deprecated. -@section Build options - -@subsection SDL 1.2 - -Previously QEMU has supported building against both SDL 1.2 -and 2.0 series APIs. Support for the SDL 1.2 builds will be -discontinued, so maintainers should switch to using SDL 2.0, -which is the default. - @section System emulator command line arguments @subsection -no-kvm (since 1.3.0)
ui/Makefile.objs +0 -5
@@ -17,15 +17,10 @@ common-obj-$(call lnot,$(CONFIG_VNC)) += vnc-stubs.o # ui-sdl module common-obj-$(CONFIG_SDL) += sdl.mo -ifeq ($(CONFIG_SDLABI),1.2) -sdl.mo-objs := sdl.o sdl_zoom.o -endif -ifeq ($(CONFIG_SDLABI),2.0) sdl.mo-objs := sdl2.o sdl2-input.o sdl2-2d.o ifeq ($(CONFIG_OPENGL),y) sdl.mo-objs += sdl2-gl.o endif -endif sdl.mo-cflags := $(SDL_CFLAGS) sdl.mo-libs := $(SDL_LIBS)
ui/sdl.c deleted +0 -1027
1,027 lines not on this page · raw message
ui/sdl_zoom.c deleted +0 -93
93 lines not on this page · raw message
ui/sdl_zoom.h deleted +0 -25
@@ -1,25 +0,0 @@ -/* -* SDL_zoom - surface scaling -* -* Copyright (c) 2009 Citrix Systems, Inc. -* -* Derived from: SDL_rotozoom, LGPL (c) A. Schiffler from the SDL_gfx library. -* Modifications by Stefano Stabellini. -* -* This work is licensed under the terms of the GNU GPL version 2. -* See the COPYING file in the top-level directory. -* -*/ - -#ifndef SDL_ZOOM_H -#define SDL_ZOOM_H - -#include <SDL.h> - -#define SMOOTHING_OFF 0 -#define SMOOTHING_ON 1 - -int sdl_zoom_blit (SDL_Surface *src_sfc,SDL_Surface *dst_sfc, -int smooth,SDL_Rect *src_rect); - -#endif /* SDL_ZOOM_H */
ui/sdl_zoom_template.h deleted +0 -219
219 lines not on this page · raw message
Signature · 1 line
2.17.1
Quoted 6 lines · Daniel P. Berrangé
We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to be removed entirely in the 3.1.0 release. The min GTK3 version can also be bumped up based the distros we aim to support.
Note that before this can merge, the openbsd VM test image needs to be updated to have SDL2, as openbsd build mandates SDL availability.
I'll send a patch to upgrade and convert openbsd to use auto_install soon.
Fam
Quoted 32 lines
The freebsd & netbsd images should also be updated, but they are not build blockers as they automatically disable SDL
Changed in v2:
- Rebased to resolve conflicts
Daniel P. Berrangé (3):
ui: remove support for GTK2 in favour of GTK3
ui: increase min required GTK3 version to 3.14.0
ui: remove support for SDL1.2 in favour of SDL2configure | 111 +---- include/ui/gtk.h | 9 - qemu-deprecated.texi | 16 - ui/Makefile.objs | 5 - ui/gtk-egl.c | 10 +- ui/gtk.c | 202 +------- ui/sdl.c | 1027 ---------------------------------------- ui/sdl_zoom.c | 93 ---- ui/sdl_zoom.h | 25 - ui/sdl_zoom_template.h | 219 --------- 10 files changed, 33 insertions(+), 1684 deletions(-) delete mode 100644 ui/sdl.c delete mode 100644 ui/sdl_zoom.c delete mode 100644 ui/sdl_zoom.h delete mode 100644 ui/sdl_zoom_template.hSignature · 1 line
2.17.1
Quoted 10 lines · Daniel P. Berrangé
We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to be removed entirely in the 3.1.0 release. The min GTK3 version can also be bumped up based the distros we aim to support.
Note that before this can merge, the openbsd VM test image needs to be updated to have SDL2, as openbsd build mandates SDL availability.
The freebsd & netbsd images should also be updated, but they are not build blockers as they automatically disable SDL
Quoted 8 lines
Changed in v2:
- Rebased to resolve conflicts
Daniel P. Berrangé (3):
ui: remove support for GTK2 in favour of GTK3
ui: increase min required GTK3 version to 3.14.0
ui: remove support for SDL1.2 in favour of SDL2
Nit: you might want to tweak some parts of the commit messages, because they're no longer accurate...
Quoted 6 lines
The GTK 3.0 release was made in Feb, 2011:
https://blog.gtk.org/2011/02/10/gtk-3-0-released/
That will soon be 7 years ago, which is enough time to consider the 3.x series widely supported.
It's been more than 7 years now.
Quoted 6 lines
The SDL 2.0 release was made in Aug, 2013:
https://www.libsdl.org/release/
That will soon be 4 + 1/2 years ago, which is enough time to consider the 2.0 series widely supported.
It's been more than 5 years now.
Signature · 1 line
Andrea Bolognani / Red Hat / Virtualization