scripts: report on author emails that are mangled by the mailing list
PATCH 1/1 scripts: report on author emails that are mangled by the mailing list
In some cases the Author: email address in patches submitted to the list gets mangled such that it says
John Doe via Qemu-devel <[email protected]>
This change is a result of workarounds for DMARC policies.
Subsystem maintainers accepting patches need to catch these and fix them before sending pull requests, so a checkpatch.pl test is highly desirable.
--- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+)
scripts/checkpatch.pl +4 -0
@@ -1402,6 +1402,10 @@ sub process { $is_patch = 1; } + if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) { + ERROR("Author email address is mangled by the mailing list\n" . $herecurr); + } + #check the patch for a signoff: if ($line =~ /^\s*signed-off-by:/i) { # This is a signoff, if ugly, so do not double report.
Signature · 1 line
2.17.1
Quoted 21 lines · On Thu, 23 Aug 2018 11:25:02 +0100 Daniel P. Berrangé <[email protected]>…
In some cases the Author: email address in patches submitted to the list gets mangled such that it says
John Doe via Qemu-devel <[email protected]>
This change is a result of workarounds for DMARC policies.
Subsystem maintainers accepting patches need to catch these and fix them before sending pull requests, so a checkpatch.pl test is highly desirable.
Signed-off-by Daniel P. Berrangé <[email protected]>--- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+)scripts/checkpatch.pl +0
-0
scripts/checkpatch.pl sub process { · line 1411
Quoted 10 lines
scripts/checkpatch.pl +4
-0@@ -1402,6 +1402,10 @@ sub process { $is_patch = 1; } + if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) { + ERROR("Author email address is mangled by the mailing list\n" . $herecurr); + } + #check the patch for a signoff: if ($line =~ /^\s*signed-off-by:/i) { # This is a signoff, if ugly, so do not double report.
Quoted 6 lines · Daniel P. Berrangé
In some cases the Author: email address in patches submitted to the list gets mangled such that it says
John Doe via Qemu-devel <[email protected]>
This change is a result of workarounds for DMARC policies.
I do wonder if overall we'd be better off with the other workaround (don't change From lines in list emails, don't add "[Qemu-devel]" prefix to subject lines)... It would be a one-off annoyance to people who filter list mail on subject rather than other headers, but it would get rid of this annoying wart where a handful of senders end up with their mail with a from address that our patch management tools don't handle very well...
thanks
-- PMM
Quoted 8 lines · Peter Maydell
Quoted 6 lines · Daniel P. Berrangé
In some cases the Author: email address in patches submitted to the list gets mangled such that it says
John Doe via Qemu-devel <[email protected]>
This change is a result of workarounds for DMARC policies.
Quoted 8 lines
I do wonder if overall we'd be better off with the other workaround (don't change From lines in list emails, don't add "[Qemu-devel]" prefix to subject lines)... It would be a one-off annoyance to people who filter list mail on subject rather than other headers, but it would get rid of this annoying wart where a handful of senders end up with their mail with a from address that our patch management tools don't handle very well...
I kind of like seeing the qemu-devel prefix, since I don't tend to pre-filter email into separate folders per list. I only do per-list filtering (on headers) once at start of the day when reading the overnight backlog. For rest of the day have a single inbox and tend to rely on subject alone.
Of course the prefix isn't entirely reliable regardless, as if you are CC'd on mails you'll probably see the copy delivered via the CC long before you get the copy via the list.
AFAIK, the libvirt mailing list isn't mangling From lines, and it also has a subject prefix added, so I wonder why it doesn't have a need for the same workaround wrt DMARC ? Or maybe it does need it and we've never realized.
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 8 lines · Peter Maydell
Quoted 6 lines · Daniel P. Berrangé
In some cases the Author: email address in patches submitted to the list gets mangled such that it says
John Doe via Qemu-devel <[email protected]>
This change is a result of workarounds for DMARC policies.
Quoted 8 lines
I do wonder if overall we'd be better off with the other workaround (don't change From lines in list emails, don't add "[Qemu-devel]" prefix to subject lines)... It would be a one-off annoyance to people who filter list mail on subject rather than other headers, but it would get rid of this annoying wart where a handful of senders end up with their mail with a from address that our patch management tools don't handle very well...
Mangling e-mail headers is a bad idea. The fact that it's commonly held only makes it worse.
If you can hack QEMU, filtering on List-Id should not be an insurmountable obstacle.
Quoted 7 lines · Daniel P. Berrangé
In some cases the Author: email address in patches submitted to the list gets mangled such that it says
John Doe via Qemu-devel <[email protected]>
This change is a result of workarounds for DMARC policies.
Quoted 9 lines
Subsystem maintainers accepting patches need to catch these and fix them before sending pull requests, so a checkpatch.pl test is highly desirable.
Signed-off-by Daniel P. Berrangé <[email protected]>--- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+)
Adding it here will let patchew flag such message; the workaround is for the submitter to resubmit with an explicit 'From: User Name <[email protected]>' line in the body of the email.
Signature · 3 lines
Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Copying Paolo, since this probably falls under the "misc patches" maintainer bucket.
Quoted 34 lines · Daniel P. Berrangé
In some cases the Author: email address in patches submitted to the list gets mangled such that it says
John Doe via Qemu-devel <[email protected]>
This change is a result of workarounds for DMARC policies.
Subsystem maintainers accepting patches need to catch these and fix them before sending pull requests, so a checkpatch.pl test is highly desirable.
Signed-off-by Daniel P. Berrangé <[email protected]>--- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+)scripts/checkpatch.pl +4
-0@@ -1402,6 +1402,10 @@ sub process { $is_patch = 1; } + if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) { + ERROR("Author email address is mangled by the mailing list\n" . $herecurr); + } + #check the patch for a signoff: if ($line =~ /^\s*signed-off-by:/i) { # This is a signoff, if ugly, so do not double report.Signature · 1 line
2.17.1
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 2 lines · Daniel P. Berrangé
Copying Paolo, since this probably falls under the "misc patches" maintainer bucket.
I think we should define a "generic maintainer stuff" bucket where every maintainer is supposed to send patches with a Reviewed-by. Maintainers are probably good enough at getting reviews by an appropriate person.
(I am slowly trying to remove stuff from the misc bucket).
Paolo
Quoted 39 lines · Daniel P. Berrangé
Quoted 34 lines
In some cases the Author: email address in patches submitted to the list gets mangled such that it says
John Doe via Qemu-devel <[email protected]>
This change is a result of workarounds for DMARC policies.
Subsystem maintainers accepting patches need to catch these and fix them before sending pull requests, so a checkpatch.pl test is highly desirable.
Signed-off-by Daniel P. Berrangé <[email protected]>--- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+)scripts/checkpatch.pl +4
-0@@ -1402,6 +1402,10 @@ sub process { $is_patch = 1; } + if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) { + ERROR("Author email address is mangled by the mailing list\n" . $herecurr); + } + #check the patch for a signoff: if ($line =~ /^\s*signed-off-by:/i) { # This is a signoff, if ugly, so do not double report.Signature · 1 line
2.17.1Regards,
Daniel
Quoted 9 lines · Paolo Bonzini
Quoted 2 lines · Daniel P. Berrangé
Copying Paolo, since this probably falls under the "misc patches" maintainer bucket.
I think we should define a "generic maintainer stuff" bucket where every maintainer is supposed to send patches with a Reviewed-by. Maintainers are probably good enough at getting reviews by an appropriate person.
(I am slowly trying to remove stuff from the misc bucket).
Ah, so you mean, any maintainer would be expected to directly send a PULL for any "generic" patches they had collected acks for.
That would makes sense to me, since we don't seem to be making much progress in getting all source files to have an explicit maintainer.
Regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|