Skip to contentSkip to conversation

doc: fix wrong usage of bind command

PATCH In review Rami Rosen 3 participants 3 messages Aug 24, 2018 – Sep 10, 2018

lore
Share & tools
lore

Rami Rosen

author
#0 lore raw

PATCH 1/1 doc: fix wrong usage of bind command

This patch fixes wrong usage of bind command in vhost.rst. Using "dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0" gives an error of "unbind failed". It should be "-b uio_pci_generic" so it will work correctly.

Signed-off-by Rami Rosen <[email protected]>
---
 doc/guides/sample_app_ug/vhost.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/sample_app_ug/vhost.rst +1 -1
index fd42cb3f7..df4d6f9a0 100644
@@ -78,7 +78,7 @@ could be done by:
 .. code-block:: console
 
    modprobe uio_pci_generic
-   $RTE_SDK/usertools/dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0
+   $RTE_SDK/usertools/dpdk-devbind.py -b uio_pci_generic 0000:00:04.0
 
 Then start testpmd for packet forwarding testing.
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Rami Rosen
Sent: Friday, August 24, 2018 3:43 PM
To: [email protected]
Cc: [email protected]; Mcnamara, John <[email protected]>; Rami Rosen <[email protected]>
Subject: [dpdk-dev] [PATCH] doc: fix wrong usage of bind command

Quoted 6 lines

This patch fixes wrong usage of bind command in vhost.rst.
Using "dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0" gives an error of "unbind failed". It should be "-b uio_pci_generic" so it will work correctly.

Signed-off-by Rami Rosen <[email protected]>

---

Acked-by Zhiyong Yang <[email protected]>
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rami Rosen
Quoted 16 lines · Rami Rosen

This patch fixes wrong usage of bind command in vhost.rst. Using "dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0" gives an error of "unbind failed". It should be "-b uio_pci_generic" so it will work correctly.

Signed-off-by Rami Rosen <[email protected]>
---
  doc/guides/sample_app_ug/vhost.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
doc/guides/sample_app_ug/vhost.rst +0 -0
index fd42cb3f7..df4d6f9a0 100644

doc/guides/sample_app_ug/vhost.rst could be done by: · line 84

Quoted 8 lines
doc/guides/sample_app_ug/vhost.rst +1 -1
@@ -78,7 +78,7 @@ could be done by:
  .. code-block:: console
 
     modprobe uio_pci_generic
-   $RTE_SDK/usertools/dpdk-devbind.py -b=uio_pci_generic 0000:00:04.0
+   $RTE_SDK/usertools/dpdk-devbind.py -b uio_pci_generic 0000:00:04.0
 
  Then start testpmd for packet forwarding testing.
Reviewed-by Maxime Coquelin <[email protected]>

And applied to dpdk-next-virtio/master

Thanks,
Maxime