Skip to contentSkip to conversation

arm64: dts: msm: add PDC device bindings for sdm845

PATCH Superseded Lina Iyer 2 participants 3 messages Aug 24, 2018 – Aug 29, 2018

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support irqchip drivers
lore
Share & tools
lore

Lina Iyer

author
#0 lore raw

PATCH v3 1/2 arm64: dts: msm: add PDC device bindings for sdm845

Add PDC interrupt controller device bindings for SDM845.

Signed-off-by Lina Iyer <[email protected]>

---
Changes in v3:
- Fix PDC map, use GIC SPI port number for hwirq
Changes in v2:
- Order by address

---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/qcom/sdm845.dtsi +9 -0
index b3d7af097edf..0208f8557ffa 100644
@@ -966,6 +966,15 @@
 			};
 		};
 
+		pdc: interrupt-controller@b220000 {
+			compatible = "qcom,sdm845-pdc";
+			reg = <0xb220000 0x30000>;
+			qcom,pdc-ranges = <0 480 94>, <94 609 15>, <115 630 7>;
+			#interrupt-cells = <2>;
+			interrupt-parent = <&intc>;
+			interrupt-controller;
+		};
+
 		spmi_bus: spmi@c440000 {
 			compatible = "qcom,spmi-pmic-arb";
 			reg = <0xc440000 0x1100>,
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#1 lore raw

PATCH v3 2/2 dt-bindings/interrupt-controller: pdc: fix example to match actual bindings

The PDC map should use the GIC SPI port and not the vector. GIC internally adds 32 to SPI hwirq numbers.

Fixes 1ae8862e27e ("dt-bindings/interrupt-controller: pdc: Describe PDC device binding")
Signed-off-by Lina Iyer <[email protected]>
---
 .../devicetree/bindings/interrupt-controller/qcom,pdc.txt     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt +2 -2
index 0b2c97ddb520..30f2f10d75e9 100644
@@ -61,13 +61,13 @@ Example:
 	pdc: interrupt-controller@b220000 {
 		compatible = "qcom,sdm845-pdc";
 		reg = <0xb220000 0x30000>;
-		qcom,pdc-ranges = <0 512 94>, <94 641 15>, <115 662 7>;
+		qcom,pdc-ranges = <0 480 94>, <94 609 15>, <115 630 7>;
 		#interrupt-cells = <2>;
 		interrupt-parent = <&intc>;
 		interrupt-controller;
 	};
 
-DT binding of a device that wants to use the GIC SPI 514 as a wakeup
+DT binding of a device that wants to use the GIC SPI 482 as a wakeup
 interrupt, must do -
 
 	wake-device {
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
maintainer Reviewed-by on v3 2/2
#2 lore raw

Re: [PATCH v3 2/2] dt-bindings/interrupt-controller: pdc: fix example to match actual bindings

Quoted 9 lines · Lina Iyer

The PDC map should use the GIC SPI port and not the vector. GIC internally adds 32 to SPI hwirq numbers.

Fixes 1ae8862e27e ("dt-bindings/interrupt-controller: pdc: Describe PDC device binding")
Signed-off-by Lina Iyer <[email protected]>
---
 .../devicetree/bindings/interrupt-controller/qcom,pdc.txt     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by Rob Herring <[email protected]>