staging: comedi: drivers: adl_pci9118: Fixes format of line 1283.
PATCH 1/1 staging: comedi: drivers: adl_pci9118: Fixes format of line 1283.
Checkpatch repored "Lines should not end with a '('" for line 1283.
Moved opening parenthesis of function on line 1283 onto next line.
--- drivers/staging/comedi/drivers/adl_pci9118.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/adl_pci9118.c +2 -2
@@ -1280,8 +1280,8 @@ static int pci9118_ai_cmdtest(struct comedi_device *dev, }else { arg = cmd->convert_arg * cmd->chanlist_len; } - err |=comedi_check_trigger_arg_min ( - &cmd->scan_begin_arg, arg); + err |=comedi_check_trigger_arg_min + (&cmd->scan_begin_arg, arg); } }
Signature · 1 line
2.14.1
PATCH 1/1 staging: comedi: drivers: dt3000: Fixes warning on multiline dereference.
Checkpatch complains about a pointer dereference on line 442-444 being split across multiple lines.
Merged the pointer dereference into one line and moved it along with the other function call parameters onto the following line so it would fit without exceeding the 80 character line limit.
--- drivers/staging/comedi/drivers/dt3000.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/comedi/drivers/dt3000.c +2 -3
@@ -439,9 +439,8 @@ static int dt3k_ai_cmdtest(struct comedi_device *dev,if (cmd->scan_begin_src ==TRIG_TIMER ) { arg = cmd->convert_arg * cmd->scan_end_arg; - err |=comedi_check_trigger_arg_min (&cmd-> - scan_begin_arg, - arg); + err |=comedi_check_trigger_arg_min + (&cmd->scan_begin_arg, arg); } }
Signature · 1 line
2.14.1
Quoted 14 lines · Sven Luthi
Checkpatch repored "Lines should not end with a '('" for line 1283.
Moved opening parenthesis of function on line 1283 onto next line.
Signed-off-by Sven Luthi <[email protected]>--- drivers/staging/comedi/drivers/adl_pci9118.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/comedi/drivers/adl_pci9118.c +0
-0
drivers/staging/comedi/drivers/adl_pci9118.c static int pci9118_ai_cmdtest(struct comedi_device *dev, · line 1284
Quoted 7 lines
drivers/staging/comedi/drivers/adl_pci9118.c +2
-2@@ -1280,8 +1280,8 @@ static int pci9118_ai_cmdtest(struct comedi_device *dev, }else { arg = cmd->convert_arg * cmd->chanlist_len; } - err |=comedi_check_trigger_arg_min ( - &cmd->scan_begin_arg, arg); + err |=comedi_check_trigger_arg_min + (&cmd->scan_begin_arg, arg);
The original is fine. It's probably better than the new version. Checkpatch.pl is just a hint, not a command.
regards,
dan carpenter