sunxi-mali-mainline*: add arm64 build support and

PATCH New Giulio Benetti 3 participants 13 messages Aug 22, 2018 – Aug 26, 2018 Arm/Allwinner sunXi SoC support

Share & tools

Giulio Benetti

author

2018-08-22 00:06 UTC #0 lore raw

v2 cover sunxi-mali-mainline*: add arm64 build support and

Blobs for arm64(aarch64) and r8p1 version are available at Bootlin Github. r8p1 driver support has been added at mripard Github.

Add support on both sunxi-mali-mainline and sunxi-mali-mainline-driver packages to:
- Build on arm64(aarch64).
- use r8p1 blob version.

Changes V1->V2:
- make sunxi-mali-mainline changes in one patch to be bi-sectable.
- make sunxi-mali-mainline-driver changes in one patch to be bi-sectable.

Giulio Benetti (2):
sunxi-mali-mainline: add support for arm64(aarch64) architecture and
r8p1 blob version.
sunxi-mali-mainline-driver: bump version and add support for building

    on arm64(aarch64).

 .../sunxi-mali-mainline-driver.mk                 |  8 +++++++-
 package/sunxi-mali-mainline/Config.in             |  6 ++++--
 .../sunxi-mali-mainline/sunxi-mali-mainline.mk    | 15 ++++++++++-----
 3 files changed, 21 insertions(+), 8 deletions(-)

Signature · 1 line

2.17.1

Giulio Benetti

author

2018-08-22 00:06 UTC #1 lore raw

PATCH v2 1/2 sunxi-mali-mainline: add support for arm64(aarch64) architecture and r8p1 blob version.

Blobs for arm64(aarch64) and r8p1 version are now available at Bootlin Github.

So:
- Bump version to latest commit:
For arm64 architecture and r8p1 version.

git shortlog --no-merges cb3e8ece9b2c3a70cbeb3204cd6f30eceaa32023.. Giulio Benetti (1):
Reorder folders splitting includes and libraries.

Maxime Ripard (6):
Move binaries to an arch subfolder
Make x11 binaries path consistent
Add r6p2 arm wayland blobs
Add r6p2 arm64 blobs
Add r8p1 fbdev blobs
Add r8p1 arm64 fbdev blobs

- Add support for them also under arm64(aarch64) architecture copying the right blobs according to architecture(arm or arm64) checking if BR2_arm or BR2_aarch64 is enabled.
Only BR2_arm needs to provide BR2_ARM_EABIHF, so check must be done only in that case.
- Mali-blobs repository folder layout has been reordered, so modify path when copying headers and libraries.
- When copying libraries copy only *.so* files to avoid useless files to end into target folder.

Signed-off-by Giulio Benetti <[email protected]>

---
 package/sunxi-mali-mainline/Config.in             |  6 ++++--
 .../sunxi-mali-mainline/sunxi-mali-mainline.mk    | 15 ++++++++++-----
 2 files changed, 14 insertions(+), 7 deletions(-)

package/sunxi-mali-mainline/Config.in +4 -2

index 759bed86ba..a889864465 100644
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_SUNXI_MALI_MAINLINE
 	bool "sunxi-mali-mainline"
-	depends on BR2_arm
-	depends on BR2_ARM_EABIHF
+	depends on BR2_aarch64 || (BR2_ARM_EABIHF && BR2_arm)
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	select BR2_PACKAGE_HAS_LIBEGL
 	select BR2_PACKAGE_HAS_LIBGLES

@@ -26,12 +25,15 @@ choice
 
 config BR2_PACKAGE_SUNXI_MALI_MAINLINE_R6P2
 	bool "r6p2"
+config BR2_PACKAGE_SUNXI_MALI_MAINLINE_R8P1
+	bool "r8p1"
 
 endchoice
 
 config BR2_PACKAGE_SUNXI_MALI_MAINLINE_REVISION
 	string
 	default "r6p2"	if BR2_PACKAGE_SUNXI_MALI_MAINLINE_R6P2
+	default "r8p1"	if BR2_PACKAGE_SUNXI_MALI_MAINLINE_R8P1
 
 endif

package/sunxi-mali-mainline/sunxi-mali-mainline.mk +10 -5

index 933e2beb0d..05b90f0bee 100644
@@ -4,20 +4,25 @@
 #
 ################################################################################
 
-SUNXI_MALI_MAINLINE_VERSION = cb3e8ece9b2c3a70cbeb3204cd6f30eceaa32023
+SUNXI_MALI_MAINLINE_VERSION = d691cb93884ca8ac67860502117bbec283dc19aa
 SUNXI_MALI_MAINLINE_SITE = $(call github,free-electrons,mali-blobs,$(SUNXI_MALI_MAINLINE_VERSION))
 SUNXI_MALI_MAINLINE_INSTALL_STAGING = YES
 SUNXI_MALI_MAINLINE_PROVIDES = libegl libgles
 
 SUNXI_MALI_MAINLINE_REV = $(call qstrip,$(BR2_PACKAGE_SUNXI_MALI_MAINLINE_REVISION))
 
+ifeq ($(BR2_arm),y)
+SUNXI_MALI_MAINLINE_ARCH=arm
+else ifeq ($(BR2_aarch64),y)
+SUNXI_MALI_MAINLINE_ARCH=arm64
+endif
+
 define SUNXI_MALI_MAINLINE_INSTALL_STAGING_CMDS
 	mkdir -p $(STAGING_DIR)/usr/lib $(STAGING_DIR)/usr/include
 
-	cp -rf $(@D)/$(SUNXI_MALI_MAINLINE_REV)/fbdev/lib/lib_fb_dev/* \
+	cp -rf $(@D)/$(SUNXI_MALI_MAINLINE_REV)/$(SUNXI_MALI_MAINLINE_ARCH)/fbdev/*.so* \
 		$(STAGING_DIR)/usr/lib/
-	cp -rf $(@D)/$(SUNXI_MALI_MAINLINE_REV)/fbdev/include/* \
-		$(STAGING_DIR)/usr/include/
+	cp -rf $(@D)/include/fbdev/* $(STAGING_DIR)/usr/include/
 
 	$(INSTALL) -D -m 0644 package/sunxi-mali-mainline/egl.pc \
 		$(STAGING_DIR)/usr/lib/pkgconfig/egl.pc

@@ -27,7 +32,7 @@ endef
 
 define SUNXI_MALI_MAINLINE_INSTALL_TARGET_CMDS
 	mkdir -p $(TARGET_DIR)/usr/lib
-	cp -rf $(@D)/$(SUNXI_MALI_MAINLINE_REV)/fbdev/lib/lib_fb_dev/* \
+	cp -rf $(@D)/$(SUNXI_MALI_MAINLINE_REV)/$(SUNXI_MALI_MAINLINE_ARCH)/fbdev/*.so* \
 		$(TARGET_DIR)/usr/lib/
 endef

Signature · 1 line

2.17.1

Thomas Petazzoni

2018-08-22 11:21 UTC #2 lore raw

PATCH v2 1/2 sunxi-mali-mainline: add support for arm64(aarch64) architecture and r8p1 blob version.

Hello,

Quoted 29 lines · Giulio Benetti

Blobs for arm64(aarch64) and r8p1 version are now available at Bootlin Github.
So:
- Bump version to latest commit:
For arm64 architecture and r8p1 version.
git shortlog --no-merges cb3e8ece9b2c3a70cbeb3204cd6f30eceaa32023.. Giulio Benetti (1):
Reorder folders splitting includes and libraries.
Maxime Ripard (6):
Move binaries to an arch subfolder
Make x11 binaries path consistent
Add r6p2 arm wayland blobs
Add r6p2 arm64 blobs
Add r8p1 fbdev blobs
Add r8p1 arm64 fbdev blobs
- Add support for them also under arm64(aarch64) architecture copying the right blobs according to architecture(arm or arm64) checking if BR2_arm or BR2_aarch64 is enabled.
Only BR2_arm needs to provide BR2_ARM_EABIHF, so check must be done only in that case.
- Mali-blobs repository folder layout has been reordered, so modify path when copying headers and libraries.
- When copying libraries copy only *.so* files to avoid useless files to end into target folder.

Quoted 5 lines

Signed-off-by Giulio Benetti <[email protected]>

---
 package/sunxi-mali-mainline/Config.in             |  6 ++++--
 .../sunxi-mali-mainline/sunxi-mali-mainline.mk    | 15 ++++++++++-----
 2 files changed, 14 insertions(+), 7 deletions(-)

This could have been three patches: one bumping the version, one adding support for the r8p1 version, and one adding support for aarch64. But OK, I've applied as is, as the patch wasn't too large. But for your next contributions, please make sure to split them in logical changes.

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Giulio Benetti

author

2018-08-22 00:06 UTC #3 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

In reply to Giulio Benetti

Blobs for arm64(aarch64) are available at Bootlin Github and sunxi-mali-mainline package has been updated to support them.

Add support for building on arm64(aarch64):
- Bump version to latest commit:
For support H3 and H5 SoCs and r8p1 driver version.

git shortlog --invert-grep --grep travis --no-merges 52ef1c5e133cc5fd791ca636239dc5e7b19c26d5.. Maxime Ripard (6):
Add r8p1 release
sunxi: Move the reset test to a function
sunxi: Add H3 support
sunxi: Add H5 support
sunxi: Remove generic compatible
sunxi: Set clock rate in the driver

- Add ARCH=arm or ARCH=arm64 to SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS to build for the right architecture according to BR2_arm or BR2_aarch64.

Signed-off-by Giulio Benetti <[email protected]>

---
 .../sunxi-mali-mainline-driver.mk                         | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

package/sunxi-mali-mainline-driver/sunxi-mali-mainline-driver.mk +7 -1

index 24817b07c7..e7a5ed2079 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-SUNXI_MALI_MAINLINE_DRIVER_VERSION = 52ef1c5e133cc5fd791ca636239dc5e7b19c26d5
+SUNXI_MALI_MAINLINE_DRIVER_VERSION = 8e6b7d25b13089d53dbfc1ebd9e8737b0dc809cb
 SUNXI_MALI_MAINLINE_DRIVER_SITE = $(call github,mripard,sunxi-mali,$(SUNXI_MALI_MAINLINE_DRIVER_VERSION))
 SUNXI_MALI_MAINLINE_DRIVER_DEPENDENCIES = linux

@@ -13,6 +13,12 @@ SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS = \
 	CROSS_COMPILE=$(TARGET_CROSS) \
 	INSTALL_MOD_PATH=$(TARGET_DIR)
 
+ifeq ($(BR2_arm),y)
+SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS += ARCH=arm
+else ifeq ($(BR2_aarch64),y)
+SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS += ARCH=arm64
+endif
+
 define SUNXI_MALI_MAINLINE_DRIVER_USE_APPLY_PATCHES
 	ln -sf $(SUNXI_MALI_MAINLINE_REV)/series $(@D)/patches
 	$(SED) 's|quilt push -a|$(TOPDIR)/support/scripts/apply-patches.sh . ../patches|' \

Signature · 1 line

2.17.1

Thomas Petazzoni

2018-08-22 11:29 UTC #4 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

Hello Giulio,

Quoted 16 lines · Giulio Benetti

Blobs for arm64(aarch64) are available at Bootlin Github and sunxi-mali-mainline package has been updated to support them.
Add support for building on arm64(aarch64):
- Bump version to latest commit:
For support H3 and H5 SoCs and r8p1 driver version.
git shortlog --invert-grep --grep travis --no-merges 52ef1c5e133cc5fd791ca636239dc5e7b19c26d5.. Maxime Ripard (6):
Add r8p1 release
sunxi: Move the reset test to a function
sunxi: Add H3 support
sunxi: Add H5 support
sunxi: Remove generic compatible
sunxi: Set clock rate in the driver

Quoted 4 lines

- Add ARCH=arm or ARCH=arm64 to SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS to build for the right architecture according to BR2_arm or BR2_aarch64.
Signed-off-by Giulio Benetti <[email protected]>

So actually your PATCH 1/2 without PATCH 2/2 is broken, because PATCH 1/2 now allows to enable sunxi-mali-mainline on AArch64, but sunxi-mali-mainline-driver does not support AArch64. It seems like you have some issue understanding the concept of bisectability :-)

Anyway, now that PATCH 1/2 is applied and pushed, it's too late to back out.

package/sunxi-mali-mainline-driver/sunxi-mali-mainline-driver.mk SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS = \ · line 20

Quoted 9 lines

package/sunxi-mali-mainline-driver/sunxi-mali-mainline-driver.mk +5 -0

@@ -13,6 +13,12 @@ SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS = \
 	CROSS_COMPILE=$(TARGET_CROSS) \
 	INSTALL_MOD_PATH=$(TARGET_DIR)
 
+ifeq ($(BR2_arm),y)
+SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS += ARCH=arm
+else ifeq ($(BR2_aarch64),y)
+SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS += ARCH=arm64
+endif

Could you instead change the .mk to do this:

SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS = \
	$(LINUX_MAKE_FLAGS) \
        KDIR=$(LINUX_DIR)

Indeed, LINUX_MAKE_FLAGS already include CROSS_COMPILE, INSTALL_MOD_PATH and ARCH.

As separate commits, please add hash files for both sunxi-mali-mainline and sunxi-mainline-driver. Also, it would be good to have patches adding license information for both of those packages. For the mali-blobs, there's a PDF containing the EULA. For the kernel driver, I didn't see a license file, but I didn't look everywhere. If there is none, could you check with Maxime to make sure a license file gets added ?

Thanks,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Giulio Benetti

author

2018-08-22 18:37 UTC #5 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

Hello,

Il 22/08/2018 13:29, Thomas Petazzoni ha scritto:

Quoted 22 lines

Hello Giulio,
Quoted 19 lines · Giulio Benetti
Blobs for arm64(aarch64) are available at Bootlin Github and sunxi-mali-mainline package has been updated to support them.
Add support for building on arm64(aarch64):
- Bump version to latest commit:
For support H3 and H5 SoCs and r8p1 driver version.
git shortlog --invert-grep --grep travis --no-merges 52ef1c5e133cc5fd791ca636239dc5e7b19c26d5.. Maxime Ripard (6):
Add r8p1 release
sunxi: Move the reset test to a function
sunxi: Add H3 support
sunxi: Add H5 support
sunxi: Remove generic compatible
sunxi: Set clock rate in the driver
- Add ARCH=arm or ARCH=arm64 to SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS to build for the right architecture according to BR2_arm or BR2_aarch64.

Quoted 6 lines

Quoted 1 line
Signed-off-by Giulio Benetti <[email protected]>
So actually your PATCH 1/2 without PATCH 2/2 is broken, because PATCH 1/2 now allows to enable sunxi-mali-mainline on AArch64, but sunxi-mali-mainline-driver does not support AArch64. It seems like you have some issue understanding the concept of bisectability :-)

Yes, fortunately you've helped me out to understand it well now. Thanks

Quoted 16 lines

Anyway, now that PATCH 1/2 is applied and pushed, it's too late to back out.
package/sunxi-mali-mainline-driver/sunxi-mali-mainline-driver.mk SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS = \ · line 20
Quoted 9 lines
package/sunxi-mali-mainline-driver/sunxi-mali-mainline-driver.mk +5 -0
@@ -13,6 +13,12 @@ SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS = \
  	CROSS_COMPILE=$(TARGET_CROSS) \
  	INSTALL_MOD_PATH=$(TARGET_DIR)
 
+ifeq ($(BR2_arm),y)
+SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS += ARCH=arm
+else ifeq ($(BR2_aarch64),y)
+SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS += ARCH=arm64
+endif
Could you instead change the .mk to do this:

Quoted 6 lines

SUNXI_MALI_MAINLINE_DRIVER_MAKE_OPTS = \
	$(LINUX_MAKE_FLAGS) \
         KDIR=$(LINUX_DIR)
Indeed, LINUX_MAKE_FLAGS already include CROSS_COMPILE, INSTALL_MOD_PATH and ARCH.

Sure, this is very clean.

Quoted 3 lines

As separate commits, please add hash files for both sunxi-mali-mainline and sunxi-mainline-driver.

Ok.

Also, it would be good to have patches

Quoted 2 lines

adding license information for both of those packages. For the mali-blobs, there's a PDF containing the EULA.

Do you mean like odroid-mali package .mk?
I mean reporting:
SUNXI_MALI_MAINLINE_LICENSE = EULA SUNXI_MALI_MAINLINE_LICENSE_FILES = EULA for Mali 400MP _AW.pdf Right?

For the kernel driver, I

Quoted 3 lines

didn't see a license file, but I didn't look everywhere. If there is none, could you check with Maxime to make sure a license file gets added ?

I'm not an expert of licensing but as stated here:
https://developer.arm.com/products/software/mali-drivers/utgard-kernel
it is distributed under GPLv2 licence the base code, so the added code should be too.
What do you all think?

Kind regards
Giulio Benetti

Thomas Petazzoni

2018-08-22 19:26 UTC #6 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

Hello,

Quoted 9 lines · Giulio Benetti

Also, it would be good to have patches
Quoted 2 lines
adding license information for both of those packages. For the mali-blobs, there's a PDF containing the EULA.
Do you mean like odroid-mali package .mk?
I mean reporting:
SUNXI_MALI_MAINLINE_LICENSE = EULA SUNXI_MALI_MAINLINE_LICENSE_FILES = EULA for Mali 400MP _AW.pdf Right?

Yes. Make sure "make legal-info" is working after this.

Quoted 10 lines

For the kernel driver, I
Quoted 3 lines
didn't see a license file, but I didn't look everywhere. If there is none, could you check with Maxime to make sure a license file gets added ?
I'm not an expert of licensing but as stated here:
https://developer.arm.com/products/software/mali-drivers/utgard-kernel
it is distributed under GPLv2 licence the base code, so the added code should be too.
What do you all think?

Yes, of course, it should be under GPLv2, but it would be nice to have a license file in the source code.

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Giulio Benetti

author

2018-08-24 19:10 UTC #7 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

Hello,

Il 22/08/2018 21:26, Thomas Petazzoni ha scritto:

Quoted 8 lines

Hello,
Quoted 4 lines · Giulio Benetti
Also, it would be good to have patches
Quoted 2 lines
adding license information for both of those packages. For the mali-blobs, there's a PDF containing the EULA.

Quoted 7 lines

Quoted 5 lines
Do you mean like odroid-mali package .mk?
I mean reporting:
SUNXI_MALI_MAINLINE_LICENSE = EULA SUNXI_MALI_MAINLINE_LICENSE_FILES = EULA for Mali 400MP _AW.pdf Right?
Yes. Make sure "make legal-info" is working after this.

I'm getting problems with whitespaces in pdf filename.
I couldn't find in Buildroot Documentation if it's allowed or not having filenames containing spaces.
I've tried using:
'EULA for Mali 400MP _AW.pdf'
"EULA for Mali 400MP _AW.pdf"
etc.
but with no luck.

If it's not possible to have whitespaces, should I workaround it in package changing filename before legal-info recipe? Like:
EULA for Mali 400MP _AW.pdf
becoming:
EULA_for_Mali_400MP_AW.pdf
?

Thanks
Giulio

Thomas Petazzoni

2018-08-24 19:58 UTC #8 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

Hello,

Quoted 9 lines · Giulio Benetti

I'm getting problems with whitespaces in pdf filename.
I couldn't find in Buildroot Documentation if it's allowed or not having filenames containing spaces.
I've tried using:
'EULA for Mali 400MP _AW.pdf'
"EULA for Mali 400MP _AW.pdf"
etc.
but with no luck.

Quoted 7 lines

If it's not possible to have whitespaces, should I workaround it in package changing filename before legal-info recipe? Like:
EULA for Mali 400MP _AW.pdf
becoming:
EULA_for_Mali_400MP_AW.pdf
?

Yes, I think it makes sense to have a POST_PATCH_HOOKS that renames the file so that it doesn't have spaces.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Yann E. MORIN

2018-08-24 21:14 UTC #9 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

In reply to Giulio Benetti

Giulio, All,

On 2018-08-24 21:10 +0200, Giulio Benetti spake thusly:
[--SNIP--]

Quoted 8 lines

I'm getting problems with whitespaces in pdf filename.
I couldn't find in Buildroot Documentation if it's allowed or not having filenames containing spaces.
I've tried using:
'EULA for Mali 400MP _AW.pdf'
"EULA for Mali 400MP _AW.pdf"
etc.
but with no luck.

Could you please also try with a \-escape:

SUNXI_MALI_MAINLINE_LICENSE_FILES = EULA\ for\ Mali\ 400MP\ _AW.pdf

If that still fails, please try with two \\.

I would prefer if we were to be able to keep the original filenames in license files, in case something else in the package would reference them.

Quoted 7 lines

If it's not possible to have whitespaces, should I workaround it in package changing filename before legal-info recipe?
Like:
EULA for Mali 400MP _AW.pdf
becoming:
EULA_for_Mali_400MP_AW.pdf
?

As Thomas already replied, yes. But I'd prefer if that were used as a last resort.

Thanks!

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Giulio Benetti

author

2018-08-24 21:28 UTC #10 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

Hi,

Il 24/08/2018 23:14, Yann E. MORIN ha scritto:

Quoted 31 lines

Giulio, All,
On 2018-08-24 21:10 +0200, Giulio Benetti spake thusly:
[--SNIP--]
Quoted 8 lines
I'm getting problems with whitespaces in pdf filename.
I couldn't find in Buildroot Documentation if it's allowed or not having filenames containing spaces.
I've tried using:
'EULA for Mali 400MP _AW.pdf'
"EULA for Mali 400MP _AW.pdf"
etc.
but with no luck.
Could you please also try with a \-escape:
SUNXI_MALI_MAINLINE_LICENSE_FILES = EULA\ for\ Mali\ 400MP\ _AW.pdf
If that still fails, please try with two \\.
I would prefer if we were to be able to keep the original filenames in license files, in case something else in the package would reference them.
Quoted 7 lines
If it's not possible to have whitespaces, should I workaround it in package changing filename before legal-info recipe?
Like:
EULA for Mali 400MP _AW.pdf
becoming:
EULA_for_Mali_400MP_AW.pdf
?

Quoted 2 lines

As Thomas already replied, yes. But I'd prefer if that were used as a last resort.

Just tried with both \ and \\ but nothing to do, it doesn't work. It always tries to find 'EULA' or 'EULA\'

So do I proceed with renaming on POST_PATCH_HOOKS?

Thanks
Giulio

Yann E. MORIN

2018-08-24 21:39 UTC #11 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

Giulio, All,

On 2018-08-24 23:28 +0200, Giulio Benetti spake thusly:

Quoted 13 lines

Il 24/08/2018 23:14, Yann E. MORIN ha scritto:
Quoted 12 lines
On 2018-08-24 21:10 +0200, Giulio Benetti spake thusly:
[--SNIP--]
Quoted 8 lines
I'm getting problems with whitespaces in pdf filename.
I couldn't find in Buildroot Documentation if it's allowed or not having filenames containing spaces.
I've tried using:
'EULA for Mali 400MP _AW.pdf'
"EULA for Mali 400MP _AW.pdf"
etc.
but with no luck.
Could you please also try with a \-escape:
SUNXI_MALI_MAINLINE_LICENSE_FILES = EULA\ for\ Mali\ 400MP\ _AW.pdf

[--SNIP--]

Quoted 2 lines

Just tried with both \ and \\ but nothing to do, it doesn't work. It always tries to find 'EULA' or 'EULA\'

Damn... Yeah, I now had a look at the code, and it indeed can not work. I had hoped ot was a shell command that would do the splitting, but no; it is done by a make foreach loop, so we're doomed...

Quoted 1 line

So do I proceed with renaming on POST_PATCH_HOOKS?

Yes, please.

Thanks! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Giulio Benetti

author

2018-08-26 21:36 UTC #12 lore raw

PATCH v2 2/2 sunxi-mali-mainline-driver: bump version and add support for building on arm64(aarch64).

In reply to Thomas Petazzoni

Hello Maxime,

Il 22/08/2018 21:26, Thomas Petazzoni ha scritto:

Quoted 21 lines

Hello,
Quoted 9 lines · Giulio Benetti
Also, it would be good to have patches
Quoted 2 lines
adding license information for both of those packages. For the mali-blobs, there's a PDF containing the EULA.
Do you mean like odroid-mali package .mk?
I mean reporting:
SUNXI_MALI_MAINLINE_LICENSE = EULA SUNXI_MALI_MAINLINE_LICENSE_FILES = EULA for Mali 400MP _AW.pdf Right?
Yes. Make sure "make legal-info" is working after this.
Quoted 5 lines
For the kernel driver, I
Quoted 3 lines
didn't see a license file, but I didn't look everywhere. If there is none, could you check with Maxime to make sure a license file gets added ?

Quoted 8 lines

Quoted 5 lines
I'm not an expert of licensing but as stated here:
https://developer.arm.com/products/software/mali-drivers/utgard-kernel
it is distributed under GPLv2 licence the base code, so the added code should be too.
What do you all think?
Yes, of course, it should be under GPLv2, but it would be nice to have a license file in the source code.

Is there a way to add a license into sunxi-mali repository? Is it enough using a classic GPLv2 COPYING file taken from elsewhere and put it in sunxi-mali root folder?
If yes I can contribute to your repo and open a PR.

Thanks

Giulio Benetti