Skip to contentSkip to conversation

staging: comedi: cb_pcidas64 fixed '(' coding style issue

PATCH In review GuyLuz 2 participants 2 messages Aug 24, 2018 – Aug 25, 2018 Staging

lore
Share & tools
lore

GuyLuz

author
#0 lore raw

PATCH 1/1 staging: comedi: cb_pcidas64 fixed '(' coding style issue

From: Guy Luz <[email protected]>

Fixed a Lines should not end with a '(' issue.

---
 drivers/staging/comedi/drivers/cb_pcidas64.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/cb_pcidas64.c +3 -4
index 63992c0babf7..a85334f53ff9 100644
@@ -2173,10 +2173,9 @@ static int ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
 			 * allows
 			 */
 			if (cmd->scan_begin_src == TRIG_TIMER) {
-				err |= comedi_check_trigger_arg_min(
-						&cmd->scan_begin_arg,
-						cmd->convert_arg *
-						cmd->chanlist_len);
+				err |= comedi_check_trigger_arg_min
+				(&cmd->scan_begin_arg, cmd->convert_arg *
+				cmd->chanlist_len);
 			}
 		}
 	}
Signature · 1 line
2.17.1
#1 lore raw
Quoted 14 lines · GuyLuz

From: Guy Luz <[email protected]>

Fixed a Lines should not end with a '(' issue.

---
 drivers/staging/comedi/drivers/cb_pcidas64.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/comedi/drivers/cb_pcidas64.c +0 -0
index 63992c0babf7..a85334f53ff9 100644

drivers/staging/comedi/drivers/cb_pcidas64.c static int ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s, · line 2178

Quoted 10 lines
drivers/staging/comedi/drivers/cb_pcidas64.c +3 -4
@@ -2173,10 +2173,9 @@ static int ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
 			 * allows
 			 */
 			if (cmd->scan_begin_src == TRIG_TIMER) {
-				err |= comedi_check_trigger_arg_min(
-						&cmd->scan_begin_arg,
-						cmd->convert_arg *
-						cmd->chanlist_len);
+				err |= comedi_check_trigger_arg_min
+				(&cmd->scan_begin_arg, cmd->convert_arg *
+				cmd->chanlist_len);

The original is better than the new version. Please leave it as is.

regards,
dan carpenter