Skip to contentSkip to conversation

gst1-plugins-good: enable jack plugins if jack2 is on

PATCH New Brad Love 2 participants 2 messages Aug 23, 2018 – Aug 24, 2018

lore
Share & tools
lore

Brad Love

author
#0 lore raw

PATCH 1/1 gst1-plugins-good: enable jack plugins if jack2 is on

Jack2 audio server is part of buildroot, but the jack gst plugins are disabled completely in gst1-plugins-good, whether or not jack2 is selected. This changes the logic to where if the build system determines jack2 audio server is selected, then the jack plugins are enabled. If the plugins are enabled, then jack2 is also added as a dependency to gst1-plugins-good.

Signed-off-by Brad Love <[email protected]>
---
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +7 -1
index c1ed039..21a7668 100644
@@ -25,13 +25,19 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \
 
 # Options which require currently unpackaged libraries
 GST1_PLUGINS_GOOD_CONF_OPTS += \
-	--disable-jack \
 	--disable-libdv \
 	--disable-dv1394 \
 	--disable-shout2
 
 GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base
 
+ifeq ($(BR2_PACKAGE_JACK2),y)
+GST1_PLUGINS_GOOD_CONF_OPTS += --enable-jack
+GST1_PLUGINS_GOOD_DEPENDENCIES += jack2
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += --disable-jack
+endif
+
 ifeq ($(BR2_PACKAGE_LIBV4L),y)
 GST1_PLUGINS_GOOD_CONF_OPTS += --with-libv4l2
 GST1_PLUGINS_GOOD_DEPENDENCIES += libv4l
Signature · 1 line
2.7.4
Applied
#1 lore raw

PATCH 1/1 gst1-plugins-good: enable jack plugins if jack2 is on

Hello Brad,

Quoted 8 lines · Brad Love

Jack2 audio server is part of buildroot, but the jack gst plugins are disabled completely in gst1-plugins-good, whether or not jack2 is selected. This changes the logic to where if the build system determines jack2 audio server is selected, then the jack plugins are enabled. If the plugins are enabled, then jack2 is also added as a dependency to gst1-plugins-good.

Quoted 4 lines
Signed-off-by Brad Love <[email protected]>
---
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com