json-c: needs host-autoconf
PATCH 1/1 json-c: needs host-autoconf
The json-c configure script uses the autoheader utility. Use the host-autoconf provided autoheader, as this tool is not always installed on the host.
Fixes:
http://autobuild.buildroot.net/results/030/030fddceda4f5bc6379f7bfcc405e92d2e24184a/
http://autobuild.buildroot.net/results/e48/e482f174b8124ace0690a26bb7daf073fe5fcd75/
http://autobuild.buildroot.net/results/482/4829425c38c58d9844aa07108532a93d47191d23/
--- package/json-c/json-c.mk | 4 ++++ 1 file changed, 4 insertions(+)
package/json-c/json-c.mk +4 -0
@@ -10,5 +10,9 @@ JSON_C_INSTALL_STAGING = YES JSON_C_LICENSE = MIT JSON_C_LICENSE_FILES = COPYING +# configure requires autoheader +JSON_C_DEPENDENCIES = host-autoconf +HOST_JSON_C_DEPENDENCIES = host-autoconf + $(eval $(autotools-package)) $(eval $(host-autotools-package))
Signature · 1 line
2.18.0
PATCH 1/1 json-c: needs host-autoconf
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
The json-c configure script uses the autoheader utility. Use the host-autoconf provided autoheader, as this tool is not always installed on the host.
Quoted 7 lines
Fixes:
http://autobuild.buildroot.net/results/030/030fddceda4f5bc6379f7bfcc405e92d2e24184a/
http://autobuild.buildroot.net/results/e48/e482f174b8124ace0690a26bb7daf073fe5fcd75/
http://autobuild.buildroot.net/results/482/4829425c38c58d9844aa07108532a93d47191d23/Cc Fabrice Fontaine <[email protected]>Signed-off-by Baruch Siach <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 json-c: needs host-autoconf
In reply to Baruch SiachHello,
Quoted 20 lines · Baruch Siach
The json-c configure script uses the autoheader utility. Use the host-autoconf provided autoheader, as this tool is not always installed on the host.
Fixes:
http://autobuild.buildroot.net/results/030/030fddceda4f5bc6379f7bfcc405e92d2e24184a/
http://autobuild.buildroot.net/results/e48/e482f174b8124ace0690a26bb7daf073fe5fcd75/
http://autobuild.buildroot.net/results/482/4829425c38c58d9844aa07108532a93d47191d23/Cc Fabrice Fontaine <[email protected]>Signed-off-by Baruch Siach <[email protected]>--- package/json-c/json-c.mk | 4 ++++ 1 file changed, 4 insertions(+)package/json-c/json-c.mk +0
-0
package/json-c/json-c.mk JSON_C_INSTALL_STAGING = YES · line 15
Quoted 6 lines
package/json-c/json-c.mk +3
-0@@ -10,5 +10,9 @@ JSON_C_INSTALL_STAGING = YES JSON_C_LICENSE = MIT JSON_C_LICENSE_FILES = COPYING +# configure requires autoheader +JSON_C_DEPENDENCIES = host-autoconf +HOST_JSON_C_DEPENDENCIES = host-autoconf
Wait, wait, why is this needed? This is a standard autotools package, it shouldn't need autoheader at build time.
Isn't it that there is a bogus timestamp or something like that forces some files to be re-generated ?
This problem only appears on Joseph's machine:
http://autobuild.buildroot.net/?reason=json-glib%.
It doesn't happen on my autobuilder, even though it doesn't have autoheader installed system-wide.
So I'm skeptical about this fix.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 json-c: needs host-autoconf
Hello,
Quoted 11 lines · Thomas Petazzoni
Wait, wait, why is this needed? This is a standard autotools package, it shouldn't need autoheader at build time.
Isn't it that there is a bogus timestamp or something like that forces some files to be re-generated ?
This problem only appears on Joseph's machine:
http://autobuild.buildroot.net/?reason=json-glib%.It doesn't happen on my autobuilder, even though it doesn't have autoheader installed system-wide.
Sorry, I messed up here: the package being fixed is json-c, not json-glib. So the build failure does occur on several autobuilders:
http://autobuild.buildroot.net/?reason=json-c%.
However, I would still like to see an explanation of why autoheader is needed in an autotools package. It should not be needed.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 json-c: needs host-autoconf
Hi Thomas,
Quoted 13 lines · Thomas Petazzoni
Quoted 11 lines · Thomas Petazzoni
Wait, wait, why is this needed? This is a standard autotools package, it shouldn't need autoheader at build time.
Isn't it that there is a bogus timestamp or something like that forces some files to be re-generated ?
This problem only appears on Joseph's machine:
http://autobuild.buildroot.net/?reason=json-glib%.It doesn't happen on my autobuilder, even though it doesn't have autoheader installed system-wide.
Quoted 6 lines
Sorry, I messed up here: the package being fixed is json-c, not json-glib. So the build failure does occur on several autobuilders:
http://autobuild.buildroot.net/?reason=json-c%.However, I would still like to see an explanation of why autoheader is needed in an autotools package. It should not be needed.
You are right. Updating the config.h.in timestamp is enough to avoid autoheader. I sent an updated patch.
Thanks for noting.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -PATCH 1/1 json-c: needs host-autoconf
Hello,
Quoted 2 lines · Baruch Siach
You are right. Updating the config.h.in timestamp is enough to avoid autoheader. I sent an updated patch.
Thanks a lot for looking deeper into this. Perhaps this issue should be reported upstream, because it's really a bug in upstream's tarball.
Thanks again!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com