mender: fix ioctl build failure on powerpc64le / power8
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Build fails due to missing // +build ppc64le in ioctl_64_bit.go
Add patch to append ppc64le to // +build list.
Fixes
http://autobuild.buildroot.net/results/f22/f222b4389f9308363c386da25ec22a0919bc29fb//
--- ...001-ioctl-allow-building-for-ppc64le.patch | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 package/mender/0001-ioctl-allow-building-for-ppc64le.patch
package/mender/0001-ioctl-allow-building-for-ppc64le.patch new file +31 -0
@@ -0,0 +1,31 @@ +From 0c15fedbfe962912c8ad5e16073f4fc5ad03797f Mon Sep 17 00:00:00 2001 +From: Giulio Benetti <[email protected]> +Date: Tue, 28 Aug 2018 18:48:22 +0200 +Subject: [PATCH] ioctl: allow building for ppc64le + +ppc64le is not supported at the moment. + +Add ppc64le to // +build of ioctl_64_bit.go allowing building for +powerpc64le. + +Signed-off-by: Giulio Benetti <[email protected]> +--- + ioctl_64_bit.go | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/ioctl_64_bit.go b/ioctl_64_bit.go +index 6f61a6c..dc4c38f 100644 +--- a/ioctl_64_bit.go ++++ b/ioctl_64_bit.go +@@ -12,7 +12,7 @@ + // See the License for the specific language governing permissions and + // limitations under the License. + +-// +build amd64 arm64 ++// +build amd64 arm64 ppc64le + + package main + +-- +2.17.1 +
Signature · 1 line
2.17.1
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
package/mender/0001-ioctl-allow-building-for-ppc64le.patch
Quoted 14 lines · Giulio Benetti
Build fails due to missing // +build ppc64le in ioctl_64_bit.go
Add patch to append ppc64le to // +build list.
Fixes
http://autobuild.buildroot.net/results/f22/f222b4389f9308363c386da25ec22a0919bc29fb//Signed-off-by Giulio Benetti <[email protected]>--- ...001-ioctl-allow-building-for-ppc64le.patch | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 package/mender/0001-ioctl-allow-building-for-ppc64le.patchpackage/mender/0001-ioctl-allow-building-for-ppc64le.patch +0
-0
Note that the 1.5.0 release of Mender also contains this patch [1], and updating the package to 1.5.0 will also fix the build problem on ppc64le.
Note that there will soon (1-2 weeks) be a new Mender release (1.6.0) that also contains this patch and updating to that will also fix the build problem on pppc64le.
[1]. https://github.com/mendersoftware/mender/commit/d7064c82c66cb7e4093c71c44b2c976c0caac8a2
Signature · 3 lines
Mirza Krak | Embedded Solutions Architect | https://mender.io Northern.tech AS | @northerntechHQ
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Hello,
Il 28/08/2018 19:12, Mirza Krak ha scritto:
Quoted 15 lines
Quoted 13 lines · Giulio Benetti
Build fails due to missing // +build ppc64le in ioctl_64_bit.go
Add patch to append ppc64le to // +build list.
Fixes
http://autobuild.buildroot.net/results/f22/f222b4389f9308363c386da25ec22a0919bc29fb//Signed-off-by Giulio Benetti <[email protected]>--- ...001-ioctl-allow-building-for-ppc64le.patch | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+)create mode 100644
package/mender/0001-ioctl-allow-building-for-ppc64le.patch
Quoted 5 lines
package/mender/0001-ioctl-allow-building-for-ppc64le.patch
Quoted 1 line
package/mender/0001-ioctl-allow-building-for-ppc64le.patch +0
-0Note that the 1.5.0 release of Mender also contains this patch [1], and updating the package to 1.5.0 will also fix the build problem on ppc64le.
Oh, I've missed that patch.
I've found this PR:
https://github.com/mendersoftware/mender/pull/302
and so I've created a new patch.
Quoted 3 lines
Note that there will soon (1-2 weeks) be a new Mender release (1.6.0) that also contains this patch and updating to that will also fix the build problem on pppc64le.
Ok, but I don't know if it will be pushed to master or next. I wanted to avoid NOK on:
http://autobuild.buildroot.net/?reason=mender-1.4.0
Quoted 3 lines
[1]. https://github.com/mendersoftware/mender/commit/d7064c82c66cb7e4093c71c44b2c976c0caac8a2
If this makes sense I can resend this patch using the patch you've pointed me to.
Thanks
Giulio
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Hello,
Quoted 2 lines · Giulio Benetti
If this makes sense I can resend this patch using the patch you've pointed me to.
Yes, if there is already the same patch committed upstream, we want to backport the upstream patch. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Hello,
Il 28/08/2018 21:57, Thomas Petazzoni ha scritto:
Quoted 9 lines
Hello,
Quoted 2 lines · Giulio Benetti
If this makes sense I can resend this patch using the patch you've pointed me to.
Yes, if there is already the same patch committed upstream, we want to backport the upstream patch. Thanks!
Sure, I will use the upstream one I've missed when searching.
Thanks
Giulio Benetti
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Hi Giulio
Quoted 12 lines · Giulio Benetti
Hello,
Il 28/08/2018 21:57, Thomas Petazzoni ha scritto:
Quoted 9 lines
Hello,
Quoted 2 lines · Giulio Benetti
If this makes sense I can resend this patch using the patch you've pointed me to.
Quoted 5 lines
Quoted 2 lines
Yes, if there is already the same patch committed upstream, we want to backport the upstream patch. Thanks!
Sure, I will use the upstream one I've missed when searching.
Mizra, one of the authors of Mender is releasing a bump of the package with other fixes. We agreed on waiting on the package bump to fix the error instead of carrying a patch in buildroot that will bu useful only for a short period of time.
Sincerely, Angelo
Quoted 8 lines
Thanks
Giulio Benetti_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Hello Angelo,
Quoted 4 lines · Angelo Compagnucci
Mizra, one of the authors of Mender is releasing a bump of the package with other fixes. We agreed on waiting on the package bump to fix the error instead of carrying a patch in buildroot that will bu useful only for a short period of time.
Hum, not really. I suppose your bump will include plenty of other changes. At this time, "master" is frozen in terms of version bumps: we only do version bumps for security fixes. The other version bumps are only done on the next branch, but we still want to fix build failures on master.
If the Mender version bump that is coming really only bug fixes, then we sometimes make exceptions and merge such version bumps in master. But as a general rule, after -rc1 is released, version bumps go in next, and therefore build issues may need to be fixed by backporting patches from upstream.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
In reply to Angelo CompagnucciQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Angelo" == Angelo Compagnucci <[email protected]> writes:
Hi,
Quoted 6 lines
Quoted 1 line
Sure, I will use the upstream one I've missed when searching.
Mizra, one of the authors of Mender is releasing a bump of the package with other fixes. We agreed on waiting on the package bump to fix the error instead of carrying a patch in buildroot that will bu useful only for a short period of time.
Ok, if it indeed is a "short time", we are very close to releasing 2018.08.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Hi,
Il 29/08/2018 09:35, Peter Korsgaard ha scritto:
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Angelo" == Angelo Compagnucci <[email protected]> writes:
Hi,
Quoted 1 line
Quoted 1 line
Sure, I will use the upstream one I've missed when searching.
Quoted 8 lines
Quoted 4 lines
Mizra, one of the authors of Mender is releasing a bump of the package with other fixes. We agreed on waiting on the package bump to fix the error instead of carrying a patch in buildroot that will bu useful only for a short period of time.
Ok, if it indeed is a "short time", we are very close to releasing 2018.08.
So can I send v2 patch? Sorry, I'm new and I don't understand.
Thanks
Giulio
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Hello,
Quoted 9 lines · Giulio Benetti
Quoted 7 lines
Quoted 4 lines
Mizra, one of the authors of Mender is releasing a bump of the package with other fixes. We agreed on waiting on the package bump to fix the error instead of carrying a patch in buildroot that will bu useful only for a short period of time.
Ok, if it indeed is a "short time", we are very close to releasing 2018.08.
So can I send v2 patch? Sorry, I'm new and I don't understand.
Yes, please. Having the backport now is good. And when/if a new Mender version is released, we will decide what to do.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
In reply to Giulio BenettiQuoted 15 lines · Giulio Benetti
Hi,
Il 29/08/2018 09:35, Peter Korsgaard ha scritto:
Quoted 12 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
"Angelo" == Angelo Compagnucci <[email protected]> writes:
Hi,
Quoted 6 lines
Quoted 1 line
Sure, I will use the upstream one I've missed when searching.
Mizra, one of the authors of Mender is releasing a bump of the package with other fixes. We agreed on waiting on the package bump to fix the error instead of carrying a patch in buildroot that will bu useful only for a short period of time.
Thank you Angelo for flattering me but I am far from "one of the authors of Mender" and simply a community member gone employee that gets paid to work on Mender :).
Quoted 3 lines
Quoted 3 lines
Ok, if it indeed is a "short time", we are very close to releasing 2018.08.
Providing some basis for a easier decision (sorry if it is a bit late and might add confusion)
The options are (all fix the build error for ppc64le):
- Backport fix for the build failure (v2 sent by Giulio)
- Bump package to 1.5.0 (existing release)
- Bump package to 1.6.0 (in process of being released 1-2 weeks)
If it acceptable to bump the package I/or someone else could bump it to 1.5.0 right now or wait 1-2 weeks for 1.6.0. Otherwise backport patch and bump to 1.6.0 once it is released (guessing that this would be after 2018.08 release, do not know what "very close" means :)).
Signature · 3 lines
Mirza Krak | Embedded Solutions Architect | https://mender.io Northern.tech AS | @northerntechHQ
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mirza" == Mirza Krak <[email protected]> writes:
Hi,
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Ok, if it indeed is a "short time", we are very close to releasing 2018.08.
Providing some basis for a easier decision (sorry if it is a bit late and might add confusion)
The options are (all fix the build error for ppc64le):
Quoted 8 lines
- Backport fix for the build failure (v2 sent by Giulio)
- Bump package to 1.5.0 (existing release)
- Bump package to 1.6.0 (in process of being released 1-2 weeks)If it acceptable to bump the package I/or someone else could bump it to 1.5.0 right now or wait 1-2 weeks for 1.6.0. Otherwise backport patch and bump to 1.6.0 once it is released (guessing that this would be after 2018.08 release, do not know what "very close" means :)).
Thanks for the overview. As mender is new in 2018.08, both option 1 and 2 could work, but given we already have option 1 ready I will commit that.
Patches for option 2 (and 3 once released) are as always welcome.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
In reply to Giulio BenettiHello,
package/mender/0001-ioctl-allow-building-for-ppc64le.patch line 4
Quoted 10 lines · Giulio Benetti
package/mender/0001-ioctl-allow-building-for-ppc64le.patch new file +4
-0@@ -0,0 +1,31 @@ +From 0c15fedbfe962912c8ad5e16073f4fc5ad03797f Mon Sep 17 00:00:00 2001 +From: Giulio Benetti <[email protected]> +Date: Tue, 28 Aug 2018 18:48:22 +0200 +Subject: [PATCH] ioctl: allow building for ppc64le
So you allow building for ppc64le...
package/mender/0001-ioctl-allow-building-for-ppc64le.patch line 6
Quoted 1 line
package/mender/0001-ioctl-allow-building-for-ppc64le.patch new file +1
-0+ppc64le is not supported at the moment.
... but ppc64le is not supported ?
This commit message doesn't make much sense I'm afraid :-/
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 mender: fix ioctl build failure on powerpc64le / power8
Hello,
Il 28/08/2018 21:56, Thomas Petazzoni ha scritto:
Quoted 17 lines
Hello,
package/mender/0001-ioctl-allow-building-for-ppc64le.patch line 4
Quoted 10 lines · Giulio Benetti
package/mender/0001-ioctl-allow-building-for-ppc64le.patch new file +4
-0@@ -0,0 +1,31 @@ +From 0c15fedbfe962912c8ad5e16073f4fc5ad03797f Mon Sep 17 00:00:00 2001 +From: Giulio Benetti <[email protected]> +Date: Tue, 28 Aug 2018 18:48:22 +0200 +Subject: [PATCH] ioctl: allow building for ppc64leSo you allow building for ppc64le...
Quoted 6 lines
package/mender/0001-ioctl-allow-building-for-ppc64le.patch line 6
Quoted 1 line
package/mender/0001-ioctl-allow-building-for-ppc64le.patch new file +1
-0+ppc64le is not supported at the moment.... but ppc64le is not supported ?
This commit message doesn't make much sense I'm afraid :-/
Thanks for pointing me a good one in IRC channel.
Giulio