mfd: ti-lmu: constify mfd_cell tables

PATCH Applied Pavel Machek 4 participants 9 messages Aug 29, 2018 – Sep 11, 2018 Multifunction devices (MFD)

lore

Share & tools

lore

Pavel Machek

author

2018-08-29 09:31 UTC #0 lore raw

PATCH 1/1 mfd: ti-lmu: constify mfd_cell tables

From: Sebastian Reichel <[email protected]>

mfd: ti-lmu: constify mfd_cell tables

Add const attribute to all mfd_cell structures.

Signed-off-by Sebastian Reichel <[email protected]>

Signed-off-by Pavel Machek <[email protected]>

drivers/mfd/ti-lmu.c +7 -7

index cfb411c..990437e 100644
@@ -25,7 +25,7 @@
 #include <linux/slab.h>
 
 struct ti_lmu_data {
-	struct mfd_cell *cells;
+	const struct mfd_cell *cells;
 	int num_cells;
 	unsigned int max_register;
 };

@@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
 		gpio_set_value(lmu->en_gpio, 0);
 }
 
-static struct mfd_cell lm3532_devices[] = {
+static const struct mfd_cell lm3532_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3532,

@@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
 	.of_compatible = "ti,lm363x-regulator",	\
 }						\
 
-static struct mfd_cell lm3631_devices[] = {
+static const struct mfd_cell lm3631_devices[] = {
 	LM363X_REGULATOR(LM3631_BOOST),
 	LM363X_REGULATOR(LM3631_LDO_CONT),
 	LM363X_REGULATOR(LM3631_LDO_OREF),

@@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3632_devices[] = {
+static const struct mfd_cell lm3632_devices[] = {
 	LM363X_REGULATOR(LM3632_BOOST),
 	LM363X_REGULATOR(LM3632_LDO_POS),
 	LM363X_REGULATOR(LM3632_LDO_NEG),

@@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3633_devices[] = {
+static const struct mfd_cell lm3633_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3633,

@@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3695_devices[] = {
+static const struct mfd_cell lm3695_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3695,

@@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3697_devices[] = {
+static const struct mfd_cell lm3697_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3697,

Signature · 9 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180829/f1f7c8fe/attachment.sig>

Tony Lindgren

Acked-by on v1 1/1

2018-08-29 19:36 UTC #1 lore raw

Quoted 5 lines · Pavel Machek

From: Sebastian Reichel <[email protected]>
mfd: ti-lmu: constify mfd_cell tables
Add const attribute to all mfd_cell structures.

Acked-by Tony Lindgren <[email protected]>

Pavel Machek

author

2018-09-07 09:39 UTC #2 lore raw

In reply to Pavel Machek

Quoted 8 lines · Pavel Machek

From: Sebastian Reichel <[email protected]>
mfd: ti-lmu: constify mfd_cell tables
Add const attribute to all mfd_cell structures.
Signed-off-by Sebastian Reichel <[email protected]>
Signed-off-by Pavel Machek <[email protected]>

Lee, I guess this is for you to apply. Any news there?

There are more patches ready,

https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v4.19

and it would be good to get them in. (Alternatively, you can just cherry-pick them from droid4-pending-v4.19).

Thanks,
Pavel

Quoted 68 lines

drivers/mfd/ti-lmu.c +7 -7

index cfb411c..990437e 100644
@@ -25,7 +25,7 @@
 #include <linux/slab.h>
 
 struct ti_lmu_data {
-	struct mfd_cell *cells;
+	const struct mfd_cell *cells;
 	int num_cells;
 	unsigned int max_register;
 };

@@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
 		gpio_set_value(lmu->en_gpio, 0);
 }
 
-static struct mfd_cell lm3532_devices[] = {
+static const struct mfd_cell lm3532_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3532,

@@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
 	.of_compatible = "ti,lm363x-regulator",	\
 }						\
 
-static struct mfd_cell lm3631_devices[] = {
+static const struct mfd_cell lm3631_devices[] = {
 	LM363X_REGULATOR(LM3631_BOOST),
 	LM363X_REGULATOR(LM3631_LDO_CONT),
 	LM363X_REGULATOR(LM3631_LDO_OREF),

@@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3632_devices[] = {
+static const struct mfd_cell lm3632_devices[] = {
 	LM363X_REGULATOR(LM3632_BOOST),
 	LM363X_REGULATOR(LM3632_LDO_POS),
 	LM363X_REGULATOR(LM3632_LDO_NEG),

@@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3633_devices[] = {
+static const struct mfd_cell lm3633_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3633,

@@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3695_devices[] = {
+static const struct mfd_cell lm3695_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3695,

@@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3697_devices[] = {
+static const struct mfd_cell lm3697_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3697,

Signature · 9 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180907/76fdc689/attachment.sig>

Dan Murphy

2018-09-07 17:20 UTC #3 lore raw

Pavel

Quoted 5 lines · Pavel Machek

Quoted 4 lines · Pavel Machek
From: Sebastian Reichel <[email protected]>
mfd: ti-lmu: constify mfd_cell tables

Quoted 8 lines

Quoted 4 lines
Add const attribute to all mfd_cell structures.
Signed-off-by Sebastian Reichel <[email protected]>
Signed-off-by Pavel Machek <[email protected]>
Lee, I guess this is for you to apply. Any news there?
There are more patches ready,

As I stated in another email thread. I don't see the need for this level of LMU framework.

Here is the reference thread

https://lore.kernel.org/patchwork/patch/982550/

Quoted 81 lines

https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v4.19

and it would be good to get them in. (Alternatively, you can just cherry-pick them from droid4-pending-v4.19).

Thanks,
Pavel

Quoted 68 lines

drivers/mfd/ti-lmu.c +7 -7

index cfb411c..990437e 100644
@@ -25,7 +25,7 @@
 #include <linux/slab.h>
 
 struct ti_lmu_data {
-	struct mfd_cell *cells;
+	const struct mfd_cell *cells;
 	int num_cells;
 	unsigned int max_register;
 };

@@ -63,7 +63,7 @@ static void ti_lmu_disable_hw(struct ti_lmu *lmu)
 		gpio_set_value(lmu->en_gpio, 0);
 }
 
-static struct mfd_cell lm3532_devices[] = {
+static const struct mfd_cell lm3532_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3532,

@@ -78,7 +78,7 @@ static struct mfd_cell lm3532_devices[] = {
 	.of_compatible = "ti,lm363x-regulator",	\
 }						\
 
-static struct mfd_cell lm3631_devices[] = {
+static const struct mfd_cell lm3631_devices[] = {
 	LM363X_REGULATOR(LM3631_BOOST),
 	LM363X_REGULATOR(LM3631_LDO_CONT),
 	LM363X_REGULATOR(LM3631_LDO_OREF),

@@ -91,7 +91,7 @@ static struct mfd_cell lm3631_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3632_devices[] = {
+static const struct mfd_cell lm3632_devices[] = {
 	LM363X_REGULATOR(LM3632_BOOST),
 	LM363X_REGULATOR(LM3632_LDO_POS),
 	LM363X_REGULATOR(LM3632_LDO_NEG),

@@ -102,7 +102,7 @@ static struct mfd_cell lm3632_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3633_devices[] = {
+static const struct mfd_cell lm3633_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3633,

@@ -120,7 +120,7 @@ static struct mfd_cell lm3633_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3695_devices[] = {
+static const struct mfd_cell lm3695_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3695,

@@ -128,7 +128,7 @@ static struct mfd_cell lm3695_devices[] = {
 	},
 };
 
-static struct mfd_cell lm3697_devices[] = {
+static const struct mfd_cell lm3697_devices[] = {
 	{
 		.name          = "ti-lmu-backlight",
 		.id            = LM3697,

Signature · 2 lines

------------------
Dan Murphy

Lee Jones

2018-09-11 15:57 UTC #4 lore raw

Quoted 15 lines · Dan Murphy

Pavel
Quoted 12 lines · Pavel Machek
Quoted 8 lines · Pavel Machek
From: Sebastian Reichel <[email protected]>
mfd: ti-lmu: constify mfd_cell tables
Add const attribute to all mfd_cell structures.
Signed-off-by Sebastian Reichel <[email protected]>
Signed-off-by Pavel Machek <[email protected]>
Lee, I guess this is for you to apply. Any news there?

Quoted 7 lines

Quoted 1 line
There are more patches ready,
As I stated in another email thread. I don't see the need for this level of LMU framework.
Here is the reference thread
https://lore.kernel.org/patchwork/patch/982550/

This driver has been present for 1.5 years.

Is that a NACK for *this* patch or are you hijacking? :)

Signature · 4 lines

Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Dan Murphy

2018-09-11 17:08 UTC #5 lore raw

Lee

Quoted 21 lines · Lee Jones

Quoted 19 lines · Dan Murphy
Pavel
Quoted 5 lines · Pavel Machek
Quoted 4 lines · Pavel Machek
From: Sebastian Reichel <[email protected]>
mfd: ti-lmu: constify mfd_cell tables
Quoted 8 lines
Quoted 4 lines
Add const attribute to all mfd_cell structures.
Signed-off-by Sebastian Reichel <[email protected]>
Signed-off-by Pavel Machek <[email protected]>
Lee, I guess this is for you to apply. Any news there?
There are more patches ready,
As I stated in another email thread. I don't see the need for this level of LMU framework.

Quoted 8 lines

Quoted 3 lines
Here is the reference thread
https://lore.kernel.org/patchwork/patch/982550/
This driver has been present for 1.5 years.
Is that a NACK for *this* patch or are you hijacking? :)

Its a NACK for adding this. I am pushing a new series for the LM3697 and will end up sending LED drivers for the non-MFD devices contained within. I will try to match the feature set the best I can.

Signature · 2 lines

------------------
Dan Murphy

Dan Murphy

2018-09-11 17:18 UTC #6 lore raw

Lee

Quoted 28 lines · Dan Murphy

Lee
Quoted 25 lines · Lee Jones
Quoted 22 lines · Dan Murphy
Pavel
Quoted 5 lines · Pavel Machek
Quoted 4 lines · Pavel Machek
From: Sebastian Reichel <[email protected]>
mfd: ti-lmu: constify mfd_cell tables
Quoted 8 lines
Quoted 4 lines
Add const attribute to all mfd_cell structures.
Signed-off-by Sebastian Reichel <[email protected]>
Signed-off-by Pavel Machek <[email protected]>
Lee, I guess this is for you to apply. Any news there?
There are more patches ready,
As I stated in another email thread. I don't see the need for this level of LMU framework.
Here is the reference thread
https://lore.kernel.org/patchwork/patch/982550/

Quoted 9 lines

Quoted 4 lines
This driver has been present for 1.5 years.
Is that a NACK for *this* patch or are you hijacking? :)
Its a NACK for adding this. I am pushing a new series for the LM3697 and will end up sending LED drivers for the non-MFD devices contained within. I will try to match the feature set the best I can.

Sorry it is a NACK for adding the backlight series. This patch is fine.

Dan

Signature · 2 lines

------------------
Dan Murphy

Lee Jones

2018-09-11 18:13 UTC #7 lore raw

Quoted 33 lines · Dan Murphy

Lee
Quoted 30 lines · Dan Murphy
Lee
Quoted 27 lines · Lee Jones
Quoted 15 lines · Dan Murphy
Pavel
Quoted 12 lines · Pavel Machek
Quoted 8 lines · Pavel Machek
From: Sebastian Reichel <[email protected]>
mfd: ti-lmu: constify mfd_cell tables
Add const attribute to all mfd_cell structures.
Signed-off-by Sebastian Reichel <[email protected]>
Signed-off-by Pavel Machek <[email protected]>
Lee, I guess this is for you to apply. Any news there?
Quoted 7 lines
Quoted 1 line
There are more patches ready,
As I stated in another email thread. I don't see the need for this level of LMU framework.
Here is the reference thread
https://lore.kernel.org/patchwork/patch/982550/
This driver has been present for 1.5 years.

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
Is that a NACK for *this* patch or are you hijacking? :)
Its a NACK for adding this. I am pushing a new series for the LM3697 and will end up sending LED drivers for the non-MFD devices contained within. I will try to match the feature set the best I can.
Sorry it is a NACK for adding the backlight series. This patch is fine.

Ack, thanks for confirming.

Signature · 4 lines

Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Lee Jones

Applied

2018-09-11 15:57 UTC #8 lore raw

In reply to Pavel Machek

Quoted 8 lines · Pavel Machek

From: Sebastian Reichel <[email protected]>
mfd: ti-lmu: constify mfd_cell tables
Add const attribute to all mfd_cell structures.
Signed-off-by Sebastian Reichel <[email protected]>
Signed-off-by Pavel Machek <[email protected]>

Applied, thanks.

Signature · 4 lines

Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog