Skip to contentSkip to conversation

staging: mt7621-pci: remove unnecessary check of device_type == pci

PATCH New Rob Herring 1 participant 1 message Aug 29, 2018

Subsystems (2)
Staging Arm MediaTek
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 staging: mt7621-pci: remove unnecessary check of device_type == pci

PCI host drivers have already matched on compatible strings, so checking device_type is redundant. Also, device_type is considered deprecated for FDT though we've still been requiring it for PCI hosts as it is useful for finding PCI buses.

Cc Greg Kroah-Hartman <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 drivers/staging/mt7621-pci/pci-mt7621.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/staging/mt7621-pci/pci-mt7621.c +0 -7
index 0d13384b90c4..5055475bd04e 100644
@@ -387,15 +387,8 @@ static int mt7621_pcie_parse_dt(struct mt7621_pcie *pcie)
 	struct device *dev = pcie->dev;
 	struct device_node *node = dev->of_node;
 	struct resource regs;
-	const char *type;
 	int err;
 
-	type = of_get_property(node, "device_type", NULL);
-	if (!type || strcmp(type, "pci") != 0) {
-		dev_err(dev, "invalid \"device_type\" %s\n", type);
-		return -EINVAL;
-	}
-
 	err = of_address_to_resource(node, 0, &regs);
 	if (err) {
 		dev_err(dev, "missing \"reg\" property\n");
Signature · 1 line
2.17.1