libyaml: fix libyaml-legal-info build failure
PATCH 1/1 libyaml: fix libyaml-legal-info build failure
LICENSE file hash is wrong, this leads to libyaml-legal-info build failure. This is probably due to version bump.
Recalculate it locally and substitute it in libyaml.hash file.
Fixes:
http://autobuild.buildroot.net/results/c10/c10baf6e9bae92d515264b677eeb1ce6c98c793d//
http://autobuild.buildroot.net/results/c66/c66ddb56fecf1570a8669bd9d8824cd2132f9776//
http://autobuild.buildroot.net/results/84e/84e9530aff0c981a009416f31470133fb2114421//
--- package/libyaml/libyaml.hash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/libyaml/libyaml.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated sha256 78281145641a080fb32d6e7a87b9c0664d611dcb4d542e90baf731f51cbb59cd yaml-0.2.1.tar.gz -sha256 d0d8b09800a45cd982e9568fc7669d9c1a4c330e275a821bbe24d54366d16fe9 LICENSE +sha256 bfcb6a7dfbfd30e0ccc8bb34ab712bd1568586ad8c5b078ccae443b04e79749e LICENSE
Signature · 1 line
2.17.1
PATCH 1/1 libyaml: fix libyaml-legal-info build failure
Hi Giulio,
Quoted 2 lines · Giulio Benetti
LICENSE file hash is wrong, this leads to libyaml-legal-info build failure. This is probably due to version bump.
What are the changes in the LICENSE file in this version bump? Does it affect the license? Please mention these details in the commit log.
baruch
Quoted 21 lines
Recalculate it locally and substitute it in libyaml.hash file.
Fixes:
http://autobuild.buildroot.net/results/c10/c10baf6e9bae92d515264b677eeb1ce6c98c793d//
http://autobuild.buildroot.net/results/c66/c66ddb56fecf1570a8669bd9d8824cd2132f9776//
http://autobuild.buildroot.net/results/84e/84e9530aff0c981a009416f31470133fb2114421//Signed-off-by Giulio Benetti <[email protected]>--- package/libyaml/libyaml.hash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/libyaml/libyaml.hash +1
-1@@ -1,3 +1,3 @@ # Locally calculated sha256 78281145641a080fb32d6e7a87b9c0664d611dcb4d542e90baf731f51cbb59cd yaml-0.2.1.tar.gz -sha256 d0d8b09800a45cd982e9568fc7669d9c1a4c330e275a821bbe24d54366d16fe9 LICENSE +sha256 bfcb6a7dfbfd30e0ccc8bb34ab712bd1568586ad8c5b078ccae443b04e79749e LICENSE
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -PATCH 1/1 libyaml: fix libyaml-legal-info build failure
Hi Baruch,
Il 29/08/2018 20:23, Baruch Siach ha scritto:
Quoted 8 lines
Hi Giulio,
Quoted 2 lines · Giulio Benetti
LICENSE file hash is wrong, this leads to libyaml-legal-info build failure. This is probably due to version bump.
What are the changes in the LICENSE file in this version bump? Does it affect the license? Please mention these details in the commit log.
Ah right, if hash changed, file changed.
Basically they've updated copyright, I'm going to send v2 patch with this in commit log.
Thank you
Giulio
PATCH v2 1/1 libyaml: fix libyaml-legal-info build failure
In reply to Baruch SiachLICENSE file changed and hash hasn't been recalculated, this leads to libyaml-legal-info build failure.
Kirill Simonov Copyright now covers 2006-2016. Ingy d?t Net Copyright has been added instead for 2017-2018.
Recalculate sha256 locally and substitute it in libyaml.hash file.
Fixes:
http://autobuild.buildroot.net/results/c10/c10baf6e9bae92d515264b677eeb1ce6c98c793d//
http://autobuild.buildroot.net/results/c66/c66ddb56fecf1570a8669bd9d8824cd2132f9776//
http://autobuild.buildroot.net/results/84e/84e9530aff0c981a009416f31470133fb2114421//
--- package/libyaml/libyaml.hash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/libyaml/libyaml.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated sha256 78281145641a080fb32d6e7a87b9c0664d611dcb4d542e90baf731f51cbb59cd yaml-0.2.1.tar.gz -sha256 d0d8b09800a45cd982e9568fc7669d9c1a4c330e275a821bbe24d54366d16fe9 LICENSE +sha256 bfcb6a7dfbfd30e0ccc8bb34ab712bd1568586ad8c5b078ccae443b04e79749e LICENSE
Signature · 1 line
2.17.1
Thomas Petazzoni
AppliedPATCH v2 1/1 libyaml: fix libyaml-legal-info build failure
Hello,
Quoted 13 lines · Giulio Benetti
LICENSE file changed and hash hasn't been recalculated, this leads to libyaml-legal-info build failure.
Kirill Simonov Copyright now covers 2006-2016. Ingy d?t Net Copyright has been added instead for 2017-2018.
Recalculate sha256 locally and substitute it in libyaml.hash file.
Fixes:
http://autobuild.buildroot.net/results/c10/c10baf6e9bae92d515264b677eeb1ce6c98c793d//
http://autobuild.buildroot.net/results/c66/c66ddb56fecf1570a8669bd9d8824cd2132f9776//
http://autobuild.buildroot.net/results/84e/84e9530aff0c981a009416f31470133fb2114421//
Quoted 4 lines
Signed-off-by Giulio Benetti <[email protected]>--- package/libyaml/libyaml.hash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to next, thanks. An additional thing that would have been nice in the commit log is something like this:
"""
Commit a4633a53ae1592ad2f4ea6f931c061382cf44b7f ("libyaml: bump to version 0.2.1") forgot to update the hash of the license file. """
or any other wording that references the commit that introduced the problem. It is sometimes useful later on to figure out when a given problem was introduced.
But that wasn't important enough for this one, so I've applied as-is. Something to keep in mind for future contributions, though.
Thanks again!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 libyaml: fix libyaml-legal-info build failure
Hello,
Il 29/08/2018 20:57, Thomas Petazzoni ha scritto:
Quoted 8 lines
Applied to next, thanks. An additional thing that would have been nice in the commit log is something like this:
"""
Commita4633a53ae1592ad2f4ea6f931c061382cf44b7f("libyaml: bump to version 0.2.1") forgot to update the hash of the license file. """
Quoted 6 lines
or any other wording that references the commit that introduced the problem. It is sometimes useful later on to figure out when a given problem was introduced.
But that wasn't important enough for this one, so I've applied as-is. Something to keep in mind for future contributions, though.
Sure I will, thank you.
Giulio Benetti