Skip to contentSkip to conversation

net/ipv4: Add extack message that dev is required for ONLINK

PATCH Applied [email protected] 2 participants 2 messages Aug 30, 2018 – Sep 1, 2018

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 net/ipv4: Add extack message that dev is required for ONLINK

From: David Ahern <[email protected]>

Make IPv4 consistent with IPv6 and return an extack message that the ONLINK flag requires a nexthop device.

Signed-off-by David Ahern <[email protected]>
---
 net/ipv4/fib_semantics.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
net/ipv4/fib_semantics.c +3 -1
index f3c89ccf14c5..bee8db979195 100644
@@ -797,8 +797,10 @@ static int fib_check_nh(struct fib_config *cfg, struct fib_nh *nh,
 				return -EINVAL;
 			}
 			dev = __dev_get_by_index(net, nh->nh_oif);
-			if (!dev)
+			if (!dev) {
+				NL_SET_ERR_MSG(extack, "Nexthop device required for onlink");
 				return -ENODEV;
+			}
 			if (!(dev->flags & IFF_UP)) {
 				NL_SET_ERR_MSG(extack,
 					       "Nexthop device is not up");
Signature · 1 line
2.11.0