Skip to contentSkip to conversation

drm/amd/powerplay: correct data type to support under voltage

PATCH In review Evan Quan 2 participants 2 messages Aug 30, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 1/1 drm/amd/powerplay: correct data type to support under voltage

For under voltage, negative value will be applied to voltage offset. Update the data type to cover this case.

Change-Id I955da13fd9777320b0605b6b620133d596b573be
---
 drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h +3 -3
index 0a39a4c564d2..59e621ef33ac 100644
@@ -569,11 +569,11 @@ typedef struct {
   uint16_t      GfxclkFmin;
   uint16_t      GfxclkFmax;
   uint16_t      GfxclkFreq1;
-  uint16_t      GfxclkOffsetVolt1;
+  int16_t      GfxclkOffsetVolt1;
   uint16_t      GfxclkFreq2;
-  uint16_t      GfxclkOffsetVolt2;
+  int16_t      GfxclkOffsetVolt2;
   uint16_t      GfxclkFreq3;
-  uint16_t      GfxclkOffsetVolt3;
+  int16_t      GfxclkOffsetVolt3;
   uint16_t      UclkFmax;
   int16_t       OverDrivePct;
   uint16_t      FanMaximumRpm;
Signature · 6 lines
2.18.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#2 lore raw
Quoted 6 lines · Evan Quan

For under voltage, negative value will be applied to voltage offset. Update the data type to cover this case.

Change-Id I955da13fd9777320b0605b6b620133d596b573be
Quoted 26 lines
---
 drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/inc/smu11_driver_if.h +3 -4
index 0a39a4c564d2..59e621ef33ac 100644
@@ -569,11 +569,11 @@ typedef struct {
   uint16_t      GfxclkFmin;
   uint16_t      GfxclkFmax;
   uint16_t      GfxclkFreq1;
-  uint16_t      GfxclkOffsetVolt1;
+  int16_t      GfxclkOffsetVolt1;
   uint16_t      GfxclkFreq2;
-  uint16_t      GfxclkOffsetVolt2;
+  int16_t      GfxclkOffsetVolt2;
   uint16_t      GfxclkFreq3;
-  uint16_t      GfxclkOffsetVolt3;
+  int16_t      GfxclkOffsetVolt3;
   uint16_t      UclkFmax;
   int16_t       OverDrivePct;
   uint16_t      FanMaximumRpm;
--

2.18.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx