Skip to contentSkip to conversation

staging:fwserial:Fix parentheses alignment in fwserial.c

PATCH Dan Carpenter 2 participants 2 messages Aug 30, 2018 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 14 lines · Nicholas Krause

Fix a checkpatch warning for the file, fwserial.c that warns about alignment between parentheses and the line belows code not being properly aligned with each other.

---
 drivers/staging/fwserial/fwserial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fwserial/fwserial.c +0 -0
index fa0dd425b454..f9fcabe7afa1 100644

drivers/staging/fwserial/fwserial.c static int fwtty_break_ctl(struct tty_struct *tty, int state) · line 1332

Quoted 6 lines
drivers/staging/fwserial/fwserial.c +1 -1
@@ -1328,7 +1328,7 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
 	if (state == -1) {
 		set_bit(STOP_TX, &port->flags);
 		ret = wait_event_interruptible_timeout(port->wait_tx,
-					       !test_bit(IN_TX, &port->flags),
+						       !test_bit(IN_TX, &port->flags),
 					       10);

Now it goes over 80 characters and the "10);" isn't aligned properly. The original is fine.

regards,
dan carpenter

#2 lore raw
Quoted 6 lines · Dan Carpenter
Quoted 5 lines · Nicholas Krause

Fix a checkpatch warning for the file, fwserial.c that warns about alignment between parentheses and the line belows code not being properly aligned with each other.

Nick Krause?

I wonder if after 4 years he has improved.

Quoted 1 line

drivers/staging/fwserial/fwserial.c

Quoted 1 line
drivers/staging/fwserial/fwserial.c +0 -0

[]

Quoted 10 lines

drivers/staging/fwserial/fwserial.c static int fwtty_break_ctl(struct tty_struct *tty, int state) · line 1332

Quoted 7 lines
drivers/staging/fwserial/fwserial.c +1 -1
@@ -1328,7 +1328,7 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
 	if (state == -1) {
 		set_bit(STOP_TX, &port->flags);
 		ret = wait_event_interruptible_timeout(port->wait_tx,
-					       !test_bit(IN_TX, &port->flags),
+						       !test_bit(IN_TX, &port->flags),
 					       10);

Now it goes over 80 characters and the "10);" isn't aligned properly. The original is fine.

Perhaps not.