Skip to contentSkip to conversation

package/libsoup: needs host-python3

PATCH New Asaf Kahlon 3 participants 5 messages Aug 30, 2018 – Sep 1, 2018

lore
Share & tools
lore

Asaf Kahlon

author
#0 lore raw

PATCH 1/1 package/libsoup: needs host-python3

The tld-parser script in libsoup is now written in Python, and needs python3 to run.

Fixes:
http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258
http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af

Signed-off-by Asaf Kahlon <[email protected]>

---

Maybe this specific script can run even with python2, but I don't think patchting the "/usr/bin/env python3" line would be the right solution, especially considering the fact that they already have python3-only code in recent commits.

---
 package/libsoup/libsoup.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libsoup/libsoup.mk +1 -1
index 95bd682010..ef17f27fcd 100644
@@ -14,7 +14,7 @@ LIBSOUP_INSTALL_STAGING = YES
 LIBSOUP_CONF_ENV = ac_cv_path_GLIB_GENMARSHAL=$(LIBGLIB2_HOST_BINARY)
 LIBSOUP_CONF_OPTS = --disable-glibtest --enable-vala=no --with-gssapi=no
 LIBSOUP_DEPENDENCIES = host-pkgconf host-libglib2 \
-	libglib2 libxml2 sqlite host-intltool
+	libglib2 libxml2 sqlite host-intltool host-python3
 
 ifeq ($(BR2_PACKAGE_LIBSOUP_GNOME),y)
 LIBSOUP_CONF_OPTS += --with-gnome
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/libsoup: needs host-python3

Hello,

Quoted 7 lines · Asaf Kahlon

The tld-parser script in libsoup is now written in Python, and needs python3 to run.

Fixes:
http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258
http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af

Quoted 7 lines
Signed-off-by Asaf Kahlon <[email protected]>

---

Maybe this specific script can run even with python2, but I don't think patchting the "/usr/bin/env python3" line would be the right solution, especially considering the fact that they already have python3-only code in recent commits.

Meh, I was hoping we could avoid the host-python3 dependency :-/

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libsoup: needs host-python3

Hi Asaf, Thomas,

Quoted 8 lines · Thomas Petazzoni
Quoted 7 lines · Asaf Kahlon

The tld-parser script in libsoup is now written in Python, and needs python3 to run.

Fixes:
http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258
http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af

Quoted 7 lines
Quoted 7 lines
Signed-off-by Asaf Kahlon <[email protected]>

---

Maybe this specific script can run even with python2, but I don't think patchting the "/usr/bin/env python3" line would be the right solution, especially considering the fact that they already have python3-only code in recent commits.

Which commits do you refer to? The get_apache_module_dirs.py script is only used by the meson build system, as far as I can see.

Quoted 1 line

Meh, I was hoping we could avoid the host-python3 dependency :-/

Later commits remove this script entirely. So we might be able to remove this dependency in the future.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
author
#3 lore raw

PATCH 1/1 package/libsoup: needs host-python3

Thomas, Baruch,

Indeed I meant to the get_apache_module_dirs.py script.
After looking deeper I can agree that the script seems to be used only with meson-context.

Therefore, it seems like this dependency is relevant only for this version, and after we bump the version it will be removed.

Asaf.

Quoted 33 lines · Baruch Siach

Hi Asaf, Thomas,

Quoted 6 lines · Thomas Petazzoni
Quoted 5 lines · Asaf Kahlon

The tld-parser script in libsoup is now written in Python, and needs python3 to run.

Fixes:

http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258

Quoted 1 line
Quoted 1 line

http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af

Quoted 6 lines
Quoted 6 lines
Signed-off-by Asaf Kahlon <[email protected]>

---

Maybe this specific script can run even with python2, but I don't think

patchting the

Quoted 1 line
Quoted 1 line

"/usr/bin/env python3" line would be the right solution, especially

considering

Quoted 1 line
Quoted 1 line

the fact that they already have python3-only code in recent commits.

Which commits do you refer to? The get_apache_module_dirs.py script is only used by the meson build system, as far as I can see.

Quoted 1 line

Meh, I was hoping we could avoid the host-python3 dependency :-/

Later commits remove this script entirely. So we might be able to remove this dependency in the future.

baruch

Quoted 10 lines

--
http://baruch.siach.name/blog/ ~. .~ Tk Open
Systems =}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180830/07439f5d/attachment.html>

#4 lore raw

PATCH 1/1 package/libsoup: needs host-python3

In reply to Asaf Kahlon

Hello,

Quoted 3 lines · Asaf Kahlon

Maybe this specific script can run even with python2, but I don't think patchting the "/usr/bin/env python3" line would be the right solution, especially considering the fact that they already have python3-only code in recent commits.

I disagree: the tld-parser.py script was changed from python to python3 with no reason other than "hey, let's use Python 3", and the script works fine with Python 2. Plus in newer versions of libsoup, the script has been removed entirely, and libsoup relies on a separate library to provide TLD information.

So for now, I've committed a change that simply reverts the script to use "python".

Thanks for your initial research on this topic!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com