drm/amd/powerplay: added vega20 overdrive support V3
Subsystems (2)
PATCH 1/1 drm/amd/powerplay: added vega20 overdrive support V3
Added vega20 overdrive support based on existing OD sysfs APIs. However, the OD logics are simplified on vega20. So, the behavior will be a little different and works only on some limited levels.
V2: fix typo
fix commit description
revise error logs
add support for clock OD
V3: separate clock from voltage OD settings
--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 45 +++ .../gpu/drm/amd/include/kgd_pp_interface.h | 2 + .../drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 289 +++++++++++++++++- 3 files changed, 335 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +45 -0
@@ -474,6 +474,8 @@ static ssize_t amdgpu_set_pp_table(struct device *dev,* in each power level within a power state. The pp_od_clk_voltage is used for * this. * +* < For Vega10 and previous ASICs > +* * Reading the file will display: * * - a list of engine clock levels and voltages labeled OD_SCLK
@@ -491,6 +493,44 @@ static ssize_t amdgpu_set_pp_table(struct device *dev,* "c" (commit) to the file to commit your changes. If you want to reset to the * default power levels, write "r" (reset) to the file to reset them. * +* +* < For Vega20 > +* +* Reading the file will display: +* +* - minimum and maximum engine clock labeled OD_SCLK +* +* - maximum memory clock labeled OD_MCLK +* +* - three <frequency, voltage offset> points labeled OD_VDDC_CURVE. +* They can be used to calibrate the sclk voltage curve. +* +* - a list of valid ranges for sclk, mclk, and voltage curve points +* labeled OD_RANGE +* +* To manually adjust these settings: +* +* - First select manual using power_dpm_force_performance_level +* +* - For clock frequency setting, enter a new value by writing a +* string that contains "s/m index clock" to the file. The index +* should be 0 if to set minimum clock. And 1 if to set maximum +* clock. E.g., "s 0 500" will update minimum sclk to be 500 MHz. +* "m 1 800" will update maximum mclk to be 800Mhz. +* +* For sclk voltage curve, enter the new values by writing a +* string that contains "vc point clock voff" to the file. The +* points are indexed by 0, 1 and 2. E.g., "vc 0 300 10" will +* update point1 with clock set as 300Mhz and voltage increased +* by 10mV. "vc 2 1000 -10" will update point3 with clock set +* as 1000Mhz and voltage drop by 10mV. +* +* - When you have edited all of the states as needed, write "c" (commit) +* to the file to commit your changes +* +* - If you want to reset to the default power levels, write "r" (reset) +* to the file to reset them +* */ static ssize_t amdgpu_set_pp_od_clk_voltage(struct device *dev,
@@ -520,6 +560,8 @@ static ssize_t amdgpu_set_pp_od_clk_voltage(struct device *dev, type =PP_OD_RESTORE_DEFAULT_TABLE ; else if (*buf == 'c') type =PP_OD_COMMIT_DPM_TABLE ; + else if (!strncmp(buf, "vc", 2)) + type =PP_OD_EDIT_VDDC_CURVE ; else return -EINVAL;
@@ -527,6 +569,8 @@ static ssize_t amdgpu_set_pp_od_clk_voltage(struct device *dev, tmp_str = buf_cpy; +if (type ==PP_OD_EDIT_VDDC_CURVE ) + tmp_str++;while (isspace (*++tmp_str));while (tmp_str[0 ]) {
@@ -570,6 +614,7 @@ static ssize_t amdgpu_get_pp_od_clk_voltage(struct device *dev,if (adev->powerplay.pp_funcs->print_clock_levels) { size =amdgpu_dpm_print_clock_levels (adev,OD_SCLK , buf); size +=amdgpu_dpm_print_clock_levels (adev,OD_MCLK , buf+size); + size +=amdgpu_dpm_print_clock_levels (adev,OD_VDDC_CURVE , buf+size); size +=amdgpu_dpm_print_clock_levels (adev,OD_RANGE , buf+size);return size; }else {
drivers/gpu/drm/amd/include/kgd_pp_interface.h +2 -0
@@ -94,6 +94,7 @@ enum pp_clock_type {PP_PCIE ,OD_SCLK ,OD_MCLK , +OD_VDDC_CURVE , OD_RANGE, };
@@ -141,6 +142,7 @@ enum {enum PP_OD_DPM_TABLE_COMMAND {PP_OD_EDIT_SCLK_VDDC_TABLE ,PP_OD_EDIT_MCLK_VDDC_TABLE , +PP_OD_EDIT_VDDC_CURVE ,PP_OD_RESTORE_DEFAULT_TABLE ,PP_OD_COMMIT_DPM_TABLE };
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +288 -1
311 lines not on this page · raw message
Signature · 6 lines
2.18.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Deucher, Alexander
Reviewed-by________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Evan Quan <[email protected]>
Sent: Friday, August 31, 2018 3:50:30 AM
To: [email protected]
Cc: Deucher, Alexander; Quan, Evan; Zhu, Rex
Subject: [PATCH] drm/amd/powerplay: added vega20 overdrive support V3
Added vega20 overdrive support based on existing OD sysfs APIs. However, the OD logics are simplified on vega20. So, the behavior will be a little different and works only on some limited levels.
V2: fix typo
fix commit description
revise error logs
add support for clock OD
V3: separate clock from voltage OD settings
--- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 45 +++ .../gpu/drm/amd/include/kgd_pp_interface.h | 2 + .../drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 289 +++++++++++++++++- 3 files changed, 335 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +45 -0
@@ -474,6 +474,8 @@ static ssize_t amdgpu_set_pp_table(struct device *dev,* in each power level within a power state. The pp_od_clk_voltage is used for * this. * +* < For Vega10 and previous ASICs > +* * Reading the file will display: * * - a list of engine clock levels and voltages labeled OD_SCLK
@@ -491,6 +493,44 @@ static ssize_t amdgpu_set_pp_table(struct device *dev,* "c" (commit) to the file to commit your changes. If you want to reset to the * default power levels, write "r" (reset) to the file to reset them. * +* +* < For Vega20 > +* +* Reading the file will display: +* +* - minimum and maximum engine clock labeled OD_SCLK +* +* - maximum memory clock labeled OD_MCLK +* +* - three <frequency, voltage offset> points labeled OD_VDDC_CURVE. +* They can be used to calibrate the sclk voltage curve. +* +* - a list of valid ranges for sclk, mclk, and voltage curve points +* labeled OD_RANGE +* +* To manually adjust these settings: +* +* - First select manual using power_dpm_force_performance_level +* +* - For clock frequency setting, enter a new value by writing a +* string that contains "s/m index clock" to the file. The index +* should be 0 if to set minimum clock. And 1 if to set maximum +* clock. E.g., "s 0 500" will update minimum sclk to be 500 MHz. +* "m 1 800" will update maximum mclk to be 800Mhz. +* +* For sclk voltage curve, enter the new values by writing a +* string that contains "vc point clock voff" to the file. The +* points are indexed by 0, 1 and 2. E.g., "vc 0 300 10" will +* update point1 with clock set as 300Mhz and voltage increased +* by 10mV. "vc 2 1000 -10" will update point3 with clock set +* as 1000Mhz and voltage drop by 10mV. +* +* - When you have edited all of the states as needed, write "c" (commit) +* to the file to commit your changes +* +* - If you want to reset to the default power levels, write "r" (reset) +* to the file to reset them +* */ static ssize_t amdgpu_set_pp_od_clk_voltage(struct device *dev,
@@ -520,6 +560,8 @@ static ssize_t amdgpu_set_pp_od_clk_voltage(struct device *dev, type =PP_OD_RESTORE_DEFAULT_TABLE ; else if (*buf == 'c') type =PP_OD_COMMIT_DPM_TABLE ; + else if (!strncmp(buf, "vc", 2)) + type =PP_OD_EDIT_VDDC_CURVE ; else return -EINVAL;
@@ -527,6 +569,8 @@ static ssize_t amdgpu_set_pp_od_clk_voltage(struct device *dev, tmp_str = buf_cpy; +if (type ==PP_OD_EDIT_VDDC_CURVE ) + tmp_str++;while (isspace (*++tmp_str));while (tmp_str[0 ]) {
@@ -570,6 +614,7 @@ static ssize_t amdgpu_get_pp_od_clk_voltage(struct device *dev,if (adev->powerplay.pp_funcs->print_clock_levels) { size =amdgpu_dpm_print_clock_levels (adev,OD_SCLK , buf); size +=amdgpu_dpm_print_clock_levels (adev,OD_MCLK , buf+size); + size +=amdgpu_dpm_print_clock_levels (adev,OD_VDDC_CURVE , buf+size); size +=amdgpu_dpm_print_clock_levels (adev,OD_RANGE , buf+size);return size; }else {
drivers/gpu/drm/amd/include/kgd_pp_interface.h +2 -0
@@ -94,6 +94,7 @@ enum pp_clock_type {PP_PCIE ,OD_SCLK ,OD_MCLK , +OD_VDDC_CURVE , OD_RANGE, };
@@ -141,6 +142,7 @@ enum {enum PP_OD_DPM_TABLE_COMMAND {PP_OD_EDIT_SCLK_VDDC_TABLE ,PP_OD_EDIT_MCLK_VDDC_TABLE , +PP_OD_EDIT_VDDC_CURVE ,PP_OD_RESTORE_DEFAULT_TABLE ,PP_OD_COMMIT_DPM_TABLE };
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +288 -1
311 lines not on this page · raw message
--
2.18.0
_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx