Skip to contentSkip to conversation

selftest: vm: add unlikely() to BUG_ON()

PATCH New Igor Stoppa 1 participant 1 message Aug 31, 2018 Kselftest

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftest: vm: add unlikely() to BUG_ON()

BUG_ON() is unlikely() to BUG()

For unlikely(), borrow the definition from tools/include/linux/compiler.h

Signed-off-by Igor Stoppa <igor.stoppa at huawei.com>
Cc Dmitry Safonov <dima at arista.com>
Cc Shuah Khan <shuah at kernel.org>
Cc linux-kselftest at vger.kernel.org
Cc linux-kernel at vger.kernel.org
---
 tools/testing/selftests/vm/map_populate.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tools/testing/selftests/vm/map_populate.c +5 -1
index 6b8aeaa0bf7a..1bf8ff068dcd 100644
@@ -21,9 +21,13 @@
 #define MMAP_SZ		4096
 #endif
 
+#ifndef unlikely
+# define unlikely(x)		__builtin_expect(!!(x), 0)
+#endif
+
 #define BUG_ON(condition, description)					\
 	do {								\
-		if (condition) {					\
+		if (unlikely(condition)) {				\
 			fprintf(stderr, "[FAIL]\t%s:%d\t%s:%s\n", __func__, \
 				__LINE__, (description), strerror(errno)); \
 			exit(1);					\
Signature · 1 line
2.17.1