net: cadence: Fix a sleep-in-atomic-context bug in macb_halt_tx()
Subsystems (3)
PATCH 1/1 net: cadence: Fix a sleep-in-atomic-context bug in macb_halt_tx()
The kernel module may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.16 are:
[FUNC] usleep_range drivers/net/ethernet/cadence/macb_main.c, 648:
usleep_range in macb_halt_txdrivers/net/ethernet/cadence/macb_main.c, 730:
macb_halt_tx in macb_tx_error_taskdrivers/net/ethernet/cadence/macb_main.c, 721:
_raw_spin_lock_irqsave in macb_tx_error_task
To fix this bug, usleep_range() is replaced with udelay().
This bug is found by my static analysis tool DSAC.
--- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/cadence/macb_main.c +1 -1
@@ -641,7 +641,7 @@ static int macb_halt_tx(struct macb *bp)if (!(status &MACB_BIT (TGO )))return 0 ; -usleep_range (10 ,250 ); +udelay (250 ); }while (time_before (halt_time, timeout));return -ETIMEDOUT ;
Signature · 1 line
2.17.0
From: Jia-Ju Bai <[email protected]>
Date: Sat, 1 Sep 2018 20:11:05 +0800
Quoted 12 lines
The kernel module may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.16 are:
[FUNC]
usleep_rangedrivers/net/ethernet/cadence/macb_main.c, 648:
usleep_rangeinmacb_halt_txdrivers/net/ethernet/cadence/macb_main.c, 730:
macb_halt_txinmacb_tx_error_taskdrivers/net/ethernet/cadence/macb_main.c, 721:
_raw_spin_lock_irqsaveinmacb_tx_error_task
Quoted 5 lines
To fix this bug,
usleep_range()is replaced withudelay().This bug is found by my static analysis tool DSAC.
Signed-off-by Jia-Ju Bai <[email protected]>
Applied, thanks.