arm64: dts: remove big-endian filed from IFC controller
Subsystems (2)
PATCH 1/1 arm64: dts: remove big-endian filed from IFC controller
As per IFC binding, Absence of "little-endian" field causes registers access in big-endian mode.
So no need to set explicit big-endian field IFC node for LS1043A and LS1046A.
--- arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +1 -1
@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */
@@ -280,7 +281,6 @@ ifc: ifc at 1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; - big-endian; interrupts = <0 43 0x4>; };
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +2 -1
@@ -4,6 +4,8 @@ * * Copyright 2016 Freescale Semiconductor, Inc. * + * Copyright 2018 NXP + * * Mingkai Hu <[email protected]> */
@@ -198,7 +200,6 @@ ifc: ifc at 1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; - big-endian; interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>; };
Signature · 1 line
2.14.1
PATCH RESEND 1/2 ARM: dts: Add big-endian in nor node for ls1021a
NOR and IFC controller connectivity is big-endian. So add big-endian field in nor device tree node allowing IFC controller to read/write data from/to the flash correctly.
---
Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports" RESEND keeping Li Yang <[email protected]>
arch/arm/boot/dts/ls1021a-qds.dts | 2 ++ arch/arm/boot/dts/ls1021a-twr.dts | 2 ++ 2 files changed, 4 insertions(+)
arch/arm/boot/dts/ls1021a-qds.dts +2 -0
@@ -1,5 +1,6 @@ /* * Copyright 2013-2014 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual
@@ -235,6 +236,7 @@ #size-cells = <1>; compatible = "cfi-flash"; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; };
arch/arm/boot/dts/ls1021a-twr.dts +2 -0
@@ -1,5 +1,6 @@ /* * Copyright 2013-2014 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual
@@ -203,6 +204,7 @@ #size-cells = <1>; compatible = "cfi-flash"; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; };
Signature · 1 line
2.14.1
PATCH RESEND 1/2 ARM: dts: Add big-endian in nor node for ls1021a
Quoted 6 lines · Prabhakar Kushwaha
NOR and IFC controller connectivity is big-endian. So add big-endian field in nor device tree node allowing IFC controller to read/write data from/to the flash correctly.
Signed-off-by Prabhakar Kushwaha <[email protected]>
Quoted 49 lines
---
Based on147395ea40b36b"dt-bindings: mtd-physmap: Add endianness supports" RESEND keeping Li Yang <[email protected]>arch/arm/boot/dts/ls1021a-qds.dts | 2 ++ arch/arm/boot/dts/ls1021a-twr.dts | 2 ++ 2 files changed, 4 insertions(+)arch/arm/boot/dts/ls1021a-qds.dts +2
-0@@ -1,5 +1,6 @@ /* * Copyright 2013-2014 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual@@ -235,6 +236,7 @@ #size-cells = <1>; compatible = "cfi-flash"; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; };arch/arm/boot/dts/ls1021a-twr.dts +2
-1@@ -1,5 +1,6 @@ /* * Copyright 2013-2014 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual@@ -203,6 +204,7 @@ #size-cells = <1>; compatible = "cfi-flash"; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; }; --2.14.1
Fabio Estevam
reviewerPATCH RESEND 1/2 ARM: dts: Add big-endian in nor node for ls1021a
In reply to Prabhakar Kushwahaarch/arm/boot/dts/ls1021a-qds.dts line 3
Quoted 8 lines · Prabhakar Kushwaha
arch/arm/boot/dts/ls1021a-qds.dts +1
-0@@ -1,5 +1,6 @@ /* * Copyright 2013-2014 Freescale Semiconductor, Inc. + * Copyright 2018 NXP
This line is unrelated to the big-endian change.
PATCH RESEND 1/2 ARM: dts: Add big-endian in nor node for ls1021a
Dear Fabio,
Quoted 15 lines
-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: Wednesday, August 29, 2018 3:56 AM
To: Prabhakar Kushwaha <[email protected]>
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Shawn Guo <[email protected]>; moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm- kernel at lists.infradead.org>; Leo Li <[email protected]>
Subject: Re: [PATCH 1/2][RESEND] ARM: dts: Add big-endian in nor node for ls1021aOn Tue, Aug 28, 2018 at 3:59 AM, Prabhakar Kushwaha <[email protected]> wrote:
Quoted 11 lines
arch/arm/boot/dts/ls1021a-qds.dts line 3
Quoted 9 lines
arch/arm/boot/dts/ls1021a-qds.dts +1
-0@@ -1,5 +1,6 @@ /* * Copyright 2013-2014 Freescale Semiconductor, Inc. + * Copyright 2018 NXPThis line is unrelated to the big-endian change.
Yes, this line is unrelated to this change.
Freeescale has been acquired by NXP in 2016.
We want to add NXP copyright wherever freescale's copyright is present. But it is not possible in one-go.
So we are adding NXP copyright as and when any file having freescale's copyright being touched.
--pk
Shawn Guo
AppliedPATCH RESEND 1/2 ARM: dts: Add big-endian in nor node for ls1021a
In reply to Prabhakar KushwahaQuoted 5 lines · Prabhakar Kushwaha
NOR and IFC controller connectivity is big-endian. So add big-endian field in nor device tree node allowing IFC controller to read/write data from/to the flash correctly.
Signed-off-by Prabhakar Kushwaha <[email protected]>
Applied both, thanks.
PATCH RESEND 2/2 arm64: dts: Add big-endian in nor node for ls104xa
In reply to Prabhakar KushwahaNOR and IFC controller connectivity is big-endian. So add big-endian field in nor device tree node allowing IFC controller to read/write data from/to the flash correctly.
---
Based on 147395ea40b36b "dt-bindings: mtd-physmap: Add endianness supports" RESEND keeping Li Yang <[email protected]>
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++ 3 files changed, 6 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +2 -0
@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */
@@ -50,6 +51,7 @@ nor at 0,0 { compatible = "cfi-flash"; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; };
arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts +2 -0
@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */
@@ -65,6 +66,7 @@ #address-cells = <1>; #size-cells = <1>; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; };
arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts +2 -0
@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1046A family SoC. * * Copyright 2016 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Shaohui Xie <[email protected]> */
@@ -141,6 +142,7 @@ nor at 0,0 { compatible = "cfi-flash"; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; };
Signature · 1 line
2.14.1
PATCH RESEND 2/2 arm64: dts: Add big-endian in nor node for ls104xa
Quoted 6 lines · Prabhakar Kushwaha
NOR and IFC controller connectivity is big-endian. So add big-endian field in nor device tree node allowing IFC controller to read/write data from/to the flash correctly.
Signed-off-by Prabhakar Kushwaha <[email protected]>
Quoted 72 lines
---
Based on147395ea40b36b"dt-bindings: mtd-physmap: Add endianness supports" RESEND keeping Li Yang <[email protected]>arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 2 ++ 3 files changed, 6 insertions(+)arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +2
-0@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */@@ -50,6 +51,7 @@ nor at 0,0 { compatible = "cfi-flash"; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; };arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts +2
-0@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */@@ -65,6 +66,7 @@ #address-cells = <1>; #size-cells = <1>; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; };arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts +2
-1@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1046A family SoC. * * Copyright 2016 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Shaohui Xie <[email protected]> */@@ -141,6 +142,7 @@ nor at 0,0 { compatible = "cfi-flash"; reg = <0x0 0x0 0x8000000>; + big-endian; bank-width = <2>; device-width = <1>; }; --2.14.1
Fabio Estevam
reviewerPATCH RESEND 2/2 arm64: dts: Add big-endian in nor node for ls104xa
In reply to Prabhakar Kushwahaarch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts line 6
Quoted 9 lines · Prabhakar Kushwaha
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts +1
-0@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP
Same comment as in the other patch.
PATCH 1/1 arm64: dts: remove big-endian filed from IFC controller
In reply to Prabhakar KushwahaQuoted 37 lines · Prabhakar Kushwaha
As per IFC binding, Absence of "little-endian" field causes registers access in big-endian mode.
So no need to set explicit big-endian field IFC node for LS1043A and LS1046A.Signed-off-by Prabhakar Kushwaha <[email protected]>--- arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +1
-1@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */@@ -280,7 +281,6 @@ ifc: ifc at 1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; - big-endian; interrupts = <0 43 0x4>; };arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +0
-0
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi line 8
Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +2
-0@@ -4,6 +4,8 @@ * * Copyright 2016 Freescale Semiconductor, Inc. * + * Copyright 2018 NXP + *
Probably better to align with the other files to not have empty line between copyright claims?
Quoted 14 lines
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +0
-2* Mingkai Hu <[email protected]> */@@ -198,7 +200,6 @@ ifc: ifc at 1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; - big-endian; interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>; }; --2.14.1