arm64: dts: remove big-endian filed from IFC controller
Subsystems (2)
PATCH v2 1/1 arm64: dts: remove big-endian filed from IFC controller
As per IFC binding, Absence of "little-endian" field causes registers access in big-endian mode.
So no need to set explicit big-endian field IFC node for LS1043A and LS1046A.
---
Changes for v2: Incorporated Leo's comments
- Remove new line between copyrights
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +1 -1
@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */
@@ -280,7 +281,6 @@ ifc: ifc at 1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; - big-endian; interrupts = <0 43 0x4>; };
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +1 -1
@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1046A family SoC. * * Copyright 2016 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */
@@ -198,7 +199,6 @@ ifc: ifc at 1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; - big-endian; interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>; };
Signature · 1 line
2.14.1
PATCH v2 1/1 arm64: dts: remove big-endian filed from IFC controller
Quoted 7 lines · Prabhakar Kushwaha
As per IFC binding, Absence of "little-endian" field causes registers access in big-endian mode.
So no need to set explicit big-endian field IFC node for LS1043A and LS1046A.Signed-off-by Prabhakar Kushwaha <[email protected]>
Quoted 51 lines
---
Changes for v2: Incorporated Leo's comments
- Remove new line between copyrightsarch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +1
-1@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1043A family SoC. * * Copyright 2014-2015 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */@@ -280,7 +281,6 @@ ifc: ifc at 1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; - big-endian; interrupts = <0 43 0x4>; };arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi +1
-2@@ -3,6 +3,7 @@ * Device Tree Include file for Freescale Layerscape-1046A family SoC. * * Copyright 2016 Freescale Semiconductor, Inc. + * Copyright 2018 NXP * * Mingkai Hu <[email protected]> */@@ -198,7 +199,6 @@ ifc: ifc at 1530000 { compatible = "fsl,ifc", "simple-bus"; reg = <0x0 0x1530000 0x0 0x10000>; - big-endian; interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>; }; --2.14.1
PATCH v2 1/1 arm64: dts: remove big-endian filed from IFC controller
In reply to Prabhakar KushwahaQuoted 6 lines · Prabhakar Kushwaha
As per IFC binding, Absence of "little-endian" field causes registers access in big-endian mode.
So no need to set explicit big-endian field IFC node for LS1043A and LS1046A.Signed-off-by Prabhakar Kushwaha <[email protected]>
s/filed/flied in subject, and having 'fsl' in subject prefix might be better, so that it's clear this is a fsl specific changes.
I fixed them up and applied the patch.
Shawn