ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
Subsystems (2)
PATCH 1/2 ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
The correct DT property for specifying a GPIO used for reset is "reset-gpios", fix this here.
--- arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +2 -2
@@ -384,7 +384,7 @@ AVDD-supply = <®_3p3v>; IOVDD-supply = <®_3p3v>; DVDD-supply = <&vgen4_reg>; - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>; }; accel@1c {
@@ -572,7 +572,7 @@ AVDD-supply = <®_3p3v>; IOVDD-supply = <®_3p3v>; DVDD-supply = <&vgen4_reg>; - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; }; touchscreen@20 {
Signature · 1 line
2.18.0
PATCH 2/2 ARM: dts: imx: Fix the audio CODEC's reset pin
The correct DT property for specifying a GPIO used for reset is "reset-gpios", fix this here.
--- arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw5903.dtsi +1 -1
@@ -310,7 +310,7 @@ tlv320aic3105: codec@18 { compatible = "ti,tlv320aic3x"; reg = <0x18>; - gpio-reset = <&gpio5 17 GPIO_ACTIVE_LOW>; + reset-gpios = <&gpio5 17 GPIO_ACTIVE_LOW>; clocks = <&clks IMX6QDL_CLK_CKO>; ai3x-micbias-vg = <2>; /* MICBIAS_2_5V */ /* Regulators */
Signature · 1 line
2.18.0
Quoted 4 lines · Andrew F. Davis
The correct DT property for specifying a GPIO used for reset is "reset-gpios", fix this here.
Fixes d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")
This Fixes tag and word 'Fix' in subject is inappropriate to me, as you are not fixing something wrong from the beginning, but actually replacing a deprecated property with new one.
Shawn
Quoted 31 lines
Signed-off-by Andrew F. Davis <[email protected]>--- arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +2
-2@@ -384,7 +384,7 @@ AVDD-supply = <®_3p3v>; IOVDD-supply = <®_3p3v>; DVDD-supply = <&vgen4_reg>; - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>; }; accel at 1c {@@ -572,7 +572,7 @@ AVDD-supply = <®_3p3v>; IOVDD-supply = <®_3p3v>; DVDD-supply = <&vgen4_reg>; - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; }; touchscreen at 20 {Signature · 1 line
2.18.0
Quoted 10 lines · Shawn Guo
Quoted 4 lines · Andrew F. Davis
The correct DT property for specifying a GPIO used for reset is "reset-gpios", fix this here.
Fixes d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")This Fixes tag and word 'Fix' in subject is inappropriate to me, as you are not fixing something wrong from the beginning, but actually replacing a deprecated property with new one.
reset-gpios was standard before this driver got it backwards, but it also wasn't required to be one way or the other as far as I can tell, so I can see your point that this isn't technically "broken". I have no preference, so I'll change the subject and drop the fixes for v2.
Andrew
Quoted 33 lines
Shawn
Quoted 31 lines
Signed-off-by Andrew F. Davis <[email protected]>--- arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +2
-2@@ -384,7 +384,7 @@ AVDD-supply = <®_3p3v>; IOVDD-supply = <®_3p3v>; DVDD-supply = <&vgen4_reg>; - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>; }; accel at 1c {@@ -572,7 +572,7 @@ AVDD-supply = <®_3p3v>; IOVDD-supply = <®_3p3v>; DVDD-supply = <&vgen4_reg>; - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; }; touchscreen at 20 {Signature · 1 line
2.18.0