Skip to contentSkip to conversation

4.14.68-stable review

PATCH In review Greg Kroah-Hartman 7 participants 174 messages Sep 3, 2018 – Oct 3, 2018 Page 2 of 2

Subsystems (9)
Stable branch VFS USB Kselftest +5 more subsystems
lore
Share & tools
lore
author maintainer
#163 lore raw

PATCH 162/165 watchdog: Mark watchdog touch functions as notrace

In reply to Greg Kroah-Hartman

4.14-stable review patch. If anyone has any objections, please let me know.

------------------

From: Vincent Whitchurch <[email protected]>

commit cb9d7fd51d9fbb329d182423bd7b92d0f8cb0e01 upstream.

Some architectures need to use stop_machine() to patch functions for ftrace, and the assumption is that the stopped CPUs do not make function calls to traceable functions when they are in the stopped state.

Commit ce4f06dcbb5d ("stop_machine: Touch_nmi_watchdog() after MULTI_STOP_PREPARE") added calls to the watchdog touch functions from the stopped CPUs and those functions lack notrace annotations. This leads to crashes when enabling/disabling ftrace on ARM kernels built with the Thumb-2 instruction set.

Fix it by adding the necessary notrace annotations.

Fixes ce4f06dcbb5d ("stop_machine: Touch_nmi_watchdog() after MULTI_STOP_PREPARE")
Signed-off-by Vincent Whitchurch <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Link https://lkml.kernel.org/r/[email protected] open here
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 kernel/watchdog.c     |    4 ++--
 kernel/watchdog_hld.c |    2 +-
 kernel/workqueue.c    |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
kernel/watchdog.c +2 -2
@@ -265,7 +265,7 @@ static void __touch_watchdog(void)
  * entering idle state.  This should only be used for scheduler events.
  * Use touch_softlockup_watchdog() for everything else.
  */
-void touch_softlockup_watchdog_sched(void)
+notrace void touch_softlockup_watchdog_sched(void)
 {
 	/*
 	 * Preemption can be enabled.  It doesn't matter which CPU's timestamp

@@ -274,7 +274,7 @@ void touch_softlockup_watchdog_sched(voi
 	raw_cpu_write(watchdog_touch_ts, 0);
 }
 
-void touch_softlockup_watchdog(void)
+notrace void touch_softlockup_watchdog(void)
 {
 	touch_softlockup_watchdog_sched();
 	wq_watchdog_touch(raw_smp_processor_id());
kernel/watchdog_hld.c +1 -1
@@ -29,7 +29,7 @@ static struct cpumask dead_events_mask;
 static unsigned long hardlockup_allcpu_dumped;
 static atomic_t watchdog_cpus = ATOMIC_INIT(0);
 
-void arch_touch_nmi_watchdog(void)
+notrace void arch_touch_nmi_watchdog(void)
 {
 	/*
 	 * Using __raw here because some code paths have
kernel/workqueue.c +1 -1
@@ -5484,7 +5484,7 @@ static void wq_watchdog_timer_fn(unsigne
 	mod_timer(&wq_watchdog_timer, jiffies + thresh);
 }
 
-void wq_watchdog_touch(int cpu)
+notrace void wq_watchdog_touch(int cpu)
 {
 	if (cpu >= 0)
 		per_cpu(wq_watchdog_touched_cpu, cpu) = jiffies;
author maintainer
#164 lore raw

PATCH 163/165 cdrom: Fix info leak/OOB read in cdrom_ioctl_drive_status

In reply to Greg Kroah-Hartman

4.14-stable review patch. If anyone has any objections, please let me know.

------------------

From: Scott Bauer <[email protected]>

commit 8f3fafc9c2f0ece10832c25f7ffcb07c97a32ad4 upstream.

Like d88b6d04: "cdrom: information leak in cdrom_ioctl_media_changed()"

There is another cast from unsigned long to int which causes a bounds check to fail with specially crafted input. The value is then used as an index in the slot array in cdrom_slot_status().

Signed-off-by Scott Bauer <[email protected]>
Signed-off-by Scott Bauer <[email protected]>
Cc [email protected]
Signed-off-by Jens Axboe <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 drivers/cdrom/cdrom.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cdrom/cdrom.c +1 -1
@@ -2542,7 +2542,7 @@ static int cdrom_ioctl_drive_status(stru
 	if (!CDROM_CAN(CDC_SELECT_DISC) ||
 	    (arg == CDSL_CURRENT || arg == CDSL_NONE))
 		return cdi->ops->drive_status(cdi, CDSL_CURRENT);
-	if (((int)arg >= cdi->capacity))
+	if (arg >= cdi->capacity)
 		return -EINVAL;
 	return cdrom_slot_status(cdi, arg);
 }
author maintainer
#165 lore raw

PATCH 164/165 gcc-plugins: Add include required by GCC release 8

In reply to Greg Kroah-Hartman

4.14-stable review patch. If anyone has any objections, please let me know.

------------------

From: Valdis Kletnieks <[email protected]>

commit 80d172431696482d9acd8d2c4ea78fed8956e2a1 upstream.

GCC requires another #include to get the gcc-plugins to build cleanly.

Signed-off-by Valdis Kletnieks <[email protected]>
Signed-off-by Kees Cook <[email protected]>
Cc Lance Albertson <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 scripts/gcc-plugins/gcc-common.h |    4 ++++
 1 file changed, 4 insertions(+)
scripts/gcc-plugins/gcc-common.h +4 -0
@@ -97,6 +97,10 @@
 #include "predict.h"
 #include "ipa-utils.h"
 
+#if BUILDING_GCC_VERSION >= 8000
+#include "stringpool.h"
+#endif
+
 #if BUILDING_GCC_VERSION >= 4009
 #include "attribs.h"
 #include "varasm.h"
#166 lore raw
In reply to Greg Kroah-Hartman
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.68 release. There are 165 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Wed Sep 5 16:56:19 UTC 2018. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.68-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

thanks,

greg k-h

Running kselftest
selftests: bpf: test_tunnel.sh reported kernel crash on i386 device running 4.14.68-rc1
and similar issue reported on 4.18.6-rc1.

[   92.244007] low stack detected by irq handler
[   92.244145] BUG: unable to handle kernel paging request at c4fb1f64
[   92.244161] IP: __call_rcu.constprop.76+0x27/0x4b0
[   92.244164] *pde = 35c05063 *pte = 04fb1161
[   92.244172] Oops: 0003 [#1] SMP
[   92.244176] Modules linked in: veth x86_pkg_temp_thermal fuse
[   92.244187] CPU: 2 PID: 19 Comm: ksoftirqd/2 Not tainted 4.14.68-rc1 #1
[   92.244190] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.244192] task: f5db8000 task.stack: f5db4000
[   92.244198] EIP: __call_rcu.constprop.76+0x27/0x4b0
[   92.244201] EFLAGS: 00210246 CPU: 2
[   92.244204] EAX: 00000000 EBX: c4fb17a0 ECX: c5c2d640 EDX: c4fb17a0
[   92.244206] ESI: c4fb1f60 EDI: c4fb1f60 EBP: f5db5ee4 ESP: f5db5eb0
[   92.244209]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.244212] CR0: 80050033 CR2: c4fb1f64 CR3: 05dff000 CR4: 003406d0
[   92.244215] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[   92.244216] DR6: fffe0ff0 DR7: 00000400
[   92.244218] Call Trace:
[   92.244228]  ? rcu_process_callbacks+0x200/0xdd0
[   92.244234]  ? __lock_is_held+0x48/0x80
[   92.244242]  ? tlb_table_flush.part.118+0x10/0x30
[   92.244248]  call_rcu_sched+0x14/0x20
[   92.244252]  tlb_table_flush.part.118+0x1d/0x30
[   92.244257]  ? rcu_process_callbacks+0x254/0xdd0
[   92.244264]  ? finish_task_switch+0x87/0x1d0
[   92.244276]  __do_softirq+0xac/0x426
[   92.244288]  run_ksoftirqd+0x1f/0x60
[   92.244295]  smpboot_thread_fn+0x120/0x1d0
[   92.244300]  kthread+0xfa/0x110
[   92.244305]  ? sort_range+0x20/0x20
[   92.244310]  ? kthread_create_on_node+0x20/0x20
[   92.244316]  ret_from_fork+0x2e/0x38
[   92.244325] Code: 00 00 00 00 3e 8d 74 26 00 55 89 e5 57 56 53 89
c6 89 d3 83 ec 28 8b 45 08 f7 c6 03 00 00 00 89 4d ec 89 45 e4 0f 85
39 03 00 00 <89> 5e 04 c7 06 00 00 00 00 9c 8f 45 f0 fa e8 66 69 fd ff
8b 55
[   92.244413] EIP: __call_rcu.constprop.76+0x27/0x4b0 SS:ESP: 0068:f5db5eb0
[   92.244415] CR2: 00000000c4fb1f64
[   92.244425] ---[ end trace df3b7c276e7f3926 ]---
[   92.244427] Kernel panic - not syncing: Fatal exception in interrupt
[   92.432150] CPU: 0 PID: 2388 Comm: named Tainted: G      D
4.14.68-rc1 #1
[   92.439620] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.447090] Call Trace:
[   92.449535]  <IRQ>
[   92.451547]  dump_stack+0x66/0x92
[   92.454865]  print_stack_overflow+0x17/0x30
[   92.459052]  call_on_stack+0x45/0x50
[   92.462628]  </IRQ>
[   92.464730] Kernel Offset: 0x3e00000 from 0xc1000000 (relocation
range: 0xc0000000-0xf7bfdfff)
[   92.473333] ---[ end Kernel panic - not syncing: Fatal exception in interrupt
[   92.480458] sched: Unexpected reschedule of offline CPU#3!
[   92.485943] ------------[ cut here ]------------
[   92.490563] WARNING: CPU: 2 PID: 19 at
/srv/oe/build/tmp-rpb-glibc/work-shared/intel-core2-32/kernel-source/arch/x86/kernel/smp.c:128
native_smp_send_reschedule+0x33/0x40
[   92.505752] Modules linked in: veth x86_pkg_temp_thermal fuse
[   92.511490] CPU: 2 PID: 19 Comm: ksoftirqd/2 Tainted: G      D
   4.14.68-rc1 #1
[   92.519305] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.526779] task: f5db8000 task.stack: f5db4000
[   92.531303] EIP: native_smp_send_reschedule+0x33/0x40
[   92.536355] EFLAGS: 00210086 CPU: 2
[   92.539837] EAX: 0000002e EBX: 00000003 ECX: f61d9900 EDX: f61d2d34
[   92.546095] ESI: f5d85500 EDI: f5d85500 EBP: f5db5b44 ESP: f5db5b3c
[   92.552352]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.557744] CR0: 80050033 CR2: c4fb1f64 CR3: 05dff000 CR4: 003406d0
[   92.563998] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[   92.570256] DR6: fffe0ff0 DR7: 00000400
[   92.574087] Call Trace:
[   92.576534]  resched_curr+0x59/0x180
[   92.580112]  check_preempt_curr+0x8d/0xb0
[   92.584115]  ttwu_do_wakeup+0x17/0x240
[   92.587857]  ? activate_task+0x52/0xc0
[   92.591602]  ttwu_do_activate+0x6c/0x90
[   92.595433]  try_to_wake_up+0x2ed/0x570
[   92.599265]  default_wake_function+0x10/0x20
[   92.603536]  autoremove_wake_function+0x14/0x40
[   92.608059]  __wake_up_common+0x68/0x110
[   92.611978]  __wake_up_common_lock+0x57/0x80
[   92.616243]  __wake_up+0x12/0x20
[   92.619476]  wake_up_klogd_work_func+0x3c/0x60
[   92.623920]  irq_work_run_list+0x38/0x60
[   92.627836]  irq_work_tick+0x31/0x40
[   92.631408]  update_process_times+0x3a/0x50
[   92.635586]  tick_sched_handle+0x40/0x60
[   92.639511]  tick_sched_timer+0x38/0x90
[   92.643342]  __hrtimer_run_queues+0xe0/0x490
[   92.647606]  ? tick_sched_do_timer+0x60/0x60
[   92.651878]  hrtimer_interrupt+0x8f/0x190
[   92.655884]  smp_apic_timer_interrupt+0x68/0x290
[   92.660501]  apic_timer_interrupt+0x3a/0x40
[   92.664678] EIP: panic+0x186/0x1cc
[   92.668073] EFLAGS: 00200246 CPU: 2
[   92.671558] EAX: c5ad3108 EBX: 00000000 ECX: f61d2d30 EDX: 00000000
[   92.677815] ESI: 00000000 EDI: 00000000 EBP: f5db5d8c ESP: f5db5d78
[   92.684072]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.689465]  ? freeze_processes+0x3b/0xe0
[   92.693477]  oops_end+0xa3/0xb0
[   92.696614]  no_context+0xd9/0x200
[   92.700010]  ? tlb_table_flush.part.118+0x14/0x30
[   92.704706]  ? find_busiest_group+0x29/0x520
[   92.708971]  ? tlb_table_flush.part.118+0x14/0x30
[   92.713668]  __bad_area_nosemaphore+0xa4/0x130
[   92.718107]  bad_area_nosemaphore+0x12/0x20
[   92.722284]  __do_page_fault+0xb5/0x4b0
[   92.726116]  ? __lock_acquire+0x1fe/0x1130
[   92.730213]  ? tlb_table_flush.part.118+0x14/0x30
[   92.734910]  ? tlb_table_flush.part.118+0x14/0x30
[   92.739607]  do_page_fault+0x20/0x240
[   92.743265]  ? tlb_flush_mmu_free+0x50/0x50
[   92.747442]  ? tlb_table_flush.part.118+0x10/0x30
[   92.752138]  ? __do_page_fault+0x4b0/0x4b0
[   92.756229]  common_exception+0x7c/0x82
[   92.760061] EIP: __call_rcu.constprop.76+0x27/0x4b0
[   92.764930] EFLAGS: 00210246 CPU: 2
[   92.768415] EAX: 00000000 EBX: c4fb17a0 ECX: c5c2d640 EDX: c4fb17a0
[   92.774671] ESI: c4fb1f60 EDI: c4fb1f60 EBP: f5db5ee4 ESP: f5db5eb0
[   92.780928]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.786320]  ? tlb_flush_mmu_free+0x50/0x50
[   92.790497]  ? tlb_flush_mmu_free+0x50/0x50
[   92.794674]  ? tlb_table_flush.part.118+0x10/0x30
[   92.799371]  ? tlb_table_flush.part.118+0x10/0x30
[   92.804069]  ? __init_swait_queue_head+0x3b/0x40
[   92.808686]  ? __do_page_fault+0x4b0/0x4b0
[   92.812778]  ? rcu_process_callbacks+0x200/0xdd0
[   92.817388]  ? __lock_is_held+0x48/0x80
[   92.821219]  ? tlb_table_flush.part.118+0x10/0x30
[   92.825916]  call_rcu_sched+0x14/0x20
[   92.829574]  tlb_table_flush.part.118+0x1d/0x30
[   92.834098]  ? rcu_process_callbacks+0x254/0xdd0
[   92.838715]  ? finish_task_switch+0x87/0x1d0
[   92.842981]  __do_softirq+0xac/0x426
[   92.846551]  run_ksoftirqd+0x1f/0x60
[   92.850122]  smpboot_thread_fn+0x120/0x1d0
[   92.854213]  kthread+0xfa/0x110
[   92.857359]  ? sort_range+0x20/0x20
[   92.860840]  ? kthread_create_on_node+0x20/0x20
[   92.865365]  ret_from_fork+0x2e/0x38
[   92.868938] Code: 0f a3 05 dc da ce c5 73 17 8b 0d 20 d6 ba c5 ba
fd 00 00 00 ff 51 58 c9 c3 8d b4 26 00 00 00 00 50 68 e0 cc ac c5 e8
0a fa 07 00 <0f> 0b 58 5a c9 c3 8d b4 26 00 00 00 00 3e 8d 74 26 00 8b
15 f0
[   92.887724] ---[ end trace df3b7c276e7f3927 ]---

Details for test full run,

4.14 run,
https://lkft.validation.linaro.org/scheduler/job/404796

4.18.6-rc1 run,
https://lkft.validation.linaro.org/scheduler/job/404027#L3244

Best regards
Naresh Kamboju

author maintainer
#167 lore raw
Quoted 174 lines · Naresh Kamboju
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.68 release. There are 165 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Wed Sep 5 16:56:19 UTC 2018. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.68-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

thanks,

greg k-h

Running kselftest
selftests: bpf: test_tunnel.sh reported kernel crash on i386 device running 4.14.68-rc1
and similar issue reported on 4.18.6-rc1.

[   92.244007] low stack detected by irq handler
[   92.244145] BUG: unable to handle kernel paging request at c4fb1f64
[   92.244161] IP: __call_rcu.constprop.76+0x27/0x4b0
[   92.244164] *pde = 35c05063 *pte = 04fb1161
[   92.244172] Oops: 0003 [#1] SMP
[   92.244176] Modules linked in: veth x86_pkg_temp_thermal fuse
[   92.244187] CPU: 2 PID: 19 Comm: ksoftirqd/2 Not tainted 4.14.68-rc1 #1
[   92.244190] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.244192] task: f5db8000 task.stack: f5db4000
[   92.244198] EIP: __call_rcu.constprop.76+0x27/0x4b0
[   92.244201] EFLAGS: 00210246 CPU: 2
[   92.244204] EAX: 00000000 EBX: c4fb17a0 ECX: c5c2d640 EDX: c4fb17a0
[   92.244206] ESI: c4fb1f60 EDI: c4fb1f60 EBP: f5db5ee4 ESP: f5db5eb0
[   92.244209]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.244212] CR0: 80050033 CR2: c4fb1f64 CR3: 05dff000 CR4: 003406d0
[   92.244215] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[   92.244216] DR6: fffe0ff0 DR7: 00000400
[   92.244218] Call Trace:
[   92.244228]  ? rcu_process_callbacks+0x200/0xdd0
[   92.244234]  ? __lock_is_held+0x48/0x80
[   92.244242]  ? tlb_table_flush.part.118+0x10/0x30
[   92.244248]  call_rcu_sched+0x14/0x20
[   92.244252]  tlb_table_flush.part.118+0x1d/0x30
[   92.244257]  ? rcu_process_callbacks+0x254/0xdd0
[   92.244264]  ? finish_task_switch+0x87/0x1d0
[   92.244276]  __do_softirq+0xac/0x426
[   92.244288]  run_ksoftirqd+0x1f/0x60
[   92.244295]  smpboot_thread_fn+0x120/0x1d0
[   92.244300]  kthread+0xfa/0x110
[   92.244305]  ? sort_range+0x20/0x20
[   92.244310]  ? kthread_create_on_node+0x20/0x20
[   92.244316]  ret_from_fork+0x2e/0x38
[   92.244325] Code: 00 00 00 00 3e 8d 74 26 00 55 89 e5 57 56 53 89
c6 89 d3 83 ec 28 8b 45 08 f7 c6 03 00 00 00 89 4d ec 89 45 e4 0f 85
39 03 00 00 <89> 5e 04 c7 06 00 00 00 00 9c 8f 45 f0 fa e8 66 69 fd ff
8b 55
[   92.244413] EIP: __call_rcu.constprop.76+0x27/0x4b0 SS:ESP: 0068:f5db5eb0
[   92.244415] CR2: 00000000c4fb1f64
[   92.244425] ---[ end trace df3b7c276e7f3926 ]---
[   92.244427] Kernel panic - not syncing: Fatal exception in interrupt
[   92.432150] CPU: 0 PID: 2388 Comm: named Tainted: G      D
4.14.68-rc1 #1
[   92.439620] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.447090] Call Trace:
[   92.449535]  <IRQ>
[   92.451547]  dump_stack+0x66/0x92
[   92.454865]  print_stack_overflow+0x17/0x30
[   92.459052]  call_on_stack+0x45/0x50
[   92.462628]  </IRQ>
[   92.464730] Kernel Offset: 0x3e00000 from 0xc1000000 (relocation
range: 0xc0000000-0xf7bfdfff)
[   92.473333] ---[ end Kernel panic - not syncing: Fatal exception in interrupt
[   92.480458] sched: Unexpected reschedule of offline CPU#3!
[   92.485943] ------------[ cut here ]------------
[   92.490563] WARNING: CPU: 2 PID: 19 at
/srv/oe/build/tmp-rpb-glibc/work-shared/intel-core2-32/kernel-source/arch/x86/kernel/smp.c:128
native_smp_send_reschedule+0x33/0x40
[   92.505752] Modules linked in: veth x86_pkg_temp_thermal fuse
[   92.511490] CPU: 2 PID: 19 Comm: ksoftirqd/2 Tainted: G      D
   4.14.68-rc1 #1
[   92.519305] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.526779] task: f5db8000 task.stack: f5db4000
[   92.531303] EIP: native_smp_send_reschedule+0x33/0x40
[   92.536355] EFLAGS: 00210086 CPU: 2
[   92.539837] EAX: 0000002e EBX: 00000003 ECX: f61d9900 EDX: f61d2d34
[   92.546095] ESI: f5d85500 EDI: f5d85500 EBP: f5db5b44 ESP: f5db5b3c
[   92.552352]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.557744] CR0: 80050033 CR2: c4fb1f64 CR3: 05dff000 CR4: 003406d0
[   92.563998] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[   92.570256] DR6: fffe0ff0 DR7: 00000400
[   92.574087] Call Trace:
[   92.576534]  resched_curr+0x59/0x180
[   92.580112]  check_preempt_curr+0x8d/0xb0
[   92.584115]  ttwu_do_wakeup+0x17/0x240
[   92.587857]  ? activate_task+0x52/0xc0
[   92.591602]  ttwu_do_activate+0x6c/0x90
[   92.595433]  try_to_wake_up+0x2ed/0x570
[   92.599265]  default_wake_function+0x10/0x20
[   92.603536]  autoremove_wake_function+0x14/0x40
[   92.608059]  __wake_up_common+0x68/0x110
[   92.611978]  __wake_up_common_lock+0x57/0x80
[   92.616243]  __wake_up+0x12/0x20
[   92.619476]  wake_up_klogd_work_func+0x3c/0x60
[   92.623920]  irq_work_run_list+0x38/0x60
[   92.627836]  irq_work_tick+0x31/0x40
[   92.631408]  update_process_times+0x3a/0x50
[   92.635586]  tick_sched_handle+0x40/0x60
[   92.639511]  tick_sched_timer+0x38/0x90
[   92.643342]  __hrtimer_run_queues+0xe0/0x490
[   92.647606]  ? tick_sched_do_timer+0x60/0x60
[   92.651878]  hrtimer_interrupt+0x8f/0x190
[   92.655884]  smp_apic_timer_interrupt+0x68/0x290
[   92.660501]  apic_timer_interrupt+0x3a/0x40
[   92.664678] EIP: panic+0x186/0x1cc
[   92.668073] EFLAGS: 00200246 CPU: 2
[   92.671558] EAX: c5ad3108 EBX: 00000000 ECX: f61d2d30 EDX: 00000000
[   92.677815] ESI: 00000000 EDI: 00000000 EBP: f5db5d8c ESP: f5db5d78
[   92.684072]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.689465]  ? freeze_processes+0x3b/0xe0
[   92.693477]  oops_end+0xa3/0xb0
[   92.696614]  no_context+0xd9/0x200
[   92.700010]  ? tlb_table_flush.part.118+0x14/0x30
[   92.704706]  ? find_busiest_group+0x29/0x520
[   92.708971]  ? tlb_table_flush.part.118+0x14/0x30
[   92.713668]  __bad_area_nosemaphore+0xa4/0x130
[   92.718107]  bad_area_nosemaphore+0x12/0x20
[   92.722284]  __do_page_fault+0xb5/0x4b0
[   92.726116]  ? __lock_acquire+0x1fe/0x1130
[   92.730213]  ? tlb_table_flush.part.118+0x14/0x30
[   92.734910]  ? tlb_table_flush.part.118+0x14/0x30
[   92.739607]  do_page_fault+0x20/0x240
[   92.743265]  ? tlb_flush_mmu_free+0x50/0x50
[   92.747442]  ? tlb_table_flush.part.118+0x10/0x30
[   92.752138]  ? __do_page_fault+0x4b0/0x4b0
[   92.756229]  common_exception+0x7c/0x82
[   92.760061] EIP: __call_rcu.constprop.76+0x27/0x4b0
[   92.764930] EFLAGS: 00210246 CPU: 2
[   92.768415] EAX: 00000000 EBX: c4fb17a0 ECX: c5c2d640 EDX: c4fb17a0
[   92.774671] ESI: c4fb1f60 EDI: c4fb1f60 EBP: f5db5ee4 ESP: f5db5eb0
[   92.780928]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.786320]  ? tlb_flush_mmu_free+0x50/0x50
[   92.790497]  ? tlb_flush_mmu_free+0x50/0x50
[   92.794674]  ? tlb_table_flush.part.118+0x10/0x30
[   92.799371]  ? tlb_table_flush.part.118+0x10/0x30
[   92.804069]  ? __init_swait_queue_head+0x3b/0x40
[   92.808686]  ? __do_page_fault+0x4b0/0x4b0
[   92.812778]  ? rcu_process_callbacks+0x200/0xdd0
[   92.817388]  ? __lock_is_held+0x48/0x80
[   92.821219]  ? tlb_table_flush.part.118+0x10/0x30
[   92.825916]  call_rcu_sched+0x14/0x20
[   92.829574]  tlb_table_flush.part.118+0x1d/0x30
[   92.834098]  ? rcu_process_callbacks+0x254/0xdd0
[   92.838715]  ? finish_task_switch+0x87/0x1d0
[   92.842981]  __do_softirq+0xac/0x426
[   92.846551]  run_ksoftirqd+0x1f/0x60
[   92.850122]  smpboot_thread_fn+0x120/0x1d0
[   92.854213]  kthread+0xfa/0x110
[   92.857359]  ? sort_range+0x20/0x20
[   92.860840]  ? kthread_create_on_node+0x20/0x20
[   92.865365]  ret_from_fork+0x2e/0x38
[   92.868938] Code: 0f a3 05 dc da ce c5 73 17 8b 0d 20 d6 ba c5 ba
fd 00 00 00 ff 51 58 c9 c3 8d b4 26 00 00 00 00 50 68 e0 cc ac c5 e8
0a fa 07 00 <0f> 0b 58 5a c9 c3 8d b4 26 00 00 00 00 3e 8d 74 26 00 8b
15 f0
[   92.887724] ---[ end trace df3b7c276e7f3927 ]---
Quoted 7 lines

Details for test full run,

4.14 run,
https://lkft.validation.linaro.org/scheduler/job/404796

4.18.6-rc1 run,
https://lkft.validation.linaro.org/scheduler/job/404027#L3244

I have pushed out a -rc2 to hopefully fix this problem.

thanks,

greg k-h

maintainer
#168 lore raw
Quoted 177 lines · Greg Kroah-Hartman
Quoted 176 lines · Naresh Kamboju
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.68 release. There are 165 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Wed Sep 5 16:56:19 UTC 2018. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.68-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

thanks,

greg k-h

Running kselftest
selftests: bpf: test_tunnel.sh reported kernel crash on i386 device running 4.14.68-rc1
and similar issue reported on 4.18.6-rc1.

[   92.244007] low stack detected by irq handler
[   92.244145] BUG: unable to handle kernel paging request at c4fb1f64
[   92.244161] IP: __call_rcu.constprop.76+0x27/0x4b0
[   92.244164] *pde = 35c05063 *pte = 04fb1161
[   92.244172] Oops: 0003 [#1] SMP
[   92.244176] Modules linked in: veth x86_pkg_temp_thermal fuse
[   92.244187] CPU: 2 PID: 19 Comm: ksoftirqd/2 Not tainted 4.14.68-rc1 #1
[   92.244190] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.244192] task: f5db8000 task.stack: f5db4000
[   92.244198] EIP: __call_rcu.constprop.76+0x27/0x4b0
[   92.244201] EFLAGS: 00210246 CPU: 2
[   92.244204] EAX: 00000000 EBX: c4fb17a0 ECX: c5c2d640 EDX: c4fb17a0
[   92.244206] ESI: c4fb1f60 EDI: c4fb1f60 EBP: f5db5ee4 ESP: f5db5eb0
[   92.244209]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.244212] CR0: 80050033 CR2: c4fb1f64 CR3: 05dff000 CR4: 003406d0
[   92.244215] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[   92.244216] DR6: fffe0ff0 DR7: 00000400
[   92.244218] Call Trace:
[   92.244228]  ? rcu_process_callbacks+0x200/0xdd0
[   92.244234]  ? __lock_is_held+0x48/0x80
[   92.244242]  ? tlb_table_flush.part.118+0x10/0x30
[   92.244248]  call_rcu_sched+0x14/0x20
[   92.244252]  tlb_table_flush.part.118+0x1d/0x30
[   92.244257]  ? rcu_process_callbacks+0x254/0xdd0
[   92.244264]  ? finish_task_switch+0x87/0x1d0
[   92.244276]  __do_softirq+0xac/0x426
[   92.244288]  run_ksoftirqd+0x1f/0x60
[   92.244295]  smpboot_thread_fn+0x120/0x1d0
[   92.244300]  kthread+0xfa/0x110
[   92.244305]  ? sort_range+0x20/0x20
[   92.244310]  ? kthread_create_on_node+0x20/0x20
[   92.244316]  ret_from_fork+0x2e/0x38
[   92.244325] Code: 00 00 00 00 3e 8d 74 26 00 55 89 e5 57 56 53 89
c6 89 d3 83 ec 28 8b 45 08 f7 c6 03 00 00 00 89 4d ec 89 45 e4 0f 85
39 03 00 00 <89> 5e 04 c7 06 00 00 00 00 9c 8f 45 f0 fa e8 66 69 fd ff
8b 55
[   92.244413] EIP: __call_rcu.constprop.76+0x27/0x4b0 SS:ESP: 0068:f5db5eb0
[   92.244415] CR2: 00000000c4fb1f64
[   92.244425] ---[ end trace df3b7c276e7f3926 ]---
[   92.244427] Kernel panic - not syncing: Fatal exception in interrupt
[   92.432150] CPU: 0 PID: 2388 Comm: named Tainted: G      D
4.14.68-rc1 #1
[   92.439620] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.447090] Call Trace:
[   92.449535]  <IRQ>
[   92.451547]  dump_stack+0x66/0x92
[   92.454865]  print_stack_overflow+0x17/0x30
[   92.459052]  call_on_stack+0x45/0x50
[   92.462628]  </IRQ>
[   92.464730] Kernel Offset: 0x3e00000 from 0xc1000000 (relocation
range: 0xc0000000-0xf7bfdfff)
[   92.473333] ---[ end Kernel panic - not syncing: Fatal exception in interrupt
[   92.480458] sched: Unexpected reschedule of offline CPU#3!
[   92.485943] ------------[ cut here ]------------
[   92.490563] WARNING: CPU: 2 PID: 19 at
/srv/oe/build/tmp-rpb-glibc/work-shared/intel-core2-32/kernel-source/arch/x86/kernel/smp.c:128
native_smp_send_reschedule+0x33/0x40
[   92.505752] Modules linked in: veth x86_pkg_temp_thermal fuse
[   92.511490] CPU: 2 PID: 19 Comm: ksoftirqd/2 Tainted: G      D
   4.14.68-rc1 #1
[   92.519305] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.526779] task: f5db8000 task.stack: f5db4000
[   92.531303] EIP: native_smp_send_reschedule+0x33/0x40
[   92.536355] EFLAGS: 00210086 CPU: 2
[   92.539837] EAX: 0000002e EBX: 00000003 ECX: f61d9900 EDX: f61d2d34
[   92.546095] ESI: f5d85500 EDI: f5d85500 EBP: f5db5b44 ESP: f5db5b3c
[   92.552352]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.557744] CR0: 80050033 CR2: c4fb1f64 CR3: 05dff000 CR4: 003406d0
[   92.563998] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[   92.570256] DR6: fffe0ff0 DR7: 00000400
[   92.574087] Call Trace:
[   92.576534]  resched_curr+0x59/0x180
[   92.580112]  check_preempt_curr+0x8d/0xb0
[   92.584115]  ttwu_do_wakeup+0x17/0x240
[   92.587857]  ? activate_task+0x52/0xc0
[   92.591602]  ttwu_do_activate+0x6c/0x90
[   92.595433]  try_to_wake_up+0x2ed/0x570
[   92.599265]  default_wake_function+0x10/0x20
[   92.603536]  autoremove_wake_function+0x14/0x40
[   92.608059]  __wake_up_common+0x68/0x110
[   92.611978]  __wake_up_common_lock+0x57/0x80
[   92.616243]  __wake_up+0x12/0x20
[   92.619476]  wake_up_klogd_work_func+0x3c/0x60
[   92.623920]  irq_work_run_list+0x38/0x60
[   92.627836]  irq_work_tick+0x31/0x40
[   92.631408]  update_process_times+0x3a/0x50
[   92.635586]  tick_sched_handle+0x40/0x60
[   92.639511]  tick_sched_timer+0x38/0x90
[   92.643342]  __hrtimer_run_queues+0xe0/0x490
[   92.647606]  ? tick_sched_do_timer+0x60/0x60
[   92.651878]  hrtimer_interrupt+0x8f/0x190
[   92.655884]  smp_apic_timer_interrupt+0x68/0x290
[   92.660501]  apic_timer_interrupt+0x3a/0x40
[   92.664678] EIP: panic+0x186/0x1cc
[   92.668073] EFLAGS: 00200246 CPU: 2
[   92.671558] EAX: c5ad3108 EBX: 00000000 ECX: f61d2d30 EDX: 00000000
[   92.677815] ESI: 00000000 EDI: 00000000 EBP: f5db5d8c ESP: f5db5d78
[   92.684072]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.689465]  ? freeze_processes+0x3b/0xe0
[   92.693477]  oops_end+0xa3/0xb0
[   92.696614]  no_context+0xd9/0x200
[   92.700010]  ? tlb_table_flush.part.118+0x14/0x30
[   92.704706]  ? find_busiest_group+0x29/0x520
[   92.708971]  ? tlb_table_flush.part.118+0x14/0x30
[   92.713668]  __bad_area_nosemaphore+0xa4/0x130
[   92.718107]  bad_area_nosemaphore+0x12/0x20
[   92.722284]  __do_page_fault+0xb5/0x4b0
[   92.726116]  ? __lock_acquire+0x1fe/0x1130
[   92.730213]  ? tlb_table_flush.part.118+0x14/0x30
[   92.734910]  ? tlb_table_flush.part.118+0x14/0x30
[   92.739607]  do_page_fault+0x20/0x240
[   92.743265]  ? tlb_flush_mmu_free+0x50/0x50
[   92.747442]  ? tlb_table_flush.part.118+0x10/0x30
[   92.752138]  ? __do_page_fault+0x4b0/0x4b0
[   92.756229]  common_exception+0x7c/0x82
[   92.760061] EIP: __call_rcu.constprop.76+0x27/0x4b0
[   92.764930] EFLAGS: 00210246 CPU: 2
[   92.768415] EAX: 00000000 EBX: c4fb17a0 ECX: c5c2d640 EDX: c4fb17a0
[   92.774671] ESI: c4fb1f60 EDI: c4fb1f60 EBP: f5db5ee4 ESP: f5db5eb0
[   92.780928]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.786320]  ? tlb_flush_mmu_free+0x50/0x50
[   92.790497]  ? tlb_flush_mmu_free+0x50/0x50
[   92.794674]  ? tlb_table_flush.part.118+0x10/0x30
[   92.799371]  ? tlb_table_flush.part.118+0x10/0x30
[   92.804069]  ? __init_swait_queue_head+0x3b/0x40
[   92.808686]  ? __do_page_fault+0x4b0/0x4b0
[   92.812778]  ? rcu_process_callbacks+0x200/0xdd0
[   92.817388]  ? __lock_is_held+0x48/0x80
[   92.821219]  ? tlb_table_flush.part.118+0x10/0x30
[   92.825916]  call_rcu_sched+0x14/0x20
[   92.829574]  tlb_table_flush.part.118+0x1d/0x30
[   92.834098]  ? rcu_process_callbacks+0x254/0xdd0
[   92.838715]  ? finish_task_switch+0x87/0x1d0
[   92.842981]  __do_softirq+0xac/0x426
[   92.846551]  run_ksoftirqd+0x1f/0x60
[   92.850122]  smpboot_thread_fn+0x120/0x1d0
[   92.854213]  kthread+0xfa/0x110
[   92.857359]  ? sort_range+0x20/0x20
[   92.860840]  ? kthread_create_on_node+0x20/0x20
[   92.865365]  ret_from_fork+0x2e/0x38
[   92.868938] Code: 0f a3 05 dc da ce c5 73 17 8b 0d 20 d6 ba c5 ba
fd 00 00 00 ff 51 58 c9 c3 8d b4 26 00 00 00 00 50 68 e0 cc ac c5 e8
0a fa 07 00 <0f> 0b 58 5a c9 c3 8d b4 26 00 00 00 00 3e 8d 74 26 00 8b
15 f0
[   92.887724] ---[ end trace df3b7c276e7f3927 ]---

Details for test full run,

Quoted 8 lines
Quoted 5 lines

4.14 run,
https://lkft.validation.linaro.org/scheduler/job/404796

4.18.6-rc1 run,
https://lkft.validation.linaro.org/scheduler/job/404027#L3244

I have pushed out a -rc2 to hopefully fix this problem.

This does fix the problem. rc1 didn't boot on my test system.

rc2 compiled and booted. No dmesg regressions.

thanks,
-- Shuah

author maintainer
#169 lore raw
Quoted 184 lines · Shuah Khan
Quoted 183 lines · Greg Kroah-Hartman
Quoted 181 lines · Naresh Kamboju
Quoted 9 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.68 release. There are 165 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Wed Sep 5 16:56:19 UTC 2018. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

Quoted 8 lines
        https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.68-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

thanks,

greg k-h

Running kselftest
selftests: bpf: test_tunnel.sh reported kernel crash on i386 device running 4.14.68-rc1
and similar issue reported on 4.18.6-rc1.

[   92.244007] low stack detected by irq handler
[   92.244145] BUG: unable to handle kernel paging request at c4fb1f64
[   92.244161] IP: __call_rcu.constprop.76+0x27/0x4b0
[   92.244164] *pde = 35c05063 *pte = 04fb1161
[   92.244172] Oops: 0003 [#1] SMP
[   92.244176] Modules linked in: veth x86_pkg_temp_thermal fuse
[   92.244187] CPU: 2 PID: 19 Comm: ksoftirqd/2 Not tainted 4.14.68-rc1 #1
[   92.244190] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.244192] task: f5db8000 task.stack: f5db4000
[   92.244198] EIP: __call_rcu.constprop.76+0x27/0x4b0
[   92.244201] EFLAGS: 00210246 CPU: 2
[   92.244204] EAX: 00000000 EBX: c4fb17a0 ECX: c5c2d640 EDX: c4fb17a0
[   92.244206] ESI: c4fb1f60 EDI: c4fb1f60 EBP: f5db5ee4 ESP: f5db5eb0
[   92.244209]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.244212] CR0: 80050033 CR2: c4fb1f64 CR3: 05dff000 CR4: 003406d0
[   92.244215] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[   92.244216] DR6: fffe0ff0 DR7: 00000400
[   92.244218] Call Trace:
[   92.244228]  ? rcu_process_callbacks+0x200/0xdd0
[   92.244234]  ? __lock_is_held+0x48/0x80
[   92.244242]  ? tlb_table_flush.part.118+0x10/0x30
[   92.244248]  call_rcu_sched+0x14/0x20
[   92.244252]  tlb_table_flush.part.118+0x1d/0x30
[   92.244257]  ? rcu_process_callbacks+0x254/0xdd0
[   92.244264]  ? finish_task_switch+0x87/0x1d0
[   92.244276]  __do_softirq+0xac/0x426
[   92.244288]  run_ksoftirqd+0x1f/0x60
[   92.244295]  smpboot_thread_fn+0x120/0x1d0
[   92.244300]  kthread+0xfa/0x110
[   92.244305]  ? sort_range+0x20/0x20
[   92.244310]  ? kthread_create_on_node+0x20/0x20
[   92.244316]  ret_from_fork+0x2e/0x38
[   92.244325] Code: 00 00 00 00 3e 8d 74 26 00 55 89 e5 57 56 53 89
c6 89 d3 83 ec 28 8b 45 08 f7 c6 03 00 00 00 89 4d ec 89 45 e4 0f 85
39 03 00 00 <89> 5e 04 c7 06 00 00 00 00 9c 8f 45 f0 fa e8 66 69 fd ff
8b 55
[   92.244413] EIP: __call_rcu.constprop.76+0x27/0x4b0 SS:ESP: 0068:f5db5eb0
[   92.244415] CR2: 00000000c4fb1f64
[   92.244425] ---[ end trace df3b7c276e7f3926 ]---
[   92.244427] Kernel panic - not syncing: Fatal exception in interrupt
[   92.432150] CPU: 0 PID: 2388 Comm: named Tainted: G      D
4.14.68-rc1 #1
[   92.439620] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.447090] Call Trace:
[   92.449535]  <IRQ>
[   92.451547]  dump_stack+0x66/0x92
[   92.454865]  print_stack_overflow+0x17/0x30
[   92.459052]  call_on_stack+0x45/0x50
[   92.462628]  </IRQ>
[   92.464730] Kernel Offset: 0x3e00000 from 0xc1000000 (relocation
range: 0xc0000000-0xf7bfdfff)
[   92.473333] ---[ end Kernel panic - not syncing: Fatal exception in interrupt
[   92.480458] sched: Unexpected reschedule of offline CPU#3!
[   92.485943] ------------[ cut here ]------------
[   92.490563] WARNING: CPU: 2 PID: 19 at
/srv/oe/build/tmp-rpb-glibc/work-shared/intel-core2-32/kernel-source/arch/x86/kernel/smp.c:128
native_smp_send_reschedule+0x33/0x40
[   92.505752] Modules linked in: veth x86_pkg_temp_thermal fuse
[   92.511490] CPU: 2 PID: 19 Comm: ksoftirqd/2 Tainted: G      D
   4.14.68-rc1 #1
[   92.519305] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS
2.0b 07/27/2017
[   92.526779] task: f5db8000 task.stack: f5db4000
[   92.531303] EIP: native_smp_send_reschedule+0x33/0x40
[   92.536355] EFLAGS: 00210086 CPU: 2
[   92.539837] EAX: 0000002e EBX: 00000003 ECX: f61d9900 EDX: f61d2d34
[   92.546095] ESI: f5d85500 EDI: f5d85500 EBP: f5db5b44 ESP: f5db5b3c
[   92.552352]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.557744] CR0: 80050033 CR2: c4fb1f64 CR3: 05dff000 CR4: 003406d0
[   92.563998] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
[   92.570256] DR6: fffe0ff0 DR7: 00000400
[   92.574087] Call Trace:
[   92.576534]  resched_curr+0x59/0x180
[   92.580112]  check_preempt_curr+0x8d/0xb0
[   92.584115]  ttwu_do_wakeup+0x17/0x240
[   92.587857]  ? activate_task+0x52/0xc0
[   92.591602]  ttwu_do_activate+0x6c/0x90
[   92.595433]  try_to_wake_up+0x2ed/0x570
[   92.599265]  default_wake_function+0x10/0x20
[   92.603536]  autoremove_wake_function+0x14/0x40
[   92.608059]  __wake_up_common+0x68/0x110
[   92.611978]  __wake_up_common_lock+0x57/0x80
[   92.616243]  __wake_up+0x12/0x20
[   92.619476]  wake_up_klogd_work_func+0x3c/0x60
[   92.623920]  irq_work_run_list+0x38/0x60
[   92.627836]  irq_work_tick+0x31/0x40
[   92.631408]  update_process_times+0x3a/0x50
[   92.635586]  tick_sched_handle+0x40/0x60
[   92.639511]  tick_sched_timer+0x38/0x90
[   92.643342]  __hrtimer_run_queues+0xe0/0x490
[   92.647606]  ? tick_sched_do_timer+0x60/0x60
[   92.651878]  hrtimer_interrupt+0x8f/0x190
[   92.655884]  smp_apic_timer_interrupt+0x68/0x290
[   92.660501]  apic_timer_interrupt+0x3a/0x40
[   92.664678] EIP: panic+0x186/0x1cc
[   92.668073] EFLAGS: 00200246 CPU: 2
[   92.671558] EAX: c5ad3108 EBX: 00000000 ECX: f61d2d30 EDX: 00000000
[   92.677815] ESI: 00000000 EDI: 00000000 EBP: f5db5d8c ESP: f5db5d78
[   92.684072]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.689465]  ? freeze_processes+0x3b/0xe0
[   92.693477]  oops_end+0xa3/0xb0
[   92.696614]  no_context+0xd9/0x200
[   92.700010]  ? tlb_table_flush.part.118+0x14/0x30
[   92.704706]  ? find_busiest_group+0x29/0x520
[   92.708971]  ? tlb_table_flush.part.118+0x14/0x30
[   92.713668]  __bad_area_nosemaphore+0xa4/0x130
[   92.718107]  bad_area_nosemaphore+0x12/0x20
[   92.722284]  __do_page_fault+0xb5/0x4b0
[   92.726116]  ? __lock_acquire+0x1fe/0x1130
[   92.730213]  ? tlb_table_flush.part.118+0x14/0x30
[   92.734910]  ? tlb_table_flush.part.118+0x14/0x30
[   92.739607]  do_page_fault+0x20/0x240
[   92.743265]  ? tlb_flush_mmu_free+0x50/0x50
[   92.747442]  ? tlb_table_flush.part.118+0x10/0x30
[   92.752138]  ? __do_page_fault+0x4b0/0x4b0
[   92.756229]  common_exception+0x7c/0x82
[   92.760061] EIP: __call_rcu.constprop.76+0x27/0x4b0
[   92.764930] EFLAGS: 00210246 CPU: 2
[   92.768415] EAX: 00000000 EBX: c4fb17a0 ECX: c5c2d640 EDX: c4fb17a0
[   92.774671] ESI: c4fb1f60 EDI: c4fb1f60 EBP: f5db5ee4 ESP: f5db5eb0
[   92.780928]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
[   92.786320]  ? tlb_flush_mmu_free+0x50/0x50
[   92.790497]  ? tlb_flush_mmu_free+0x50/0x50
[   92.794674]  ? tlb_table_flush.part.118+0x10/0x30
[   92.799371]  ? tlb_table_flush.part.118+0x10/0x30
[   92.804069]  ? __init_swait_queue_head+0x3b/0x40
[   92.808686]  ? __do_page_fault+0x4b0/0x4b0
[   92.812778]  ? rcu_process_callbacks+0x200/0xdd0
[   92.817388]  ? __lock_is_held+0x48/0x80
[   92.821219]  ? tlb_table_flush.part.118+0x10/0x30
[   92.825916]  call_rcu_sched+0x14/0x20
[   92.829574]  tlb_table_flush.part.118+0x1d/0x30
[   92.834098]  ? rcu_process_callbacks+0x254/0xdd0
[   92.838715]  ? finish_task_switch+0x87/0x1d0
[   92.842981]  __do_softirq+0xac/0x426
[   92.846551]  run_ksoftirqd+0x1f/0x60
[   92.850122]  smpboot_thread_fn+0x120/0x1d0
[   92.854213]  kthread+0xfa/0x110
[   92.857359]  ? sort_range+0x20/0x20
[   92.860840]  ? kthread_create_on_node+0x20/0x20
[   92.865365]  ret_from_fork+0x2e/0x38
[   92.868938] Code: 0f a3 05 dc da ce c5 73 17 8b 0d 20 d6 ba c5 ba
fd 00 00 00 ff 51 58 c9 c3 8d b4 26 00 00 00 00 50 68 e0 cc ac c5 e8
0a fa 07 00 <0f> 0b 58 5a c9 c3 8d b4 26 00 00 00 00 3e 8d 74 26 00 8b
15 f0
[   92.887724] ---[ end trace df3b7c276e7f3927 ]---

Details for test full run,

4.14 run,
https://lkft.validation.linaro.org/scheduler/job/404796

4.18.6-rc1 run,
https://lkft.validation.linaro.org/scheduler/job/404027#L3244

Quoted 6 lines
Quoted 2 lines

I have pushed out a -rc2 to hopefully fix this problem.

This does fix the problem. rc1 didn't boot on my test system.

rc2 compiled and booted. No dmesg regressions.

That's great! Thanks for testing all of these and letting me know.

greg k-h

#170 lore raw
In reply to Greg Kroah-Hartman
Quoted 1 line

I have pushed out a -rc2 to hopefully fix this problem.

4.14.68-rc2 results looks good.
Results from Linaro’s test farm.
No regressions on arm64, arm and x86_64.

Summary
------------------------------------------------------------------------

kernel: 4.14.68-rc2
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.14.y
git commit: e2d662d77f7aace50c2647cb7439acc9a97b1b70
git describe: v4.14.67-167-ge2d662d77f7a
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.14-oe/build/v4.14.67-167-ge2d662d77f7a

No regressions (compared to build v4.14.67)

Ran 21181 total tests in the following environments and test suites.

Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- i386
- juno-r2 - arm64
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15 - arm
- x86_64

Test Suites
-----------
* boot
* kselftest
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-containers-tests
* ltp-cve-tests
* ltp-filecaps-tests
* ltp-fs-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-timers-tests
* ltp-fcntl-locktests-tests
* ltp-math-tests
* ltp-open-posix-tests
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none

Signature · 2 lines
Linaro LKFT
https://lkft.linaro.org
Quoted 4 lines

thanks,

greg k-h

author maintainer
#171 lore raw

PATCH 165/165 gcc-plugins: Use dynamic initializers

In reply to Greg Kroah-Hartman

4.14-stable review patch. If anyone has any objections, please let me know.

------------------

From: Kees Cook <[email protected]>

commit b86729109c5fd0a480300f40608aac68764b5adf upstream.

GCC 8 changed the order of some fields and is very picky about ordering in static initializers, so instead just move to dynamic initializers, and drop the redundant already-zero field assignments.

Suggested-by Valdis Kletnieks <[email protected]>
Signed-off-by Kees Cook <[email protected]>
Cc Lance Albertson <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 scripts/gcc-plugins/latent_entropy_plugin.c   |   17 +----
 scripts/gcc-plugins/randomize_layout_plugin.c |   75 +++++++-------------------
 scripts/gcc-plugins/structleak_plugin.c       |   19 ++----
 3 files changed, 33 insertions(+), 78 deletions(-)
scripts/gcc-plugins/latent_entropy_plugin.c +5 -12
@@ -255,21 +255,14 @@ static tree handle_latent_entropy_attrib
 	return NULL_TREE;
 }
 
-static struct attribute_spec latent_entropy_attr = {
-	.name				= "latent_entropy",
-	.min_length			= 0,
-	.max_length			= 0,
-	.decl_required			= true,
-	.type_required			= false,
-	.function_type_required		= false,
-	.handler			= handle_latent_entropy_attribute,
-#if BUILDING_GCC_VERSION >= 4007
-	.affects_type_identity		= false
-#endif
-};
+static struct attribute_spec latent_entropy_attr = { };
 
 static void register_attributes(void *event_data __unused, void *data __unused)
 {
+	latent_entropy_attr.name		= "latent_entropy";
+	latent_entropy_attr.decl_required	= true;
+	latent_entropy_attr.handler		= handle_latent_entropy_attribute;
+
 	register_attribute(&latent_entropy_attr);
 }
scripts/gcc-plugins/randomize_layout_plugin.c +21 -54

89 lines not on this page · raw message

scripts/gcc-plugins/structleak_plugin.c +7 -12
@@ -57,21 +57,16 @@ static tree handle_user_attribute(tree *
 	return NULL_TREE;
 }
 
-static struct attribute_spec user_attr = {
-	.name			= "user",
-	.min_length		= 0,
-	.max_length		= 0,
-	.decl_required		= false,
-	.type_required		= false,
-	.function_type_required	= false,
-	.handler		= handle_user_attribute,
-#if BUILDING_GCC_VERSION >= 4007
-	.affects_type_identity	= true
-#endif
-};
+static struct attribute_spec user_attr = { };
 
 static void register_attributes(void *event_data, void *data)
 {
+	user_attr.name			= "user";
+	user_attr.handler		= handle_user_attribute;
+#if BUILDING_GCC_VERSION >= 4007
+	user_attr.affects_type_identity	= true;
+#endif
+
 	register_attribute(&user_attr);
 }
author maintainer
#172 lore raw
In reply to Greg Kroah-Hartman
Quoted 5 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.68 release. There are 165 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Quoted 8 lines

Responses should be made by Wed Sep 5 16:56:19 UTC 2018. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.68-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

I have released a -rc2 kernel to fix a reported problem in -rc1:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.68-rc2.gz
#173 lore raw
In reply to Greg Kroah-Hartman
Quoted 8 lines · Greg Kroah-Hartman

This is the start of the stable review cycle for the 4.14.68 release. There are 165 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Wed Sep 5 16:56:19 UTC 2018. Anything received after that time might be too late.

Build results:

	total: 150 pass: 150 fail: 0
Qemu test results:
	total: 311 pass: 311 fail: 0

Details are available at https://kerneltests.org/builders/.

Guenter