Skip to contentSkip to conversation

net: usbnet: mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Sep 3, 2018 – Sep 4, 2018

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: usbnet: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1077614 ("Missing break in switch")

---
 drivers/net/usb/usbnet.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/usb/usbnet.c +1 -0
index 770aa62..73aa333 100644
@@ -1527,6 +1527,7 @@ static void usbnet_bh (struct timer_list *t)
 			continue;
 		case tx_done:
 			kfree(entry->urb->sg);
+			/* fall through */
 		case rx_cleanup:
 			usb_free_urb (entry->urb);
 			dev_kfree_skb (skb);
maintainer Applied
#1 lore raw

From: "Gustavo A. R. Silva" <[email protected]>
Date: Mon, 3 Sep 2018 13:48:45 -0500

Quoted 5 lines

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1077614 ("Missing break in switch")

Applied, thank you.