Skip to contentSkip to conversation

9p: fix spelling mistake in fall-through annotation

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Sep 3, 2018 9P file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 9p: fix spelling mistake in fall-through annotation

Replace "fallthough" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Addresses-Coverity-ID: 402012 ("Missing break in switch")

---
 fs/9p/vfs_file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/9p/vfs_file.c +1 -1
index 5f2e48d..374bc1c 100644
@@ -216,7 +216,7 @@ static int v9fs_file_do_lock(struct file *filp, int cmd, struct file_lock *fl)
 		break;
 	default:
 		WARN_ONCE(1, "unknown lock status code: %d\n", status);
-		/* fallthough */
+		/* fall through */
 	case P9_LOCK_ERROR:
 	case P9_LOCK_GRACE:
 		res = -ENOLCK;
Signature · 1 line
2.7.4
#1 lore raw

Gustavo A. R. Silva wrote on Mon, Sep 03, 2018:

Quoted 5 lines

Replace "fallthough" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Addresses-Coverity-ID: 402012 ("Missing break in switch")

I'm not a fan of these, as each coverity instance has their own ID, and I have no idea if there is an "official" coverity for the linux kernel -- is there?

(Well, I see many patches got landed with that, so I guess there would be)

Quoted 1 line

I'll take this, thanks.

Signature · 1 line
Dominique