Skip to contentSkip to conversation

platform: x86: intel_cht_int33fe: Fix the identifier for the mux connection

PATCH New Heikki Krogerus 1 participant 1 message Sep 4, 2018 USB

lore
Share & tools
lore
#0 lore raw

PATCH v2 6/10 platform: x86: intel_cht_int33fe: Fix the identifier for the mux connection

Hi Hans,

Quoted 14 lines · Hans de Goede

Hi,

Quoted 11 lines · Heikki Krogerus

PI3USB30532 is used for muxing the port to DisplayPort on CHT platforms, so changing the connection ID so that the mux will get assigned to the alternate mode device and not the port device. Connection ID "typec-mux" is now reserved for Accessory Modes.

---
  drivers/platform/x86/intel_cht_int33fe.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines

drivers/platform/x86/intel_cht_int33fe.c static int cht_int33fe_probe(struct i2c_client *client) · line 182

Quoted 10 lines
drivers/platform/x86/intel_cht_int33fe.c +1 -1
index b0cef48f77af..f8c881f871f9 100644
@@ -179,7 +179,7 @@ static int cht_int33fe_probe(struct i2c_client *client)
  	data->connections[0].id = "typec-switch";
  	data->connections[1].endpoint[0] = "i2c-fusb302";
  	data->connections[1].endpoint[1] = "i2c-pi3usb30532";
-	data->connections[1].id = "typec-mux";
+	data->connections[1].id = "idff01m01";

Hmm, so the mux will start in open connection and needs to be moved from open to TYPEC_STATE_USB when doing USB3, I assume the alternative driver is only going to come into play when actually using a DP over Type-C capable device/dongle, so what will do the TYPEC_STATE_SAFE -> TYPEC_STATE_USB switching now ?

Ah, for some reason I assumed that the orientation switch will take care of that, but of course it does not. So we'll keep the existing connections, and just add a new one for the alt mode device.

Sorry for this.

Thanks,