Skip to contentSkip to conversation

ARM: dts: imx6: RDU2: Use new CODEC reset pin name

PATCH In review Andrew F. Davis 2 participants 3 messages Sep 4, 2018 – Sep 10, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 ARM: dts: imx6: RDU2: Use new CODEC reset pin name

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name use this here.

---

Changes from v1:
- Remove "fix" from commit message

 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +2 -2
index 7fff3717cf7c..a0f5cfda0055 100644
@@ -384,7 +384,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
 	};
 
 	accel@1c {
@@ -572,7 +572,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
 	};
 
 	touchscreen@20 {
Signature · 1 line
2.18.0
#1 lore raw

PATCH v2 2/2 ARM: dts: imx: Use new CODEC reset pin name

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name use this here.

---

Changes from v1:
- Remove "fix" from commit message

 arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw5903.dtsi +1 -1
index 368132274a91..ddabab168a8a 100644
@@ -310,7 +310,7 @@
 	tlv320aic3105: codec@18 {
 		compatible = "ti,tlv320aic3x";
 		reg = <0x18>;
-		gpio-reset = <&gpio5 17 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio5 17 GPIO_ACTIVE_LOW>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		ai3x-micbias-vg = <2>; /* MICBIAS_2_5V */
 		/* Regulators */
Signature · 1 line
2.18.0
#2 lore raw
In reply to Andrew F. Davis
Quoted 17 lines · Andrew F. Davis

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name use this here.

---

Changes from v1:
- Remove "fix" from commit message

 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +0 -0
index 7fff3717cf7c..a0f5cfda0055 100644

arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi line 387

Quoted 5 lines
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +1 -1
@@ -384,7 +384,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;

Is it intended to change the polarity?

Shawn

Quoted 15 lines
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +1 -1
 	};
 
 	accel at 1c {
@@ -572,7 +572,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
 	};
 
 	touchscreen at 20 {
Signature · 1 line
2.18.0