Skip to contentSkip to conversation

x86/mm: Add an option to change the padding used for the physical memory mapping

PATCH Superseded Masayoshi Mizuma 4 participants 11 messages Sep 4, 2018 – Sep 20, 2018

Subsystems (3)

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 x86/mm: Add an option to change the padding used for the physical memory mapping

From: Masayoshi Mizuma <[email protected]>

If each node of physical memory layout has huge space for hotplug, the padding used for the physical memory mapping section is not enough. For exapmle of the layout:
SRAT: Node 6 PXM 4 [mem 0x100000000000-0x13ffffffffff] hotplug
SRAT: Node 7 PXM 5 [mem 0x140000000000-0x17ffffffffff] hotplug
SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug

We can increase the padding by CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, however, the needed padding size depends on the system environment. The kernel option is better than changing the config.

Change log from v2:
- Simplify the description. As Baoquan said, this is simillar SGI UV issue, but a little different. Remove SGI UV description.

---
 arch/x86/mm/kaslr.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
arch/x86/mm/kaslr.c +16 -1
index 61db77b0eda9..aeb62615bd46 100644
@@ -40,6 +40,7 @@
  */
 static const unsigned long vaddr_end = CPU_ENTRY_AREA_BASE;
 
+static int __initdata rand_mem_physical_padding = CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING;
 /*
  * Memory regions randomized by KASLR (except modules that use a separate logic
  * earlier during boot). The list is ordered based on virtual addresses. This
@@ -69,6 +70,20 @@ static inline bool kaslr_memory_enabled(void)
 	return kaslr_enabled() && !IS_ENABLED(CONFIG_KASAN);
 }
 
+static int __init rand_mem_physical_padding_setup(char *str)
+{
+	int max_padding = (1 << (MAX_PHYSMEM_BITS - TB_SHIFT)) - 1;
+
+	get_option(&str, &rand_mem_physical_padding);
+	if (rand_mem_physical_padding < 0)
+		rand_mem_physical_padding = 0;
+	else if (rand_mem_physical_padding > max_padding)
+		rand_mem_physical_padding = max_padding;
+
+	return 0;
+}
+early_param("rand_mem_physical_padding", rand_mem_physical_padding_setup);
+
 /* Initialize base and padding for each memory region randomized with KASLR */
 void __init kernel_randomize_memory(void)
 {
@@ -102,7 +117,7 @@ void __init kernel_randomize_memory(void)
 	 */
 	BUG_ON(kaslr_regions[0].base != &page_offset_base);
 	memory_tb = DIV_ROUND_UP(max_pfn << PAGE_SHIFT, 1UL << TB_SHIFT) +
-		CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING;
+		rand_mem_physical_padding;
 
 	/* Adapt phyiscal memory region size based on available memory */
 	if (memory_tb < kaslr_regions[0].size_tb)
Signature · 1 line
2.18.0
#1 lore raw

PATCH v3 2/2 docs: kernel-parameters.txt: document rand_mem_physical_padding parameter

From: Masayoshi Mizuma <[email protected]>

This kernel parameter allows to change the padding used for the physical memory mapping section when KASLR memory is enabled.

For some systems, the default value, CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, is not enough. The option is useful to adjust the padding size to work around such issue.

---
 Documentation/admin-guide/kernel-parameters.txt | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/admin-guide/kernel-parameters.txt +7 -0
index 0c883029881a..97f54c910c9c 100644
@@ -3477,6 +3477,13 @@
 	ramdisk_size=	[RAM] Sizes of RAM disks in kilobytes
 			See Documentation/blockdev/ramdisk.txt.
 
+	rand_mem_physical_padding=
+			[KNL] Define the padding size in terabytes
+			used for the physical memory mapping section
+			when KASLR memory is enabled.
+			The default value is
+			CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING.
+
 	ras=option[,option,...]	[KNL] RAS-specific options
 
 		cec_disable	[X86]
Signature · 1 line
2.18.0
#2 lore raw
In reply to Masayoshi Mizuma

Ping...
I would appreciate if someone could review it because this patch fixes the real memory hotplug issue...

Quoted 69 lines · Masayoshi Mizuma

From: Masayoshi Mizuma <[email protected]>

If each node of physical memory layout has huge space for hotplug, the padding used for the physical memory mapping section is not enough. For exapmle of the layout:
SRAT: Node 6 PXM 4 [mem 0x100000000000-0x13ffffffffff] hotplug
SRAT: Node 7 PXM 5 [mem 0x140000000000-0x17ffffffffff] hotplug
SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug

We can increase the padding by CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, however, the needed padding size depends on the system environment. The kernel option is better than changing the config.

Change log from v2:
- Simplify the description. As Baoquan said, this is simillar SGI UV issue, but a little different. Remove SGI UV description.

---
 arch/x86/mm/kaslr.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
arch/x86/mm/kaslr.c +16 -1
index 61db77b0eda9..aeb62615bd46 100644
@@ -40,6 +40,7 @@
  */
 static const unsigned long vaddr_end = CPU_ENTRY_AREA_BASE;
 
+static int __initdata rand_mem_physical_padding = CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING;
 /*
  * Memory regions randomized by KASLR (except modules that use a separate logic
  * earlier during boot). The list is ordered based on virtual addresses. This
@@ -69,6 +70,20 @@ static inline bool kaslr_memory_enabled(void)
 	return kaslr_enabled() && !IS_ENABLED(CONFIG_KASAN);
 }
 
+static int __init rand_mem_physical_padding_setup(char *str)
+{
+	int max_padding = (1 << (MAX_PHYSMEM_BITS - TB_SHIFT)) - 1;
+
+	get_option(&str, &rand_mem_physical_padding);
+	if (rand_mem_physical_padding < 0)
+		rand_mem_physical_padding = 0;
+	else if (rand_mem_physical_padding > max_padding)
+		rand_mem_physical_padding = max_padding;
+
+	return 0;
+}
+early_param("rand_mem_physical_padding", rand_mem_physical_padding_setup);
+
 /* Initialize base and padding for each memory region randomized with KASLR */
 void __init kernel_randomize_memory(void)
 {
@@ -102,7 +117,7 @@ void __init kernel_randomize_memory(void)
 	 */
 	BUG_ON(kaslr_regions[0].base != &page_offset_base);
 	memory_tb = DIV_ROUND_UP(max_pfn << PAGE_SHIFT, 1UL << TB_SHIFT) +
-		CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING;
+		rand_mem_physical_padding;
 
 	/* Adapt phyiscal memory region size based on available memory */
 	if (memory_tb < kaslr_regions[0].size_tb)
Signature · 1 line
2.18.0
#3 lore raw
Quoted 3 lines · Masayoshi Mizuma

Ping...
I would appreciate if someone could review it because this patch fixes the real memory hotplug issue...

Yeah, so I generally try to resist random new boot options that work around real bugs, so please convince me that this patch is the best option:

Quoted 12 lines · Masayoshi Mizuma
Quoted 10 lines

From: Masayoshi Mizuma <[email protected]>

If each node of physical memory layout has huge space for hotplug, the padding used for the physical memory mapping section is not enough. For exapmle of the layout:
SRAT: Node 6 PXM 4 [mem 0x100000000000-0x13ffffffffff] hotplug
SRAT: Node 7 PXM 5 [mem 0x140000000000-0x17ffffffffff] hotplug
SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug

Quoted 7 lines
Quoted 7 lines

We can increase the padding by CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, however, the needed padding size depends on the system environment. The kernel option is better than changing the config.

Change log from v2:
- Simplify the description. As Baoquan said, this is simillar SGI UV issue, but a little different. Remove SGI UV description.

Could you please explain it a bit better where the higher padding requirement comes from?

'system environment' is very opaque.

Thanks,

Ingo

#4 lore raw
Quoted 26 lines · Ingo Molnar
Quoted 3 lines · Masayoshi Mizuma

Ping...
I would appreciate if someone could review it because this patch fixes the real memory hotplug issue...

Yeah, so I generally try to resist random new boot options that work around real bugs, so please convince me that this patch is the best option:

Quoted 16 lines · Masayoshi Mizuma
Quoted 14 lines

From: Masayoshi Mizuma <[email protected]>

If each node of physical memory layout has huge space for hotplug, the padding used for the physical memory mapping section is not enough. For exapmle of the layout:
SRAT: Node 6 PXM 4 [mem 0x100000000000-0x13ffffffffff] hotplug
SRAT: Node 7 PXM 5 [mem 0x140000000000-0x17ffffffffff] hotplug
SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug

We can increase the padding by CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, however, the needed padding size depends on the system environment. The kernel option is better than changing the config.

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

Change log from v2:
- Simplify the description. As Baoquan said, this is simillar SGI UV issue, but a little different. Remove SGI UV description.

Could you please explain it a bit better where the higher padding requirement comes from?

'system environment' is very opaque.

As I understand it, it's depending on the actual physical characteristics of the machine. So setting a fixed value in Kconfig might work for one, but not for others and having a command line option allows to tweak that at boot time and having a common kernel image.

Ideally we would calculate that from SRAT, but AFAICT SRAT is not available at the point where this needs to be done.

Thanks,

tglx

#5 lore raw
Quoted 35 lines · Thomas Gleixner
Quoted 26 lines · Ingo Molnar
Quoted 3 lines · Masayoshi Mizuma

Ping...
I would appreciate if someone could review it because this patch fixes the real memory hotplug issue...

Yeah, so I generally try to resist random new boot options that work around real bugs, so please convince me that this patch is the best option:

Quoted 16 lines · Masayoshi Mizuma
Quoted 14 lines

From: Masayoshi Mizuma <[email protected]>

If each node of physical memory layout has huge space for hotplug, the padding used for the physical memory mapping section is not enough. For exapmle of the layout:
SRAT: Node 6 PXM 4 [mem 0x100000000000-0x13ffffffffff] hotplug
SRAT: Node 7 PXM 5 [mem 0x140000000000-0x17ffffffffff] hotplug
SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug

We can increase the padding by CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, however, the needed padding size depends on the system environment. The kernel option is better than changing the config.

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

Change log from v2:
- Simplify the description. As Baoquan said, this is simillar SGI UV issue, but a little different. Remove SGI UV description.

Could you please explain it a bit better where the higher padding requirement comes from?

'system environment' is very opaque.

Quoted 7 lines

As I understand it, it's depending on the actual physical characteristics of the machine. So setting a fixed value in Kconfig might work for one, but not for others and having a command line option allows to tweak that at boot time and having a common kernel image.

Ideally we would calculate that from SRAT, but AFAICT SRAT is not available at the point where this needs to be done.

Yeah, so could we at least do something like this:

- See whether using the maximum padding as the new default padding would work for everyone? A bit more virtual memory used, or are there other costs as well?

- Add checking code to the later SRAT case to at least _detect_ bad padding after the fact. We don't utilize RAM with bad padding until that, right?

- Add 'quirk' to the name of the boot parameter, to make it clear that this is really due to suboptimal communication between the firmware and the kernel.

Hm?

Thanks,

Ingo

#6 lore raw
Quoted 38 lines · Ingo Molnar
Quoted 35 lines · Thomas Gleixner
Quoted 33 lines · Ingo Molnar
Quoted 3 lines · Masayoshi Mizuma

Ping...
I would appreciate if someone could review it because this patch fixes the real memory hotplug issue...

Yeah, so I generally try to resist random new boot options that work around real bugs, so please convince me that this patch is the best option:

Quoted 12 lines · Masayoshi Mizuma
Quoted 10 lines

From: Masayoshi Mizuma <[email protected]>

If each node of physical memory layout has huge space for hotplug, the padding used for the physical memory mapping section is not enough. For exapmle of the layout:
SRAT: Node 6 PXM 4 [mem 0x100000000000-0x13ffffffffff] hotplug
SRAT: Node 7 PXM 5 [mem 0x140000000000-0x17ffffffffff] hotplug
SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug

Quoted 7 lines
Quoted 7 lines

We can increase the padding by CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, however, the needed padding size depends on the system environment. The kernel option is better than changing the config.

Change log from v2:
- Simplify the description. As Baoquan said, this is simillar SGI UV issue, but a little different. Remove SGI UV description.

Could you please explain it a bit better where the higher padding requirement comes from?

'system environment' is very opaque.

Quoted 7 lines
Quoted 7 lines

As I understand it, it's depending on the actual physical characteristics of the machine. So setting a fixed value in Kconfig might work for one, but not for others and having a command line option allows to tweak that at boot time and having a common kernel image.

Ideally we would calculate that from SRAT, but AFAICT SRAT is not available at the point where this needs to be done.

Yes, that's right. The KASLR initialization is early boot sequence, so SRAT is not available at that time.

Quoted 5 lines

Yeah, so could we at least do something like this:

- See whether using the maximum padding as the new default padding would work for everyone? A bit more virtual memory used, or are there other costs as well?

The current default padding size if CONFIG_MEMORY_HOTPLUG set is 10TB. IMO, it should not be increased because it gets the available entropy decreased...

Quoted 2 lines

- Add checking code to the later SRAT case to at least _detect_ bad padding after the fact. We don't utilize RAM with bad padding until that, right?

I have an idea as following. Does that make sense?

Add a warning message which shows the padding size is not enough for the physical memory mapping and tell to the user about recommended padding size. User can change the padding size in next reboot to add the boot parameter.

Quoted 3 lines

- Add 'quirk' to the name of the boot parameter, to make it clear that this is really due to suboptimal communication between the firmware and the kernel.

I'm ok if 'quirk' is added to the boot parameter.

Thanks,
Masa

#7 lore raw
Quoted 7 lines · Masayoshi Mizuma
Quoted 6 lines · Ingo Molnar
Quoted 3 lines · Thomas Gleixner
Quoted 2 lines · Ingo Molnar

* Masayoshi Mizuma <[email protected]> wrote:

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

Ping...
I would appreciate if someone could review it because this patch fixes the real memory hotplug issue...

Yeah, so I generally try to resist random new boot options that work around real bugs, so please convince me that this patch is the best option:

I whole hardily concur, that having boot options which are not easily understood should be avoided. The very best is the system should just work. But on very large systems, these boot options are typically determined by either automated scripts, or careful instructions to the trained onsite customer engineers, who are required to "get it right".

Quoted 30 lines
Quoted 30 lines
Quoted 30 lines
Quoted 17 lines
Quoted 17 lines · Masayoshi Mizuma
Quoted 14 lines

From: Masayoshi Mizuma <[email protected]>

If each node of physical memory layout has huge space for hotplug, the padding used for the physical memory mapping section is not enough. For exapmle of the layout:

   SRAT: Node 6 PXM 4 [mem 0x100000000000-0x13ffffffffff] hotplug
   SRAT: Node 7 PXM 5 [mem 0x140000000000-0x17ffffffffff] hotplug
   SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
   SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug

We can increase the padding by CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, however, the needed padding size depends on the system environment. The kernel option is better than changing the config.

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

Change log from v2:
- Simplify the description. As Baoquan said, this is simillar SGI UV issue, but a little different. Remove SGI UV description.

Could you please explain it a bit better where the higher padding requirement comes from?

'system environment' is very opaque.

As I understand it, it's depending on the actual physical characteristics of the machine. So setting a fixed value in Kconfig might work for one, but not for others and having a command line option allows to tweak that at boot time and having a common kernel image.

Quoted 5 lines
Quoted 2 lines
Quoted 2 lines

Ideally we would calculate that from SRAT, but AFAICT SRAT is not available at the point where this needs to be done.

Yes, that's right. The KASLR initialization is early boot sequence, so SRAT is not available at that time.

Some facts are available via the x86 boot options structure passed from BIOS. Is there enough info in there to help determine what the optimal value of this parameter should be? Even a safe guess gets the system booted and can then be refined for the next reboot.

Quoted 13 lines
Quoted 5 lines

Yeah, so could we at least do something like this:

- See whether using the maximum padding as the new default padding would work for everyone? A bit more virtual memory used, or are there other costs as well?

The current default padding size if CONFIG_MEMORY_HOTPLUG set is 10TB. IMO, it should not be increased because it gets the available entropy decreased...

Quoted 2 lines

- Add checking code to the later SRAT case to at least _detect_ bad padding after the fact. We don't utilize RAM with bad padding until that, right?

Quoted 6 lines

I have an idea as following. Does that make sense?

Add a warning message which shows the padding size is not enough for the physical memory mapping and tell to the user about recommended padding size. User can change the padding size in next reboot to add the boot parameter.

Again, leaving it solely up to the user is probably not the best approach, either for single workstation users who may not understand what's up, or large system users which will just generate a customer service call, because something went wrong and they can't boot. Or their performance went down the drain. [Normally upgrades that change the system config use an onsite CE, but that's not strictly required.]

So basically a deterministic method of calculating what this padding should be works best from a customer support angle. For an individual workstation user, having the kernel determine what's correct for proper operation is the best.

Thanks,
Mike

Quoted 9 lines
Quoted 3 lines

- Add 'quirk' to the name of the boot parameter, to make it clear that this is really due to suboptimal communication between the firmware and the kernel.

I'm ok if 'quirk' is added to the boot parameter.

Thanks,
Masa

#8 lore raw
Quoted 57 lines · Mike
Quoted 7 lines · Masayoshi Mizuma
Quoted 6 lines · Ingo Molnar
Quoted 3 lines · Thomas Gleixner
Quoted 2 lines · Ingo Molnar

* Masayoshi Mizuma <[email protected]> wrote:

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

Ping...
I would appreciate if someone could review it because this patch fixes the real memory hotplug issue...

Yeah, so I generally try to resist random new boot options that work around real bugs, so please convince me that this patch is the best option:

I whole hardily concur, that having boot options which are not easily understood should be avoided. The very best is the system should just work. But on very large systems, these boot options are typically determined by either automated scripts, or careful instructions to the trained onsite customer engineers, who are required to "get it right".

Quoted 33 lines
Quoted 32 lines
Quoted 32 lines
Quoted 17 lines
Quoted 17 lines · Masayoshi Mizuma
Quoted 14 lines

From: Masayoshi Mizuma <[email protected]>

If each node of physical memory layout has huge space for hotplug, the padding used for the physical memory mapping section is not enough. For exapmle of the layout:

   SRAT: Node 6 PXM 4 [mem 0x100000000000-0x13ffffffffff] hotplug
   SRAT: Node 7 PXM 5 [mem 0x140000000000-0x17ffffffffff] hotplug
   SRAT: Node 2 PXM 6 [mem 0x180000000000-0x1bffffffffff] hotplug
   SRAT: Node 3 PXM 7 [mem 0x1c0000000000-0x1fffffffffff] hotplug

We can increase the padding by CONFIG_RANDOMIZE_MEMORY_PHYSICAL_PADDING, however, the needed padding size depends on the system environment. The kernel option is better than changing the config.

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

Change log from v2:
- Simplify the description. As Baoquan said, this is simillar SGI UV issue, but a little different. Remove SGI UV description.

Could you please explain it a bit better where the higher padding requirement comes from?

'system environment' is very opaque.

As I understand it, it's depending on the actual physical characteristics of the machine. So setting a fixed value in Kconfig might work for one, but not for others and having a command line option allows to tweak that at boot time and having a common kernel image.

Ideally we would calculate that from SRAT, but AFAICT SRAT is not available at the point where this needs to be done.

Quoted 7 lines
Quoted 2 lines

Yes, that's right. The KASLR initialization is early boot sequence, so SRAT is not available at that time.

Some facts are available via the x86 boot options structure passed from BIOS. Is there enough info in there to help determine what the optimal value of this parameter should be? Even a safe guess gets the system booted and can then be refined for the next reboot.

Unfortunately, the bios information doesn't useful for the padding size for memory hotplug. ACPI SRAT is needed, but it is not available at the KASLR initialization time...

Quoted 28 lines
Quoted 14 lines
Quoted 6 lines

Yeah, so could we at least do something like this:

- See whether using the maximum padding as the new default padding would work for everyone? A bit more virtual memory used, or are there other costs as well?

The current default padding size if CONFIG_MEMORY_HOTPLUG set is 10TB. IMO, it should not be increased because it gets the available entropy decreased...

Quoted 2 lines

- Add checking code to the later SRAT case to at least _detect_ bad padding after the fact. We don't utilize RAM with bad padding until that, right?

Quoted 6 lines

I have an idea as following. Does that make sense?

Add a warning message which shows the padding size is not enough for the physical memory mapping and tell to the user about recommended padding size. User can change the padding size in next reboot to add the boot parameter.

Again, leaving it solely up to the user is probably not the best approach, either for single workstation users who may not understand what's up, or large system users which will just generate a customer service call, because something went wrong and they can't boot. Or their performance went down the drain. [Normally upgrades that change the system config use an onsite CE, but that's not strictly required.]

Quoted 4 lines

So basically a deterministic method of calculating what this padding should be works best from a customer support angle. For an individual workstation user, having the kernel determine what's correct for proper operation is the best.

I agree it is better to set the padding size automatically for users, however, we cannot do so at the KASLR initialization timing because of the above reason.
So, I will try to add warning message to show the recommended padding size for the memory hotplug.

Thanks,
Masa

#9 lore raw
In reply to Masayoshi Mizuma
Quoted 5 lines · Masayoshi Mizuma
Quoted 3 lines · Ingo Molnar

- Add checking code to the later SRAT case to at least _detect_ bad padding after the fact.

Quoted 8 lines
Quoted 1 line

We don't utilize RAM with bad padding until that, right?

I have an idea as following. Does that make sense?

Add a warning message which shows the padding size is not enough for the physical memory mapping and tell to the user about recommended padding size. User can change the padding size in next reboot to add the boot parameter.

Yes, that makes sense because silently failing is bad.

Thanks,

tglx

#10 lore raw
Quoted 8 lines · Thomas Gleixner
Quoted 7 lines · Masayoshi Mizuma
Quoted 4 lines · Ingo Molnar

- Add checking code to the later SRAT case to at least _detect_ bad padding after the fact.

We don't utilize RAM with bad padding until that, right?

Quoted 8 lines
Quoted 6 lines

I have an idea as following. Does that make sense?

Add a warning message which shows the padding size is not enough for the physical memory mapping and tell to the user about recommended padding size. User can change the padding size in next reboot to add the boot parameter.

Yes, that makes sense because silently failing is bad.

Thanks. I will try to add it.

- Masa