boost: fix static detection of lock-free atomic ints
PATCH v3 1/1 boost: fix static detection of lock-free atomic ints
When build statically, boost is unable to detect lock-free atomics ints because it tries to link dynamically, see output/build/boost-1.67.0/bin.v2/config.log (with -d5 option):
Using shell: /bin/sh -c
argv[0] = '/bin/sh'
argv[1] = '-c'
argv[2] = '
"/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o "bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp"'
gcc.compile.c++ bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o
"/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o "bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp"
0.033561 sec system; 0.126314 sec user; 288.682473 sec clock gcc.compile.c++ bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o
"/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -I"." -c -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" "libs/system/src/error_code.cpp"
0.084060 sec system; 0.644133 sec user; 8.858824 sec clock
SEM: <s>gcc-link-semaphore now used by <pbin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi>libboost_system.so.1.67.0 Using shell: /bin/sh -c
argv[0] = '/bin/sh'
argv[1] = '-c'
argv[2] = '
"/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0" -Wl,-h -Wl,libboost_system.so.1.67.0 -shared -Wl,--start-group "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" -Wl,-Bstatic -Wl,-Bdynamic -lrt -Wl,--end-group -fPIC -pthread -g -Wl,-elf2flt -static'
gcc.link.dll bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0
"/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0" -Wl,-h -Wl,libboost_system.so.1.67.0 -shared -Wl,--start-group "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" -Wl,-Bstatic -Wl,-Bdynamic -lrt -Wl,--end-group -fPIC -pthread -g -Wl,-elf2flt -static
ld (ld-elf2flt): -shared used without passing a shared library ID
collect2: error: ld a retourn? le statut de sortie 1
0.003123 sec system; 0.004732 sec user; 15.646509 sec clock
...failed gcc.link.dll bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0...
Due to this wrong detection, boost_atomic is wrongly selected by boost_thread which cause a build failure on missing select
To fix this, move the exe statement before the boost/thread project
Fixes:
- http://autobuild.buildroot.org/results/f46d38991385cbc2a4fa14eb31074e770cd79803
---
Changes v2 -> v3 (after review of Thomas Petazzoni):
- Replace hack by a patch movin exe statement in the beginning of libs/thread/build/Jamfile.v2
Changes v1 -> v2 (after review of Arnout Vandecappelle):
- Fix URL of build failure
...c-detection-of-lock-free-atomic-ints.patch | 80 +++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch new file +80 -0
@@ -0,0 +1,80 @@ +From 48be99d20753ecab8817b030b95a7f1260aa777f Mon Sep 17 00:00:00 2001 +From: Fabrice Fontaine <[email protected]> +Date: Wed, 5 Sep 2018 12:04:15 +0200 +Subject: [PATCH 17/17] fix static detection of lock-free atomic ints +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +When build statically, boost is unable to detect lock-free atomics ints +because it tries to link dynamically with boost_system, see +output/build/boost-1.67.0/bin.v2/config.log (with -d5 option): + +Using shell: /bin/sh -c + argv[0] = '/bin/sh' + argv[1] = '-c' + argv[2] = ' + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o "bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp" +' +gcc.compile.c++ bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o + + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o "bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp" + +0.033561 sec system; 0.126314 sec user; 288.682473 sec clock +gcc.compile.c++ bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o + + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -I"." -c -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" "libs/system/src/error_code.cpp" + +0.084060 sec system; 0.644133 sec user; 8.858824 sec clock +SEM: <s>gcc-link-semaphore now used by <pbin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi>libboost_system.so.1.67.0 +Using shell: /bin/sh -c + argv[0] = '/bin/sh' + argv[1] = '-c' + argv[2] = ' + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0" -Wl,-h -Wl,libboost_system.so.1.67.0 -shared -Wl,--start-group "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" -Wl,-Bstatic -Wl,-Bdynamic -lrt -Wl,--end-group -fPIC -pthread -g -Wl,-elf2flt -static +' +gcc.link.dll bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0 + + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0" -Wl,-h -Wl,libboost_system.so.1.67.0 -shared -Wl,--start-group "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" -Wl,-Bstatic -Wl,-Bdynamic -lrt -Wl,--end-group -fPIC -pthread -g -Wl,-elf2flt -static + +ld (ld-elf2flt): -shared used without passing a shared library ID +collect2: error: ld a retourn? le statut de sortie 1 +0.003123 sec system; 0.004732 sec user; 15.646509 sec clock +...failed gcc.link.dll bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0... + +To fix this, move the exe statement before the boost/thread project + +Fixes: + - http://autobuild.buildroot.org/results/f46d38991385cbc2a4fa14eb31074e770cd79803 + +Signed-off-by: Fabrice Fontaine <[email protected]> +[Upstream status: https://github.com/boostorg/thread/pull/231] +--- + build/Jamfile.v2 | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/libs/thread/build/Jamfile.v2 b/build/Jamfile.v2 +index ce8c7f47..26d8b9c3 100644 +--- a/libs/thread/build/Jamfile.v2 ++++ b/libs/thread/build/Jamfile.v2 +@@ -38,6 +38,8 @@ import path ; + import configure ; + import threadapi-feature ; + ++exe has_atomic_flag_lockfree : ../build/has_atomic_flag_lockfree_test.cpp ; ++ + project boost/thread + : source-location ../src + : requirements <threading>multi +@@ -141,8 +143,6 @@ project boost/thread + <library>/boost/system//boost_system + ; + +-exe has_atomic_flag_lockfree : ../build/has_atomic_flag_lockfree_test.cpp ; +- + rule tag ( name : type ? : property-set ) + { + local result = $(name) ; +-- +2.17.1 +
Signature · 1 line
2.17.1
PATCH v3 1/1 boost: fix static detection of lock-free atomic ints
Hello Fabrice,
Thanks again for your work on this topic. However, I am sorry, but I still don't understand :-/
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch line 10
Quoted 2 lines · Fabrice Fontaine
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch new file +2
-0+When build statically, boost is unable to detect lock-free atomics ints +because it tries to link dynamically with boost_system, see
I don't see where it tries to link dynamically with boost_system.
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch line 21
Quoted 9 lines
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch new file +8
-0+Using shell: /bin/sh -c + argv[0] = '/bin/sh' + argv[1] = '-c' + argv[2] = ' + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o "bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp" +gcc.compile.c++ bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o + + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o "bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp"
Here it builds the object file has_atomic_flag_lockfree_test.o, it uses -static, there's no -shared or nothing really wrong here. This tests succeeds, so lock-free atomic ints are available, we're all good.
It does *not* try to link against libboost_system at this point.
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch line 34
Quoted 12 lines
+0.033561 sec system; 0.126314 sec user; 288.682473 sec clock
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch new file +11
-0+gcc.compile.c++ bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o + + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -I"." -c -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" "libs/system/src/error_code.cpp" + +0.084060 sec system; 0.644133 sec user; 8.858824 sec clock +SEM: <s>gcc-link-semaphore now used by <pbin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi>libboost_system.so.1.67.0 +Using shell: /bin/sh -c + argv[0] = '/bin/sh' + argv[1] = '-c' + argv[2] = ' + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0" -Wl,-h -Wl,libboost_system.so.1.67.0 -shared -Wl,--start-group "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" -Wl,-Bstatic -Wl,-Bdynamic -lrt -Wl,--end-group -fPIC -pthread -g -Wl,-elf2flt -static
Here is also does not try to link against libboost_system: it tries to *generate* it!
The summarized command is "g++ -o libboost_system.so.1.67.0" so the overall goal of the command is to *produce* libboost_system.so.1.67.0, not to link against it.
Quoted 1 line
+ld (ld-elf2flt): -shared used without passing a shared library ID
Obviously, this fails because building shared libraries is not possible in this static-only configuration.
But I fail to see the relation:
- Between producing libboost_system.so and the "project boost/thread" thing
- Between inverting "project boost/thread" and the atomic_flag_lock_free test and this issue disappearing.
This still feel very mysterious to me.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v3 1/1 boost: fix static detection of lock-free atomic ints
Dear Thomas,
Le jeu. 6 sept. 2018 ? 21:06, Thomas Petazzoni <[email protected]> a ?crit :
Quoted 69 lines
Hello Fabrice,
Thanks again for your work on this topic. However, I am sorry, but I still don't understand :-/
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch line 10
Quoted 2 lines · Fabrice Fontaine
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch new file +2
-0+When build statically, boost is unable to detect lock-free atomics ints +because it tries to link dynamically with boost_system, seeI don't see where it tries to link dynamically with
boost_system.package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch
Quoted 5 lines
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch new file +5
-0+Using shell: /bin/sh -c + argv[0] = '/bin/sh' + argv[1] = '-c' + argv[2] = ' + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++"-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline
(quoted diff) +0
-3-Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o"
bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp"Quoted 2 lines
+gcc.compile.c++
bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.oReview
Quoted 2 lines
(quoted diff) +2
-0+ + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++"-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline
(quoted diff) +0
-3-Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o"
bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp"Here it builds the object file has_atomic_flag_lockfree_test.o, it uses -static, there's no -shared or nothing really wrong here. This tests succeeds, so lock-free atomic ints are available, we're all good.
It does *not* try to link against
libboost_systemat this point.Quoted 2 lines
+0.033561 sec system; 0.126314 sec user; 288.682473 sec clock +gcc.compile.c++
bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.oReview
Quoted 2 lines
(quoted diff) +2
-0+ + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++"-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline
(quoted diff) +0
-2-Wall -pedantic -g -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -I"." -c -o"
bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" "libs/system/src/error_code.cpp"package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch
Quoted 3 lines
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch new file +3
-0+ +0.084060 sec system; 0.644133 sec user; 8.858824 sec clock +SEM: <s>gcc-link-semaphore now used by<pbin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi>libboost_system.so.1.67.0
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch
Quoted 5 lines
package/boost/0005-fix-static-detection-of-lock-free-atomic-ints.patch new file +5
-0+Using shell: /bin/sh -c + argv[0] = '/bin/sh' + argv[1] = '-c' + argv[2] = ' + "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -o"bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0" -Wl,-h -Wl,libboost_system.so.1.67.0 -shared -Wl,--start-group "
bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o"(quoted diff) +0
-2-Wl,-Bstatic -Wl,-Bdynamic -lrt -Wl,--end-group -fPIC -pthread -g -Wl,-elf2flt -static
Quoted 7 lines
Here is also does not try to link against
libboost_system: it tries to *generate* it!The summarized command is "g++ -o libboost_system.so.1.67.0" so the overall goal of the command is to *produce* libboost_system.so.1.67.0, not to link against it.
That's right it fails because it can't produce it but it produces it in the goal of linking to it. For more information, you can see more traces of a successfull build in the PR: https://github.com/boostorg/thread/pull/231.
Quoted 12 lines
Quoted 2 lines
+ld (ld-elf2flt): -shared used without passing a shared library ID
Obviously, this fails because building shared libraries is not possible in this static-only configuration.
But I fail to see the relation:
- Between producing libboost_system.so and the "project boost/thread" thing
Here is an extract of the "Project attributes" section of
https://www.boost.org/doc/libs/1_67_0/doc/html/bbv2/tutorial.html
<https://www.boost.org/doc/libs/1_36_0/doc/html/bbv2/tutorial.html>:
"If we want the same requirements for our other target, hello2 , we could simply duplicate them. However, as projects grow, that approach leads to a great deal of repeated boilerplate in Jamfiles. Fortunately, there's a better way. Each project can specify a set of *attributes*, including requirements:
project
: requirements <include>/home/ghost/Work/boost <threading>multi ;
exe hello : hello.cpp ;
exe hello2 : hello.cpp ;"
So in our case, we have:
project boost/thread
: requirements <threading>multi
[...]
<library>/boost/system//boost_system ;
exe has_atomic_flag_lockfree : ../build/has_atomic_flag_lockfree_test.cpp ;
This means that has_atomic_flag_lockfree requires boost_system. If we move has_atomic_flag_lockfree before the project statement then boost_system is not required anymore. This also means that all the other requirements for boost/thread does not apply for this simple test which seems acceptabe to me.
Quoted 6 lines
- Between inverting "project boost/thread" and the
atomic_flag_lock_freetest and this issue disappearing.This still feel very mysterious to me.
Quoted 8 lines
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Best Regards,
Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180906/a41b789d/attachment.html>
Thomas Petazzoni
AppliedPATCH v3 1/1 boost: fix static detection of lock-free atomic ints
In reply to Fabrice FontaineHello,
Quoted 41 lines · Fabrice Fontaine
When build statically, boost is unable to detect lock-free atomics ints because it tries to link dynamically, see output/build/boost-1.67.0/bin.v2/config.log (with -d5 option):
Using shell:
/bin/sh-cargv[0] = '/bin/sh' argv[1] = '-c' argv[2] = ' "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o "bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp"'
gcc.compile.c++bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o"
/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -Wextra -Wno-long-long -Wno-unused-parameter -Wunused-function -pedantic -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -I"." -c -o "bin.v2/libs/thread/build/gcc-6.4.0/debug/threading-multi/has_atomic_flag_lockfree_test.o" "libs/thread/src/../build/has_atomic_flag_lockfree_test.cpp"0.033561 sec system; 0.126314 sec user; 288.682473 sec clock gcc.compile.c++
bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o"
/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -Wl,-elf2flt -static -Wl,-elf2flt -static -fPIC -pthread -O0 -fno-inline -Wall -pedantic -g -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -I"." -c -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" "libs/system/src/error_code.cpp"0.084060 sec system; 0.644133 sec user; 8.858824 sec clock
SEM: <s>gcc-link-semaphore now used by <pbin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi>libboost_system.so.1.67.0 Using shell:/bin/sh-cargv[0] = '/bin/sh' argv[1] = '-c' argv[2] = ' "/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0" -Wl,-h -Wl,libboost_system.so.1.67.0 -shared -Wl,--start-group "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" -Wl,-Bstatic -Wl,-Bdynamic -lrt -Wl,--end-group -fPIC -pthread -g -Wl,-elf2flt -static'
gcc.link.dll bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0"/home/fabrice/buildroot/output/host/bin/arm-linux-g++" -o "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0" -Wl,-h -Wl,libboost_system.so.1.67.0 -shared -Wl,--start-group "bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/error_code.o" -Wl,-Bstatic -Wl,-Bdynamic -lrt -Wl,--end-group -fPIC -pthread -g -Wl,-elf2flt -staticld (ld-elf2flt): -shared used without passing a shared library ID
collect2: error: ld a retourn? le statut de sortie 1
0.003123 sec system; 0.004732 sec user; 15.646509 sec clock
...failed gcc.link.dll bin.v2/libs/system/build/gcc-6.4.0/debug/threading-multi/libboost_system.so.1.67.0...Due to this wrong detection,
boost_atomicis wrongly selected byboost_threadwhich cause a build failure on missing selectTo fix this, move the exe statement before the boost/thread project
Quoted 8 lines
Fixes:
- http://autobuild.buildroot.org/results/f46d38991385cbc2a4fa14eb31074e770cd79803Signed-off-by Fabrice Fontaine <[email protected]>---
Changes v2 -> v3 (after review of Thomas Petazzoni):
- Replace hack by a patch movin exe statement in the beginning of libs/thread/build/Jamfile.v2
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com