Skip to contentSkip to conversation

linux-fslc: Update SRCREV

PATCH In review Andreas Müller 3 participants 8 messages Sep 5, 2018 – Sep 6, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 linux-fslc: Update SRCREV

The only change introduced is menuconfig fix.

---
 recipes-kernel/linux/linux-fslc_4.17.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-kernel/linux/linux-fslc_4.17.bb +1 -1
index 61c0c385..8426357c 100644
@@ -14,6 +14,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=bbea815ee2795b2f4230826c0c6b8814"
 PV = "4.17+git${SRCPV}"
 
 SRCBRANCH = "4.17.x+fslc"
-SRCREV = "076d88a62d8a3ef0f393ea52fa89bb4ab1d720c5"
+SRCREV = "65375933f02aac8aa8e0e2da7827e2ae9dec0ff3"
 
 COMPATIBLE_MACHINE = "(mxs|mx5|mx6|vf|use-mainline-bsp)"
Signature · 1 line
2.14.4
#1 lore raw

PATCH 2/2 linux-fslc/defconfig: Add CONFIG_TMPFS_POSIX_ACL=y

Fixes:

| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[220]: Failed to apply ACL on /dev/v4l-subdev0: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[224]: Failed to apply ACL on /dev/v4l-subdev1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[215]: Failed to apply ACL on /dev/v4l-subdev10: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[228]: Failed to apply ACL on /dev/v4l-subdev2: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[232]: Failed to apply ACL on /dev/v4l-subdev5: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[217]: Failed to apply ACL on /dev/v4l-subdev11: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[214]: Failed to apply ACL on /dev/dri/card1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[216]: Failed to apply ACL on /dev/v4l-subdev8: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[226]: Failed to apply ACL on /dev/v4l-subdev9: Operation not supported

and nasty follow-ups: Starting weston from sddm as unpriviledged user fails with some hints on missing access rights.

For a better understanding CONFIG_TMPFS=y was added which was set indirectly by CONFIG_DEVTMPFS=y

---
 recipes-kernel/linux/linux-fslc/defconfig | 2 ++
 1 file changed, 2 insertions(+)
recipes-kernel/linux/linux-fslc/defconfig +2 -0
index 3b68a8af..84d59fc4 100644
@@ -394,6 +394,8 @@ CONFIG_ZISOFS=y
 CONFIG_UDF_FS=m
 CONFIG_MSDOS_FS=m
 CONFIG_VFAT_FS=y
+CONFIG_TMPFS=y
+CONFIG_TMPFS_POSIX_ACL=y
 CONFIG_JFFS2_FS=y
 CONFIG_UBIFS_FS=y
 CONFIG_NFS_FS=y
Signature · 1 line
2.14.4
#2 lore raw

Re: [PATCH 2/2] linux-fslc/defconfig: Add CONFIG_TMPFS_POSIX_ACL=y

Quoted 13 lines · Andreas Müller

Fixes:

| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[220]: Failed to apply ACL on /dev/v4l-subdev0: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[224]: Failed to apply ACL on /dev/v4l-subdev1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[215]: Failed to apply ACL on /dev/v4l-subdev10: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[228]: Failed to apply ACL on /dev/v4l-subdev2: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[232]: Failed to apply ACL on /dev/v4l-subdev5: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[217]: Failed to apply ACL on /dev/v4l-subdev11: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[214]: Failed to apply ACL on /dev/dri/card1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[216]: Failed to apply ACL on /dev/v4l-subdev8: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[226]: Failed to apply ACL on /dev/v4l-subdev9: Operation not supported
Quoted 7 lines

and nasty follow-ups: Starting weston from sddm as unpriviledged user fails with some hints on missing access rights.

For a better understanding CONFIG_TMPFS=y was added which was set indirectly by CONFIG_DEVTMPFS=y

I applied this to master. Could you send this as a change to our imx_v6_v7_defconfig ? it would be good to send it upstream as well so we avoid keeping this change for next releases.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#3 lore raw

Re: [PATCH 2/2] linux-fslc/defconfig: Add CONFIG_TMPFS_POSIX_ACL=y

Quoted 17 lines · Otavio Salvador
Quoted 16 lines · Andreas Müller

Fixes:

| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[220]: Failed to apply ACL on /dev/v4l-subdev0: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[224]: Failed to apply ACL on /dev/v4l-subdev1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[215]: Failed to apply ACL on /dev/v4l-subdev10: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[228]: Failed to apply ACL on /dev/v4l-subdev2: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[232]: Failed to apply ACL on /dev/v4l-subdev5: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[217]: Failed to apply ACL on /dev/v4l-subdev11: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[214]: Failed to apply ACL on /dev/dri/card1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[216]: Failed to apply ACL on /dev/v4l-subdev8: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[226]: Failed to apply ACL on /dev/v4l-subdev9: Operation not supported

and nasty follow-ups: Starting weston from sddm as unpriviledged user fails with some hints on missing access rights.

Quoted 9 lines
Quoted 4 lines

For a better understanding CONFIG_TMPFS=y was added which was set indirectly by CONFIG_DEVTMPFS=y

I applied this to master. Could you send this as a change to our imx_v6_v7_defconfig ? it would be good to send it upstream as well so we avoid keeping this change for next releases.

Done

Just checked: Copying imx_v6_v7_defconfig to our defconfig fives the following diff:

(quoted diff) +0 -0

b/recipes-kernel/linux/linux-fslc/defconfig
index 84d59fc4..8bee1f96 100644

recipes-kernel/linux/linux-fslc/defconfig +4 -1
@@ -158,6 +158,7 @@ CONFIG_WL18XX=m
 CONFIG_WLCORE_SDIO=m
 # CONFIG_WILINK_PLATFORM_DATA is not set
 CONFIG_INPUT_EVDEV=y
+CONFIG_INPUT_EVBUG=m
 CONFIG_KEYBOARD_GPIO=y
 CONFIG_KEYBOARD_SNVS_PWRKEY=y
 CONFIG_KEYBOARD_IMX=y
@@ -293,6 +294,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y
 CONFIG_USB_SERIAL=m
 CONFIG_USB_SERIAL_GENERIC=y
 CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -329,6 +331,7 @@ CONFIG_USB_GADGETFS=m
 CONFIG_USB_FUNCTIONFS=m
 CONFIG_USB_MASS_STORAGE=m
 CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_PLTFM=y
@@ -414,7 +417,7 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_SCHED_DEBUG is not set
 CONFIG_PROVE_LOCKING=y
 # CONFIG_DEBUG_BUGVERBOSE is not set
-CONFIG_FUNCTION_TRACER=y
+# CONFIG_FTRACE is not set
 # CONFIG_ARM_UNWIND is not set
 CONFIG_SECURITYFS=y
 CONFIG_CRYPTO_DEV_FSL_CAAM=y

Shouldn't we swap to use imx_v6_v7_defconfig shipped?

Andreas

#4 lore raw

Re: [PATCH 2/2] linux-fslc/defconfig: Add CONFIG_TMPFS_POSIX_ACL=y

Quoted 39 lines · Andreas Müller
Quoted 17 lines · Otavio Salvador
Quoted 16 lines · Andreas Müller

Fixes:

| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[220]: Failed to apply ACL on /dev/v4l-subdev0: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[224]: Failed to apply ACL on /dev/v4l-subdev1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[215]: Failed to apply ACL on /dev/v4l-subdev10: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[228]: Failed to apply ACL on /dev/v4l-subdev2: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[232]: Failed to apply ACL on /dev/v4l-subdev5: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[217]: Failed to apply ACL on /dev/v4l-subdev11: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[214]: Failed to apply ACL on /dev/dri/card1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[216]: Failed to apply ACL on /dev/v4l-subdev8: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[226]: Failed to apply ACL on /dev/v4l-subdev9: Operation not supported

and nasty follow-ups: Starting weston from sddm as unpriviledged user fails with some hints on missing access rights.

Quoted 9 lines
Quoted 4 lines

For a better understanding CONFIG_TMPFS=y was added which was set indirectly by CONFIG_DEVTMPFS=y

I applied this to master. Could you send this as a change to our imx_v6_v7_defconfig ? it would be good to send it upstream as well so we avoid keeping this change for next releases.

Done

Just checked: Copying imx_v6_v7_defconfig to our defconfig fives the following diff:

recipes-kernel/linux/linux-fslc/defconfig +0 -0
index 84d59fc4..8bee1f96 100644

recipes-kernel/linux/linux-fslc/defconfig CONFIG_WL18XX=m · line 161

Quoted 4 lines
recipes-kernel/linux/linux-fslc/defconfig +1 -0
@@ -158,6 +158,7 @@ CONFIG_WL18XX=m
 CONFIG_WLCORE_SDIO=m
 # CONFIG_WILINK_PLATFORM_DATA is not set
 CONFIG_INPUT_EVDEV=y
+CONFIG_INPUT_EVBUG=m

^ That is not the best idea for productive environment - it floods journal

Quoted 20 lines
recipes-kernel/linux/linux-fslc/defconfig +2 -0
 CONFIG_KEYBOARD_GPIO=y
 CONFIG_KEYBOARD_SNVS_PWRKEY=y
 CONFIG_KEYBOARD_IMX=y
@@ -293,6 +294,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y
 CONFIG_USB_SERIAL=m
 CONFIG_USB_SERIAL_GENERIC=y
 CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -329,6 +331,7 @@ CONFIG_USB_GADGETFS=m
 CONFIG_USB_FUNCTIONFS=m
 CONFIG_USB_MASS_STORAGE=m
 CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_PLTFM=y

recipes-kernel/linux/linux-fslc/defconfig CONFIG_MAGIC_SYSRQ=y · line 417

Quoted 4 lines
recipes-kernel/linux/linux-fslc/defconfig +0 -1
@@ -414,7 +417,7 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_SCHED_DEBUG is not set
 CONFIG_PROVE_LOCKING=y
 # CONFIG_DEBUG_BUGVERBOSE is not set
-CONFIG_FUNCTION_TRACER=y

^ That should be kept

Quoted 9 lines
recipes-kernel/linux/linux-fslc/defconfig +1 -0
+# CONFIG_FTRACE is not set
 # CONFIG_ARM_UNWIND is not set
 CONFIG_SECURITYFS=y
 CONFIG_CRYPTO_DEV_FSL_CAAM=y

Shouldn't we swap to use imx_v6_v7_defconfig shipped?

Andreas

Suggestion: Since I have further issues with this kernel (seems not a single firmware is loaded) - so I continue debug. As soon as I think there is a better config I will

1. Send it to linux-fslc / imx_v6_v7_defconfig
2. Send a patch here to use imx_v6_v7_defconfig

OK?

Andreas

#5 lore raw

Re: [PATCH 2/2] linux-fslc/defconfig: Add CONFIG_TMPFS_POSIX_ACL=y

On Thu, Sep 6, 2018 at 9:10 AM Andreas Müller <[email protected]> wrote:
...

Quoted 8 lines

Suggestion: Since I have further issues with this kernel (seems not a single firmware is loaded) - so I continue debug. As soon as I think there is a better config I will

1. Send it to linux-fslc / imx_v6_v7_defconfig
2. Send a patch here to use imx_v6_v7_defconfig

OK?

Please do. But let's use the defconfig in the layer as it makes easier for users to customize it.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#6 lore raw

Re: [PATCH 2/2] linux-fslc/defconfig: Add CONFIG_TMPFS_POSIX_ACL=y

In reply to Andreas Müller
Quoted 40 lines · Andreas Müller
Quoted 17 lines · Otavio Salvador
Quoted 16 lines · Andreas Müller

Fixes:

| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[220]: Failed to apply ACL on /dev/v4l-subdev0: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[224]: Failed to apply ACL on /dev/v4l-subdev1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[215]: Failed to apply ACL on /dev/v4l-subdev10: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[228]: Failed to apply ACL on /dev/v4l-subdev2: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[232]: Failed to apply ACL on /dev/v4l-subdev5: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[217]: Failed to apply ACL on /dev/v4l-subdev11: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[214]: Failed to apply ACL on /dev/dri/card1: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[216]: Failed to apply ACL on /dev/v4l-subdev8: Operation not supported
| Sep 04 09:05:10 imx6qdl-variscite-som systemd-udevd[226]: Failed to apply ACL on /dev/v4l-subdev9: Operation not supported

and nasty follow-ups: Starting weston from sddm as unpriviledged user fails with some hints on missing access rights.

Quoted 9 lines
Quoted 4 lines

For a better understanding CONFIG_TMPFS=y was added which was set indirectly by CONFIG_DEVTMPFS=y

I applied this to master. Could you send this as a change to our imx_v6_v7_defconfig ? it would be good to send it upstream as well so we avoid keeping this change for next releases.

Done

Just checked: Copying imx_v6_v7_defconfig to our defconfig fives the following diff:

recipes-kernel/linux/linux-fslc/defconfig +0 -0
index 84d59fc4..8bee1f96 100644

recipes-kernel/linux/linux-fslc/defconfig CONFIG_WL18XX=m · line 161

Quoted 4 lines
recipes-kernel/linux/linux-fslc/defconfig +1 -0
@@ -158,6 +158,7 @@ CONFIG_WL18XX=m
 CONFIG_WLCORE_SDIO=m
 # CONFIG_WILINK_PLATFORM_DATA is not set
 CONFIG_INPUT_EVDEV=y
+CONFIG_INPUT_EVBUG=m

This is not nice to have loaded automatically; it is very verbose.

recipes-kernel/linux/linux-fslc/defconfig CONFIG_USB_STORAGE=y · line 297

Quoted 8 lines
recipes-kernel/linux/linux-fslc/defconfig +1 -0
 CONFIG_KEYBOARD_GPIO=y
 CONFIG_KEYBOARD_SNVS_PWRKEY=y
 CONFIG_KEYBOARD_IMX=y
@@ -293,6 +294,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y

Fine. Add it to our defconfig.

recipes-kernel/linux/linux-fslc/defconfig CONFIG_USB_GADGETFS=m · line 334

Quoted 8 lines
recipes-kernel/linux/linux-fslc/defconfig +1 -0
 CONFIG_USB_SERIAL=m
 CONFIG_USB_SERIAL_GENERIC=y
 CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -329,6 +331,7 @@ CONFIG_USB_GADGETFS=m
 CONFIG_USB_FUNCTIONFS=m
 CONFIG_USB_MASS_STORAGE=m
 CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y

Fine. Add it to our defconfig.

recipes-kernel/linux/linux-fslc/defconfig CONFIG_MAGIC_SYSRQ=y · line 420

Quoted 9 lines
recipes-kernel/linux/linux-fslc/defconfig +1 -1
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_PLTFM=y
@@ -414,7 +417,7 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_SCHED_DEBUG is not set
 CONFIG_PROVE_LOCKING=y
 # CONFIG_DEBUG_BUGVERBOSE is not set
-CONFIG_FUNCTION_TRACER=y
+# CONFIG_FTRACE is not set

We need this to lttng to work.

Quoted 6 lines
recipes-kernel/linux/linux-fslc/defconfig +0 -0
 # CONFIG_ARM_UNWIND is not set
 CONFIG_SECURITYFS=y
 CONFIG_CRYPTO_DEV_FSL_CAAM=y

Shouldn't we swap to use imx_v6_v7_defconfig shipped?

We can make more commits to it to simplify the sync.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
#7 lore raw

Re: [PATCH 2/2] linux-fslc/defconfig: Add CONFIG_TMPFS_POSIX_ACL=y

Hi Otavio,
.

Quoted 11 lines · Otavio Salvador

recipes-kernel/linux/linux-fslc/defconfig CONFIG_USB_STORAGE=y · line 297

Quoted 8 lines

CONFIG_KEYBOARD_GPIO=y
CONFIG_KEYBOARD_SNVS_PWRKEY=y
CONFIG_KEYBOARD_IMX=y

recipes-kernel/linux/linux-fslc/defconfig +1 -0
@@ -293,6 +294,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y

Fine. Add it to our defconfig.

Quoted 10 lines

recipes-kernel/linux/linux-fslc/defconfig CONFIG_USB_GADGETFS=m · line 334

Quoted 8 lines
recipes-kernel/linux/linux-fslc/defconfig +1 -0
 CONFIG_USB_SERIAL=m
 CONFIG_USB_SERIAL_GENERIC=y
 CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -329,6 +331,7 @@ CONFIG_USB_GADGETFS=m
 CONFIG_USB_FUNCTIONFS=m
 CONFIG_USB_MASS_STORAGE=m
 CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y

Fine. Add it to our defconfig.

Please don't add these two options.

These options ended up in 4.17 linux-stable tree by mistake.

i sent a revert for this change in the linux-stable tree as it causes a reboot regression on mx6 wandboard.