EDAC, sb_edac: Early return on ADDRV bit and address type test
Borislav Petkov
maintainerPATCH 2/3 EDAC, sb_edac: Early return on ADDRV bit and address type test
Quoted 7 lines · Tony Luck
From: Qiuxu Zhuo <[email protected]>
Current EDAC driver only decodes valid memory physical addresses. So move the test for bit 58(ADDRV) into
sbridge_mce_check_error(), and add a test that the address is the right type (looking as MISC bits{8:6}). Get rid of the duplicated test whether it's a memory controller error insbridge_mce_output_error().
So I had to go and look at the code what exactly this patch is fixing.
Above you are explaining *what* this patch changes in the commit message whereas you should be explaining *why* it is being changed. The *what* is visible from the diff below.
In general, when writing a commit message, try to structure it somewhat like this:
Problem is A.
It happens because of B.
Fix it by doing C.
(Potentially do D).
For more detailed info, see Documentation/process/submitting-patches.rst, Section "2) Describe your changes".
Thx.