Skip to contentSkip to conversation

x86: extend baudrate table with 57600

PATCH New Christian Gmeiner 3 participants 9 messages Jun 6, 2017 – Sep 6, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +1 -1
index b5ef8b5..9a97714 100644
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE	{300, 600, 1200, 2400, 4800, \
-					 9600, 19200, 38400, 115200}
+					 9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
 #define CONFIG_CMDLINE_EDITING
Signature · 1 line
2.9.4
#1 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

Quoted 10 lines · Christian Gmeiner
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +0 -0
index b5ef8b5..9a97714 100644

include/configs/x86-common.h line 62

Quoted 8 lines
include/configs/x86-common.h +1 -1
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE	{300, 600, 1200, 2400, 4800, \
-					 9600, 19200, 38400, 115200}
+					 9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
 #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170606/3536ec56/attachment.sig>
#2 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

Hi Tom

2017-06-06 22:04 GMT+02:00 Tom Rini <[email protected]>:

Quoted 19 lines · Christian Gmeiner
Quoted 18 lines
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +1 -1
index b5ef8b5..9a97714 100644
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
-                                      9600, 19200, 38400, 115200}
+                                      9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
Quoted 4 lines

include/configs/x86-common.h line 62

Quoted 1 line
include/configs/x86-common.h +0 -0
 #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead? Thanks!

Can you point me to the "fall back table"?

thanks
--
Christian Gmeiner, MSc

https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner

#3 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

Quoted 22 lines · Christian Gmeiner

Hi Tom

2017-06-06 22:04 GMT+02:00 Tom Rini <[email protected]>:

Quoted 19 lines · Christian Gmeiner
Quoted 18 lines
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +1 -1
index b5ef8b5..9a97714 100644
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
-                                      9600, 19200, 38400, 115200}
+                                      9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
Quoted 5 lines
Quoted 3 lines

include/configs/x86-common.h line 62

Quoted 1 line
include/configs/x86-common.h +0 -0
 #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead? Thanks!

Can you point me to the "fall back table"?

If one isn't defined the one in <config_fallbacks.h> is used.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170608/646a82a8/attachment.sig>
#4 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

Hi Christian,

Quoted 23 lines · Tom Rini
Quoted 22 lines · Christian Gmeiner

Hi Tom

2017-06-06 22:04 GMT+02:00 Tom Rini <[email protected]>:

Quoted 19 lines · Christian Gmeiner
Quoted 18 lines
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +1 -1
index b5ef8b5..9a97714 100644
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
-                                      9600, 19200, 38400, 115200}
+                                      9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

include/configs/x86-common.h line 62

Quoted 1 line
include/configs/x86-common.h +0 -0
 #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead? Thanks!

Can you point me to the "fall back table"?

If one isn't defined the one in <config_fallbacks.h> is used.

Can you respin the patch per Tom's suggestion? Thanks!

Regards,
Bin

#5 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

Hi all,

I totally forgot to answer that mail - but as I need this change my motivation is back.

Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <[email protected]>:

Quoted 35 lines

Hi Christian,

Quoted 30 lines · Tom Rini
Quoted 22 lines · Christian Gmeiner

Hi Tom

2017-06-06 22:04 GMT+02:00 Tom Rini <[email protected]>:

Quoted 19 lines · Christian Gmeiner
Quoted 18 lines
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +1 -1
index b5ef8b5..9a97714 100644
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
-                                      9600, 19200, 38400, 115200}
+                                      9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
Quoted 5 lines
Quoted 3 lines

include/configs/x86-common.h line 62

Quoted 1 line
include/configs/x86-common.h +0 -0
 #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead? Thanks!

Can you point me to the "fall back table"?

If one isn't defined the one in <config_fallbacks.h> is used.

The fallback table looks okay and has 57600 as baud rate in it. The problematic part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and as a result the fallback table plays no role here.

Quoted 1 line

Can you respin the patch per Tom's suggestion? Thanks!

I think that the current patch is okay as Tom's suggestion does not fly.

Signature · 5 lines
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info
#6 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

Hi Christian,

Quoted 43 lines · Christian Gmeiner

Hi all,

I totally forgot to answer that mail - but as I need this change my motivation is back.

Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <[email protected]>:

Quoted 35 lines

Hi Christian,

Quoted 30 lines · Tom Rini
Quoted 22 lines · Christian Gmeiner

Hi Tom

2017-06-06 22:04 GMT+02:00 Tom Rini <[email protected]>:

Quoted 19 lines · Christian Gmeiner
Quoted 18 lines
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +1 -1
index b5ef8b5..9a97714 100644
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
-                                      9600, 19200, 38400, 115200}
+                                      9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
Quoted 5 lines
Quoted 3 lines

include/configs/x86-common.h line 62

Quoted 1 line
include/configs/x86-common.h +0 -0
 #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead? Thanks!

Can you point me to the "fall back table"?

If one isn't defined the one in <config_fallbacks.h> is used.

Quoted 8 lines

The fallback table looks okay and has 57600 as baud rate in it. The problematic part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and as a result the fallback table plays no role here.

Quoted 1 line

Can you respin the patch per Tom's suggestion? Thanks!

I think that the current patch is okay as Tom's suggestion does not fly.

I believe what Tom asked was to update config_fallbacks.h directly, and then no need to keep x86-specific one.

Regards,
Bin

#7 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

Quoted 51 lines · Bin Meng

Hi Christian,

Quoted 47 lines · Christian Gmeiner

Hi all,

I totally forgot to answer that mail - but as I need this change my motivation is back.

Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <[email protected]>:

Quoted 35 lines

Hi Christian,

Quoted 30 lines · Tom Rini
Quoted 22 lines · Christian Gmeiner

Hi Tom

2017-06-06 22:04 GMT+02:00 Tom Rini <[email protected]>:

Quoted 19 lines · Christian Gmeiner
Quoted 18 lines
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +1 -1
index b5ef8b5..9a97714 100644
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
-                                      9600, 19200, 38400, 115200}
+                                      9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
Quoted 5 lines
Quoted 3 lines

include/configs/x86-common.h line 62

Quoted 1 line
include/configs/x86-common.h +0 -0
 #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead? Thanks!

Can you point me to the "fall back table"?

If one isn't defined the one in <config_fallbacks.h> is used.

The fallback table looks okay and has 57600 as baud rate in it. The problematic part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and as a result the fallback table plays no role here.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Can you respin the patch per Tom's suggestion? Thanks!

I think that the current patch is okay as Tom's suggestion does not fly.

I believe what Tom asked was to update config_fallbacks.h directly, and then no need to keep x86-specific one.

To be extra clear, drop the table from the x86 file and then the default will be used.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180905/cc40ac9c/attachment.sig>
#8 lore raw

PATCH 1/1 x86: extend baudrate table with 57600

Am Mi., 5. Sep. 2018 um 17:10 Uhr schrieb Tom Rini <[email protected]>:

Quoted 55 lines · Bin Meng
Quoted 53 lines

Hi Christian,

Quoted 49 lines · Christian Gmeiner

Hi all,

I totally forgot to answer that mail - but as I need this change my motivation is back.

Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <[email protected]>:

Quoted 35 lines

Hi Christian,

Quoted 30 lines · Tom Rini
Quoted 22 lines · Christian Gmeiner

Hi Tom

2017-06-06 22:04 GMT+02:00 Tom Rini <[email protected]>:

Quoted 19 lines · Christian Gmeiner
Quoted 18 lines
---
 include/configs/x86-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/x86-common.h +1 -1
index b5ef8b5..9a97714 100644
@@ -56,7 +56,7 @@
  * Serial Configuration
  */
 #define CONFIG_SYS_BAUDRATE_TABLE    {300, 600, 1200, 2400, 4800, \
-                                      9600, 19200, 38400, 115200}
+                                      9600, 19200, 38400, 57600, 115200}
 #define CONFIG_SYS_NS16550_PORT_MAPPED
 
Quoted 5 lines
Quoted 3 lines

include/configs/x86-common.h line 62

Quoted 1 line
include/configs/x86-common.h +0 -0
 #define CONFIG_CMDLINE_EDITING

Can we just use the fall back table instead? Thanks!

Can you point me to the "fall back table"?

If one isn't defined the one in <config_fallbacks.h> is used.

The fallback table looks okay and has 57600 as baud rate in it. The problematic part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and as a result the fallback table plays no role here.

Quoted 1 line

Can you respin the patch per Tom's suggestion? Thanks!

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

I think that the current patch is okay as Tom's suggestion does not fly.

I believe what Tom asked was to update config_fallbacks.h directly, and then no need to keep x86-specific one.

To be extra clear, drop the table from the x86 file and then the default will be used.

Got it - thanks...

Signature · 5 lines
greets
--
Christian Gmeiner, MSc

https://christian-gmeiner.info