drm/rockchip: rgb: add stub functions when rgb encoder is disabled
Subsystems (4)
Heiko Stuebner
maintainerPATCH 1/1 drm/rockchip: rgb: add stub functions when rgb encoder is disabled
The newly added internal rgb encoder for Rockchip vops is missing stubs for the case that the rgb output part is not enabled in the kernel config. So add these.
Fixes 1f0f01515172 ("drm/rockchip: Add support for Rockchip Soc RGB output interface")
Signed-off-by Heiko Stuebner <[email protected]>
--- drivers/gpu/drm/rockchip/rockchip_rgb.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/gpu/drm/rockchip/rockchip_rgb.h +14 -0
@@ -14,7 +14,21 @@* GNU General Public License for more details. */ +#ifdef CONFIG_ROCKCHIP_RGB struct rockchip_rgb *rockchip_rgb_init (struct device *dev,struct drm_crtc *crtc,struct drm_device *drm_dev);void rockchip_rgb_fini (struct rockchip_rgb *rgb); +#else +static inline struct rockchip_rgb *rockchip_rgb_init (struct device *dev, +struct drm_crtc *crtc, +struct drm_device *drm_dev) +{ +return NULL ; +} + +static inline void rockchip_rgb_fini (struct rockchip_rgb *rgb) +{ +return ; +} +#endif
Signature · 6 lines
2.17.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 24 lines · Heiko Stuebner
The newly added internal rgb encoder for Rockchip vops is missing stubs for the case that the rgb output part is not enabled in the kernel config. So add these.
Fixes 1f0f01515172 ("drm/rockchip: Add support for Rockchip Soc RGB output interface")Signed-off-by Heiko Stuebner <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_rgb.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)drivers/gpu/drm/rockchip/rockchip_rgb.h +2
-0@@ -14,7 +14,21 @@* GNU General Public License for more details. */ +#ifdef CONFIG_ROCKCHIP_RGB struct rockchip_rgb *rockchip_rgb_init (struct device *dev,struct drm_crtc *crtc,struct drm_device *drm_dev);void rockchip_rgb_fini (struct rockchip_rgb *rgb); +#else
drivers/gpu/drm/rockchip/rockchip_rgb.h line 32
Quoted 10 lines
drivers/gpu/drm/rockchip/rockchip_rgb.h +10
-0+static inline struct rockchip_rgb *rockchip_rgb_init (struct device *dev, +struct drm_crtc *crtc, +struct drm_device *drm_dev) +{ +return NULL ; +} + +static inline void rockchip_rgb_fini (struct rockchip_rgb *rgb) +{ +return ;
This return is redundant. With that nit fixed, feel free to commit with
Reviewed-by Sean Paul <[email protected]>
Quoted 9 lines
drivers/gpu/drm/rockchip/rockchip_rgb.h +2
-0+} +#endif Signature · 6 lines
2.17.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 38 lines · Sean Paul
Quoted 24 lines · Heiko Stuebner
The newly added internal rgb encoder for Rockchip vops is missing stubs for the case that the rgb output part is not enabled in the kernel config. So add these.
Fixes 1f0f01515172 ("drm/rockchip: Add support for Rockchip Soc RGB output interface")Signed-off-by Heiko Stuebner <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_rgb.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+)drivers/gpu/drm/rockchip/rockchip_rgb.h +2
-0@@ -14,7 +14,21 @@* GNU General Public License for more details. */ +#ifdef CONFIG_ROCKCHIP_RGB struct rockchip_rgb *rockchip_rgb_init (struct device *dev,struct drm_crtc *crtc,struct drm_device *drm_dev);void rockchip_rgb_fini (struct rockchip_rgb *rgb); +#else drivers/gpu/drm/rockchip/rockchip_rgb.h line 32
Quoted 10 lines
drivers/gpu/drm/rockchip/rockchip_rgb.h +10
-0+static inline struct rockchip_rgb *rockchip_rgb_init (struct device *dev, +struct drm_crtc *crtc, +struct drm_device *drm_dev) +{ +return NULL ; +} + +static inline void rockchip_rgb_fini (struct rockchip_rgb *rgb) +{ +return ;This return is redundant. With that nit fixed, feel free to commit with
Quoted 1 line
Reviewed-by Sean Paul <[email protected]>
I went ahead and applied this myself since I'm prepping a pull request.
Thanks for the quick fix.
Sean
Quoted 14 lines
Quoted 11 lines
drivers/gpu/drm/rockchip/rockchip_rgb.h +2
-0+} +#endif Signature · 6 lines
2.17.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 1 line
Sean Paul, Software Engineer, Google / Chromium OS
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel