Skip to contentSkip to conversation

Devicetree build consolidation

PATCH Superseded Rob Herring 5 participants 21 messages Sep 5, 2018 – Sep 12, 2018

Subsystems (10)
Device tree bindings Arm (32-bit) PowerPC Kbuild +6 more subsystems

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

v2 cover Devicetree build consolidation

This series addresses a couple of issues I have with building dts files.

First, the ability to build all the dts files in the tree. This has been supported on most arches for some time with powerpc being the main exception. The reason powerpc wasn't supported was it needed a change in the location built dtb files are put.

Secondly, it's a pain to acquire all the cross-compilers needed to build dtbs for each arch. There's no reason to build with the cross compiler and the host compiler is perfectly fine as we only need the pre-processor.

I started addressing just those 2 problems, but kept finding small differences such as target dependencies and dtbs_install support across architectures. Instead of trying to align all these, I've consolidated the build targets moving them out of the arch makefiles.

I'd like to take the series via the DT tree.

Rob

v2:
- Fix $arch/boot/dts path check for out of tree builds
- Fix dtc dependency for building built-in dtbs
- Fix microblaze built-in dtb building
- Add dtbs target for microblaze

Rob Herring (9):
powerpc: build .dtb files in dts directory
nios2: build .dtb files in dts directory
nios2: use common rules to build built-in dtb
nios2: fix building all dtbs
c6x: use common built-in dtb support
kbuild: consolidate Devicetree dtb build rules
powerpc: enable building all dtbs
c6x: enable building all dtbs
microblaze: enable building all dtbs

 Makefile                           | 32 +++++++++++++++++++
 arch/arc/Makefile                  |  6 ----
 arch/arm/Makefile                  | 20 +-----------
 arch/arm64/Makefile                | 17 +----------
 arch/c6x/Makefile                  |  2 --
 arch/c6x/boot/dts/Makefile         | 17 +++++------
 arch/c6x/boot/dts/linked_dtb.S     |  2 --
 arch/c6x/include/asm/sections.h    |  1 -
 arch/c6x/kernel/setup.c            |  4 +--
 arch/c6x/kernel/vmlinux.lds.S      | 10 ------
 arch/h8300/Makefile                | 11 +------
 arch/microblaze/Makefile           |  4 +--
 arch/microblaze/boot/dts/Makefile  |  4 +++
 arch/mips/Makefile                 | 15 +--------
 arch/nds32/Makefile                |  2 +-
 arch/nios2/Makefile                | 11 +------
 arch/nios2/boot/Makefile           | 22 --------------
 arch/nios2/boot/dts/Makefile       |  6 ++++
 arch/nios2/boot/linked_dtb.S       | 19 ------------
 arch/powerpc/Makefile              |  3 --
 arch/powerpc/boot/Makefile         | 49 ++++++++++++++----------------
 arch/powerpc/boot/dts/Makefile     |  6 ++++
 arch/powerpc/boot/dts/fsl/Makefile |  4 +++
 arch/xtensa/Makefile               | 12 +-------
 scripts/Makefile.lib               |  2 +-
 25 files changed, 93 insertions(+), 188 deletions(-)
 delete mode 100644 arch/c6x/boot/dts/linked_dtb.S
 create mode 100644 arch/nios2/boot/dts/Makefile
 delete mode 100644 arch/nios2/boot/linked_dtb.S
 create mode 100644 arch/powerpc/boot/dts/Makefile
 create mode 100644 arch/powerpc/boot/dts/fsl/Makefile

--
2.17.1

author maintainer
#1 lore raw

PATCH v2 1/9 powerpc: build .dtb files in dts directory

Align powerpc with other architectures which build the dtb files in the same directory as the dts files. This is also in line with most other build targets which are located in the same directory as the source. This move will help enable the 'dtbs' target which builds all the dtbs regardless of kernel config.

This transition could break some scripts if they expect dtb files in the old location.

Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/powerpc/Makefile          |  2 +-
 arch/powerpc/boot/Makefile     | 49 ++++++++++++++++------------------
 arch/powerpc/boot/dts/Makefile |  1 +
 3 files changed, 25 insertions(+), 27 deletions(-)
 create mode 100644 arch/powerpc/boot/dts/Makefile
arch/powerpc/Makefile +1 -1
index 11a1acba164a..53ea887eb34e 100644
@@ -294,7 +294,7 @@ bootwrapper_install:
 	$(Q)$(MAKE) $(build)=$(boot) $(patsubst %,$(boot)/%,$@)
 
 %.dtb: scripts
-	$(Q)$(MAKE) $(build)=$(boot) $(patsubst %,$(boot)/%,$@)
+	$(Q)$(MAKE) $(build)=$(boot)/dts $(patsubst %,$(boot)/dts/%,$@)
 
 # Used to create 'merged defconfigs'
 # To use it $(call) it with the first argument as the base defconfig
arch/powerpc/boot/Makefile +23 -26

70 lines not on this page · raw message

arch/powerpc/boot/dts/Makefile new file +1 -0
new file mode 100644
index 000000000000..f66554cd5c45
@@ -0,0 +1 @@
+# SPDX-License-Identifier: GPL-2.0

--
2.17.1

author maintainer
#2 lore raw

PATCH v2 2/9 nios2: build .dtb files in dts directory

In reply to Rob Herring

Align nios2 with other architectures which build the dtb files in the same directory as the dts files. This is also in line with most other build targets which are located in the same directory as the source. This move will help enable the 'dtbs' target which builds all the dtbs regardless of kernel config.

This transition could break some scripts if they expect dtb files in the old location.

Cc Ley Foon Tan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/nios2/Makefile          | 4 ++--
 arch/nios2/boot/Makefile     | 4 ----
 arch/nios2/boot/dts/Makefile | 1 +
 3 files changed, 3 insertions(+), 6 deletions(-)
 create mode 100644 arch/nios2/boot/dts/Makefile
arch/nios2/Makefile +2 -2
index 8673a79dca9c..50eece1c6adb 100644
@@ -59,10 +59,10 @@ archclean:
 	$(Q)$(MAKE) $(clean)=$(nios2-boot)
 
 %.dtb: | scripts
-	$(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
+	$(Q)$(MAKE) $(build)=$(nios2-boot)/dts $(nios2-boot)/dts/$@
 
 dtbs:
-	$(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
+	$(Q)$(MAKE) $(build)=$(nios2-boot)/dts
 
 $(BOOT_TARGETS): vmlinux
 	$(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
arch/nios2/boot/Makefile +0 -4
index 2ba23a679732..007586094dde 100644
@@ -47,10 +47,6 @@ obj-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) += linked_dtb.o
 
 targets += $(dtb-y)
 
-# Rule to build device tree blobs with make command
-$(obj)/%.dtb: $(src)/dts/%.dts FORCE
-	$(call if_changed_dep,dtc)
-
 $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
 
 install:
arch/nios2/boot/dts/Makefile new file +1 -0
new file mode 100644
index 000000000000..f66554cd5c45
@@ -0,0 +1 @@
+# SPDX-License-Identifier: GPL-2.0

--
2.17.1

#3 lore raw

Re: [PATCH v2 2/9] nios2: build .dtb files in dts directory

Quoted 64 lines · Rob Herring

Align nios2 with other architectures which build the dtb files in the same directory as the dts files. This is also in line with most other build targets which are located in the same directory as the source. This move will help enable the 'dtbs' target which builds all the dtbs
regardless of kernel config.

This transition could break some scripts if they expect dtb files in the old location.

Cc Ley Foon Tan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/nios2/Makefile          | 4 ++--
 arch/nios2/boot/Makefile     | 4 ----
 arch/nios2/boot/dts/Makefile | 1 +

 3 files changed, 3 insertions(+), 6 deletions(-)

 create mode 100644 arch/nios2/boot/dts/Makefile

arch/nios2/Makefile +0 -0
index 8673a79dca9c..50eece1c6adb 100644
@@ -59,10 +59,10 @@ archclean:
         $(Q)$(MAKE) $(clean)=$(nios2-boot)

 %.dtb: | scripts
-       $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@ +       $(Q)$(MAKE) $(build)=$(nios2-boot)/dts $(nios2-boot)/dts/$@

 dtbs:
-       $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@ +       $(Q)$(MAKE) $(build)=$(nios2-boot)/dts

 $(BOOT_TARGETS): vmlinux
        $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@

arch/nios2/boot/Makefile +0 -0
index 2ba23a679732..007586094dde 100644
@@ -47,10 +47,6 @@ obj-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) +=

linked_dtb.o

 targets += $(dtb-y)

arch/nios2/boot/Makefile +0 -4
-# Rule to build device tree blobs with make command
-$(obj)/%.dtb: $(src)/dts/%.dts FORCE
-       $(call if_changed_dep,dtc)
-

 $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))

 install:

arch/nios2/boot/dts/Makefile new file +1 -1
new file mode 100644
index 000000000000..f66554cd5c45
@@ -0,0 +1 @@
+# SPDX-License-Identifier: GPL-2.0
--
Quoted 2 lines

2.17.1

Hi Rob

I have synced your all-dtbs branch from here: https://git.kernel.org/pu
b/scm/linux/kernel/git/robh/linux.git/log/?h=all-dtbs

It shows error when compile kernel image and also when "make dtbs_install".

make dtbs_install
make[1]: *** No rule to make target 'arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dtb', needed by 'arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dtb.S'.  Stop. Makefile:1229: recipe for target 'dtbs' failed
make: *** [dtbs] Error 2

Regards
Ley Foon

author maintainer
#4 lore raw

Re: [PATCH v2 2/9] nios2: build .dtb files in dts directory

Quoted 70 lines · Ley Foon Tan
Quoted 64 lines · Rob Herring

Align nios2 with other architectures which build the dtb files in the same directory as the dts files. This is also in line with most other build targets which are located in the same directory as the source. This move will help enable the 'dtbs' target which builds all the dtbs
regardless of kernel config.

This transition could break some scripts if they expect dtb files in the old location.

Cc Ley Foon Tan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/nios2/Makefile          | 4 ++--
 arch/nios2/boot/Makefile     | 4 ----
 arch/nios2/boot/dts/Makefile | 1 +
 3 files changed, 3 insertions(+), 6 deletions(-)
 create mode 100644 arch/nios2/boot/dts/Makefile
arch/nios2/Makefile +2 -2
index 8673a79dca9c..50eece1c6adb 100644
@@ -59,10 +59,10 @@ archclean:
        $(Q)$(MAKE) $(clean)=$(nios2-boot)
 
 %.dtb: | scripts
-       $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
+       $(Q)$(MAKE) $(build)=$(nios2-boot)/dts $(nios2-boot)/dts/$@
 
 dtbs:
-       $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
+       $(Q)$(MAKE) $(build)=$(nios2-boot)/dts
 
 $(BOOT_TARGETS): vmlinux
        $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
arch/nios2/boot/Makefile +0 -0
index 2ba23a679732..007586094dde 100644
@@ -47,10 +47,6 @@ obj-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) +=

linked_dtb.o

targets += $(dtb-y)

arch/nios2/boot/Makefile +0 -4
-# Rule to build device tree blobs with make command
-$(obj)/%.dtb: $(src)/dts/%.dts FORCE
-       $(call if_changed_dep,dtc)
-
 $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
 
 install:
arch/nios2/boot/dts/Makefile new file +1 -1
new file mode 100644
index 000000000000..f66554cd5c45
@@ -0,0 +1 @@
+# SPDX-License-Identifier: GPL-2.0
--
Quoted 2 lines

2.17.1

Hi Rob

Quoted 5 lines

I have synced your all-dtbs branch from here: https://git.kernel.org/pu
b/scm/linux/kernel/git/robh/linux.git/log/?h=all-dtbs

It shows error when compile kernel image and also when "make dtbs_install".

Can you fetch the branch again and try it. I fixed a few dependency issues.

Quoted 4 lines

make dtbs_install
make[1]: *** No rule to make target 'arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dtb', needed by 'arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dtb.S'. Stop.

What is the value of CONFIG_NIOS2_DTB_SOURCE? As patch 3 notes, it now should not have any path.

If that's a problem, I could take the basename to strip the path, but then sub directories wouldn't work either.

BTW, next up, I want to consolidate the config variables for built-in dtbs.

Rob

#5 lore raw

Re: [PATCH v2 2/9] nios2: build .dtb files in dts directory

Quoted 99 lines · Rob Herring
Quoted 77 lines · Ley Foon Tan
Quoted 70 lines · Rob Herring

Align nios2 with other architectures which build the dtb files in the
same directory as the dts files. This is also in line with most other
build targets which are located in the same directory as the source.
This move will help enable the 'dtbs' target which builds all the dtbs
regardless of kernel config.

This transition could break some scripts if they expect dtb files in
the old location.

Cc Ley Foon Tan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/nios2/Makefile          | 4 ++--
 arch/nios2/boot/Makefile     | 4 ----
 arch/nios2/boot/dts/Makefile | 1 +

 3 files changed, 3 insertions(+), 6 deletions(-)

 create mode 100644 arch/nios2/boot/dts/Makefile

arch/nios2/Makefile +0 -0
index 8673a79dca9c..50eece1c6adb 100644
@@ -59,10 +59,10 @@ archclean:
         $(Q)$(MAKE) $(clean)=$(nios2-boot)

 %.dtb: | scripts
-       $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@ +       $(Q)$(MAKE) $(build)=$(nios2-boot)/dts $(nios2- boot)/dts/$@

 dtbs:
-       $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@ +       $(Q)$(MAKE) $(build)=$(nios2-boot)/dts

 $(BOOT_TARGETS): vmlinux
        $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@

arch/nios2/boot/Makefile +0 -0
index 2ba23a679732..007586094dde 100644
@@ -47,10 +47,6 @@ obj-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) +=

linked_dtb.o

 targets += $(dtb-y)

arch/nios2/boot/Makefile +0 -4
-# Rule to build device tree blobs with make command
-$(obj)/%.dtb: $(src)/dts/%.dts FORCE
-       $(call if_changed_dep,dtc)
-

 $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))

 install:

arch/nios2/boot/dts/Makefile new file +1 -1
new file mode 100644
index 000000000000..f66554cd5c45
@@ -0,0 +1 @@
+# SPDX-License-Identifier: GPL-2.0
--
Quoted 2 lines

2.17.1

Hi Rob

Quoted 6 lines

I have synced your all-dtbs branch from here: https://git.kernel.or
g/pu b/scm/linux/kernel/git/robh/linux.git/log/?h=all-dtbs

It shows error when compile kernel image and also when "make dtbs_install".

Can you fetch the branch again and try it. I fixed a few dependency issues.

Quoted 7 lines

make dtbs_install
make[1]: *** No rule to make target 'arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dtb', needed by 'arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dtb.S'.  St op.

What is the value of CONFIG_NIOS2_DTB_SOURCE? As patch 3 notes, it now
should not have any path.

Quoted 6 lines

If that's a problem, I could take the basename to strip the path, but then sub directories wouldn't work either.

BTW, next up, I want to consolidate the config variables for built-in dtbs.

Hi Rob

CONFIG_NIOS2_DTB_SOURCE has the relative path to dts file, arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dts

Change CONFIG_NIOS2_DTB_SOURCE=10m50_devboard.dtb.S fix the dtb build issue.

Regards
Ley Foon

author maintainer
#6 lore raw

PATCH v2 3/9 nios2: use common rules to build built-in dtb

In reply to Rob Herring

Using the common build support for built-in dtb files just requires adding a .dtb.o target to obj-y.

This has the side effect that CONFIG_NIOS2_DTB_SOURCE should now be just the dts filename in arch/nios2/boot/dts/ directory. Before any path was supported, but if you want to build in your dtb to the kernel, it should be in the kernel tree.

Cc Ley Foon Tan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/nios2/Makefile          |  6 ++----
 arch/nios2/boot/Makefile     | 14 --------------
 arch/nios2/boot/dts/Makefile |  2 ++
 arch/nios2/boot/linked_dtb.S | 19 -------------------
 4 files changed, 4 insertions(+), 37 deletions(-)
 delete mode 100644 arch/nios2/boot/linked_dtb.S
arch/nios2/Makefile +2 -4
index 50eece1c6adb..db2e78fe65c7 100644
@@ -49,16 +49,14 @@ BOOT_TARGETS = vmImage zImage
 PHONY += $(BOOT_TARGETS) install
 KBUILD_IMAGE := $(nios2-boot)/vmImage
 
-ifneq ($(CONFIG_NIOS2_DTB_SOURCE),"")
-	core-y	+= $(nios2-boot)/
-endif
+core-y	+= $(nios2-boot)/dts/
 
 all: vmImage
 
 archclean:
 	$(Q)$(MAKE) $(clean)=$(nios2-boot)
 
-%.dtb: | scripts
+%.dtb %.dtb.S %.dtb.o: | scripts
 	$(Q)$(MAKE) $(build)=$(nios2-boot)/dts $(nios2-boot)/dts/$@
 
 dtbs:
arch/nios2/boot/Makefile +0 -14
index 007586094dde..0b48f1bf086d 100644
@@ -31,20 +31,6 @@ $(obj)/zImage: $(obj)/compressed/vmlinux FORCE
 $(obj)/compressed/vmlinux: $(obj)/vmlinux.gz FORCE
 	$(Q)$(MAKE) $(build)=$(obj)/compressed $@
 
-# Rule to build device tree blobs
-DTB_SRC := $(patsubst "%",%,$(CONFIG_NIOS2_DTB_SOURCE))
-
-# Make sure the generated dtb gets removed during clean
-extra-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) += system.dtb
-
-$(obj)/system.dtb: $(DTB_SRC) FORCE
-	$(call cmd,dtc)
-
-# Ensure system.dtb exists
-$(obj)/linked_dtb.o: $(obj)/system.dtb
-
-obj-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) += linked_dtb.o
-
 targets += $(dtb-y)
 
 $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
arch/nios2/boot/dts/Makefile +2 -0
index f66554cd5c45..f6358e395b25 100644
@@ -1 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
+
+obj-y := $(patsubst "%.dts",%.dtb.o,$(CONFIG_NIOS2_DTB_SOURCE))
arch/nios2/boot/linked_dtb.S deleted +0 -19
deleted file mode 100644
index 071f922db338..000000000000
@@ -1,19 +0,0 @@
-/*
- * Copyright (C) 2011 Thomas Chou <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
- */
-.section .dtb.init.rodata,"a"
-.incbin "arch/nios2/boot/system.dtb"

--
2.17.1

author maintainer
#7 lore raw

PATCH v2 4/9 nios2: fix building all dtbs

In reply to Rob Herring

nios2 has a 'dtbs' target, but nothing is added to 'dtb-*' targets and no dtbs were getting built. This enables building all the dts files in arch/nios2/boot/dts/ when COMPILE_TEST and OF_ALL_DTBS are enabled.

Cc Ley Foon Tan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/nios2/boot/dts/Makefile | 3 +++
 1 file changed, 3 insertions(+)
arch/nios2/boot/dts/Makefile +3 -0
index f6358e395b25..a91a0b09be63 100644
@@ -1,3 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 
 obj-y := $(patsubst "%.dts",%.dtb.o,$(CONFIG_NIOS2_DTB_SOURCE))
+
+dtstree		:= $(srctree)/$(src)
+dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))

--
2.17.1

author maintainer
#8 lore raw

PATCH v2 5/9 c6x: use common built-in dtb support

In reply to Rob Herring

Using the common build support for built-in dtb files just requires adding a .dtb.o target to obj-y.

The dtb now needs to be copied when unflattened because an init section is used now.

Cc Mark Salter <[email protected]>
Cc Aurelien Jacquiot <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/c6x/boot/dts/Makefile      | 11 +----------
 arch/c6x/boot/dts/linked_dtb.S  |  2 --
 arch/c6x/include/asm/sections.h |  1 -
 arch/c6x/kernel/setup.c         |  4 ++--
 arch/c6x/kernel/vmlinux.lds.S   | 10 ----------
 5 files changed, 3 insertions(+), 25 deletions(-)
 delete mode 100644 arch/c6x/boot/dts/linked_dtb.S
arch/c6x/boot/dts/Makefile +1 -10
index b212d278ebc4..fd937f781d16 100644
@@ -6,14 +6,5 @@
 DTC_FLAGS ?= -p 1024
 
 ifneq ($(DTB),)
-obj-y += linked_dtb.o
+obj-y += $(DTB).dtb.o
 endif
-
-quiet_cmd_cp = CP      $< $@$2
-	cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false)
-
-# Generate builtin.dtb from $(DTB).dtb
-$(obj)/builtin.dtb: $(obj)/$(DTB).dtb
-	$(call if_changed,cp)
-
-$(obj)/linked_dtb.o: $(obj)/builtin.dtb
arch/c6x/boot/dts/linked_dtb.S deleted +0 -2
deleted file mode 100644
index cf347f1d16ce..000000000000
@@ -1,2 +0,0 @@
-.section __fdt_blob,"a"
-.incbin "arch/c6x/boot/dts/builtin.dtb"
arch/c6x/include/asm/sections.h +0 -1
index d6c591ab5b7e..dc2f15eb3bde 100644
@@ -8,6 +8,5 @@ extern char _vectors_start[];
 extern char _vectors_end[];
 
 extern char _data_lma[];
-extern char _fdt_start[], _fdt_end[];
 
 #endif /* _ASM_C6X_SECTIONS_H */
arch/c6x/kernel/setup.c +2 -2
index 786e36e2f61d..509c5f086496 100644
@@ -270,7 +270,7 @@ int __init c6x_add_memory(phys_addr_t start, unsigned long size)
 notrace void __init machine_init(unsigned long dt_ptr)
 {
 	void *dtb = __va(dt_ptr);
-	void *fdt = _fdt_start;
+	void *fdt = __dtb_start;
 
 	/* interrupts must be masked */
 	set_creg(IER, 2);

@@ -363,7 +363,7 @@ void __init setup_arch(char **cmdline_p)
 					 memory_end >> PAGE_SHIFT);
 	memblock_reserve(memory_start, bootmap_size);
 
-	unflatten_device_tree();
+	unflatten_and_copy_device_tree();
 
 	c6x_cache_init();
arch/c6x/kernel/vmlinux.lds.S +0 -10
index 1fba5b421eee..584bab2bace6 100644
@@ -90,16 +90,6 @@ SECTIONS
 		*(.switch)
 	}
 
-	. = ALIGN (8) ;
-	__fdt_blob : AT(ADDR(__fdt_blob) - LOAD_OFFSET)
-	{
-		_fdt_start = . ;	/* place for fdt blob */
-		*(__fdt_blob) ;		/* Any link-placed DTB */
-		BYTE(0);		/* section always has contents */
-	        . = _fdt_start + 0x4000;	/* Pad up to 16kbyte */
-		_fdt_end = . ;
-	}
-
 	_etext = .;
 
 	/*

--
2.17.1

author maintainer
#9 lore raw

PATCH v2 6/9 kbuild: consolidate Devicetree dtb build rules

In reply to Rob Herring

There is nothing arch specific about building dtb files other than their location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'. These pull in several dependencies some of which need a target compiler (specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be dtc.

This change enables support 'dtbs_install' on some arches which were missing the target.

Cc Masahiro Yamada <[email protected]>
Cc Michal Marek <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Russell King <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Michal Simek <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Paul Burton <[email protected]>
Cc James Hogan <[email protected]>
Cc Ley Foon Tan <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Chris Zankel <[email protected]>
Cc Max Filippov <[email protected]>
Cc linux-kbuild at vger.kernel.org
Cc linux-snps-arc at lists.infradead.org
Cc linux-arm-kernel at lists.infradead.org
Cc uclinux-h8-devel at lists.sourceforge.jp
Cc linux-mips at linux-mips.org
Cc nios2-dev at lists.rocketboards.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-xtensa at linux-xtensa.org
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

v2:
- Fix $arch/boot/dts path check for out of tree builds
- Fix dtc dependency for building built-in dtbs
- Fix microblaze built-in dtb building

 Makefile                          | 32 +++++++++++++++++++++++++++++++
 arch/arc/Makefile                 |  6 ------
 arch/arm/Makefile                 | 20 +------------------
 arch/arm64/Makefile               | 17 +---------------
 arch/c6x/Makefile                 |  2 --
 arch/h8300/Makefile               | 11 +----------
 arch/microblaze/Makefile          |  4 +---
 arch/microblaze/boot/dts/Makefile |  2 ++
 arch/mips/Makefile                | 15 +--------------
 arch/nds32/Makefile               |  2 +-
 arch/nios2/Makefile               |  7 -------
 arch/nios2/boot/Makefile          |  4 ----
 arch/powerpc/Makefile             |  3 ---
 arch/xtensa/Makefile              | 12 +-----------
 scripts/Makefile.lib              |  2 +-
 15 files changed, 42 insertions(+), 97 deletions(-)
Makefile +32 -0
index 2b458801ba74..bc18dbbc16c5 100644
@@ -1212,6 +1212,32 @@ kselftest-merge:
 		$(srctree)/tools/testing/selftests/*/config
 	+$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig
 
+# ---------------------------------------------------------------------------
+# Devicetree files
+
+ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/boot/dts/),)
+dtstree := arch/$(SRCARCH)/boot/dts
+endif
+
+ifdef CONFIG_OF_EARLY_FLATTREE
+
+%.dtb %.dtb.S %.dtb.o: | dtc
+	$(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@
+
+PHONY += dtbs
+dtbs: | dtc
+	$(Q)$(MAKE) $(build)=$(dtstree)
+
+dtbs_install: dtbs
+	$(Q)$(MAKE) $(dtbinst)=$(dtstree)
+
+all: dtbs
+
+dtc:
+	$(Q)$(MAKE) $(build)=scripts/dtc
+
+endif
+
 # ---------------------------------------------------------------------------
 # Modules
 

@@ -1421,6 +1447,12 @@ help:
 	@echo  '  kselftest-merge - Merge all the config dependencies of kselftest to existing'
 	@echo  '                    .config.'
 	@echo  ''
+	@$(if $(dtstree), \
+		echo 'Devicetree:'; \
+		echo '* dtbs            - Build device tree blobs for enabled boards'; \
+		echo '  dtbs_install    - Install dtbs to $(INSTALL_DTBS_PATH)'; \
+		echo '')
+
 	@echo 'Userspace tools targets:'
 	@echo '  use "make tools/help"'
 	@echo '  or  "cd tools; make help"'
arch/arc/Makefile +0 -6
index fb026196aaab..5c7bc6d62f43 100644
@@ -132,11 +132,5 @@ boot_targets += uImage uImage.bin uImage.gz
 $(boot_targets): vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
 
-%.dtb %.dtb.S %.dtb.o: scripts
-	$(Q)$(MAKE) $(build)=$(boot)/dts $(boot)/dts/$@
-
-dtbs: scripts
-	$(Q)$(MAKE) $(build)=$(boot)/dts
-
 archclean:
 	$(Q)$(MAKE) $(clean)=$(boot)
arch/arm/Makefile +1 -19
index d1516f85f25d..161c2df6567e 100644
@@ -307,12 +307,7 @@ else
 KBUILD_IMAGE := $(boot)/zImage
 endif
 
-# Build the DT binary blobs if we have OF configured
-ifeq ($(CONFIG_USE_OF),y)
-KBUILD_DTBS := dtbs
-endif
-
-all:	$(notdir $(KBUILD_IMAGE)) $(KBUILD_DTBS)
+all:	$(notdir $(KBUILD_IMAGE))
 
 
 archheaders:

@@ -339,17 +334,6 @@ $(BOOT_TARGETS): vmlinux
 $(INSTALL_TARGETS):
 	$(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@
 
-%.dtb: | scripts
-	$(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@
-
-PHONY += dtbs dtbs_install
-
-dtbs: prepare scripts
-	$(Q)$(MAKE) $(build)=$(boot)/dts
-
-dtbs_install:
-	$(Q)$(MAKE) $(dtbinst)=$(boot)/dts
-
 PHONY += vdso_install
 vdso_install:
 ifeq ($(CONFIG_VDSO),y)

@@ -371,8 +355,6 @@ define archhelp
   echo  '  uImage        - U-Boot wrapped zImage'
   echo  '  bootpImage    - Combined zImage and initial RAM disk'
   echo  '                  (supply initrd image via make variable INITRD=<path>)'
-  echo  '* dtbs          - Build device tree blobs for enabled boards'
-  echo  '  dtbs_install  - Install dtbs to $(INSTALL_DTBS_PATH)'
   echo  '  install       - Install uncompressed kernel'
   echo  '  zinstall      - Install compressed kernel'
   echo  '  uinstall      - Install U-Boot wrapped compressed kernel'
arch/arm64/Makefile +1 -16
index 106039d25e2f..b4e994cd3a42 100644
@@ -113,9 +113,8 @@ core-$(CONFIG_EFI_STUB) += $(objtree)/drivers/firmware/efi/libstub/lib.a
 # Default target when executing plain make
 boot		:= arch/arm64/boot
 KBUILD_IMAGE	:= $(boot)/Image.gz
-KBUILD_DTBS	:= dtbs
 
-all:	Image.gz $(KBUILD_DTBS)
+all:	Image.gz
 
 
 Image: vmlinux

@@ -127,17 +126,6 @@ Image.%: Image
 zinstall install:
 	$(Q)$(MAKE) $(build)=$(boot) $@
 
-%.dtb: scripts
-	$(Q)$(MAKE) $(build)=$(boot)/dts $(boot)/dts/$@
-
-PHONY += dtbs dtbs_install
-
-dtbs: prepare scripts
-	$(Q)$(MAKE) $(build)=$(boot)/dts
-
-dtbs_install:
-	$(Q)$(MAKE) $(dtbinst)=$(boot)/dts
-
 PHONY += vdso_install
 vdso_install:
 	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso $@

@@ -145,7 +133,6 @@ vdso_install:
 # We use MRPROPER_FILES and CLEAN_FILES now
 archclean:
 	$(Q)$(MAKE) $(clean)=$(boot)
-	$(Q)$(MAKE) $(clean)=$(boot)/dts
 
 # We need to generate vdso-offsets.h before compiling certain files in kernel/.
 # In order to do that, we should use the archprepare target, but we can't since

@@ -160,8 +147,6 @@ vdso_prepare: prepare0
 define archhelp
   echo  '* Image.gz      - Compressed kernel image (arch/$(ARCH)/boot/Image.gz)'
   echo  '  Image         - Uncompressed kernel image (arch/$(ARCH)/boot/Image)'
-  echo  '* dtbs          - Build device tree blobs for enabled boards'
-  echo  '  dtbs_install  - Install dtbs to $(INSTALL_DTBS_PATH)'
   echo  '  install       - Install uncompressed kernel'
   echo  '  zinstall      - Install compressed kernel'
   echo  '                  Install using (your) ~/bin/installkernel or'
arch/c6x/Makefile +0 -2
index 3fe8a948e94c..b7aa854f7008 100644
@@ -40,9 +40,7 @@ boot := arch/$(ARCH)/boot
 DTB:=$(subst dtbImage.,,$(filter dtbImage.%, $(MAKECMDGOALS)))
 export DTB
 
-ifneq ($(DTB),)
 core-y	+= $(boot)/dts/
-endif
 
 # With make 3.82 we cannot mix normal and wildcard targets
arch/h8300/Makefile +1 -10
index 58634e6bae92..4003ddc616e1 100644
@@ -31,21 +31,12 @@ CROSS_COMPILE := h8300-unknown-linux-
 endif
 
 core-y	+= arch/$(ARCH)/kernel/ arch/$(ARCH)/mm/
-ifneq '$(CONFIG_H8300_BUILTIN_DTB)' '""'
-core-y += arch/h8300/boot/dts/
-endif
+core-y	+= arch/$(ARCH)/boot/dts/
 
 libs-y	+= arch/$(ARCH)/lib/
 
 boot := arch/h8300/boot
 
-%.dtb %.dtb.S %.dtb.o: | scripts
-	$(Q)$(MAKE) $(build)=arch/h8300/boot/dts arch/h8300/boot/dts/$@
-
-PHONY += dtbs
-dtbs: scripts
-	$(Q)$(MAKE) $(build)=arch/h8300/boot/dts
-
 archmrproper:
 
 archclean:
arch/microblaze/Makefile +1 -3
index 4f3ab5707265..0823d291fbeb 100644
@@ -65,9 +65,7 @@ boot := arch/microblaze/boot
 # Are we making a simpleImage.<boardname> target? If so, crack out the boardname
 DTB:=$(subst simpleImage.,,$(filter simpleImage.%, $(MAKECMDGOALS)))
 
-ifneq ($(DTB),)
-	core-y	+= $(boot)/dts/
-endif
+core-y	+= $(boot)/dts/
 
 # defines filename extension depending memory management type
 ifeq ($(CONFIG_MMU),)
arch/microblaze/boot/dts/Makefile +2 -0
index 1f77913d404d..fe9af267f598 100644
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
 #
 
+ifneq ($(DTB),)
 obj-y += linked_dtb.o
 
 # Ensure system.dtb exists

@@ -11,6 +12,7 @@ ifneq ($(DTB),system)
 $(obj)/system.dtb: $(obj)/$(DTB).dtb
 	$(call if_changed,cp)
 endif
+endif
 
 quiet_cmd_cp = CP      $< $@$2
 	cmd_cp = cat $< >$@$2 || (rm -f $@ && echo false)
arch/mips/Makefile +1 -14
index d74b3742fa5d..d43eeaa6d75b 100644
@@ -407,18 +407,7 @@ endif
 CLEAN_FILES += vmlinux.32 vmlinux.64
 
 # device-trees
-core-$(CONFIG_BUILTIN_DTB) += arch/mips/boot/dts/
-
-%.dtb %.dtb.S %.dtb.o: | scripts
-	$(Q)$(MAKE) $(build)=arch/mips/boot/dts arch/mips/boot/dts/$@
-
-PHONY += dtbs
-dtbs: scripts
-	$(Q)$(MAKE) $(build)=arch/mips/boot/dts
-
-PHONY += dtbs_install
-dtbs_install:
-	$(Q)$(MAKE) $(dtbinst)=arch/mips/boot/dts
+core-y += arch/mips/boot/dts/
 
 archprepare:
 ifdef CONFIG_MIPS32_N32

@@ -461,8 +450,6 @@ define archhelp
 	echo '  uImage.lzma          - U-Boot image (lzma)'
 	echo '  uImage.lzo           - U-Boot image (lzo)'
 	echo '  uzImage.bin          - U-Boot image (self-extracting)'
-	echo '  dtbs                 - Device-tree blobs for enabled boards'
-	echo '  dtbs_install         - Install dtbs to $(INSTALL_DTBS_PATH)'
 	echo
 	echo '  These will be default as appropriate for a configured platform.'
 	echo
arch/nds32/Makefile +1 -1
index 63f4f173e5f4..adcac830d051 100644
@@ -43,7 +43,7 @@ CHECKFLAGS      += -D__NDS32_EB__
 endif
 
 boot := arch/nds32/boot
-core-$(BUILTIN_DTB) += $(boot)/dts/
+core-y += $(boot)/dts/
 
 .PHONY: FORCE
arch/nios2/Makefile +0 -7
index db2e78fe65c7..52c03e60b114 100644
@@ -56,12 +56,6 @@ all: vmImage
 archclean:
 	$(Q)$(MAKE) $(clean)=$(nios2-boot)
 
-%.dtb %.dtb.S %.dtb.o: | scripts
-	$(Q)$(MAKE) $(build)=$(nios2-boot)/dts $(nios2-boot)/dts/$@
-
-dtbs:
-	$(Q)$(MAKE) $(build)=$(nios2-boot)/dts
-
 $(BOOT_TARGETS): vmlinux
 	$(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
 

@@ -74,5 +68,4 @@ define archhelp
   echo  '                     (your) ~/bin/$(INSTALLKERNEL) or'
   echo  '                     (distribution) /sbin/$(INSTALLKERNEL) or'
   echo  '                     install to $$(INSTALL_PATH)'
-  echo  '  dtbs            - Build device tree blobs for enabled boards'
 endef
arch/nios2/boot/Makefile +0 -4
index 0b48f1bf086d..37dfc7e584bc 100644
@@ -31,9 +31,5 @@ $(obj)/zImage: $(obj)/compressed/vmlinux FORCE
 $(obj)/compressed/vmlinux: $(obj)/vmlinux.gz FORCE
 	$(Q)$(MAKE) $(build)=$(obj)/compressed $@
 
-targets += $(dtb-y)
-
-$(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
-
 install:
 	sh $(srctree)/$(src)/install.sh $(KERNELRELEASE) $(BOOTIMAGE) System.map "$(INSTALL_PATH)"
arch/powerpc/Makefile +0 -3
index 53ea887eb34e..42f225f6ec93 100644
@@ -293,9 +293,6 @@ $(BOOT_TARGETS2): vmlinux
 bootwrapper_install:
 	$(Q)$(MAKE) $(build)=$(boot) $(patsubst %,$(boot)/%,$@)
 
-%.dtb: scripts
-	$(Q)$(MAKE) $(build)=$(boot)/dts $(patsubst %,$(boot)/dts/%,$@)
-
 # Used to create 'merged defconfigs'
 # To use it $(call) it with the first argument as the base defconfig
 # and the second argument as a space separated list of .config files to merge,
arch/xtensa/Makefile +1 -11
index 295c120ed099..13fd3301c517 100644
@@ -84,28 +84,18 @@ LIBGCC := $(shell $(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
 head-y		:= arch/xtensa/kernel/head.o
 core-y		+= arch/xtensa/kernel/ arch/xtensa/mm/
 core-y		+= $(buildvar) $(buildplf)
+core-y 		+= arch/xtensa/boot/dts/
 
 libs-y		+= arch/xtensa/lib/ $(LIBGCC)
 drivers-$(CONFIG_OPROFILE)	+= arch/xtensa/oprofile/
 
-ifneq ($(CONFIG_BUILTIN_DTB),"")
-core-$(CONFIG_OF) += arch/xtensa/boot/dts/
-endif
-
 boot		:= arch/xtensa/boot
 
 all Image zImage uImage: vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) $@
 
-%.dtb:
-	$(Q)$(MAKE) $(build)=$(boot)/dts $(boot)/dts/$@
-
-dtbs: scripts
-	$(Q)$(MAKE) $(build)=$(boot)/dts
-
 define archhelp
   @echo '* Image       - Kernel ELF image with reset vector'
   @echo '* zImage      - Compressed kernel image (arch/xtensa/boot/images/zImage.*)'
   @echo '* uImage      - U-Boot wrapped image'
-  @echo '  dtbs        - Build device tree blobs for enabled boards'
 endef
scripts/Makefile.lib +1 -1
index 61e596650ed3..8fe4468f9bda 100644
@@ -283,7 +283,7 @@ $(obj)/%.dtb.S: $(obj)/%.dtb FORCE
 
 quiet_cmd_dtc = DTC     $@
 cmd_dtc = mkdir -p $(dir ${dtc-tmp}) ; \
-	$(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
+	$(HOSTCC) -E $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
 	$(DTC) -O dtb -o $@ -b 0 \
 		$(addprefix -i,$(dir $<) $(DTC_INCLUDE)) $(DTC_FLAGS) \
 		-d $(depfile).dtc.tmp $(dtc-tmp) ; \

--
2.17.1

Acked-by on v2 6/9
#10 lore raw

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

Quoted 43 lines · Rob Herring

There is nothing arch specific about building dtb files other than their location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'. These pull in several dependencies some of which need a target compiler (specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be dtc.

This change enables support 'dtbs_install' on some arches which were missing the target.

Cc Masahiro Yamada <[email protected]>
Cc Michal Marek <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Russell King <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Michal Simek <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Paul Burton <[email protected]>
Cc James Hogan <[email protected]>
Cc Ley Foon Tan <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Chris Zankel <[email protected]>
Cc Max Filippov <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Quoted 2 lines

---
Please ack so I can take the whole series via the DT tree.

For arm64:

Acked-by Will Deacon <[email protected]>

Will

Acked-by on v2 6/9
#11 lore raw

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

In reply to Rob Herring

Hi Rob,

Quoted 14 lines · Rob Herring

There is nothing arch specific about building dtb files other than their location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'. These pull in several dependencies some of which need a target compiler (specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be dtc.

Quoted 7 lines

This change enables support 'dtbs_install' on some arches which were missing the target.

%

Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

For MIPS:

Acked-by Paul Burton <[email protected]>

Thanks,
Paul

Acked-by on v2 6/9
#12 lore raw

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

In reply to Rob Herring
Quoted 49 lines · Rob Herring

There is nothing arch specific about building dtb files other than their
location under /arch/*/boot/dts/. Keeping each arch aligned is a pain.
The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This
is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'.
These pull in several dependencies some of which need a target compiler
(specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be
dtc.

This change enables support 'dtbs_install' on some arches which were missing the target.

Cc Masahiro Yamada <[email protected]>
Cc Michal Marek <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Russell King <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Michal Simek <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Paul Burton <[email protected]>
Cc James Hogan <[email protected]>
Cc Ley Foon Tan <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Chris Zankel <[email protected]>
Cc Max Filippov <[email protected]>
Cc linux-kbuild at vger.kernel.org
Cc linux-snps-arc at lists.infradead.org
Cc linux-arm-kernel at lists.infradead.org
Cc uclinux-h8-devel at lists.sourceforge.jp
Cc linux-mips at linux-mips.org
Cc nios2-dev at lists.rocketboards.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-xtensa at linux-xtensa.org
Signed-off-by Rob Herring <[email protected]>
Quoted 3 lines

---
Please ack so I can take the whole series via the DT tree.

For nios2:

Acked-by Ley Foon Tan <[email protected]>

Regards
Ley Foon

#13 lore raw

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

In reply to Rob Herring

2018-09-06 8:53 GMT+09:00 Rob Herring <[email protected]>:

Quoted 43 lines

There is nothing arch specific about building dtb files other than their location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'. These pull in several dependencies some of which need a target compiler (specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be dtc.

This change enables support 'dtbs_install' on some arches which were missing the target.

Cc Masahiro Yamada <[email protected]>
Cc Michal Marek <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Russell King <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Michal Simek <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Paul Burton <[email protected]>
Cc James Hogan <[email protected]>
Cc Ley Foon Tan <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Chris Zankel <[email protected]>
Cc Max Filippov <[email protected]>
Cc linux-kbuild at vger.kernel.org
Cc linux-snps-arc at lists.infradead.org
Cc linux-arm-kernel at lists.infradead.org
Cc uclinux-h8-devel at lists.sourceforge.jp
Cc linux-mips at linux-mips.org
Cc nios2-dev at lists.rocketboards.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-xtensa at linux-xtensa.org
Signed-off-by Rob Herring <[email protected]>
Quoted 7 lines

---
Please ack so I can take the whole series via the DT tree.

v2:
- Fix $arch/boot/dts path check for out of tree builds
- Fix dtc dependency for building built-in dtbs
- Fix microblaze built-in dtb building

This breaks parallel building
because two threads could descend into scripts/dtc at the same time.

'all' depends on both 'scripts' and 'dtc'.

* 'scripts' target -- descends into scripts/, then scripts/dtc
* 'dtc' target -- descents into scripts/dtc directly

Signature · 2 lines
Best Regards
Masahiro Yamada
author maintainer
#14 lore raw

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

Quoted 54 lines · Masahiro Yamada

2018-09-06 8:53 GMT+09:00 Rob Herring <[email protected]>:

Quoted 43 lines

There is nothing arch specific about building dtb files other than their location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'. These pull in several dependencies some of which need a target compiler (specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be dtc.

This change enables support 'dtbs_install' on some arches which were missing the target.

Cc Masahiro Yamada <[email protected]>
Cc Michal Marek <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Russell King <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Michal Simek <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Paul Burton <[email protected]>
Cc James Hogan <[email protected]>
Cc Ley Foon Tan <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Chris Zankel <[email protected]>
Cc Max Filippov <[email protected]>
Cc linux-kbuild at vger.kernel.org
Cc linux-snps-arc at lists.infradead.org
Cc linux-arm-kernel at lists.infradead.org
Cc uclinux-h8-devel at lists.sourceforge.jp
Cc linux-mips at linux-mips.org
Cc nios2-dev at lists.rocketboards.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-xtensa at linux-xtensa.org
Signed-off-by Rob Herring <[email protected]>
Quoted 7 lines

---
Please ack so I can take the whole series via the DT tree.

v2:
- Fix $arch/boot/dts path check for out of tree builds
- Fix dtc dependency for building built-in dtbs
- Fix microblaze built-in dtb building

Quoted 8 lines

This breaks parallel building
because two threads could descend into scripts/dtc at the same time.

'all' depends on both 'scripts' and 'dtc'.

* 'scripts' target -- descends into scripts/, then scripts/dtc
* 'dtc' target -- descents into scripts/dtc directly

Any suggestions for how to fix given the problem with depending on scripts? I suppose I could make scripts depend on dtc instead, but I'd be back to needing to fix cleaning. Or I could just skip removing the cross compiler dependency for now.

Rob

#15 lore raw

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

Hi Rob,

2018-09-07 21:17 GMT+09:00 Rob Herring <[email protected]>:

Quoted 60 lines
Quoted 58 lines · Masahiro Yamada

2018-09-06 8:53 GMT+09:00 Rob Herring <[email protected]>:

Quoted 43 lines

There is nothing arch specific about building dtb files other than their location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'. These pull in several dependencies some of which need a target compiler (specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be dtc.

This change enables support 'dtbs_install' on some arches which were missing the target.

Cc Masahiro Yamada <[email protected]>
Cc Michal Marek <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Russell King <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Michal Simek <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Paul Burton <[email protected]>
Cc James Hogan <[email protected]>
Cc Ley Foon Tan <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Chris Zankel <[email protected]>
Cc Max Filippov <[email protected]>
Cc linux-kbuild at vger.kernel.org
Cc linux-snps-arc at lists.infradead.org
Cc linux-arm-kernel at lists.infradead.org
Cc uclinux-h8-devel at lists.sourceforge.jp
Cc linux-mips at linux-mips.org
Cc nios2-dev at lists.rocketboards.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-xtensa at linux-xtensa.org
Signed-off-by Rob Herring <[email protected]>
Quoted 7 lines

---
Please ack so I can take the whole series via the DT tree.

v2:
- Fix $arch/boot/dts path check for out of tree builds
- Fix dtc dependency for building built-in dtbs
- Fix microblaze built-in dtb building

This breaks parallel building
because two threads could descend into scripts/dtc at the same time.

Quoted 8 lines
Quoted 4 lines

'all' depends on both 'scripts' and 'dtc'.

* 'scripts' target -- descends into scripts/, then scripts/dtc
* 'dtc' target -- descents into scripts/dtc directly

Any suggestions for how to fix given the problem with depending on scripts? I suppose I could make scripts depend on dtc instead, but I'd be back to needing to fix cleaning.

How about making 'prepare' depend on 'dtc'?

Then, remove
subdir-$(CONFIG_DTC) += dtc
from scripts/Makefile

but, add dtc to subdir-

Quoted 2 lines

Or I could just skip removing the
cross compiler dependency for now.

I want to build scripts/
without target compiler.

modpost is a special host-program
that depends on $(CC).

I will take a look at it
when I find some time.

Signature · 2 lines
Best Regards
Masahiro Yamada
#16 lore raw

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

In reply to Rob Herring

2018-09-06 8:53 GMT+09:00 Rob Herring <[email protected]>:

Quoted 77 lines

There is nothing arch specific about building dtb files other than their location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'. These pull in several dependencies some of which need a target compiler (specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be dtc.

This change enables support 'dtbs_install' on some arches which were missing the target.

Cc Masahiro Yamada <[email protected]>
Cc Michal Marek <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Russell King <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Michal Simek <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Paul Burton <[email protected]>
Cc James Hogan <[email protected]>
Cc Ley Foon Tan <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Chris Zankel <[email protected]>
Cc Max Filippov <[email protected]>
Cc linux-kbuild at vger.kernel.org
Cc linux-snps-arc at lists.infradead.org
Cc linux-arm-kernel at lists.infradead.org
Cc uclinux-h8-devel at lists.sourceforge.jp
Cc linux-mips at linux-mips.org
Cc nios2-dev at lists.rocketboards.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-xtensa at linux-xtensa.org
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

v2:
- Fix $arch/boot/dts path check for out of tree builds
- Fix dtc dependency for building built-in dtbs
- Fix microblaze built-in dtb building

 Makefile                          | 32 +++++++++++++++++++++++++++++++
 arch/arc/Makefile                 |  6 ------
 arch/arm/Makefile                 | 20 +------------------
 arch/arm64/Makefile               | 17 +---------------
 arch/c6x/Makefile                 |  2 --
 arch/h8300/Makefile               | 11 +----------
 arch/microblaze/Makefile          |  4 +---
 arch/microblaze/boot/dts/Makefile |  2 ++
 arch/mips/Makefile                | 15 +--------------
 arch/nds32/Makefile               |  2 +-
 arch/nios2/Makefile               |  7 -------
 arch/nios2/boot/Makefile          |  4 ----
 arch/powerpc/Makefile             |  3 ---
 arch/xtensa/Makefile              | 12 +-----------
 scripts/Makefile.lib              |  2 +-
 15 files changed, 42 insertions(+), 97 deletions(-)
Makefile +1 -0
index 2b458801ba74..bc18dbbc16c5 100644
@@ -1212,6 +1212,32 @@ kselftest-merge:
                $(srctree)/tools/testing/selftests/*/config
        +$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig
 
+# ---------------------------------------------------------------------------

Makefile kselftest-merge: · line 1225

Quoted 10 lines
Makefile +10 -0
+# Devicetree files
+
+ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/boot/dts/),)
+dtstree := arch/$(SRCARCH)/boot/dts
+endif
+
+ifdef CONFIG_OF_EARLY_FLATTREE
+
+%.dtb %.dtb.S %.dtb.o: | dtc
+       $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@

Hmm, I was worried about '%.dtb.o: | dtc'
but seems working.

Compiling %.S -> %.o requires objtool for x86,
but x86 does not support DT.

If CONFIG_MODVERSIONS=y, scripts/genksyms/genksyms is required, %.dtb.S does not contain EXPORT_SYMBOL.

BTW, 'dtc' should be a PHONY target.

Signature · 2 lines
Best Regards
Masahiro Yamada
author maintainer
#17 lore raw

Re: [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules

Quoted 94 lines · Masahiro Yamada

2018-09-06 8:53 GMT+09:00 Rob Herring <[email protected]>:

Quoted 77 lines

There is nothing arch specific about building dtb files other than their location under /arch/*/boot/dts/. Keeping each arch aligned is a pain. The dependencies and supported targets are all slightly different. Also, a cross-compiler for each arch is needed, but really the host compiler preprocessor is perfectly fine for building dtbs. Move the build rules to a common location and remove the arch specific ones. This is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'. These pull in several dependencies some of which need a target compiler (specifically devicetable-offsets.h) and aren't needed to build dtbs. All that is really needed is dtc, so adjust the dependencies to only be dtc.

This change enables support 'dtbs_install' on some arches which were missing the target.

Cc Masahiro Yamada <[email protected]>
Cc Michal Marek <[email protected]>
Cc Vineet Gupta <[email protected]>
Cc Russell King <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc Yoshinori Sato <[email protected]>
Cc Michal Simek <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Paul Burton <[email protected]>
Cc James Hogan <[email protected]>
Cc Ley Foon Tan <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Chris Zankel <[email protected]>
Cc Max Filippov <[email protected]>
Cc linux-kbuild at vger.kernel.org
Cc linux-snps-arc at lists.infradead.org
Cc linux-arm-kernel at lists.infradead.org
Cc uclinux-h8-devel at lists.sourceforge.jp
Cc linux-mips at linux-mips.org
Cc nios2-dev at lists.rocketboards.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-xtensa at linux-xtensa.org
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

v2:
- Fix $arch/boot/dts path check for out of tree builds
- Fix dtc dependency for building built-in dtbs
- Fix microblaze built-in dtb building

 Makefile                          | 32 +++++++++++++++++++++++++++++++
 arch/arc/Makefile                 |  6 ------
 arch/arm/Makefile                 | 20 +------------------
 arch/arm64/Makefile               | 17 +---------------
 arch/c6x/Makefile                 |  2 --
 arch/h8300/Makefile               | 11 +----------
 arch/microblaze/Makefile          |  4 +---
 arch/microblaze/boot/dts/Makefile |  2 ++
 arch/mips/Makefile                | 15 +--------------
 arch/nds32/Makefile               |  2 +-
 arch/nios2/Makefile               |  7 -------
 arch/nios2/boot/Makefile          |  4 ----
 arch/powerpc/Makefile             |  3 ---
 arch/xtensa/Makefile              | 12 +-----------
 scripts/Makefile.lib              |  2 +-
 15 files changed, 42 insertions(+), 97 deletions(-)
Makefile +1 -0
index 2b458801ba74..bc18dbbc16c5 100644
@@ -1212,6 +1212,32 @@ kselftest-merge:
                $(srctree)/tools/testing/selftests/*/config
        +$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig
 
+# ---------------------------------------------------------------------------

Makefile kselftest-merge: · line 1225

Quoted 10 lines
Makefile +10 -0
+# Devicetree files
+
+ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/boot/dts/),)
+dtstree := arch/$(SRCARCH)/boot/dts
+endif
+
+ifdef CONFIG_OF_EARLY_FLATTREE
+
+%.dtb %.dtb.S %.dtb.o: | dtc
+       $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@

Hmm, I was worried about '%.dtb.o: | dtc'
but seems working.

Quoted 2 lines

Compiling %.S -> %.o requires objtool for x86,
but x86 does not support DT.

Well, x86 does support DT to some extent. There's 2 platforms and the DT unittests build and run on x86.

Actually, we can remove "%.dtb.S %.dtb.o" because we don't need those as top-level build targets. Must have been a copy-n-paste relic from before having common rules.

Quoted 3 lines

If CONFIG_MODVERSIONS=y, scripts/genksyms/genksyms is required, %.dtb.S does not contain EXPORT_SYMBOL.

Okay, but that shouldn't affect any of this. We only build *.dtb.S when doing built-in dtbs.

Quoted 1 line

BTW, 'dtc' should be a PHONY target.

Right, I found that too.

Rob

author maintainer
#18 lore raw

PATCH v2 7/9 powerpc: enable building all dtbs

In reply to Rob Herring

Enable the 'dtbs' target for powerpc. This allows building all the dts files in arch/powerpc/boot/dts/ when COMPILE_TEST and OF_ALL_DTBS are enabled.

Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/powerpc/boot/dts/Makefile     | 5 +++++
 arch/powerpc/boot/dts/fsl/Makefile | 4 ++++
 2 files changed, 9 insertions(+)
 create mode 100644 arch/powerpc/boot/dts/fsl/Makefile
arch/powerpc/boot/dts/Makefile +5 -0
index f66554cd5c45..fb335d05aae8 100644
@@ -1 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
+
+subdir-y += fsl
+
+dtstree		:= $(srctree)/$(src)
+dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
arch/powerpc/boot/dts/fsl/Makefile new file +4 -0
new file mode 100644
index 000000000000..3bae982641e9
@@ -0,0 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0
+
+dtstree		:= $(srctree)/$(src)
+dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))

--
2.17.1

author maintainer
#19 lore raw

PATCH v2 8/9 c6x: enable building all dtbs

In reply to Rob Herring

Enable the 'dtbs' target for c6x. This allows building all the dts files in arch/c6x/boot/dts/ for enabled platforms or when COMPILE_TEST and OF_ALL_DTBS are enabled.

Cc Mark Salter <[email protected]>
Cc Aurelien Jacquiot <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

 arch/c6x/boot/dts/Makefile | 6 ++++++
 1 file changed, 6 insertions(+)
arch/c6x/boot/dts/Makefile +6 -0
index fd937f781d16..f438285c3640 100644
@@ -5,6 +5,12 @@
 
 DTC_FLAGS ?= -p 1024
 
+dtb-$(CONFIG_SOC_TMS320C6455) += dsk6455.dtb
+dtb-$(CONFIG_SOC_TMS320C6457) += evmc6457.dtb
+dtb-$(CONFIG_SOC_TMS320C6472) += evmc6472.dtb
+dtb-$(CONFIG_SOC_TMS320C6474) += evmc6474.dtb
+dtb-$(CONFIG_SOC_TMS320C6678) += evmc6678.dtb
+
 ifneq ($(DTB),)
 obj-y += $(DTB).dtb.o
 endif

--
2.17.1

author maintainer
#20 lore raw

PATCH v2 9/9 microblaze: enable building all dtbs

In reply to Rob Herring

Enable the 'dtbs' target for microblaze. As microblaze only has one dts file, always enable it.

Cc Michal Simek <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
Please ack so I can take the whole series via the DT tree.

v2:
- new patch

 arch/microblaze/boot/dts/Makefile | 2 ++
 1 file changed, 2 insertions(+)
arch/microblaze/boot/dts/Makefile +2 -0
index fe9af267f598..c7324e74f9ef 100644
@@ -1,6 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0
 #
 
+dtb-y := system.dtb
+
 ifneq ($(DTB),)
 obj-y += linked_dtb.o

--
2.17.1