Skip to contentSkip to conversation

mm: Export alloc_migrate_huge_page

RFC PATCH In review Aneesh Kumar K.V 2 participants 14 messages Sep 6, 2018 – Sep 7, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

RFC PATCH v2 1/4 mm: Export alloc_migrate_huge_page

We want to use this to support customized huge page migration.

---
 include/linux/hugetlb.h | 2 ++
 mm/hugetlb.c            | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)
include/linux/hugetlb.h +2 -0
index c39d9170a8a0..98c9c6dc308c 100644
@@ -357,6 +357,8 @@ struct page *alloc_huge_page_nodemask(struct hstate *h, int preferred_nid,
 				nodemask_t *nmask);
 struct page *alloc_huge_page_vma(struct hstate *h, struct vm_area_struct *vma,
 				unsigned long address);
+struct page *alloc_migrate_huge_page(struct hstate *h, gfp_t gfp_mask,
+				     int nid, nodemask_t *nmask);
 int huge_add_to_page_cache(struct page *page, struct address_space *mapping,
 			pgoff_t idx);
 
mm/hugetlb.c +2 -2
index 47566bb0b4b1..88881b3f8628 100644
@@ -1586,8 +1586,8 @@ static struct page *alloc_surplus_huge_page(struct hstate *h, gfp_t gfp_mask,
 	return page;
 }
 
-static struct page *alloc_migrate_huge_page(struct hstate *h, gfp_t gfp_mask,
-		int nid, nodemask_t *nmask)
+struct page *alloc_migrate_huge_page(struct hstate *h, gfp_t gfp_mask,
+				     int nid, nodemask_t *nmask)
 {
 	struct page *page;
 
Signature · 1 line
2.17.1
#1 lore raw

RFC PATCH v2 2/4 mm: Add get_user_pages_cma_migrate

This helper does a get_user_pages_fast and if it find pages in the CMA area it will try to migrate them before taking page reference. This makes sure that we don't keep non-movable pages (due to page reference count) in the CMA area. Not able to move pages out of CMA area result in CMA allocation failures.

---
 include/linux/migrate.h |   3 ++
 mm/migrate.c            | 108 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 111 insertions(+)
include/linux/migrate.h +3 -0
index f2b4abbca55e..d82b35afd2eb 100644
@@ -286,6 +286,9 @@ static inline int migrate_vma(const struct migrate_vma_ops *ops,
 }
 #endif /* IS_ENABLED(CONFIG_MIGRATE_VMA_HELPER) */
 
+extern int get_user_pages_cma_migrate(unsigned long start, int nr_pages, int write,
+				      struct page **pages);
+
 #endif /* CONFIG_MIGRATION */
 
 #endif /* _LINUX_MIGRATE_H */
mm/migrate.c +108 -0

111 lines not on this page · raw message

Signature · 1 line
2.17.1
#2 lore raw

Re: [RFC PATCH V2 2/4] mm: Add get_user_pages_cma_migrate

Quoted 4 lines · Aneesh Kumar K.V

This helper does a get_user_pages_fast and if it find pages in the CMA area it will try to migrate them before taking page reference. This makes sure that we don't keep non-movable pages (due to page reference count) in the CMA area. Not able to move pages out of CMA area result in CMA allocation failures.

Again, there is no user so it is hard to guess the intention completely. There is no documentation to describe the expected context and assumptions about locking etc.

As noted in the previous email. You should better describe why you are bypassing hugetlb pools. I assume that the reason is to guarantee a forward progress because those might be sitting in the CMA pools already, right?

Signature · 2 lines
Michal Hocko
SUSE Labs
#3 lore raw

Re: [RFC PATCH V2 2/4] mm: Add get_user_pages_cma_migrate

Quoted 10 lines · Michal Hocko
Quoted 4 lines · Aneesh Kumar K.V

This helper does a get_user_pages_fast and if it find pages in the CMA area it will try to migrate them before taking page reference. This makes sure that we don't keep non-movable pages (due to page reference count) in the CMA area. Not able to move pages out of CMA area result in CMA allocation failures.

Again, there is no user so it is hard to guess the intention completely. There is no documentation to describe the expected context and assumptions about locking etc.

patch 4 is the user for the new helper. I will add the documentation update.

Quoted 5 lines

As noted in the previous email. You should better describe why you are bypassing hugetlb pools. I assume that the reason is to guarantee a forward progress because those might be sitting in the CMA pools already, right?

The reason for that is explained in the code

+ struct hstate *h = page_hstate(page);
+ /*
+ * We don't want to dequeue from the pool because pool pages will
+ * mostly be from the CMA region.
+ */
+ return alloc_migrate_huge_page(h, gfp_mask, nid, NULL);

-aneesh

#4 lore raw

RFC PATCH v2 3/4 powerpc/mm/iommu: Allow large IOMMU page size only for hugetlb backing

In reply to Aneesh Kumar K.V

THP pages can get split during different code paths. An incremented reference count do imply we will not split the compound page. But the pmd entry can be converted to level 4 pte entries. Keep the code simpler by allowing large IOMMU page size only if the guest ram is backed by hugetlb pages.

---
 arch/powerpc/mm/mmu_context_iommu.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)
arch/powerpc/mm/mmu_context_iommu.c +2 -14
index c9ee9e23845f..f472965f7638 100644
@@ -212,21 +212,9 @@ long mm_iommu_get(struct mm_struct *mm, unsigned long ua, unsigned long entries,
 		}
 populate:
 		pageshift = PAGE_SHIFT;
-		if (mem->pageshift > PAGE_SHIFT && PageCompound(page)) {
-			pte_t *pte;
+		if (mem->pageshift > PAGE_SHIFT && PageHuge(page)) {
 			struct page *head = compound_head(page);
-			unsigned int compshift = compound_order(head);
-			unsigned int pteshift;
-
-			local_irq_save(flags); /* disables as well */
-			pte = find_linux_pte(mm->pgd, cur_ua, NULL, &pteshift);
-
-			/* Double check it is still the same pinned page */
-			if (pte && pte_page(*pte) == head &&
-			    pteshift == compshift + PAGE_SHIFT)
-				pageshift = max_t(unsigned int, pteshift,
-						PAGE_SHIFT);
-			local_irq_restore(flags);
+			pageshift = compound_order(head) + PAGE_SHIFT;
 		}
 		mem->pageshift = min(mem->pageshift, pageshift);
 		mem->hpas[i] = page_to_pfn(page) << PAGE_SHIFT;
Signature · 1 line
2.17.1
#5 lore raw

RFC PATCH v2 4/4 powerpc/mm/iommu: Allow migration of cma allocated pages during mm_iommu_get

In reply to Aneesh Kumar K.V

Current code doesn't do page migration if the page allocated is a compound page. With HugeTLB migration support, we can end up allocating hugetlb pages from CMA region. Also THP pages can be allocated from CMA region. This patch updates the code to handle compound pages correctly.

This use the new helper get_user_pages_cma_migrate. It does one get_user_pages with right count, instead of doing one get_user_pages per page. That avoids reading page table multiple times.

The patch also convert the hpas member of mm_iommu_table_group_mem_t to a union. We use the same storage location to store pointers to struct page. We cannot update alll the code path use struct page *, because we access hpas in real mode and we can't do that struct page * to pfn conversion in real mode.

---
 arch/powerpc/mm/mmu_context_iommu.c | 124 +++++++++-------------------
 1 file changed, 37 insertions(+), 87 deletions(-)
arch/powerpc/mm/mmu_context_iommu.c +37 -87
index f472965f7638..607acd03ab06 100644
@@ -20,6 +20,7 @@
 #include <linux/swap.h>
 #include <asm/mmu_context.h>
 #include <asm/pte-walk.h>
+#include <linux/mm_inline.h>
 
 static DEFINE_MUTEX(mem_list_mutex);
 
@@ -30,8 +31,18 @@ struct mm_iommu_table_group_mem_t {
 	atomic64_t mapped;
 	unsigned int pageshift;
 	u64 ua;			/* userspace address */
-	u64 entries;		/* number of entries in hpas[] */
-	u64 *hpas;		/* vmalloc'ed */
+	u64 entries;		/* number of entries in hpages[] */
+	/*
+	 * in mm_iommu_get we temporarily use this to store
+	 * struct page address.
+	 *
+	 * We need to convert ua to hpa in real mode. Make it
+	 * simpler by storing physicall address.
+	 */
+	union {
+		struct page **hpages;	/* vmalloc'ed */
+		phys_addr_t *hpas;
+	};
 };
 
 static long mm_iommu_adjust_locked_vm(struct mm_struct *mm,
@@ -74,63 +85,12 @@ bool mm_iommu_preregistered(struct mm_struct *mm)
 }
 EXPORT_SYMBOL_GPL(mm_iommu_preregistered);
 
-/*
- * Taken from alloc_migrate_target with changes to remove CMA allocations
- */
-struct page *new_iommu_non_cma_page(struct page *page, unsigned long private)
-{
-	gfp_t gfp_mask = GFP_USER;
-	struct page *new_page;
-
-	if (PageCompound(page))
-		return NULL;
-
-	if (PageHighMem(page))
-		gfp_mask |= __GFP_HIGHMEM;
-
-	/*
-	 * We don't want the allocation to force an OOM if possibe
-	 */
-	new_page = alloc_page(gfp_mask | __GFP_NORETRY | __GFP_NOWARN);
-	return new_page;
-}
-
-static int mm_iommu_move_page_from_cma(struct page *page)
-{
-	int ret = 0;
-	LIST_HEAD(cma_migrate_pages);
-
-	/* Ignore huge pages for now */
-	if (PageCompound(page))
-		return -EBUSY;
-
-	lru_add_drain();
-	ret = isolate_lru_page(page);
-	if (ret)
-		return ret;
-
-	list_add(&page->lru, &cma_migrate_pages);
-	put_page(page); /* Drop the gup reference */
-
-	ret = migrate_pages(&cma_migrate_pages, new_iommu_non_cma_page,
-				NULL, 0, MIGRATE_SYNC, MR_CONTIG_RANGE);
-	if (ret) {
-		if (!list_empty(&cma_migrate_pages))
-			putback_movable_pages(&cma_migrate_pages);
-	}
-
-	return 0;
-}
-
 long mm_iommu_get(struct mm_struct *mm, unsigned long ua, unsigned long entries,
 		struct mm_iommu_table_group_mem_t **pmem)
 {
 	struct mm_iommu_table_group_mem_t *mem;
-	long i, j, ret = 0, locked_entries = 0;
+	long i, ret = 0, locked_entries = 0;
 	unsigned int pageshift;
-	unsigned long flags;
-	unsigned long cur_ua;
-	struct page *page = NULL;
 
 	mutex_lock(&mem_list_mutex);
 
@@ -177,47 +137,37 @@ long mm_iommu_get(struct mm_struct *mm, unsigned long ua, unsigned long entries,
 		goto unlock_exit;
 	}
 
+	ret = get_user_pages_cma_migrate(ua, entries, 1, mem->hpages);
+	if (ret != entries) {
+		/* free the reference taken */
+		for (i = 0; i < ret; i++)
+			put_page(mem->hpages[i]);
+
+		vfree(mem->hpas);
+		kfree(mem);
+		ret = -EFAULT;
+		goto unlock_exit;
+	} else
+		ret = 0;
+
+	pageshift = PAGE_SHIFT;
 	for (i = 0; i < entries; ++i) {
-		cur_ua = ua + (i << PAGE_SHIFT);
-		if (1 != get_user_pages_fast(cur_ua,
-					1/* pages */, 1/* iswrite */, &page)) {
-			ret = -EFAULT;
-			for (j = 0; j < i; ++j)
-				put_page(pfn_to_page(mem->hpas[j] >>
-						PAGE_SHIFT));
-			vfree(mem->hpas);
-			kfree(mem);
-			goto unlock_exit;
-		}
+		struct page *page = mem->hpages[i];
 		/*
-		 * If we get a page from the CMA zone, since we are going to
-		 * be pinning these entries, we might as well move them out
-		 * of the CMA zone if possible. NOTE: faulting in + migration
-		 * can be expensive. Batching can be considered later
+		 * Allow to use larger than 64k IOMMU pages. Only do that
+		 * if we are backed by hugetlb.
 		 */
-		if (is_migrate_cma_page(page)) {
-			if (mm_iommu_move_page_from_cma(page))
-				goto populate;
-			if (1 != get_user_pages_fast(cur_ua,
-						1/* pages */, 1/* iswrite */,
-						&page)) {
-				ret = -EFAULT;
-				for (j = 0; j < i; ++j)
-					put_page(pfn_to_page(mem->hpas[j] >>
-								PAGE_SHIFT));
-				vfree(mem->hpas);
-				kfree(mem);
-				goto unlock_exit;
-			}
-		}
-populate:
-		pageshift = PAGE_SHIFT;
-		if (mem->pageshift > PAGE_SHIFT && PageHuge(page)) {
+		if ((mem->pageshift > PAGE_SHIFT) && PageHuge(page)) {
 			struct page *head = compound_head(page);
 			pageshift = compound_order(head) + PAGE_SHIFT;
 		}
 		mem->pageshift = min(mem->pageshift, pageshift);
+		/*
+		 * We don't need struct page reference any more, switch
+		 * physicall address.
+		 */
 		mem->hpas[i] = page_to_pfn(page) << PAGE_SHIFT;
+
 	}
 
 	atomic64_set(&mem->mapped, 1);
Signature · 1 line
2.17.1
#6 lore raw

Re: [RFC PATCH V2 4/4] powerpc/mm/iommu: Allow migration of cma allocated pages during mm_iommu_get

Quoted 5 lines · Aneesh Kumar K.V

Current code doesn't do page migration if the page allocated is a compound page. With HugeTLB migration support, we can end up allocating hugetlb pages from CMA region. Also THP pages can be allocated from CMA region. This patch updates the code to handle compound pages correctly.

Quoted 8 lines

This use the new helper get_user_pages_cma_migrate. It does one get_user_pages with right count, instead of doing one get_user_pages per page. That avoids reading page table multiple times.

The patch also convert the hpas member of mm_iommu_table_group_mem_t to a union. We use the same storage location to store pointers to struct page. We cannot update alll the code path use struct page *, because we access hpas in real mode and we can't do that struct page * to pfn conversion in real mode.

I am not fmailiar with this code so bear with me. I am completely missing the purpose of this patch. The changelog doesn't really explain that AFAICS. I can only guess that you do not want to establish long pins on CMA pages, right? So whenever you are about to pin a page that is in CMA you migrate it away to a different !__GFP_MOVABLE page, right? If that is the case then how do you handle pins which are already in zone_movable? I do not see any specific check for those.

Btw. why is this a proper thing to do? Problems with longterm pins are not only for CMA/ZONE_MOVABLE pages. Pinned pages are not reclaimable as well so there is a risk of OOMs if there are too many of them. We have discussed approaches that would allow to force pin invalidation/revocation at LSF/MM. Isn't that a more appropriate solution to the problem you are seeing?

Signature · 2 lines
Michal Hocko
SUSE Labs
#7 lore raw

Re: [RFC PATCH V2 4/4] powerpc/mm/iommu: Allow migration of cma allocated pages during mm_iommu_get

Quoted 15 lines · Michal Hocko
Quoted 5 lines · Aneesh Kumar K.V

Current code doesn't do page migration if the page allocated is a compound page. With HugeTLB migration support, we can end up allocating hugetlb pages from CMA region. Also THP pages can be allocated from CMA region. This patch updates the code to handle compound pages correctly.

Quoted 8 lines

This use the new helper get_user_pages_cma_migrate. It does one get_user_pages with right count, instead of doing one get_user_pages per page. That avoids reading page table multiple times.

The patch also convert the hpas member of mm_iommu_table_group_mem_t to a union. We use the same storage location to store pointers to struct page. We cannot update alll the code path use struct page *, because we access hpas in real mode and we can't do that struct page * to pfn conversion in real mode.

Quoted 5 lines

I am not fmailiar with this code so bear with me. I am completely missing the purpose of this patch. The changelog doesn't really explain that AFAICS. I can only guess that you do not want to establish long pins on CMA pages, right? So whenever you are about to pin a page that is in CMA you migrate it away to a different !__GFP_MOVABLE page, right?

That is right.

Quoted 5 lines

If that is the case then how do you handle pins which are already in zone_movable? I do not see any specific check for those.

Quoted 7 lines

Btw. why is this a proper thing to do? Problems with longterm pins are not only for CMA/ZONE_MOVABLE pages. Pinned pages are not reclaimable as well so there is a risk of OOMs if there are too many of them. We have discussed approaches that would allow to force pin invalidation/revocation at LSF/MM. Isn't that a more appropriate solution to the problem you are seeing?

The CMA area is used on powerpc platforms to allocate guest specific page table (hash page table). If we don't have sufficient free pages we fail to allocate hash page table that result in failure to start guest.

Now with vfio, we end up pinning the entire guest RAM. There is a possibility that these guest RAM pages got allocated from CMA region. We already do supporting migrating those pages out except for compound pages. What this patch does is to start supporting compound page migration that got allocated out of CMA region (ie, THP pages and hugetlb pages if platform supported hugetlb migration).

Now to do that I added a helper get_user_pages_cma_migrate().

I agree that long term pinned pages do have other issues. The patchset is not solving that issue.

-aneesh

#8 lore raw

Re: [RFC PATCH V2 4/4] powerpc/mm/iommu: Allow migration of cma allocated pages during mm_iommu_get

Quoted 41 lines · Aneesh Kumar K.V
Quoted 15 lines · Michal Hocko
Quoted 5 lines · Aneesh Kumar K.V

Current code doesn't do page migration if the page allocated is a compound page. With HugeTLB migration support, we can end up allocating hugetlb pages from CMA region. Also THP pages can be allocated from CMA region. This patch updates the code to handle compound pages correctly.

Quoted 8 lines

This use the new helper get_user_pages_cma_migrate. It does one get_user_pages with right count, instead of doing one get_user_pages per page. That avoids reading page table multiple times.

The patch also convert the hpas member of mm_iommu_table_group_mem_t to a union. We use the same storage location to store pointers to struct page. We cannot update alll the code path use struct page *, because we access hpas in real mode and we can't do that struct page * to pfn conversion in real mode.

Quoted 5 lines

I am not fmailiar with this code so bear with me. I am completely missing the purpose of this patch. The changelog doesn't really explain that AFAICS. I can only guess that you do not want to establish long pins on CMA pages, right? So whenever you are about to pin a page that is in CMA you migrate it away to a different !__GFP_MOVABLE page, right?

That is right.

Quoted 5 lines

If that is the case then how do you handle pins which are already in zone_movable? I do not see any specific check for those.

Quoted 7 lines

Btw. why is this a proper thing to do? Problems with longterm pins are not only for CMA/ZONE_MOVABLE pages. Pinned pages are not reclaimable as well so there is a risk of OOMs if there are too many of them. We have discussed approaches that would allow to force pin invalidation/revocation at LSF/MM. Isn't that a more appropriate solution to the problem you are seeing?

The CMA area is used on powerpc platforms to allocate guest specific page table (hash page table). If we don't have sufficient free pages we fail to allocate hash page table that result in failure to start guest.

Quoted 6 lines

Now with vfio, we end up pinning the entire guest RAM. There is a possibility that these guest RAM pages got allocated from CMA region. We already do supporting migrating those pages out except for compound pages. What this patch does is to start supporting compound page migration that got allocated out of CMA region (ie, THP pages and hugetlb pages if platform supported hugetlb migration).

This definitely belongs to the changelog.

Quoted 4 lines

Now to do that I added a helper get_user_pages_cma_migrate().

I agree that long term pinned pages do have other issues. The patchset is not solving that issue.

It would be great to note why a generic approach is not viable. I assume the main reason is that those pins are pretty much permanent for the guest lifetime so the situation has to be handled in advance. In other words, more information please.

Signature · 2 lines
Michal Hocko
SUSE Labs
#9 lore raw

Re: [RFC PATCH V2 4/4] powerpc/mm/iommu: Allow migration of cma allocated pages during mm_iommu_get

Quoted 53 lines · Michal Hocko
Quoted 41 lines · Aneesh Kumar K.V
Quoted 15 lines · Michal Hocko
Quoted 5 lines · Aneesh Kumar K.V

Current code doesn't do page migration if the page allocated is a compound page. With HugeTLB migration support, we can end up allocating hugetlb pages from CMA region. Also THP pages can be allocated from CMA region. This patch updates the code to handle compound pages correctly.

Quoted 8 lines

This use the new helper get_user_pages_cma_migrate. It does one get_user_pages with right count, instead of doing one get_user_pages per page. That avoids reading page table multiple times.

The patch also convert the hpas member of mm_iommu_table_group_mem_t to a union. We use the same storage location to store pointers to struct page. We cannot update alll the code path use struct page *, because we access hpas in real mode and we can't do that struct page * to pfn conversion in real mode.

Quoted 5 lines

I am not fmailiar with this code so bear with me. I am completely missing the purpose of this patch. The changelog doesn't really explain that AFAICS. I can only guess that you do not want to establish long pins on CMA pages, right? So whenever you are about to pin a page that is in CMA you migrate it away to a different !__GFP_MOVABLE page, right?

That is right.

Quoted 5 lines

If that is the case then how do you handle pins which are already in zone_movable? I do not see any specific check for those.

Quoted 7 lines

Btw. why is this a proper thing to do? Problems with longterm pins are not only for CMA/ZONE_MOVABLE pages. Pinned pages are not reclaimable as well so there is a risk of OOMs if there are too many of them. We have discussed approaches that would allow to force pin invalidation/revocation at LSF/MM. Isn't that a more appropriate solution to the problem you are seeing?

The CMA area is used on powerpc platforms to allocate guest specific page table (hash page table). If we don't have sufficient free pages we fail to allocate hash page table that result in failure to start guest.

Quoted 6 lines

Now with vfio, we end up pinning the entire guest RAM. There is a possibility that these guest RAM pages got allocated from CMA region. We already do supporting migrating those pages out except for compound pages. What this patch does is to start supporting compound page migration that got allocated out of CMA region (ie, THP pages and hugetlb pages if platform supported hugetlb migration).

This definitely belongs to the changelog.

Quoted 2 lines

Now to do that I added a helper get_user_pages_cma_migrate().

Quoted 8 lines
Quoted 2 lines

I agree that long term pinned pages do have other issues. The patchset is not solving that issue.

It would be great to note why a generic approach is not viable. I assume the main reason is that those pins are pretty much permanent for the guest lifetime so the situation has to be handled in advance. In other words, more information please.

That is correct. I will add these details to commit message. And will also do a cover letter for the patch series.

-aneesh

#10 lore raw

Re: [RFC PATCH V2 4/4] powerpc/mm/iommu: Allow migration of cma allocated pages during mm_iommu_get

Quoted 57 lines · Aneesh Kumar K.V
Quoted 56 lines · Michal Hocko
Quoted 41 lines · Aneesh Kumar K.V
Quoted 15 lines · Michal Hocko
Quoted 5 lines · Aneesh Kumar K.V

Current code doesn't do page migration if the page allocated is a compound page. With HugeTLB migration support, we can end up allocating hugetlb pages from CMA region. Also THP pages can be allocated from CMA region. This patch updates the code to handle compound pages correctly.

Quoted 8 lines

This use the new helper get_user_pages_cma_migrate. It does one get_user_pages with right count, instead of doing one get_user_pages per page. That avoids reading page table multiple times.

The patch also convert the hpas member of mm_iommu_table_group_mem_t to a union. We use the same storage location to store pointers to struct page. We cannot update alll the code path use struct page *, because we access hpas in real mode and we can't do that struct page * to pfn conversion in real mode.

Quoted 5 lines

I am not fmailiar with this code so bear with me. I am completely missing the purpose of this patch. The changelog doesn't really explain that AFAICS. I can only guess that you do not want to establish long pins on CMA pages, right? So whenever you are about to pin a page that is in CMA you migrate it away to a different !__GFP_MOVABLE page, right?

That is right.

Quoted 5 lines

If that is the case then how do you handle pins which are already in zone_movable? I do not see any specific check for those.

Quoted 7 lines

Btw. why is this a proper thing to do? Problems with longterm pins are not only for CMA/ZONE_MOVABLE pages. Pinned pages are not reclaimable as well so there is a risk of OOMs if there are too many of them. We have discussed approaches that would allow to force pin invalidation/revocation at LSF/MM. Isn't that a more appropriate solution to the problem you are seeing?

The CMA area is used on powerpc platforms to allocate guest specific page table (hash page table). If we don't have sufficient free pages we fail to allocate hash page table that result in failure to start guest.

Quoted 6 lines

Now with vfio, we end up pinning the entire guest RAM. There is a possibility that these guest RAM pages got allocated from CMA region. We already do supporting migrating those pages out except for compound pages. What this patch does is to start supporting compound page migration that got allocated out of CMA region (ie, THP pages and hugetlb pages if platform supported hugetlb migration).

This definitely belongs to the changelog.

Quoted 4 lines

Now to do that I added a helper get_user_pages_cma_migrate().

I agree that long term pinned pages do have other issues. The patchset is not solving that issue.

Quoted 8 lines
Quoted 5 lines

It would be great to note why a generic approach is not viable. I assume the main reason is that those pins are pretty much permanent for the guest lifetime so the situation has to be handled in advance. In other words, more information please.

That is correct. I will add these details to commit message. And will also do a cover letter for the patch series.

OK, then the early migration makes some sense. Although I suspect this will lead to other issues (OOM in kernel zones) but revocation approach is clearly not usable. An excessive pinning simply sucks.

Thanks a lot for the updated information though!

Signature · 2 lines
Michal Hocko
SUSE Labs
#11 lore raw
In reply to Aneesh Kumar K.V
Quoted 1 line · Aneesh Kumar K.V

We want to use this to support customized huge page migration.

Please be much more specific. Ideally including the user. Btw. why do you want to skip the hugetlb pools? In other words alloc_huge_page_node* which are intended to an external use?

Signature · 2 lines
Michal Hocko
SUSE Labs
#12 lore raw
Quoted 6 lines · Michal Hocko
Quoted 1 line · Aneesh Kumar K.V

We want to use this to support customized huge page migration.

Please be much more specific. Ideally including the user. Btw. why do you want to skip the hugetlb pools? In other words alloc_huge_page_node* which are intended to an external use?

Ups, I have now found http://lkml.kernel.org/r/[email protected]
which ended up in a different email folder so I have missed it. It would
be much better to merge those two to make the user immediately obvious.
There is a good reason to keep newly added functions closer to their
users.

Signature · 2 lines
Michal Hocko
SUSE Labs
#13 lore raw
Quoted 8 lines · Michal Hocko
Quoted 6 lines · Michal Hocko
Quoted 1 line · Aneesh Kumar K.V

We want to use this to support customized huge page migration.

Please be much more specific. Ideally including the user. Btw. why do you want to skip the hugetlb pools? In other words alloc_huge_page_node* which are intended to an external use?

Quoted 6 lines

Ups, I have now found http://lkml.kernel.org/r/[email protected]
which ended up in a different email folder so I have missed it. It would
be much better to merge those two to make the user immediately obvious.
There is a good reason to keep newly added functions closer to their
users.

It is the same series. I will fold the patch 1 and 2.

-aneesh