Skip to contentSkip to conversation

arm64: dts: add support for SolidRun Clearfog GT 8K

PATCH Superseded Baruch Siach 3 participants 4 messages Sep 6, 2018 – Sep 21, 2018

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: add support for SolidRun Clearfog GT 8K

The SolidRun Clearfog GT-8K is based on Marvell Armada 8040 SoC.

https://wiki.solid-run.com/doku.php?id=products:a8040:clearfoggt8k

The following devices were tested with this DT on top of kernel v4.19-rc1:

* 1GB Ethernet WAN

* 4 ports 1GB Ethernet switch (2.5GB uplink)

* SATA on CON3 PCIe slot

* USB3 type A port

* SD card and eMMC

* 2 LEDs

* 2 push buttons

---
v2:
* Add SATA node

* Set front button code to KEY_WPS_BUTTON

* Use LEDs labels more aligned to conversion

* Document the marvell,reg-init meaning

---
 arch/arm64/boot/dts/marvell/Makefile          |   1 +
 .../marvell/armada-8040-clearfog-gt-8k.dts    | 430 ++++++++++++++++++
 2 files changed, 431 insertions(+)
 create mode 100644 arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
arch/arm64/boot/dts/marvell/Makefile +1 -0
index ea9d49f2a911..eca8bac6303a 100644
@@ -3,6 +3,7 @@
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-7040-db.dtb
+dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-clearfog-gt-8k.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-db.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-mcbin.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-8080-db.dtb
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts new file +430 -0

430 lines not on this page · raw message

Signature · 1 line
2.18.0
maintainer
#1 lore raw

PATCH v2 1/1 arm64: dts: add support for SolidRun Clearfog GT 8K

Quoted 6 lines

v2:
* Add SATA node

* Set front button code to KEY_WPS_BUTTON

* Use LEDs labels more aligned to conversion

Hi Baruch

It would be good to say why you did not make it fully aligned to convention. What is wrong with "clearfog-gt-8k:green:led0"

Quoted 6 lines
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts new file +6 -0
+		mdio {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			switch0phy0: switch0phy0 at 11 {
+				reg = <0x11>;
+			};

arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts line 388

Quoted 10 lines
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts new file +10 -0
+			switch0phy1: switch0phy1 at 12 {
+				reg = <0x12>;
+			};
+			switch0phy2: switch0phy2 at 13 {
+				reg = <0x13>;
+			};
+			switch0phy3: switch0phy3 at 14 {
+				reg = <0x14>;
+			};
+		};

It would be nice to add a black line after each child node.

Otherwise, this looks good.

Andrew

#2 lore raw

PATCH v2 1/1 arm64: dts: add support for SolidRun Clearfog GT 8K

Hi Andrew,

Quoted 11 lines · Andrew Lunn
Quoted 6 lines

v2:
* Add SATA node

* Set front button code to KEY_WPS_BUTTON

* Use LEDs labels more aligned to conversion

Hi Baruch

It would be good to say why you did not make it fully aligned to convention. What is wrong with "clearfog-gt-8k:green:led0"

I wasn't sure what the 'devicename' field translates to for on-board LEDs. The leds-class.txt document recommends to leave blank non-applicable fields. Existing DTs already have have labels like "beaglebone:green:usr0", and "am3517evm:green:user_led_1". So I'm fine with your suggestion.

Quoted 19 lines
Quoted 6 lines
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts new file +6 -0
+		mdio {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			switch0phy0: switch0phy0 at 11 {
+				reg = <0x11>;
+			};

arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts line 388

Quoted 10 lines
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts new file +10 -0
+			switch0phy1: switch0phy1 at 12 {
+				reg = <0x12>;
+			};
+			switch0phy2: switch0phy2 at 13 {
+				reg = <0x13>;
+			};
+			switch0phy3: switch0phy3 at 14 {
+				reg = <0x14>;
+			};
+		};

It would be nice to add a black line after each child node.

Quoted 1 line

Otherwise, this looks good.

Thanks for reviewing.

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

maintainer
#3 lore raw

PATCH v2 1/1 arm64: dts: add support for SolidRun Clearfog GT 8K

Hi Baruch,

Quoted 12 lines · Baruch Siach

Hi Andrew,

Quoted 9 lines · Andrew Lunn
Quoted 6 lines

v2:
* Add SATA node

* Set front button code to KEY_WPS_BUTTON

* Use LEDs labels more aligned to conversion

Hi Baruch

Quoted 8 lines
Quoted 2 lines

It would be good to say why you did not make it fully aligned to convention. What is wrong with "clearfog-gt-8k:green:led0"

I wasn't sure what the 'devicename' field translates to for on-board LEDs. The leds-class.txt document recommends to leave blank non-applicable fields. Existing DTs already have have labels like "beaglebone:green:usr0", and "am3517evm:green:user_led_1". So I'm fine with your suggestion.

If you send a new version with this change than I will apply it on the mvebu trees.

Thanks,

Gregory

Quoted 35 lines
Quoted 20 lines
Quoted 7 lines
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts new file +6 -0
+		mdio {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			switch0phy0: switch0phy0 at 11 {
+				reg = <0x11>;
+			};

arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts line 388

Quoted 10 lines
arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts new file +10 -0
+			switch0phy1: switch0phy1 at 12 {
+				reg = <0x12>;
+			};
+			switch0phy2: switch0phy2 at 13 {
+				reg = <0x13>;
+			};
+			switch0phy3: switch0phy3 at 14 {
+				reg = <0x14>;
+			};
+		};

It would be nice to add a black line after each child node.

Quoted 1 line

Otherwise, this looks good.

Thanks for reviewing.

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 3 lines
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com